geet 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5179b22079f6fef1c7bc0d4559cedea9f7ce8b5c
-  data.tar.gz: ef9fd7a82c156274908dab31008c31f90096ce49
+  metadata.gz: 033e3851278fd2e0b27bbf58ed7b4fe63f1dc293
+  data.tar.gz: 5a89dbdd4d43594638e67453d9cdaab7c64bfcf4
 SHA512:
-  metadata.gz: 64834768832dfcffe28ff36e43fc8c453667be6032049f2dd34ed655da38f0b0e7c8840bf634b24467c154052026edd44ce34cd71a9c634969c13d07671227e0
-  data.tar.gz: c0d92c7037c183cc614144bf18551268eb682e99122c5e930685bdf0839d579d599770e7f56645dc2a01f876b4e80920417507a75c809616df7155f6763a0044
+  metadata.gz: f038e218da489bc3599091209b8241dba8339441144775e8af0193c793a403187ffb14e88aedfcbcdd2fb427da1f7a9556804c9d2c4e54d7585bc3a2bd7232c5
+  data.tar.gz: 0faf78b1473415d7725fe04f561177eb64740158d3f1993b4056f5ec21784998d8dce409df944a43c2555d13dff8b5701e7c353a41353b7d44d76bdfc8b61e35

data/README.md

@@ -10,20 +10,28 @@ This tool is very similar to [Hub](https://github.com/github/hub), but it suppor
 
 Basic creation of an issue and a PR (both actions will open the pages with the result in the browser):
 
-    $ geet issue 'Issue Title' 'Issue Description'
-    $ geet pr 'PR Title' 'PR Description
+    $ geet issue create 'Issue Title' 'Issue Description'
+    
+    $ geet pr create 'PR Title' 'Multi-line
     > 
-    > Closes #1' --label-patterns "code review" --reviewer-patterns john,tom,adrian
+    > description'
 
-Create an issue, adding the label matching `bug`, and assigning it to the collaborators matching `john`, `tom`, `kevin`:
+More advanced issue/PR creation, with label, reviewers and assignees:
 
-    $ geet issue 'Issue Title' 'Issue Description' --label-patterns "code review" --assignee-patterns john,tom,kevin
+    $ geet issue create 'Issue Title' 'Issue Description' --label-patterns bug,wip --assignee-patterns john
+    
+    $ geet pr create 'PR Title' 'Closes #1' --label-patterns "code review" --reviewer-patterns kevin,tom,adrian
 
-Create a PR, adding the label matching `code review`, and requesting reviews from the collaborators matching `john`, `tom`, `adrian`:
+patterns are partial matches, so, for example, `johncarmack` will be matched as assignee in the first case.
 
-    $ geet pr 'PR Title' 'PR Description
-    > 
-    > Closes #1' --label-patterns "code review" --reviewer-patterns john,tom,adrian
+List the open issues, in default order (inverse creation date):
+
+    $ geet issue list
+    > 16. Implement issue opening (https://github.com/saveriomiroddi/geet/issues/16)
+    > 14. Update README (https://github.com/saveriomiroddi/geet/issues/14)
+    > 8. Implement milestones listing/show (https://github.com/saveriomiroddi/geet/issues/8)
+    > 4. Allow writing description in an editor (https://github.com/saveriomiroddi/geet/issues/4)
+    > 2. Support opening PR into other repositories (https://github.com/saveriomiroddi/geet/issues/2)
 
 For the help:
 

data/lib/geet/git_hub/api_helper.rb

@@ -1,7 +1,8 @@
 # frozen_string_literal: true
 
+require 'uri'
+require 'net/http'
 require 'json'
-require 'open3'
 require 'shellwords'
 
 module Geet
@@ -28,34 +29,15 @@ module Geet
       #                 return an array, with the concatenated (parsed) responses
       #
       def send_request(address, data: nil, multipage: false)
-        # `--data` implies `-X POST`
-        #
-        if data
-          escaped_request_body = JSON.generate(data).shellescape
-          data_option = "--data #{escaped_request_body}"
-        end
-
         # filled only on :multipage
         parsed_responses = []
 
         loop do
-          command = %(curl --verbose --silent --user "#{@user}:#{@api_token}" #{data_option} #{address})
-          response_metadata, response_body = nil
-
-          Open3.popen3(command) do |_, stdout, stderr, wait_thread|
-            response_metadata = stderr.readlines.join
-            response_body = stdout.readlines.join
-
-            if !wait_thread.value.success?
-              puts response_metadata
-              puts "Error! Command: #{command}"
-              exit
-            end
-          end
+          response = send_http_request(address, data: data)
 
-          parsed_response = JSON.parse(response_body)
+          parsed_response = JSON.parse(response.body)
 
-          if error?(response_metadata)
+          if error?(response)
             formatted_error = decode_and_format_error(parsed_response)
             raise(formatted_error)
           end
@@ -64,7 +46,7 @@ module Geet
 
           parsed_responses.concat(parsed_response)
 
-          address = link_next_page(response_metadata)
+          address = link_next_page(response.to_hash)
 
           return parsed_responses if address.nil?
         end
@@ -72,13 +54,35 @@ module Geet
 
       private
 
-      def decode_and_format_error(response)
-        message = response['message']
+      def send_http_request(address, data: nil)
+        uri = URI(address)
+
+        Net::HTTP.start(uri.host, use_ssl: true) do |http|
+          if data
+            request = Net::HTTP::Post.new(uri)
+            request.body = data.to_json
+          else
+            request = Net::HTTP::Get.new(uri)
+          end
+
+          request.basic_auth @user, @api_token
+          request['Accept'] = 'application/vnd.github.v3+json'
+
+          http.request(request)
+        end
+      end
+
+      def error?(response)
+        !response['Status'].start_with?('2')
+      end
+
+      def decode_and_format_error(parsed_response)
+        message = parsed_response['message']
 
-        if response.key?('errors')
+        if parsed_response.key?('errors')
           message += ':'
 
-          error_details = response['errors'].map do |error_data|
+          error_details = parsed_response['errors'].map do |error_data|
             error_code = error_data.fetch('code')
 
             if error_code == 'custom'
@@ -94,27 +98,13 @@ module Geet
         message
       end
 
-      def error?(response_metadata)
-        status_header = find_header_content(response_metadata, 'Status')
-
-        !!(status_header =~ /^4\d\d/)
-      end
-
-      def link_next_page(response_metadata)
-        link_header = find_header_content(response_metadata, 'Link')
+      def link_next_page(response_headers)
+        link_header = response_headers['Link']
 
         return nil if link_header.nil?
 
         link_header[/<(\S+)>; rel="next"/, 1]
       end
-
-      def find_header_content(response_metadata, header_name)
-        response_metadata.split("\n").each do |header|
-          return Regexp.last_match(1) if header =~ /^< #{header_name}: (.*)/
-        end
-
-        nil
-      end
     end
   end
 end

data/lib/geet/services/list_issues.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-# require_relative '../helpers/os_helper.rb'
-# require_relative '../git/repository.rb'
-
 module Geet
   module Services
     class ListIssues

data/lib/geet/version.rb

@@ -1,3 +1,3 @@
 module Geet
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: geet
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Saverio Miroddi