gecko-ruby 0.9.0 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b82efcf479bde2b049bfd09f55185e8c4c5fd29377ca35a8865dc2816c6cba0c
-  data.tar.gz: 838ba153b885dcbca0accf42143733b4e9d79478bcd1d26d57001c3cfda9f4ca
+  metadata.gz: ebfbdacb19b2e0dbc4478c614578298de91e01e1ee79d29ace8833da5ef5ce4d
+  data.tar.gz: 4d4e8551a79728045733fb7fa336a30b655e779c152ae7d0a8ec49af1c746aff
 SHA512:
-  metadata.gz: 607951bf8f6958c8b11814dcaa5c9f8d3d24517dcf0ae2f34e2b443358abdf1f27354a53f227baba505a1bfebae42891519b17cdadecde23c5fd696d0a9ff087
-  data.tar.gz: da203fe38e4d22f35de38d56217489338a5319de2f6cdd82fb8a67d9533a5f97969e2397010323f53598c19203c0e63b422211cf2b296d2db4ca67877ab9d7ee
+  metadata.gz: 92333d13c62ab98a009c8d8a6396dcd89be342fa3d58fb152a024330f419d44d113aaa19aedbe34de10ba7a3741bb8fd54bab20ee6bb33597edee8131629f386
+  data.tar.gz: e74fb5237da5c6a1a023517c6cc8fa76f5f45f4674362f887ccb82d7887d159aa95f3e329a6faf65fa8bcdfe359874735791db1d3d1b08362e5c2a67afee28cb

data/.github/config/rubocop_linter_action.yml

@@ -0,0 +1,7 @@
+---
+check_name: 'Rubocop Results'
+check_scope: 'modified'
+versions:
+  - rubocop
+  - rubocop-minitest
+  - rubocop-performance

data/.github/workflows/testing.yml

@@ -0,0 +1,26 @@
+---
+name: Ruby Tests
+
+'on': [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: ['2.4', '2.5', '2.6', '2.7']
+    name: Ruby ${{ matrix.ruby }}
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: Run Tests
+        run: |
+          gem install bundler --no-document
+          bundle install --jobs 4 --retry 3
+          bundle exec rake
+      - name: Rubocop
+        uses: andrewmcodes/rubocop-linter-action@v3.1.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.rubocop.yml

@@ -1,5 +1,8 @@
 AllCops:
   DisplayCopNames: true
+  Exclude:
+    - 'bin/*'
+    - 'generate.thor'
 
 # class Example
 # ...
@@ -9,33 +12,34 @@ AllCops:
 Layout/AccessModifierIndentation:
   EnforcedStyle: outdent
 
-Style/Blocks:
-  Enabled: false
-
-# Allows foo(bar: baz)
-Style/BracesAroundHashParameters:
-  Enabled: false
-
 Layout/DotPosition:
   EnforcedStyle: leading
 
-Layout/IndentHash:
+Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
-Style/RedundantSelf:
-  Enabled: false
+Layout/HashAlignment:
+  EnforcedColonStyle: table
 
-# We like neatly-aligned code
-Layout/SpaceBeforeFirstArg:
+Metrics/AbcSize:
+  Exclude:
+    - 'test/**/*.rb'
+
+Naming/FileName:
+  Exclude:
+    - 'lib/gecko-ruby.rb'
+
+Naming/PredicateName:
   Enabled: false
 
-Layout/SpaceAroundEqualsInParameterDefault:
+Naming/AccessorMethodName:
   Enabled: false
 
-Layout/SpaceInsideHashLiteralBraces:
+# We like neatly-aligned code
+Layout/SpaceBeforeFirstArg:
   Enabled: false
 
 # Allow single or double quotes
@@ -63,7 +67,10 @@ Layout/MultilineOperationIndentation:
   Enabled: false
 
 Style/ClassAndModuleChildren:
-  EnforcedStyle: compact
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
 
 Style/DoubleNegation:
   Enabled: false

data/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 0.12.0 (2020-07-09)
+- Silence warnings in Ruby 2.7
+- Ensure response is passed to `ActiveSupport::Notifications` on error
+- Ensure `adapter.last_response` is set on error response
+
+## 0.11.1 (2020-04-30)
+- Fix addresses on Invoice
+
+## 0.11.0 (2020-04-29)
+- Store create/update responses under `adapter.last_response` as well.
+
+## 0.10.0 (2020-04-06)
+- Add extra delegated attributes to invoice record
+- [BREAKING] Update Image record to latest API with product and multiple variant support
+
+## 0.9.1 (2019-07-29)
+- Fix issue with LiquidCompat that broke during refactor
+
 ## 0.9.0 (2019-07-24)
 - Added an optional `ActiveSupport::LogSubscriber` class for easy logging,
   can be enabled via `Gecko.enable_logging`.

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in gecko.gemspec

data/README.md

@@ -1,4 +1,4 @@
-# TradeGecko RubyGem [![Build Status](https://travis-ci.org/tradegecko/gecko.png)](https://travis-ci.org/tradegecko/gecko) [![Code Climate](https://codeclimate.com/github/tradegecko/gecko.png)](https://codeclimate.com/github/tradegecko/gecko)
+# TradeGecko RubyGem ![Build Status](https://github.com/tradegecko/gecko/workflows/Ruby%20Tests/badge.svg) [![Code Climate](https://codeclimate.com/github/tradegecko/gecko.png)](https://codeclimate.com/github/tradegecko/gecko)
 The official TradeGecko API RubyGem
 
 ## Introduction

data/Rakefile

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 
 require 'rake/testtask'
 
-task :default => [:test]
+task default: [:test]
 
 Rake::TestTask.new do |t|
   t.libs << 'test'

data/gecko-ruby.gemspec

@@ -1,5 +1,6 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gecko/version'
 
@@ -8,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.version = Gecko::VERSION
   spec.authors = ["Bradley Priest"]
   spec.email = ['bradley@tradegecko.com']
-  spec.description = %q{A Ruby interface to the TradeGecko API.}
+  spec.description = 'A Ruby interface to the TradeGecko API.'
   spec.summary = spec.description
   spec.homepage = 'https://github.com/tradegecko/gecko/'
   spec.license = 'MIT'
@@ -19,17 +20,17 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "dotenv"
   spec.add_development_dependency "minitest"
-  spec.add_development_dependency "vcr"
-  spec.add_development_dependency "webmock"
   spec.add_development_dependency "mocha"
-  spec.add_development_dependency "timecop"
-  spec.add_development_dependency "dotenv"
-  spec.add_development_dependency "thor"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "thor"
+  spec.add_development_dependency "timecop"
+  spec.add_development_dependency "vcr"
+  spec.add_development_dependency "webmock"
 
+  spec.add_dependency "activesupport"
   spec.add_dependency "oauth2", "> 1.1.0"
   spec.add_dependency "virtus"
-  spec.add_dependency "activesupport"
 end

data/generate.thor

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/inflector'
 class Generate < Thor
   include Thor::Actions
@@ -7,7 +9,7 @@ class Generate < Thor
     @model_name = model_name
     @file_name  = model_name.underscore
     @plural     = ask "What is the underscore plural of #{@model_name}? (#{@file_name}s):"
-    @plural     = @plural.to_s.length > 0 ? @plural : @file_name + "s"
+    @plural     = !@plural.to_s.empty? ? @plural : @file_name + "s"
     create_file "lib/gecko/record/#{@file_name}.rb", model_template
     create_file "test/record/#{@file_name}_adapter_test.rb", test_adapter_template
     create_file "test/record/#{@file_name}_test.rb", test_template
@@ -16,6 +18,7 @@ class Generate < Thor
   end
 
 private
+
   def default_plural?
     @plural == @file_name + "s"
   end

data/lib/gecko-ruby.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'gecko'

data/lib/gecko.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'virtus'
 require 'active_support/inflector'
 require 'active_support/notifications'

data/lib/gecko/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday'
 require 'oauth2/version'
 require 'gecko/version'
@@ -57,7 +59,7 @@ module Gecko
     # @return [undefined]
     #
     # @api private
-    def initialize(client_id, client_secret, options={})
+    def initialize(client_id, client_secret, options = {})
       setup_oauth_client(client_id, client_secret, options)
     end
 
@@ -107,29 +109,29 @@ module Gecko
     #
     # @api private
     def adapter_for(klass_name)
-      self.public_send(klass_name.to_sym)
+      public_send(klass_name.to_sym)
+    end
+
+    def self.default_headers
+      {
+        'User-Agent' => ["Gecko/#{Gecko::VERSION}",
+                         "OAuth2/#{OAuth2::Version}",
+                         "Faraday/#{Faraday::VERSION}",
+                         "Ruby/#{RUBY_VERSION}"].join(' ')
+      }
     end
 
   private
 
     def setup_oauth_client(client_id, client_secret, options)
       defaults = {
-        site:          'https://api.tradegecko.com',
-        authorize_url: 'https://go.tradegecko.com/oauth/authorize',
+        site:            'https://api.tradegecko.com',
+        authorize_url:   'https://go.tradegecko.com/oauth/authorize',
         connection_opts: {
-          headers:     self.class.default_headers
+          headers: self.class.default_headers
         }
       }
       @oauth_client = OAuth2::Client.new(client_id, client_secret, defaults.merge(options))
     end
-
-    def self.default_headers
-      {
-        'User-Agent' => ["Gecko/#{Gecko::VERSION}",
-                         "OAuth2/#{OAuth2::Version.to_s}",
-                         "Faraday/#{Faraday::VERSION}",
-                         "Ruby/#{RUBY_VERSION}"].join(' ')
-      }
-    end
   end
 end

data/lib/gecko/ext/liquid_compat.rb

@@ -56,18 +56,20 @@ module Gecko
 
     ## Override Liquid::Drop#invoke_drop to also check method arity
     def invoke_drop(method_or_key)
-      if self.invokable_methods.include?(method_or_key.to_s) && self.method_arity(method_or_key.to_sym) <= 0
-        self.public_send(method_or_key)
-      end
+      return unless invokable_methods.include?(method_or_key.to_s) && method_arity(method_or_key.to_sym) <= 0
+
+      public_send(method_or_key)
     end
 
+    alias [] invoke_drop
+
     ## Override Liquid::Drop#invokable_methods to add extra checks
     def invokable_methods
       @invokable_methods ||= begin
-        blacklist = Gecko::Record::Base.public_instance_methods + Liquid::Drop.public_instance_methods
-        blacklist -= [:to_liquid, :id, :created_at, :updated_at]
-        whitelist = self.public_methods + @delegate.public_methods
-        available_methods = (whitelist - blacklist).map(&:to_s)
+        denylist = Gecko::Record::Base.public_instance_methods + Liquid::Drop.public_instance_methods
+        denylist -= %i[to_liquid id created_at updated_at]
+        allowlist = public_methods + @delegate.public_methods
+        available_methods = (allowlist - denylist).map(&:to_s)
         available_methods.reject! { |method_name| method_name.ends_with?("=") }
         Set.new(available_methods)
       end
@@ -76,8 +78,8 @@ module Gecko
   protected
 
     def method_arity(method_name)
-      if self.methods.include?(method_name)
-        self.method(method_name).arity
+      if methods.include?(method_name)
+        method(method_name).arity
       else
         @delegate.method(method_name).arity
       end

data/lib/gecko/ext/log_subscriber.rb

@@ -13,7 +13,7 @@ class GeckoLogSubscriber < ActiveSupport::LogSubscriber
     @odd = false
   end
 
-  def request(event)
+  def request(event) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
     RequestStore.store[ENV_KEY] = []
     payload = event.payload
 
@@ -27,11 +27,11 @@ class GeckoLogSubscriber < ActiveSupport::LogSubscriber
     name  = "#{payload[:model_class]} Load (#{event.duration.round(1)}ms)"
     query = "#{payload[:verb].to_s.upcase} /#{request_path}"
 
-    if odd?
-      name = color(name, CYAN, true)
-    else
-      name = color(name, MAGENTA, true)
-    end
+    name = if odd?
+             color(name, CYAN, true)
+           else
+             color(name, MAGENTA, true)
+           end
 
     query = color(query, nil, true)
 

data/lib/gecko/helpers/association_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Helpers
     # Helper for has_many/belongs_to relationships
@@ -24,7 +26,7 @@ module Gecko
         # @return [undefined]
         #
         # @api public
-        def belongs_to(model_name, options={})
+        def belongs_to(model_name, options = {})
           class_name  = options[:class_name] || model_name.to_s.classify
           foreign_key = model_name.to_s.foreign_key.to_sym
 
@@ -55,22 +57,22 @@ module Gecko
         # @return [undefined]
         #
         # @api public
-        def has_many(association_name, options={})
+        def has_many(association_name, options = {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
           model_name = association_name.to_s.singularize
           class_name = options[:class_name] || model_name.classify
           foreign_key = model_name.foreign_key.pluralize.to_sym
           readonly    = options.key?(:readonly) ? options[:readonly] : true
 
-          define_method association_name do
+          define_method association_name do # rubocop:disable Metrics/MethodLength
             collection_proxies[association_name] ||= begin
-              ids = self.attributes[foreign_key]
-              if ids.any?
-                collection = @client.adapter_for(class_name).find_many(ids)
-              else
-                collection = []
-              end
-
-              build_collection_proxy(collection, {
+              ids = attributes[foreign_key]
+              collection = if ids.any?
+                             @client.adapter_for(class_name).find_many(ids)
+                           else
+                             []
+                           end
+
+              build_collection_proxy(collection, **{
                 embedded:         options[:embedded],
                 class_name:       class_name,
                 association_name: association_name
@@ -98,7 +100,7 @@ module Gecko
       #
       # @api private
       def build_collection_proxy(target, association_name:, class_name:, embedded:)
-        CollectionProxy.new({
+        CollectionProxy.new(**{
           parent:           self,
           target:           target,
           embedded:         embedded,

data/lib/gecko/helpers/inspection_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Helpers
     # Helper for providing custom #inspect values to Records
@@ -39,9 +41,9 @@ module Gecko
         if value.is_a?(String) && value.length > 50
           "#{value[0..50]}...".inspect
         elsif value.is_a?(DateTime) || value.is_a?(Time)
-          %("#{value.strftime("%Y-%m-%d %H:%M:%S")}")
+          %("#{value.strftime('%Y-%m-%d %H:%M:%S')}")
         elsif value.is_a?(Date)
-          %("#{value.strftime("%Y-%m-%d")}")
+          %("#{value.strftime('%Y-%m-%d')}")
         else
           value.inspect
         end

data/lib/gecko/helpers/record_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gecko
   module Helpers
     # Helper for registering valid record types