gecko-ruby 0.11.1 → 0.12.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d199e8dad0e8cfc71dab3994fd32e91d9862fbacd17e5ef33b7ea56042a0c47b
-  data.tar.gz: d588aafb7703430db428da743fda7f5acab475759b5c45cb007f843b0fe41822
+  metadata.gz: '069a7e4b8a02ab0289b0e3e1a605900023f10eec49527357450d1015d60d12e0'
+  data.tar.gz: e5feb98bafcc6779fff79a311417d7066d2ee13b0673bb71b26adfac9b86e2c2
 SHA512:
-  metadata.gz: ded7f2c92168eb1266b892d91d81902715893ba6df9c3b3d5b738b7655ea8a3a031046324718d170741b9dd9397316aa403d129234eed16dcfb5175ca0bc0dea
-  data.tar.gz: 0c4684e13aef815bb59a2b09a49c7cb6625c9201a85af9b9cbad569a2291287a10dc2c9bdb006ac9a31581a1b3ae8bc8651ac0c1b30ba4090158799425578f1e
+  metadata.gz: 6602475856673d6859aa177edf2d0b2841fdabdaebcb03865642f3c69c1522b5b9ca5e385754e38476129d64b8a42e2b8d27c809726e6b68af77c808be55607c
+  data.tar.gz: c7d8508ab889d9cde9f1c5df08c24f53dc9c65099df71a00f5b5096a44683336dfd549bb1dce3bd949696d7bf600b74760b4e61c7c6030acb8d890068e7189f4

data/.github/workflows/testing.yml

@@ -12,7 +12,7 @@ jobs:
     name: Ruby ${{ matrix.ruby }}
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-ruby@v1
+      - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
       - name: Run Tests
@@ -20,7 +20,3 @@ jobs:
           gem install bundler --no-document
           bundle install --jobs 4 --retry 3
           bundle exec rake
-      - name: Rubocop
-        uses: andrewmcodes/rubocop-linter-action@v3.1.0
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 0.12.3 (2021-12-22)
+- Add `issued_at` to `Gecko::Record::PurchaseOrder`
+- Make liquid shim work with `Gecko::Record::Variant#locations`
+
+## 0.12.2 (2020-08-12)
+- Change authorize url to commerce.intuit.com
+- Add `payment_due_at` to `Gecko::Record::PurchaseOrder`
+
+## 0.12.1 (2020-07-20)
+- Add `Gecko::Record::PaymentMethod` model.
+
+## 0.12.0 (2020-07-09)
+- Silence warnings in Ruby 2.7
+- Ensure response is passed to `ActiveSupport::Notifications` on error
+- Ensure `adapter.last_response` is set on error response
+
 ## 0.11.1 (2020-04-30)
 - Fix addresses on Invoice
 
@@ -14,7 +30,7 @@
 ## 0.9.0 (2019-07-24)
 - Added an optional `ActiveSupport::LogSubscriber` class for easy logging,
   can be enabled via `Gecko.enable_logging`.
-- Added an optional compatibility shim for the Liquid templating language, 
+- Added an optional compatibility shim for the Liquid templating language,
   can be enabled via `Gecko.install_liquid_shim`.
 
 ## 0.8.0 (2019-07-01)

data/lib/gecko/client.rb

@@ -33,6 +33,7 @@ module Gecko
     record :PurchaseOrder
     record :PurchaseOrderLineItem
     record :TaxType
+    record :PaymentMethod
     record :PaymentTerm
     record :Webhook
 
@@ -126,7 +127,7 @@ module Gecko
     def setup_oauth_client(client_id, client_secret, options)
       defaults = {
         site:            'https://api.tradegecko.com',
-        authorize_url:   'https://go.tradegecko.com/oauth/authorize',
+        authorize_url:   'https://commerce.intuit.com/oauth/authorize',
         connection_opts: {
           headers: self.class.default_headers
         }

data/lib/gecko/ext/liquid_compat.rb

@@ -35,6 +35,9 @@ module Gecko
   Gecko::Record::Base.include(LiquidCompatibility)
   Gecko::Helpers::CollectionProxy.delegate(:to_liquid, to: :@target)
 
+  Gecko::Record::Variant::VariantLocation.include(Gecko::LiquidCompatibility)
+  Gecko::Record::Variant::VariantPrice.include(Gecko::LiquidCompatibility)
+
   class BaseDecorator < Liquid::Drop
     def initialize(delegate)
       raise 'Turtles all the way down' if delegate.is_a?(BaseDecorator)

data/lib/gecko/helpers/association_helper.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'active_support/core_ext/module'
+
 module Gecko
   module Helpers
     # Helper for has_many/belongs_to relationships
@@ -72,7 +74,7 @@ module Gecko
                              []
                            end
 
-              build_collection_proxy(collection, {
+              build_collection_proxy(collection, **{
                 embedded:         options[:embedded],
                 class_name:       class_name,
                 association_name: association_name
@@ -100,7 +102,7 @@ module Gecko
       #
       # @api private
       def build_collection_proxy(target, association_name:, class_name:, embedded:)
-        CollectionProxy.new({
+        CollectionProxy.new(**{
           parent:           self,
           target:           target,
           embedded:         embedded,

data/lib/gecko/record/account.rb

@@ -11,6 +11,7 @@ module Gecko
       belongs_to :primary_location,                class_name: "Location"
       belongs_to :primary_billing_location,        class_name: "Location"
       belongs_to :default_currency,                class_name: "Currency"
+      belongs_to :default_payment_method,          class_name: "PaymentMethod"
       belongs_to :default_payment_term,            class_name: "PaymentTerm"
       belongs_to :billing_contact,                 class_name: "User"
       belongs_to :default_sales_order_tax_type,    class_name: "TaxType"

data/lib/gecko/record/base_adapter.rb

@@ -111,7 +111,7 @@ module Gecko
       #
       # @api public
       def where(params = {})
-        response = @last_response = request(:get, plural_path, params: params)
+        response = request(:get, plural_path, params: params)
         parsed_response = response.parsed
         set_pagination(response.headers)
         parse_records(parsed_response)
@@ -203,7 +203,7 @@ module Gecko
       # @api private
       def fetch(id) # rubocop:disable Metrics/MethodLength
         verify_id_presence!(id)
-        response = @last_response = request(:get, plural_path + '/' + id.to_s)
+        response = request(:get, plural_path + '/' + id.to_s)
         record_json = extract_record(response.parsed)
         instantiate_and_register_record(record_json)
       rescue OAuth2::Error => e
@@ -343,7 +343,7 @@ module Gecko
       #
       # @api private
       def create_record(record, opts = {})
-        response = @last_response = request(:post, plural_path, {
+        response = request(:post, plural_path, {
           body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
@@ -356,7 +356,7 @@ module Gecko
       #
       # @api private
       def update_record(record, opts = {})
-        response = @last_response = request(:put, plural_path + "/" + record.id.to_s, {
+        response = request(:put, plural_path + "/" + record.id.to_s, {
           body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
@@ -431,18 +431,24 @@ module Gecko
       # @return [OAuth2::Response]
       #
       # @api private
-      def request(verb, path, options = {}) # rubocop:disable Metrics/MethodLength
+      def request(verb, path, options = {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
         ActiveSupport::Notifications.instrument('request.gecko') do |payload|
           payload[:verb]         = verb
           payload[:params]       = options[:params]
           payload[:body]         = options[:body]
           payload[:model_class]  = model_class
           payload[:request_path] = path
+
           options[:headers]      = options.fetch(:headers, {}).tap do |headers|
             headers['Content-Type'] = 'application/json'
           end
-          options[:body]         = options[:body].to_json if options[:body]
-          payload[:response]     = @client.access_token.request(verb, path, options)
+
+          options[:body] = options[:body].to_json if options[:body]
+
+          @client.access_token.request(verb, path, options.merge(raise_errors: false)).tap do |response|
+            payload[:response] = @last_response = response
+            raise response.error if response.error && options[:raise_errors] != false
+          end
         end
       end
 

data/lib/gecko/record/company.rb

@@ -7,6 +7,7 @@ module Gecko
     class Company < Base
       belongs_to :assignee,               class_name: "User"
       belongs_to :default_tax_type,       class_name: "TaxType"
+      belongs_to :default_payment_method, class_name: "PaymentMethod"
       belongs_to :default_payment_term,   class_name: "PaymentTerm"
       belongs_to :default_stock_location, class_name: "Location"
       # belongs_to :default_price_list,   class_name: "PriceList"

data/lib/gecko/record/payment_method.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+require 'gecko/record/base'
+
+module Gecko
+  module Record
+    class PaymentMethod < Base
+      attribute :name,        String
+      attribute :is_default,  Boolean,   readonly: true
+    end
+
+    class PaymentMethodAdapter < BaseAdapter
+    end
+  end
+end

data/lib/gecko/record/purchase_order.rb

@@ -20,7 +20,10 @@ module Gecko
       attribute :order_number,          String
       attribute :reference_number,      String
       attribute :email,                 String
+
       attribute :due_at,                Date
+      attribute :issued_at,             Date
+      attribute :payment_due_at,        Date
       attribute :received_at,           Date
 
       attribute :status,                String
@@ -34,9 +37,6 @@ module Gecko
       attribute :cached_quantity,       BigDecimal, readonly: true
 
       attribute :tags,                  Array[String]
-
-      # DEPRECATED
-      # attribute :cached_total,          BigDecimal, readonly: true
     end
 
     class PurchaseOrderAdapter < BaseAdapter

data/lib/gecko/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gecko
-  VERSION = '0.11.1'
+  VERSION = '0.12.3'
 end

data/lib/gecko.rb

@@ -32,6 +32,7 @@ require 'gecko/record/user'
 require 'gecko/record/purchase_order'
 require 'gecko/record/purchase_order_line_item'
 require 'gecko/record/tax_type'
+require 'gecko/record/payment_method'
 require 'gecko/record/payment_term'
 require 'gecko/record/webhook'
 

data/test/fixtures/vcr_cassettes/payment_methods.yml

@@ -0,0 +1,69 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.lvh.me:3000/payment_methods?limit=5
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Gecko/0.12.0 OAuth2/1.4.1 Faraday/0.15.4 Ruby/2.5.7
+      Content-Type:
+      - application/json
+      Authorization:
+      - Bearer <__ACCESS_TOKEN__>
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Frame-Options:
+      - SAMEORIGIN
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Content-Type-Options:
+      - nosniff
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      X-Rate-Limit-Limit:
+      - '300'
+      X-Rate-Limit-Remaining:
+      - '299'
+      X-Rate-Limit-Reset:
+      - '1594871400'
+      Cache-Control:
+      - no-cache, no-store
+      X-Pagination:
+      - '{"total_records":11,"total_pages":3,"first_page":true,"last_page":false,"out_of_bounds":false,"offset":0}'
+      Link:
+      - <http://api.lvh.me:3000/ajax/payment_methods?limit=5&page=2>; rel="next",
+        <http://api.lvh.me:3000/ajax/payment_methods?limit=5&page=3>; rel="last"
+      Content-Type:
+      - application/json; charset=utf-8
+      Etag:
+      - W/"7462907dae56049f84e55abca4a15c5e"
+      X-Request-Id:
+      - ac553ee8-d518-404c-bd7b-215a168d164c
+      X-Runtime:
+      - '0.108324'
+      Connection:
+      - close
+      Server:
+      - thin
+    body:
+      encoding: UTF-8
+      string: '{"payment_methods":[{"id":32,"created_at":"2020-07-16T03:46:03.946Z","updated_at":"2020-07-16T03:46:03.946Z","name":"PayNow","is_default":false},{"id":31,"created_at":"2020-07-16T03:45:50.096Z","updated_at":"2020-07-16T03:45:50.096Z","name":"Singtel
+        Dash","is_default":false},{"id":30,"created_at":"2020-07-16T03:45:36.276Z","updated_at":"2020-07-16T03:45:36.276Z","name":"eNets","is_default":false},{"id":29,"created_at":"2020-07-16T03:45:21.473Z","updated_at":"2020-07-16T03:45:21.473Z","name":"Voucher","is_default":false},{"id":28,"created_at":"2020-07-16T03:45:15.160Z","updated_at":"2020-07-16T03:45:15.160Z","name":"Credit
+        Note","is_default":false}]}'
+    http_version: null
+  recorded_at: Thu, 16 Jul 2020 03:48:15 GMT
+recorded_with: VCR 5.1.0

data/test/fixtures/vcr_cassettes/payment_methods_count.yml

@@ -0,0 +1,66 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://api.lvh.me:3000/payment_methods?limit=0
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Gecko/0.12.0 OAuth2/1.4.1 Faraday/0.15.4 Ruby/2.5.7
+      Content-Type:
+      - application/json
+      Authorization:
+      - Bearer <__ACCESS_TOKEN__>
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Frame-Options:
+      - SAMEORIGIN
+      X-Xss-Protection:
+      - 1; mode=block
+      X-Content-Type-Options:
+      - nosniff
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      X-Rate-Limit-Limit:
+      - '300'
+      X-Rate-Limit-Remaining:
+      - '299'
+      X-Rate-Limit-Reset:
+      - '1594871400'
+      Cache-Control:
+      - no-cache, no-store
+      X-Pagination:
+      - '{"total_records":11,"total_pages":1,"first_page":true,"last_page":true,"out_of_bounds":false,"offset":0}'
+      Link:
+      - <http://api.lvh.me:3000/ajax/payment_methods?limit=0&page=1>; rel="last"
+      Content-Type:
+      - application/json; charset=utf-8
+      Etag:
+      - W/"98c458ef2a733afd7d9fbf88e776e5c2"
+      X-Request-Id:
+      - 89f1b27c-35d7-4b3c-a356-d87c0a1d4cc1
+      X-Runtime:
+      - '0.160860'
+      Connection:
+      - close
+      Server:
+      - thin
+    body:
+      encoding: UTF-8
+      string: '{"payment_methods":[]}'
+    http_version: null
+  recorded_at: Thu, 16 Jul 2020 03:48:14 GMT
+recorded_with: VCR 5.1.0

data/test/record/payment_method_adapter_test.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class Gecko::Record::PaymentMethodAdapterTest < Minitest::Test
+  include TestingAdapter
+  include SharedAdapterExamples
+
+  let(:adapter)       { @client.PaymentMethod }
+  let(:plural_name)   { "payment_methods" }
+  let(:record_class)  { Gecko::Record::PaymentMethod }
+
+  def test_initializes_adapter
+    assert_instance_of(Gecko::Record::PaymentMethodAdapter, @client.PaymentMethod)
+  end
+end

data/test/record/payment_method_test.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class Gecko::PaymentMethodTest < Minitest::Test
+  include VCRHelper
+  include SharedRecordExamples
+
+  let(:plural_name)   { "payment_methods" }
+  let(:record_class)  { Gecko::Record::PaymentMethod }
+
+  def setup
+    @json   = load_vcr_hash("payment_methods", "payment_methods").first
+    @record = record_class.new(client, @json)
+  end
+
+  def test_initializes_record
+    assert_instance_of(Gecko::Record::PaymentMethod, @record)
+  end
+end

data/test/support/shared_adapter_examples.rb

@@ -147,7 +147,7 @@ module SharedAdapterExamples # rubocop:disable Metrics/ModuleLength
   def test_saving_record_with_idempotency_key # rubocop:disable Metrics/MethodLength
     record = adapter.build
     mock_token = mock
-    mock_response = mock(status: 200, parsed: { plural_name.singularize => { id: 123 } })
+    mock_response = mock(status: 200, parsed: { plural_name.singularize => { id: 123 } }, error: nil)
     mock_token.expects(:request)
               .with(:post, plural_name, {
                 body:         record.as_json.to_json,
@@ -165,7 +165,7 @@ private
 
   def mock_api_request(record, request, response)
     mock_token = mock
-    mock_response = mock(status: response[0], parsed: response[1])
+    mock_response = mock(status: response[0], parsed: response[1], error: nil)
     mock_token.expects(:request)
               .with(request[0], request[1], {
                 body:         record.as_json.to_json,

data/test/test_helper.rb

@@ -15,9 +15,19 @@ require 'support/shared_sideloaded_data_parsing_examples'
 require 'support/testing_adapter'
 require 'support/vcr_support'
 
+ENV_SECRETS = %w[
+  OAUTH_ID
+  OAUTH_SECRET
+  ACCESS_TOKEN
+  REFRESH_TOKEN
+].freeze
+
 VCR.configure do |c|
   c.cassette_library_dir = 'test/fixtures/vcr_cassettes'
   c.hook_into :webmock
+  ENV_SECRETS.each do |variable|
+    c.filter_sensitive_data("<__#{variable}__>") { ENV[variable] }
+  end
 end
 
 class Minitest::Test

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gecko-ruby
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.3
 platform: ruby
 authors:
 - Bradley Priest
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2021-12-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -199,7 +199,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/config/rubocop_linter_action.yml"
 - ".github/workflows/testing.yml"
 - ".gitignore"
 - ".hound.yml"
@@ -239,6 +238,7 @@ files:
 - lib/gecko/record/note.rb
 - lib/gecko/record/order.rb
 - lib/gecko/record/order_line_item.rb
+- lib/gecko/record/payment_method.rb
 - lib/gecko/record/payment_term.rb
 - lib/gecko/record/product.rb
 - lib/gecko/record/purchase_order.rb
@@ -275,6 +275,8 @@ files:
 - test/fixtures/vcr_cassettes/order_line_items_specific_count.yml
 - test/fixtures/vcr_cassettes/orders.yml
 - test/fixtures/vcr_cassettes/orders_count.yml
+- test/fixtures/vcr_cassettes/payment_methods.yml
+- test/fixtures/vcr_cassettes/payment_methods_count.yml
 - test/fixtures/vcr_cassettes/payment_terms.yml
 - test/fixtures/vcr_cassettes/payment_terms_count.yml
 - test/fixtures/vcr_cassettes/products.yml
@@ -325,6 +327,8 @@ files:
 - test/record/order_line_item_adapter_test.rb
 - test/record/order_line_item_test.rb
 - test/record/order_test.rb
+- test/record/payment_method_adapter_test.rb
+- test/record/payment_method_test.rb
 - test/record/payment_term_adapter_test.rb
 - test/record/payment_term_test.rb
 - test/record/product_adapter_test.rb
@@ -366,7 +370,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: A Ruby interface to the TradeGecko API.
@@ -398,6 +402,8 @@ test_files:
 - test/fixtures/vcr_cassettes/order_line_items_specific_count.yml
 - test/fixtures/vcr_cassettes/orders.yml
 - test/fixtures/vcr_cassettes/orders_count.yml
+- test/fixtures/vcr_cassettes/payment_methods.yml
+- test/fixtures/vcr_cassettes/payment_methods_count.yml
 - test/fixtures/vcr_cassettes/payment_terms.yml
 - test/fixtures/vcr_cassettes/payment_terms_count.yml
 - test/fixtures/vcr_cassettes/products.yml
@@ -448,6 +454,8 @@ test_files:
 - test/record/order_line_item_adapter_test.rb
 - test/record/order_line_item_test.rb
 - test/record/order_test.rb
+- test/record/payment_method_adapter_test.rb
+- test/record/payment_method_test.rb
 - test/record/payment_term_adapter_test.rb
 - test/record/payment_term_test.rb
 - test/record/product_adapter_test.rb

data/.github/config/rubocop_linter_action.yml

@@ -1,7 +0,0 @@
----
-check_name: 'Rubocop Results'
-check_scope: 'modified'
-versions:
-  - rubocop
-  - rubocop-minitest
-  - rubocop-performance