gecko-ruby 0.11.1 → 0.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d199e8dad0e8cfc71dab3994fd32e91d9862fbacd17e5ef33b7ea56042a0c47b
-  data.tar.gz: d588aafb7703430db428da743fda7f5acab475759b5c45cb007f843b0fe41822
+  metadata.gz: ebfbdacb19b2e0dbc4478c614578298de91e01e1ee79d29ace8833da5ef5ce4d
+  data.tar.gz: 4d4e8551a79728045733fb7fa336a30b655e779c152ae7d0a8ec49af1c746aff
 SHA512:
-  metadata.gz: ded7f2c92168eb1266b892d91d81902715893ba6df9c3b3d5b738b7655ea8a3a031046324718d170741b9dd9397316aa403d129234eed16dcfb5175ca0bc0dea
-  data.tar.gz: 0c4684e13aef815bb59a2b09a49c7cb6625c9201a85af9b9cbad569a2291287a10dc2c9bdb006ac9a31581a1b3ae8bc8651ac0c1b30ba4090158799425578f1e
+  metadata.gz: 92333d13c62ab98a009c8d8a6396dcd89be342fa3d58fb152a024330f419d44d113aaa19aedbe34de10ba7a3741bb8fd54bab20ee6bb33597edee8131629f386
+  data.tar.gz: e74fb5237da5c6a1a023517c6cc8fa76f5f45f4674362f887ccb82d7887d159aa95f3e329a6faf65fa8bcdfe359874735791db1d3d1b08362e5c2a67afee28cb

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.12.0 (2020-07-09)
+- Silence warnings in Ruby 2.7
+- Ensure response is passed to `ActiveSupport::Notifications` on error
+- Ensure `adapter.last_response` is set on error response
+
 ## 0.11.1 (2020-04-30)
 - Fix addresses on Invoice
 

data/lib/gecko/helpers/association_helper.rb

@@ -72,7 +72,7 @@ module Gecko
                              []
                            end
 
-              build_collection_proxy(collection, {
+              build_collection_proxy(collection, **{
                 embedded:         options[:embedded],
                 class_name:       class_name,
                 association_name: association_name
@@ -100,7 +100,7 @@ module Gecko
       #
       # @api private
       def build_collection_proxy(target, association_name:, class_name:, embedded:)
-        CollectionProxy.new({
+        CollectionProxy.new(**{
           parent:           self,
           target:           target,
           embedded:         embedded,

data/lib/gecko/record/base_adapter.rb

@@ -111,7 +111,7 @@ module Gecko
       #
       # @api public
       def where(params = {})
-        response = @last_response = request(:get, plural_path, params: params)
+        response = request(:get, plural_path, params: params)
         parsed_response = response.parsed
         set_pagination(response.headers)
         parse_records(parsed_response)
@@ -203,7 +203,7 @@ module Gecko
       # @api private
       def fetch(id) # rubocop:disable Metrics/MethodLength
         verify_id_presence!(id)
-        response = @last_response = request(:get, plural_path + '/' + id.to_s)
+        response = request(:get, plural_path + '/' + id.to_s)
         record_json = extract_record(response.parsed)
         instantiate_and_register_record(record_json)
       rescue OAuth2::Error => e
@@ -343,7 +343,7 @@ module Gecko
       #
       # @api private
       def create_record(record, opts = {})
-        response = @last_response = request(:post, plural_path, {
+        response = request(:post, plural_path, {
           body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
@@ -356,7 +356,7 @@ module Gecko
       #
       # @api private
       def update_record(record, opts = {})
-        response = @last_response = request(:put, plural_path + "/" + record.id.to_s, {
+        response = request(:put, plural_path + "/" + record.id.to_s, {
           body:         record.as_json,
           raise_errors: false
         }.merge(headers: headers_from_opts(opts)))
@@ -431,18 +431,24 @@ module Gecko
       # @return [OAuth2::Response]
       #
       # @api private
-      def request(verb, path, options = {}) # rubocop:disable Metrics/MethodLength
+      def request(verb, path, options = {}) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
         ActiveSupport::Notifications.instrument('request.gecko') do |payload|
           payload[:verb]         = verb
           payload[:params]       = options[:params]
           payload[:body]         = options[:body]
           payload[:model_class]  = model_class
           payload[:request_path] = path
+
           options[:headers]      = options.fetch(:headers, {}).tap do |headers|
             headers['Content-Type'] = 'application/json'
           end
-          options[:body]         = options[:body].to_json if options[:body]
-          payload[:response]     = @client.access_token.request(verb, path, options)
+
+          options[:body] = options[:body].to_json if options[:body]
+
+          @client.access_token.request(verb, path, options.merge(raise_errors: false)).tap do |response|
+            payload[:response] = @last_response = response
+            raise response.error if response.error && options[:raise_errors] != false
+          end
         end
       end
 

data/lib/gecko/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Gecko
-  VERSION = '0.11.1'
+  VERSION = '0.12.0'
 end

data/test/support/shared_adapter_examples.rb

@@ -147,7 +147,7 @@ module SharedAdapterExamples # rubocop:disable Metrics/ModuleLength
   def test_saving_record_with_idempotency_key # rubocop:disable Metrics/MethodLength
     record = adapter.build
     mock_token = mock
-    mock_response = mock(status: 200, parsed: { plural_name.singularize => { id: 123 } })
+    mock_response = mock(status: 200, parsed: { plural_name.singularize => { id: 123 } }, error: nil)
     mock_token.expects(:request)
               .with(:post, plural_name, {
                 body:         record.as_json.to_json,
@@ -165,7 +165,7 @@ private
 
   def mock_api_request(record, request, response)
     mock_token = mock
-    mock_response = mock(status: response[0], parsed: response[1])
+    mock_response = mock(status: response[0], parsed: response[1], error: nil)
     mock_token.expects(:request)
               .with(request[0], request[1], {
                 body:         record.as_json.to_json,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gecko-ruby
 version: !ruby/object:Gem::Version
-  version: 0.11.1
+  version: 0.12.0
 platform: ruby
 authors:
 - Bradley Priest
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-29 00:00:00.000000000 Z
+date: 2020-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler