geared_pagination 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6442a3bf0d55e8a7959814c6fd7d7e02da254952dbd829493aaf99c01bdd85f4
-  data.tar.gz: d064b59363360f871c6cc91adcce01d4a863d6379282fabb354fbeea0f402cfb
+  metadata.gz: c3e2956267a150a716db8afc9a1e0a9b03ac14906162faa283d5de88624b2f21
+  data.tar.gz: 85222f625262561aafae1025403375f21adc4fb3b78d750d68929183dcd2269b
 SHA512:
-  metadata.gz: becae20eab1dd38355befb8a1440dcd432c0743f94d59f27f7323a7a2386849736605c96ddb344aa45d039569d4a5b406d0732fec2576cdbe093a602084e4fbc
-  data.tar.gz: 066f7da6d2db1875602aeb1517bf0cb19be41fc142dd3104cd68e0e204b77c3f196cac3ca19604ef75132424a7c6d988352c2e5d5ee1ed651047b4680d5c0c6c
+  metadata.gz: ebaba73472a04348a60e2e73b679dc4040f39e9b2193816bdda3c111c3a6dc9d16bcf944d4a4adf3c41b9636f6f4d194d21137dcf652f727e3223ae0576b21b1
+  data.tar.gz: 657c6f6d8d0ee877910fb0f394e5229928325af59c471aa48c8bcddb34c75a824a5c92a128bb60757d2178205c914e3aaf3c2c96adcff036fba0098a30c7e3fe

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    geared_pagination (0.2)
+    geared_pagination (1.0.1)
       activesupport (>= 5.0)
       addressable (>= 2.5.0)
 
@@ -63,8 +63,8 @@ GEM
       minitest (~> 5.1)
       tzinfo (~> 1.1)
       zeitwerk (~> 2.2, >= 2.2.2)
-    addressable (2.5.2)
-      public_suffix (>= 2.0.2, < 4.0)
+    addressable (2.7.0)
+      public_suffix (>= 2.0.2, < 5.0)
     builder (3.2.4)
     byebug (10.0.2)
     concurrent-ruby (1.1.6)
@@ -89,7 +89,7 @@ GEM
     nio4r (2.5.2)
     nokogiri (1.10.9)
       mini_portile2 (~> 2.4.0)
-    public_suffix (3.0.3)
+    public_suffix (4.0.5)
     rack (2.2.2)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)

data/README.md

@@ -59,7 +59,7 @@ ORDER BY created_at DESC, id DESC
 LIMIT 30
 ```
 
-Geared Pagination supports cursor-based pagination. To use it, pass the `:order_by` option to `set_page_and_extract_portion_from` in your controllers. Provide the orders to apply to the paginated relation:
+Geared Pagination supports cursor-based pagination. To use it, pass the `:ordered_by` option to `set_page_and_extract_portion_from` in your controllers. Provide the orders to apply to the paginated relation:
 
 ```ruby
 set_page_and_extract_portion_from Message.all, ordered_by: { created_at: :desc, id: :desc }

data/geared_pagination.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'geared_pagination'
-  s.version  = '1.0.0'
+  s.version  = '1.0.1'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Paginate Active Record sets at variable speeds'

data/lib/geared_pagination/page.rb

@@ -35,7 +35,7 @@ module GearedPagination
     end
 
     def last?
-      number == recordset.page_count
+      number >= recordset.page_count
     end
 
 

data/test/page_test.rb

@@ -19,6 +19,11 @@ class GearedPagination::PageTest < ActiveSupport::TestCase
     assert_not GearedPagination::Recordset.new(Recording.all, per_page:    1).page(1).last?
   end
 
+  test "last with page number greater than page count" do
+    page_for_empty_set = GearedPagination::Recordset.new(Recording.none, per_page: 1000).page(2)
+    assert page_for_empty_set.last?
+  end
+
   test "next offset param" do
     assert_equal 2, GearedPagination::Recordset.new(Recording.all, per_page: 1000).page(1).next_param
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: geared_pagination
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-20 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport