gds-api-adapters 9.1.0 → 9.2.0

data/lib/gds_api/need_api.rb

@@ -37,4 +37,8 @@ class GdsApi::NeedApi < GdsApi::Base
     # author params: { "author" => { ... } }"
     delete_json!("#{endpoint}/needs/#{CGI.escape(need_id.to_s)}/closed", author)
   end
+
+  def create_note(note)
+    post_json!("#{endpoint}/notes", note)
+  end
 end

data/lib/gds_api/support.rb

@@ -1,24 +1,24 @@
 require_relative 'base'
 
 class GdsApi::Support < GdsApi::Base
-  def create_foi_request(request_details, options = {})
-    post_json!("#{base_url}/foi_requests", { :foi_request => request_details }, options[:headers] || {})
+  def create_foi_request(request_details)
+    post_json!("#{base_url}/foi_requests", { :foi_request => request_details })
   end
 
-  def create_problem_report(request_details, options = {})
-    post_json!("#{base_url}/anonymous_feedback/problem_reports", { :problem_report => request_details }, options[:headers] || {})
+  def create_problem_report(request_details)
+    post_json!("#{base_url}/anonymous_feedback/problem_reports", { :problem_report => request_details })
   end
 
-  def create_named_contact(request_details, options = {})
-    post_json!("#{base_url}/named_contacts", { :named_contact => request_details }, options[:headers] || {})
+  def create_named_contact(request_details)
+    post_json!("#{base_url}/named_contacts", { :named_contact => request_details })
   end
 
-  def create_anonymous_long_form_contact(request_details, options = {})
-    post_json!("#{base_url}/anonymous_feedback/long_form_contacts", { :long_form_contact => request_details }, options[:headers] || {})
+  def create_anonymous_long_form_contact(request_details)
+    post_json!("#{base_url}/anonymous_feedback/long_form_contacts", { :long_form_contact => request_details })
   end
 
-  def create_service_feedback(request_details, options = {})
-    post_json!("#{base_url}/anonymous_feedback/service_feedback", { :service_feedback => request_details }, options[:headers] || {})
+  def create_service_feedback(request_details)
+    post_json!("#{base_url}/anonymous_feedback/service_feedback", { :service_feedback => request_details })
   end
 
   def feedback_url(slug)

data/lib/gds_api/test_helpers/need_api.rb

@@ -77,6 +77,12 @@ module GdsApi
           headers: {}
         )
       end
+
+      def stub_create_note(note_details = nil)
+        post_stub = stub_request(:post, NEED_API_ENDPOINT + "/notes")
+        post_stub.with(:body => note_details.to_json) unless note_details.nil?
+        post_stub.to_return(:status => 201)
+      end
     end
   end
 end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '9.1.0'
+  VERSION = '9.2.0'
 end

data/test/need_api_test.rb

@@ -238,4 +238,22 @@ describe GdsApi::NeedApi do
       assert_requested reopen_stub
     end
   end
+
+  describe "creating notes" do
+    it "should send a post request" do
+      fields = {
+        "text" => "test",
+        "need_id" => "100001",
+        "author" => {
+          "name" => "Winston Smith-Churchill",
+          "email" => "winston@alphagov.co.uk"
+        }
+      }
+      request_stub = stub_create_note(fields)
+
+      @api.create_note(fields)
+
+      assert_requested(request_stub)
+    end
+  end
 end

data/test/support_api_test.rb

@@ -22,16 +22,6 @@ describe GdsApi::Support do
     assert_requested(stub_post)
   end
 
-  it "can add a custom header onto the FOI request to the support app" do
-    stub_request(:post, "#{@base_api_url}/foi_requests")
-
-    @api.create_foi_request({}, headers: { "X-Varnish" => "12345"})
-
-    assert_requested(:post, %r{/foi_requests}) do |request|
-      request.headers["X-Varnish"] == "12345"
-    end
-  end
-
   it "throws an exception when the support app isn't available" do
     support_isnt_available
 
@@ -62,16 +52,6 @@ describe GdsApi::Support do
     assert_requested(stub_post)
   end
 
-  it "can add a custom header onto the problem_report request to the support app" do
-    stub_request(:post, "#{@base_api_url}/anonymous_feedback/problem_reports")
-
-    @api.create_problem_report({}, headers: { "X-Varnish" => "12345"})
-
-    assert_requested(:post, %r{/problem_reports}) do |request|
-      request.headers["X-Varnish"] == "12345"
-    end
-  end
-
   it "can create a named contact" do
     request_details = {certain: "details"}
 
@@ -84,16 +64,6 @@ describe GdsApi::Support do
     assert_requested(stub_post)
   end
 
-  it "can add a custom header onto the named_contact request to the support app" do
-    stub_request(:post, "#{@base_api_url}/named_contacts")
-
-    @api.create_named_contact({}, headers: { "X-Varnish" => "12345"})
-
-    assert_requested(:post, %r{/named_contacts}) do |request|
-      request.headers["X-Varnish"] == "12345"
-    end
-  end
-
   it "throws an exception when the support app isn't available" do
     support_isnt_available
 
@@ -112,16 +82,6 @@ describe GdsApi::Support do
     assert_requested(stub_post)
   end
 
-  it "can add a custom header onto the service feedback to the support app" do
-    stub_request(:post, "#{@base_api_url}/anonymous_feedback/service_feedback")
-
-    @api.create_service_feedback({}, headers: { "X-Varnish" => "12345"})
-
-    assert_requested(:post, %r{/service_feedback}) do |request|
-      request.headers["X-Varnish"] == "12345"
-    end
-  end
-
   it "throws an exception when the support app isn't available" do
     support_isnt_available
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 9.1.0
+  version: 9.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek
@@ -367,7 +367,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2182195135345570645
+      hash: 3249051588083426737
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -376,7 +376,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2182195135345570645
+      hash: 3249051588083426737
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23