gds-api-adapters 70.0.0 → 71.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 632391e17f65b54797ea177945c0993fc71545d61a10975b244cf45355723ca1
-  data.tar.gz: dc7b387e7d2038c54541d4dd5382a75d316bbe383870326e89c6c31e8fdbb229
+  metadata.gz: f43e07de0971fb6d31f613c0e6ecf3894ddc198755ad003da36e6c43e37dedf5
+  data.tar.gz: 66369531af1d7c4412b79994759e360b78cb67b2e842a3d6f82e10267bd18876
 SHA512:
-  metadata.gz: e1a99f505078d1b27dba69a7b53b1945fdc83c2eb25fb0a6627090d6b77b67b43f324f8ff1ae76c447608e0265749083b78f74d28ec5c7703be4600aebf15174
-  data.tar.gz: a02640e69fb8a4d0292bdd97dee1061c5c498c5412812d74b40733bd7e10a06077631b93f74e8687b763362e1b4776221e60e201d287cbccf3b6d6d1868795c4
+  metadata.gz: ca1f75189c94449dac72f8e3826b67c36d57e55a40103a69aa2cc48dce9cbc75eff901b060d2d360d301ec482bca4937f5178a57b3b53a1e497bb96ca1a84490
+  data.tar.gz: 2cca74c89f2a0f827a09917fe6817aeac7199871f1f4c990845668b68c7daff9889dd2f885c809399c732d98b8c074f607072c24db8ad438a287b23f96a5dcb9

data/lib/gds_api/account_api.rb

@@ -75,7 +75,7 @@ class GdsApi::AccountApi < GdsApi::Base
   #
   # @return [Hash] A new session header
   def set_attributes(attributes:, govuk_account_session:)
-    patch_json("#{endpoint}/api/attributes", { attributes: attributes.transform_values(&:to_json) }, auth_headers(govuk_account_session))
+    patch_json("#{endpoint}/api/attributes", { attributes: attributes }, auth_headers(govuk_account_session))
   end
 
 private

data/lib/gds_api/test_helpers/account_api.rb

@@ -87,11 +87,11 @@ module GdsApi
       def stub_account_api_set_attributes(govuk_account_session: nil, attributes: nil, new_govuk_account_session: nil)
         if govuk_account_session
           stub_request(:patch, "#{ACCOUNT_API_ENDPOINT}/api/attributes")
-            .with(body: hash_including({ attributes: attributes&.transform_values(&:to_json) }.compact), headers: { GdsApi::AccountApi::AUTH_HEADER_NAME => govuk_account_session })
+            .with(body: hash_including({ attributes: attributes }.compact), headers: { GdsApi::AccountApi::AUTH_HEADER_NAME => govuk_account_session })
             .to_return(status: 200, body: { govuk_account_session: new_govuk_account_session }.compact.to_json)
         else
           stub_request(:patch, "#{ACCOUNT_API_ENDPOINT}/api/attributes")
-            .with(body: hash_including({ attributes: attributes&.transform_values(&:to_json) }.compact))
+            .with(body: hash_including({ attributes: attributes }.compact))
             .to_return(status: 200, body: { govuk_account_session: new_govuk_account_session }.compact.to_json)
         end
       end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = "70.0.0".freeze
+  VERSION = "71.0.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 70.0.0
+  version: 71.0.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-15 00:00:00.000000000 Z
+date: 2021-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -389,8 +389,6 @@ files:
 - lib/gds_api/maslow.rb
 - lib/gds_api/middleware/govuk_header_sniffer.rb
 - lib/gds_api/organisations.rb
-- lib/gds_api/performance_platform/data_in.rb
-- lib/gds_api/performance_platform/data_out.rb
 - lib/gds_api/publishing_api.rb
 - lib/gds_api/publishing_api/special_route_publisher.rb
 - lib/gds_api/railtie.rb
@@ -413,8 +411,6 @@ files:
 - lib/gds_api/test_helpers/local_links_manager.rb
 - lib/gds_api/test_helpers/mapit.rb
 - lib/gds_api/test_helpers/organisations.rb
-- lib/gds_api/test_helpers/performance_platform/data_in.rb
-- lib/gds_api/test_helpers/performance_platform/data_out.rb
 - lib/gds_api/test_helpers/publishing_api.rb
 - lib/gds_api/test_helpers/router.rb
 - lib/gds_api/test_helpers/search.rb

data/lib/gds_api/performance_platform/data_in.rb

@@ -1,27 +0,0 @@
-require_relative "../base"
-
-module GdsApi
-  class PerformancePlatformDatasetNotConfigured < BaseError; end
-
-  module PerformancePlatform
-    class DataIn < GdsApi::Base
-      def submit_service_feedback_day_aggregate(slug, request_details)
-        post_json("#{endpoint}/data/#{slug}/customer-satisfaction", request_details)
-      rescue GdsApi::HTTPNotFound
-        raise PerformancePlatformDatasetNotConfigured, "Dataset for slug [#{slug}] not set up"
-      end
-
-      def corporate_content_problem_report_count(entries)
-        post_json("#{endpoint}/data/gov-uk-content/feedback-count", entries)
-      end
-
-      def corporate_content_urls_with_the_most_problem_reports(entries)
-        post_json("#{endpoint}/data/gov-uk-content/top-urls", entries)
-      end
-
-      def submit_problem_report_daily_totals(entries)
-        post_json("#{endpoint}/data/govuk-info/page-contacts", entries)
-      end
-    end
-  end
-end

data/lib/gds_api/performance_platform/data_out.rb

@@ -1,131 +0,0 @@
-require_relative "../base"
-
-module GdsApi
-  module PerformancePlatform
-    class DataOut < GdsApi::Base
-      # Fetch all service feedback from the performance platform for a given transaction
-      # page slug.
-      #
-      # Makes a +GET+ request.
-      #
-      # The results are ordered date ascending.
-      #
-      # @param transaction_page_slug [String] The slug for which service feedback is
-      # needed.
-      #
-      # # @example
-      #
-      #  performance_platform_data_out.service_feedback('register-to-vote')
-      #
-      #  #=> {
-      #      "data": [
-      #   {
-      #     "_day_start_at": "2014-06-10T00:00:00+00:00",
-      #     "_hour_start_at": "2014-06-10T00:00:00+00:00",
-      #     "_id": "20140610_register-to-vote",
-      #     "_month_start_at": "2014-06-01T00:00:00+00:00",
-      #     "_quarter_start_at": "2014-04-01T00:00:00+00:00",
-      #     "_timestamp": "2014-06-10T00:00:00+00:00",
-      #     "_updated_at": "2014-06-11T00:30:50.901000+00:00",
-      #     "_week_start_at": "2014-06-09T00:00:00+00:00",
-      #     "comments": 217,
-      #     "period": "day",
-      #     "rating_1": 4,
-      #     "rating_2": 6,
-      #     "rating_3": 7,
-      #     "rating_4": 74,
-      #     "rating_5": 574,
-      #     "slug": "register-to-vote",
-      #     "total": 665
-      #   },
-      #   ...
-      #  }
-      def service_feedback(transaction_page_slug)
-        get_json("#{endpoint}/data/#{transaction_page_slug}/customer-satisfaction")
-      end
-
-      # Fetching statistics data from the performance platform for a given page slug
-      #
-      # Makes a +GET+ request.
-      #
-      # @param slug [String] Points to the page for which we are requesting
-      # statistics.
-      # @param is_multipart [Boolean] Flag that marks whether the slug is multipart
-      # or not:
-      #
-      # - simple: `/european-health-insurance-card`
-      # - multipart: `/european-health-insurance-card/123`
-      #
-      # # @examples
-      #
-      #  1. Without multipart filtering:
-      #
-      #  performance_platform_data_out.search_terms('/european-health-insurance-card')
-      #
-      #  2. With multipart filtering:
-      #
-      #  performance_platform_data_out.searches('/european-health-insurance-card', true)
-      #  performance_platform_data_out.page_views('/european-health-insurance-card', true)
-      #  performance_platform_data_out.problem_reports('/european-health-insurance-card', true)
-
-      def search_terms(slug)
-        options = {
-          slug: slug,
-          transaction: "search-terms",
-          group_by: "searchKeyword",
-          collect: "searchUniques:sum",
-        }
-        statistics(options)
-      end
-
-      def searches(slug, is_multipart)
-        options = {
-          slug: slug,
-          transaction: "search-terms",
-          group_by: "pagePath",
-          collect: "searchUniques:sum",
-        }
-        statistics(options, is_multipart)
-      end
-
-      def page_views(slug, is_multipart)
-        options = {
-          slug: slug,
-          transaction: "page-statistics",
-          group_by: "pagePath",
-          collect: "uniquePageviews:sum",
-        }
-        statistics(options, is_multipart)
-      end
-
-      def problem_reports(slug, is_multipart)
-        options = {
-          slug: slug,
-          transaction: "page-contacts",
-          group_by: "pagePath",
-          collect: "total:sum",
-        }
-        statistics(options, is_multipart)
-      end
-
-      # This can be used as a free form call to the performance platform.
-      # The performance platform uses Backdrop and its query language for
-      # storing and querying data.
-      # Backdrop can be found here: https://github.com/alphagov/backdrop
-      def statistics(options, is_multipart = false) # rubocop:disable Style/OptionalBooleanParameter
-        params = {
-          group_by: options[:group_by],
-          collect: options[:collect],
-          duration: 42,
-          period: "day",
-          end_at: Date.today.to_time.getutc.iso8601,
-        }
-
-        filter_param = is_multipart ? :filter_by_prefix : :filter_by
-        params[filter_param] = "pagePath:#{options[:slug]}"
-
-        get_json("#{endpoint}/data/govuk-info/#{options[:transaction]}#{query_string(params)}")
-      end
-    end
-  end
-end

data/lib/gds_api/test_helpers/performance_platform/data_in.rb

@@ -1,45 +0,0 @@
-module GdsApi
-  module TestHelpers
-    module PerformancePlatform
-      module DataIn
-        PP_DATA_IN_ENDPOINT = "http://www.performance.dev.gov.uk".freeze
-
-        def stub_service_feedback_day_aggregate_submission(slug, request_body = nil)
-          post_stub = stub_http_request(:post, "#{PP_DATA_IN_ENDPOINT}/data/#{slug}/customer-satisfaction")
-          post_stub.with(body: request_body) unless request_body.nil?
-          post_stub.to_return(status: 200)
-        end
-
-        def stub_corporate_content_problem_report_count_submission(submissions = nil)
-          post_stub = stub_http_request(:post, "#{PP_DATA_IN_ENDPOINT}/data/gov-uk-content/feedback-count")
-          post_stub.with(body: submissions.to_json) unless submissions.nil?
-          post_stub.to_return(status: 200)
-        end
-
-        def stub_corporate_content_urls_with_the_most_problem_reports_submission(submissions = nil)
-          post_stub = stub_http_request(:post, "#{PP_DATA_IN_ENDPOINT}/data/gov-uk-content/top-urls")
-          post_stub.with(body: submissions.to_json) unless submissions.nil?
-          post_stub.to_return(status: 200)
-        end
-
-        def stub_problem_report_daily_totals_submission(submissions = nil)
-          post_stub = stub_http_request(:post, "#{PP_DATA_IN_ENDPOINT}/data/govuk-info/page-contacts")
-          post_stub.with(body: submissions.to_json) unless submissions.nil?
-          post_stub.to_return(status: 200)
-        end
-
-        def stub_service_feedback_bucket_unavailable_for(slug)
-          stub_request(:post, "#{PP_DATA_IN_ENDPOINT}/data/#{slug}/customer-satisfaction").to_return(status: 404)
-        end
-
-        def stub_pp_isnt_available
-          stub_request(:post, /#{PP_DATA_IN_ENDPOINT}\/.*/).to_return(status: 503)
-        end
-
-        def stub_pp_dataset_unavailable
-          stub_request(:any, /#{PP_DATA_IN_ENDPOINT}/).to_return(status: 404)
-        end
-      end
-    end
-  end
-end

data/lib/gds_api/test_helpers/performance_platform/data_out.rb

@@ -1,98 +0,0 @@
-module GdsApi
-  module TestHelpers
-    module PerformancePlatform
-      module DataOut
-        PP_DATA_OUT_ENDPOINT = "https://www.performance.service.gov.uk".freeze
-
-        def stub_service_feedback(slug, response_body = {})
-          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction")
-            .to_return(status: 200, body: response_body.to_json)
-        end
-
-        def stub_data_set_not_available(slug)
-          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction")
-            .to_return(status: 404)
-        end
-
-        def stub_service_not_available
-          stub_request(:any, /#{PP_DATA_OUT_ENDPOINT}\/.*/).to_return(status: 503)
-        end
-
-        def stub_search_terms(slug, response_body = {})
-          options = {
-            slug: slug,
-            transaction: "search-terms",
-            group_by: "searchKeyword",
-            collect: "searchUniques:sum",
-          }
-          stub_statistics(options, false, response_body)
-        end
-
-        def stub_searches(slug, is_multipart, response_body = {})
-          options = {
-            slug: slug,
-            transaction: "search-terms",
-            group_by: "pagePath",
-            collect: "searchUniques:sum",
-          }
-          stub_statistics(options, is_multipart, response_body)
-        end
-
-        def stub_page_views(slug, is_multipart, response_body = {})
-          options = {
-            slug: slug,
-            transaction: "page-statistics",
-            group_by: "pagePath",
-            collect: "uniquePageviews:sum",
-          }
-          stub_statistics(options, is_multipart, response_body)
-        end
-
-        def stub_problem_reports(slug, is_multipart, response_body = {})
-          options = {
-            slug: slug,
-            transaction: "page-contacts",
-            group_by: "pagePath",
-            collect: "total:sum",
-          }
-          stub_statistics(options, is_multipart, response_body)
-        end
-
-        def stub_statistics(options, is_multipart, response_body = {})
-          params = {
-            group_by: options[:group_by],
-            collect: options[:collect],
-            duration: 42,
-            period: "day",
-            end_at: Date.today.to_time.getutc.iso8601,
-          }
-
-          filter_param = is_multipart ? :filter_by_prefix : :filter_by
-          params[filter_param] = "pagePath:#{options[:slug]}"
-
-          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/#{options[:transaction]}")
-              .with(query: params)
-              .to_return(status: 200, body: response_body.to_json)
-        end
-
-        def stub_search_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/search-terms")
-              .with(query: hash_including(filter_by: slug))
-              .to_return(status: 404, headers: { content_type: "application/json" })
-        end
-
-        def stub_page_views_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-statistics")
-              .with(query: hash_including(filter_by: slug))
-              .to_return(status: 404, headers: { content_type: "application/json" })
-        end
-
-        def stub_problem_reports_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-contacts")
-              .with(query: hash_including(filter_by: slug))
-              .to_return(status: 404, headers: { content_type: "application/json" })
-        end
-      end
-    end
-  end
-end