gds-api-adapters 63.6.0 → 67.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c63bd76ee4646694f763c71980fcce76ae359bfd12ad2de8437679eb0f389422
-  data.tar.gz: 5729acfdc3d52d7fd1c7e053a7740bc09424006088e6ce0631fed2144479e267
+  metadata.gz: 35ee9f533f626d99fe8f62ae41b6445e2f75729c333b096c52b90c49555e1d69
+  data.tar.gz: b1413571e9e8bf09d19497c88790549c947c66258fd25bd11884a6ade859acdf
 SHA512:
-  metadata.gz: 7676cf189a66b0b699c08ae50605a4f481da8b775201876e641167b49d7a6fc33a2139c97f4b7d0801af335e3c32929afc7bb8c6cc562cd2999c889f7603f5c3
-  data.tar.gz: 2c9f91be586e98a61e91dccf0c8bb66a9db31d1bbac59eccabf13e7fc8689f169126907d15a50ad483cb5605934240438ce5e2fbd97243511718be2278e7c359
+  metadata.gz: b05108e31ccb65d3c2e4735792de423580f2cdbb2ea8d8d0c6de92955b24084559f7e25b6aaed2cbca34b17734d37f2f9df98a5f8d676bcf8e072dc3880aef2b
+  data.tar.gz: 37ff704afc41d4b516ee043358099d9aadc4097ab0d6f70f47a3c38ed922e29d22c0f3b82a1bcac612c53af8c9649a72066709ddf8134ffe1279125f4e81d62f

data/README.md

@@ -5,7 +5,6 @@ A set of API adapters to work with the GDS APIs.
 Example usage:
 
 ```ruby
-require 'gds_api/publishing_api'
 GdsApi.publishing_api.get_content("f3bbdec2-0e62-4520-a7fd-6ffd5d36e03a")
 ```
 

data/Rakefile

@@ -1,5 +1,3 @@
-# -*- encoding: utf-8 -*-
-
 require "rdoc/task"
 require "rake/testtask"
 
@@ -13,7 +11,8 @@ Rake::TestTask.new("test") do |t|
   t.test_files = FileList["test/**/*_test.rb"]
   t.warning = false
 end
-task default: :test
+
+task default: %i[lint test]
 
 require "pact_broker/client/tasks"
 
@@ -31,5 +30,5 @@ end
 
 desc "Run the linter against changed files"
 task :lint do
-  sh "bundle exec rubocop --format clang lib test"
+  sh "bundle exec rubocop --format clang"
 end

data/lib/gds_api.rb

@@ -11,7 +11,6 @@ require "gds_api/mapit"
 require "gds_api/maslow"
 require "gds_api/organisations"
 require "gds_api/publishing_api"
-require "gds_api/publishing_api_v2"
 require "gds_api/router"
 require "gds_api/search"
 require "gds_api/support"
@@ -139,19 +138,6 @@ module GdsApi
     )
   end
 
-  # Creates a GdsApi::PublishingApiV2 adapter
-  #
-  # This will set a bearer token if a PUBLISHING_API_BEARER_TOKEN environment
-  # variable is set
-  #
-  # @return [GdsApi::PublishingApiV2]
-  def self.publishing_api_v2(options = {})
-    GdsApi::PublishingApiV2.new(
-      Plek.find("publishing-api"),
-      { bearer_token: ENV["PUBLISHING_API_BEARER_TOKEN"] }.merge(options),
-    )
-  end
-
   # Creates a GdsApi::Router adapter for communicating with Router API
   #
   # This will set a bearer token if a ROUTER_API_BEARER_TOKEN environment

data/lib/gds_api/base.rb

@@ -24,7 +24,8 @@ class GdsApi::Base
                  :put_json,
                  :patch_json,
                  :delete_json,
-                 :get_raw, :get_raw!,
+                 :get_raw,
+                 :get_raw!,
                  :put_multipart,
                  :post_multipart
 
@@ -69,9 +70,9 @@ private
     param_pairs = params.sort.map { |key, value|
       case value
       when Array
-        value.map { |v|
+        value.map do |v|
           "#{CGI.escape(key.to_s + '[]')}=#{CGI.escape(v.to_s)}"
-        }
+        end
       else
         "#{CGI.escape(key.to_s)}=#{CGI.escape(value.to_s)}"
       end

data/lib/gds_api/imminence.rb

@@ -20,8 +20,8 @@ class GdsApi::Imminence < GdsApi::Base
   end
 
   def self.parse_place_hash(place_hash)
-    location = self.extract_location_hash(place_hash["location"])
-    address = self.extract_address_hash(place_hash)
+    location = extract_location_hash(place_hash["location"])
+    address = extract_address_hash(place_hash)
 
     place_hash.merge(location).merge(address)
   end

data/lib/gds_api/json_client.rb

@@ -29,7 +29,7 @@ module GdsApi
     end
 
     def self.default_request_with_json_body_headers
-      self.default_request_headers.merge(self.json_body_headers)
+      default_request_headers.merge(json_body_headers)
     end
 
     def self.json_body_headers
@@ -109,7 +109,7 @@ module GdsApi
       end
 
       # If no custom response is given, just instantiate Response
-      create_response ||= Proc.new { |r| Response.new(r) }
+      create_response ||= proc { |r| Response.new(r) }
       create_response.call(response)
     end
 
@@ -177,10 +177,10 @@ module GdsApi
       ::RestClient::Request.execute(method_params)
     rescue Errno::ECONNREFUSED => e
       logger.error loggable.merge(status: "refused", error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
-      raise GdsApi::EndpointNotFound.new("Could not connect to #{url}")
+      raise GdsApi::EndpointNotFound, "Could not connect to #{url}"
     rescue RestClient::Exceptions::Timeout => e
       logger.error loggable.merge(status: "timeout", error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
-      raise GdsApi::TimedOutException.new
+      raise GdsApi::TimedOutException
     rescue URI::InvalidURIError => e
       logger.error loggable.merge(status: "invalid_uri", error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
       raise GdsApi::InvalidUrl
@@ -192,10 +192,10 @@ module GdsApi
       raise
     rescue Errno::ECONNRESET => e
       logger.error loggable.merge(status: "connection_reset", error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
-      raise GdsApi::TimedOutException.new
+      raise GdsApi::TimedOutException
     rescue SocketError => e
       logger.error loggable.merge(status: "socket_error", error_message: e.message, error_class: e.class.name, end_time: Time.now.to_f).to_json
-      raise GdsApi::SocketErrorException.new
+      raise GdsApi::SocketErrorException
     end
   end
 end

data/lib/gds_api/list_response.rb

@@ -25,7 +25,7 @@ module GdsApi
     end
 
     def has_next_page?
-      ! page_link("next").nil?
+      !page_link("next").nil?
     end
 
     def next_page
@@ -39,7 +39,7 @@ module GdsApi
     end
 
     def has_previous_page?
-      ! page_link("previous").nil?
+      !page_link("previous").nil?
     end
 
     def previous_page
@@ -70,12 +70,12 @@ module GdsApi
     # point. Note that the responses are stored so subsequent pages will not be
     # loaded multiple times.
     def with_subsequent_pages
-      Enumerator.new { |yielder|
-        self.each do |i| yielder << i end
+      Enumerator.new do |yielder|
+        each { |i| yielder << i }
         if has_next_page?
-          next_page.with_subsequent_pages.each do |i| yielder << i end
+          next_page.with_subsequent_pages.each { |i| yielder << i }
         end
-      }
+      end
     end
 
   private

data/lib/gds_api/performance_platform/data_out.rb

@@ -70,40 +70,40 @@ module GdsApi
 
       def search_terms(slug)
         options = {
-            slug: slug,
-            transaction: "search-terms",
-            group_by: "searchKeyword",
-            collect: "searchUniques:sum",
+          slug: slug,
+          transaction: "search-terms",
+          group_by: "searchKeyword",
+          collect: "searchUniques:sum",
         }
         statistics(options)
       end
 
       def searches(slug, is_multipart)
         options = {
-            slug: slug,
-            transaction: "search-terms",
-            group_by: "pagePath",
-            collect: "searchUniques:sum",
+          slug: slug,
+          transaction: "search-terms",
+          group_by: "pagePath",
+          collect: "searchUniques:sum",
         }
         statistics(options, is_multipart)
       end
 
       def page_views(slug, is_multipart)
         options = {
-            slug: slug,
-            transaction: "page-statistics",
-            group_by: "pagePath",
-            collect: "uniquePageviews:sum",
+          slug: slug,
+          transaction: "page-statistics",
+          group_by: "pagePath",
+          collect: "uniquePageviews:sum",
         }
         statistics(options, is_multipart)
       end
 
       def problem_reports(slug, is_multipart)
         options = {
-            slug: slug,
-            transaction: "page-contacts",
-            group_by: "pagePath",
-            collect: "total:sum",
+          slug: slug,
+          transaction: "page-contacts",
+          group_by: "pagePath",
+          collect: "total:sum",
         }
         statistics(options, is_multipart)
       end
@@ -114,11 +114,11 @@ module GdsApi
       # Backdrop can be found here: https://github.com/alphagov/backdrop
       def statistics(options, is_multipart = false)
         params = {
-            group_by: options[:group_by],
-            collect: options[:collect],
-            duration: 42,
-            period: "day",
-            end_at: Date.today.to_time.getutc.iso8601,
+          group_by: options[:group_by],
+          collect: options[:collect],
+          duration: 42,
+          period: "day",
+          end_at: Date.today.to_time.getutc.iso8601,
         }
 
         filter_param = is_multipart ? :filter_by_prefix : :filter_by

data/lib/gds_api/publishing_api.rb

@@ -381,7 +381,7 @@ class GdsApi::PublishingApi < GdsApi::Base
   # @see https://github.com/alphagov/publishing-api/blob/master/doc/api.md#get-v2linkables
   def get_linkables(document_type: nil)
     if document_type.nil?
-      raise ArgumentError.new("Please provide a `document_type`")
+      raise ArgumentError, "Please provide a `document_type`"
     end
 
     get_json("#{endpoint}/v2/linkables?document_type=#{document_type}")
@@ -486,7 +486,7 @@ class GdsApi::PublishingApi < GdsApi::Base
   #     publishing_app: 'content-publisher',
   #     rendering_app: 'government-frontend',
   #   }
-  #)
+  # )
   #
   # @see https://github.com/alphagov/publishing-api/blob/master/doc/api.md#put-publish-intentbase_path
   def put_intent(base_path, payload)

data/lib/gds_api/response.rb

@@ -74,9 +74,13 @@ module GdsApi
       @parsed_content ||= transform_parsed(JSON.parse(@http_response.body))
     end
 
-    def present?; true; end
+    def present?
+      true
+    end
 
-    def blank?; false; end
+    def blank?
+      false
+    end
 
   private
 
@@ -85,7 +89,7 @@ module GdsApi
 
       case value
       when Hash
-        Hash[value.map { |k, v|
+        Hash[value.map do |k, v|
           # NOTE: Don't bother transforming if the value is nil
           if k == "web_url" && v
             # Use relative URLs to route when the web_url value is on the
@@ -98,7 +102,7 @@ module GdsApi
           else
             [k, transform_parsed(v)]
           end
-        }]
+        end]
       when Array
         value.map { |v| transform_parsed(v) }
       else

data/lib/gds_api/test_helpers/asset_manager.rb

@@ -1,10 +1,6 @@
-require "gds_api/test_helpers/alias_deprecated"
-
 module GdsApi
   module TestHelpers
     module AssetManager
-      extend AliasDeprecated
-
       ASSET_MANAGER_ENDPOINT = Plek.current.find("asset-manager")
 
       def stub_any_asset_manager_call
@@ -107,19 +103,6 @@ module GdsApi
       def stub_asset_manager_delete_asset_failure(asset_id)
         stub_request(:delete, "#{ASSET_MANAGER_ENDPOINT}/assets/#{asset_id}").to_return(status: 500)
       end
-
-      alias_deprecated :asset_manager_updates_any_asset, :stub_asset_manager_updates_any_asset
-      alias_deprecated :asset_manager_deletes_any_asset, :stub_asset_manager_deletes_any_asset
-      alias_deprecated :asset_manager_has_an_asset, :stub_asset_manager_has_an_asset
-      alias_deprecated :asset_manager_has_a_whitehall_asset, :stub_asset_manager_has_a_whitehall_asset
-      alias_deprecated :asset_manager_does_not_have_an_asset, :stub_asset_manager_does_not_have_an_asset
-      alias_deprecated :asset_manager_does_not_have_a_whitehall_asset, :stub_asset_manager_does_not_have_a_whitehall_asset
-      alias_deprecated :asset_manager_receives_an_asset, :stub_asset_manager_receives_an_asset
-      alias_deprecated :asset_manager_upload_failure, :stub_asset_manager_upload_failure
-      alias_deprecated :asset_manager_update_asset, :stub_asset_manager_update_asset
-      alias_deprecated :asset_manager_update_failure, :stub_asset_manager_update_asset_failure
-      alias_deprecated :asset_manager_delete_asset, :stub_asset_manager_delete_asset
-      alias_deprecated :asset_manager_delete_failure, :stub_asset_manager_delete_asset_failure
     end
   end
 end

data/lib/gds_api/test_helpers/calendars.rb

@@ -1,10 +1,6 @@
-require "gds_api/test_helpers/alias_deprecated"
-
 module GdsApi
   module TestHelpers
     module Calendars
-      extend AliasDeprecated
-
       def calendars_endpoint(in_division: nil)
         endpoint = "#{Plek.new.website_root}/bank-holidays"
         endpoint += "/#{in_division}" unless in_division.nil?
@@ -55,11 +51,6 @@ module GdsApi
       def stub_calendars_has_a_bank_holiday_on(date, in_division: nil)
         stub_calendars_has_bank_holidays_on([date], in_division: in_division)
       end
-
-      # Aliases for DEPRECATED methods
-      alias_deprecated :calendars_has_no_bank_holidays, :stub_calendars_has_no_bank_holidays
-      alias_deprecated :calendars_has_bank_holidays_on, :stub_calendars_has_bank_holidays_on
-      alias_deprecated :calendars_has_a_bank_holiday_on, :stub_calendars_has_a_bank_holiday_on
     end
   end
 end

data/lib/gds_api/test_helpers/content_store.rb

@@ -1,4 +1,3 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 require "gds_api/test_helpers/content_item_helpers"
 require "json"
@@ -6,7 +5,6 @@ require "json"
 module GdsApi
   module TestHelpers
     module ContentStore
-      extend AliasDeprecated
       include ContentItemHelpers
 
       def content_store_endpoint(draft = false)
@@ -93,13 +91,6 @@ module GdsApi
 
         stub_request(:get, url).to_return(body: body)
       end
-
-      # Aliases for DEPRECATED methods
-      alias_deprecated :content_store_has_item, :stub_content_store_has_item
-      alias_deprecated :content_store_does_not_have_item, :stub_content_store_does_not_have_item
-      alias_deprecated :content_store_has_gone_item, :stub_content_store_has_gone_item
-      alias_deprecated :content_store_isnt_available, :stub_content_store_isnt_available
-      alias_deprecated :content_store_has_incoming_links, :stub_content_store_has_incoming_links
     end
   end
 end

data/lib/gds_api/test_helpers/email_alert_api.rb

@@ -83,12 +83,12 @@ module GdsApi
       #  stub_email_alert_api_has_subscriptions([
       #    {
       #      id: 'id-of-my-subscriber-list',
-      #      frequency: 'weekly',
+      #      frequency: 'weekly',
       #      ended: true,
       #    },
       #    {
       #      id: 'id-of-my-subscriber-list',
-      #      frequency: 'daily',
+      #      frequency: 'daily',
       #    },
       #  ])
       #
@@ -176,7 +176,7 @@ module GdsApi
 
       def assert_email_alert_api_content_change_created(attributes = nil)
         if attributes
-          matcher = ->(request) do
+          matcher = lambda do |request|
             payload = JSON.parse(request.body)
             payload.select { |k, _| attributes.key?(k) } == attributes
           end
@@ -187,7 +187,7 @@ module GdsApi
 
       def assert_email_alert_api_message_created(attributes = nil)
         if attributes
-          matcher = ->(request) do
+          matcher = lambda do |request|
             payload = JSON.parse(request.body)
             payload.select { |k, _| attributes.key?(k) } == attributes
           end
@@ -222,21 +222,21 @@ module GdsApi
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 201, body: { subscription_id: returned_subscription_id }.to_json)
+          ).to_return(status: 201, body: { subscription_id: returned_subscription_id }.to_json)
       end
 
       def stub_email_alert_api_creates_an_existing_subscription(subscriber_list_id, address, frequency, returned_subscription_id)
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 200, body: { subscription_id: returned_subscription_id }.to_json)
+          ).to_return(status: 200, body: { subscription_id: returned_subscription_id }.to_json)
       end
 
       def stub_email_alert_api_refuses_to_create_subscription(subscriber_list_id, address, frequency)
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 422)
+          ).to_return(status: 422)
       end
 
       def stub_email_alert_api_sends_subscription_verification_email(address, frequency, topic_id)
@@ -292,7 +292,7 @@ module GdsApi
             body: {
               subscriber_list: returned_attributes,
             }.to_json,
-        )
+          )
       end
 
       def stub_email_alert_api_does_not_have_subscriber_list_by_slug(slug:)
@@ -300,30 +300,6 @@ module GdsApi
           .to_return(status: 404)
       end
 
-      # Aliases for DEPRECATED methods
-      alias_method :email_alert_api_has_updated_subscriber, :stub_email_alert_api_has_updated_subscriber
-      alias_method :email_alert_api_does_not_have_updated_subscriber, :stub_email_alert_api_does_not_have_updated_subscriber
-      alias_method :email_alert_api_has_updated_subscription, :stub_email_alert_api_has_updated_subscription
-      alias_method :email_alert_api_does_not_have_updated_subscription, :stub_email_alert_api_does_not_have_updated_subscription
-      alias_method :email_alert_api_has_subscriber_subscriptions, :stub_email_alert_api_has_subscriber_subscriptions
-      alias_method :email_alert_api_does_not_have_subscriber_subscriptions, :stub_email_alert_api_does_not_have_subscriber_subscriptions
-      alias_method :email_alert_api_has_subscription, :stub_email_alert_api_has_subscription
-      alias_method :email_alert_api_has_subscriptions, :stub_email_alert_api_has_subscriptions
-      alias_method :email_alert_api_has_subscriber_list, :stub_email_alert_api_has_subscriber_list
-      alias_method :email_alert_api_does_not_have_subscriber_list, :stub_email_alert_api_does_not_have_subscriber_list
-      alias_method :email_alert_api_creates_subscriber_list, :stub_email_alert_api_creates_subscriber_list
-      alias_method :email_alert_api_refuses_to_create_subscriber_list, :stub_email_alert_api_refuses_to_create_subscriber_list
-      alias_method :email_alert_api_accepts_unpublishing_message, :stub_email_alert_api_accepts_unpublishing_message
-      alias_method :email_alert_api_unsubscribes_a_subscription, :stub_email_alert_api_unsubscribes_a_subscription
-      alias_method :email_alert_api_has_no_subscription_for_uuid, :stub_email_alert_api_has_no_subscription_for_uuid
-      alias_method :email_alert_api_unsubscribes_a_subscriber, :stub_email_alert_api_unsubscribes_a_subscriber
-      alias_method :email_alert_api_has_no_subscriber, :stub_email_alert_api_has_no_subscriber
-      alias_method :email_alert_api_creates_a_subscription, :stub_email_alert_api_creates_a_subscription
-      alias_method :email_alert_api_creates_an_existing_subscription, :stub_email_alert_api_creates_an_existing_subscription
-      alias_method :email_alert_api_refuses_to_create_subscription, :stub_email_alert_api_refuses_to_create_subscription
-      alias_method :email_alert_api_has_subscriber_list_by_slug, :stub_email_alert_api_has_subscriber_list_by_slug
-      alias_method :email_alert_api_does_not_have_subscriber_list_by_slug, :stub_email_alert_api_does_not_have_subscriber_list_by_slug
-
     private
 
       def get_subscriber_response(id, address)