gds-api-adapters 63.3.0 → 67.0.0

data/lib/gds_api/test_helpers/content_store.rb

@@ -1,4 +1,3 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 require "gds_api/test_helpers/content_item_helpers"
 require "json"
@@ -6,7 +5,6 @@ require "json"
 module GdsApi
   module TestHelpers
     module ContentStore
-      extend AliasDeprecated
       include ContentItemHelpers
 
       def content_store_endpoint(draft = false)
@@ -93,13 +91,6 @@ module GdsApi
 
         stub_request(:get, url).to_return(body: body)
       end
-
-      # Aliases for DEPRECATED methods
-      alias_deprecated :content_store_has_item, :stub_content_store_has_item
-      alias_deprecated :content_store_does_not_have_item, :stub_content_store_does_not_have_item
-      alias_deprecated :content_store_has_gone_item, :stub_content_store_has_gone_item
-      alias_deprecated :content_store_isnt_available, :stub_content_store_isnt_available
-      alias_deprecated :content_store_has_incoming_links, :stub_content_store_has_incoming_links
     end
   end
 end

data/lib/gds_api/test_helpers/email_alert_api.rb

@@ -83,12 +83,12 @@ module GdsApi
       #  stub_email_alert_api_has_subscriptions([
       #    {
       #      id: 'id-of-my-subscriber-list',
-      #      frequency: 'weekly',
+      #      frequency: 'weekly',
       #      ended: true,
       #    },
       #    {
       #      id: 'id-of-my-subscriber-list',
-      #      frequency: 'daily',
+      #      frequency: 'daily',
       #    },
       #  ])
       #
@@ -176,7 +176,7 @@ module GdsApi
 
       def assert_email_alert_api_content_change_created(attributes = nil)
         if attributes
-          matcher = ->(request) do
+          matcher = lambda do |request|
             payload = JSON.parse(request.body)
             payload.select { |k, _| attributes.key?(k) } == attributes
           end
@@ -187,7 +187,7 @@ module GdsApi
 
       def assert_email_alert_api_message_created(attributes = nil)
         if attributes
-          matcher = ->(request) do
+          matcher = lambda do |request|
             payload = JSON.parse(request.body)
             payload.select { |k, _| attributes.key?(k) } == attributes
           end
@@ -222,21 +222,21 @@ module GdsApi
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 201, body: { subscription_id: returned_subscription_id }.to_json)
+          ).to_return(status: 201, body: { subscription_id: returned_subscription_id }.to_json)
       end
 
       def stub_email_alert_api_creates_an_existing_subscription(subscriber_list_id, address, frequency, returned_subscription_id)
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 200, body: { subscription_id: returned_subscription_id }.to_json)
+          ).to_return(status: 200, body: { subscription_id: returned_subscription_id }.to_json)
       end
 
       def stub_email_alert_api_refuses_to_create_subscription(subscriber_list_id, address, frequency)
         stub_request(:post, "#{EMAIL_ALERT_API_ENDPOINT}/subscriptions")
           .with(
             body: { subscriber_list_id: subscriber_list_id, address: address, frequency: frequency }.to_json,
-        ).to_return(status: 422)
+          ).to_return(status: 422)
       end
 
       def stub_email_alert_api_sends_subscription_verification_email(address, frequency, topic_id)
@@ -292,7 +292,7 @@ module GdsApi
             body: {
               subscriber_list: returned_attributes,
             }.to_json,
-        )
+          )
       end
 
       def stub_email_alert_api_does_not_have_subscriber_list_by_slug(slug:)
@@ -300,30 +300,6 @@ module GdsApi
           .to_return(status: 404)
       end
 
-      # Aliases for DEPRECATED methods
-      alias_method :email_alert_api_has_updated_subscriber, :stub_email_alert_api_has_updated_subscriber
-      alias_method :email_alert_api_does_not_have_updated_subscriber, :stub_email_alert_api_does_not_have_updated_subscriber
-      alias_method :email_alert_api_has_updated_subscription, :stub_email_alert_api_has_updated_subscription
-      alias_method :email_alert_api_does_not_have_updated_subscription, :stub_email_alert_api_does_not_have_updated_subscription
-      alias_method :email_alert_api_has_subscriber_subscriptions, :stub_email_alert_api_has_subscriber_subscriptions
-      alias_method :email_alert_api_does_not_have_subscriber_subscriptions, :stub_email_alert_api_does_not_have_subscriber_subscriptions
-      alias_method :email_alert_api_has_subscription, :stub_email_alert_api_has_subscription
-      alias_method :email_alert_api_has_subscriptions, :stub_email_alert_api_has_subscriptions
-      alias_method :email_alert_api_has_subscriber_list, :stub_email_alert_api_has_subscriber_list
-      alias_method :email_alert_api_does_not_have_subscriber_list, :stub_email_alert_api_does_not_have_subscriber_list
-      alias_method :email_alert_api_creates_subscriber_list, :stub_email_alert_api_creates_subscriber_list
-      alias_method :email_alert_api_refuses_to_create_subscriber_list, :stub_email_alert_api_refuses_to_create_subscriber_list
-      alias_method :email_alert_api_accepts_unpublishing_message, :stub_email_alert_api_accepts_unpublishing_message
-      alias_method :email_alert_api_unsubscribes_a_subscription, :stub_email_alert_api_unsubscribes_a_subscription
-      alias_method :email_alert_api_has_no_subscription_for_uuid, :stub_email_alert_api_has_no_subscription_for_uuid
-      alias_method :email_alert_api_unsubscribes_a_subscriber, :stub_email_alert_api_unsubscribes_a_subscriber
-      alias_method :email_alert_api_has_no_subscriber, :stub_email_alert_api_has_no_subscriber
-      alias_method :email_alert_api_creates_a_subscription, :stub_email_alert_api_creates_a_subscription
-      alias_method :email_alert_api_creates_an_existing_subscription, :stub_email_alert_api_creates_an_existing_subscription
-      alias_method :email_alert_api_refuses_to_create_subscription, :stub_email_alert_api_refuses_to_create_subscription
-      alias_method :email_alert_api_has_subscriber_list_by_slug, :stub_email_alert_api_has_subscriber_list_by_slug
-      alias_method :email_alert_api_does_not_have_subscriber_list_by_slug, :stub_email_alert_api_does_not_have_subscriber_list_by_slug
-
     private
 
       def get_subscriber_response(id, address)

data/lib/gds_api/test_helpers/imminence.rb

@@ -1,11 +1,8 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 
 module GdsApi
   module TestHelpers
     module Imminence
-      extend AliasDeprecated
-
       # Generally true. If you are initializing the client differently,
       # you could redefine/override the constant or stub directly.
       IMMINENCE_API_ENDPOINT = Plek.current.find("imminence")
@@ -18,12 +15,16 @@ module GdsApi
       def stub_imminence_has_areas_for_postcode(postcode, areas)
         results = {
           "_response_info" => { "status" => "ok" },
-          "total" => areas.size, "startIndex" => 1, "pageSize" => areas.size,
-          "currentPage" => 1, "pages" => 1, "results" => areas
+          "total" => areas.size,
+          "startIndex" => 1,
+          "pageSize" => areas.size,
+          "currentPage" => 1,
+          "pages" => 1,
+          "results" => areas,
         }
 
-        stub_request(:get, %r{\A#{IMMINENCE_API_ENDPOINT}/areas/#{postcode}\.json}).
-          to_return(body: results.to_json)
+        stub_request(:get, %r{\A#{IMMINENCE_API_ENDPOINT}/areas/#{postcode}\.json})
+          .to_return(body: results.to_json)
       end
 
       def stub_imminence_has_places_for_postcode(places, slug, postcode, limit)
@@ -32,14 +33,10 @@ module GdsApi
       end
 
       def stub_imminence_places_request(slug, query_hash, return_data, status_code = 200)
-        stub_request(:get, "#{IMMINENCE_API_ENDPOINT}/places/#{slug}.json").
-        with(query: query_hash).
-        to_return(status: status_code, body: return_data.to_json, headers: {})
+        stub_request(:get, "#{IMMINENCE_API_ENDPOINT}/places/#{slug}.json")
+        .with(query: query_hash)
+        .to_return(status: status_code, body: return_data.to_json, headers: {})
       end
-
-      alias_deprecated :imminence_has_places, :stub_imminence_has_places
-      alias_deprecated :imminence_has_areas_for_postcode, :stub_imminence_has_areas_for_postcode
-      alias_deprecated :imminence_has_places_for_postcode, :stub_imminence_has_places_for_postcode
     end
   end
 end

data/lib/gds_api/test_helpers/licence_application.rb

@@ -1,28 +1,25 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 
 module GdsApi
   module TestHelpers
     module LicenceApplication
-      extend AliasDeprecated
-
       # Generally true. If you are initializing the client differently,
       # you could redefine/override the constant or stub directly.
       LICENCE_APPLICATION_ENDPOINT = Plek.current.find("licensify")
 
       def stub_licence_exists(identifier, licence)
         licence = licence.to_json unless licence.is_a?(String)
-        stub_request(:get, "#{LICENCE_APPLICATION_ENDPOINT}/api/licence/#{identifier}").
-          with(headers: GdsApi::JsonClient.default_request_headers).
-          to_return(status: 200,
-            body: licence)
+        stub_request(:get, "#{LICENCE_APPLICATION_ENDPOINT}/api/licence/#{identifier}")
+          .with(headers: GdsApi::JsonClient.default_request_headers)
+          .to_return(status: 200,
+                     body: licence)
       end
 
       def stub_licence_does_not_exist(identifier)
-        stub_request(:get, "#{LICENCE_APPLICATION_ENDPOINT}/api/licence/#{identifier}").
-          with(headers: GdsApi::JsonClient.default_request_headers).
-          to_return(status: 404,
-            body: "{\"error\": [\"Unrecognised Licence Id: #{identifier}\"]}")
+        stub_request(:get, "#{LICENCE_APPLICATION_ENDPOINT}/api/licence/#{identifier}")
+          .with(headers: GdsApi::JsonClient.default_request_headers)
+          .to_return(status: 404,
+                     body: "{\"error\": [\"Unrecognised Licence Id: #{identifier}\"]}")
       end
 
       def stub_licence_times_out(identifier)
@@ -32,11 +29,6 @@ module GdsApi
       def stub_licence_returns_error(identifier)
         stub_request(:get, "#{LICENCE_APPLICATION_ENDPOINT}/api/licence/#{identifier}").to_return(status: 500)
       end
-
-      alias_deprecated :licence_exists, :stub_licence_exists
-      alias_deprecated :licence_does_not_exist, :stub_licence_does_not_exist
-      alias_deprecated :licence_times_out, :stub_licence_times_out
-      alias_deprecated :licence_returns_error, :stub_licence_returns_error
     end
   end
 end

data/lib/gds_api/test_helpers/link_checker_api.rb

@@ -1,10 +1,8 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 
 module GdsApi
   module TestHelpers
     module LinkCheckerApi
-      extend AliasDeprecated
       LINK_CHECKER_API_ENDPOINT = Plek.current.find("link-checker-api")
 
       def link_checker_api_link_report_hash(uri:, status: :ok, checked: nil, errors: [], warnings: [], problem_summary: nil, suggested_fix: nil)
@@ -91,12 +89,6 @@ module GdsApi
             headers: { "Content-Type" => "application/json" },
           )
       end
-
-      # Aliases for DEPRECATED methods
-      alias_deprecated :link_checker_api_check, :stub_link_checker_api_check
-      alias_deprecated :link_checker_api_get_batch, :stub_link_checker_api_get_batch
-      alias_deprecated :link_checker_api_create_batch, :stub_link_checker_api_create_batch
-      alias_deprecated :link_checker_api_upsert_resource_monitor, :stub_link_checker_api_upsert_resource_monitor
     end
   end
 end

data/lib/gds_api/test_helpers/local_links_manager.rb

@@ -1,10 +1,8 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 
 module GdsApi
   module TestHelpers
     module LocalLinksManager
-      extend AliasDeprecated
       LOCAL_LINKS_MANAGER_ENDPOINT = Plek.current.find("local-links-manager")
 
       def stub_local_links_manager_has_a_link(authority_slug:, lgsl:, lgil:, url:)
@@ -142,17 +140,6 @@ module GdsApi
           .with(query: { authority_slug: authority_slug })
           .to_return(body: response.to_json, status: 200)
       end
-
-      alias_deprecated :local_links_manager_has_a_link, :stub_local_links_manager_has_a_link
-      alias_deprecated :local_links_manager_has_no_link, :stub_local_links_manager_has_no_link
-      alias_deprecated :local_links_manager_has_no_link_and_no_homepage_url, :stub_local_links_manager_has_no_link_and_no_homepage_url
-      alias_deprecated :local_links_manager_request_with_missing_parameters, :stub_local_links_manager_request_with_missing_parameters
-      alias_deprecated :local_links_manager_does_not_have_required_objects, :stub_local_links_manager_does_not_have_required_objects
-      alias_deprecated :local_links_manager_has_a_local_authority, :stub_local_links_manager_has_a_local_authority
-      alias_deprecated :local_links_manager_has_a_district_and_county_local_authority, :stub_local_links_manager_has_a_district_and_county_local_authority
-      alias_deprecated :local_links_manager_request_without_local_authority_slug, :stub_local_links_manager_request_without_local_authority_slug
-      alias_deprecated :local_links_manager_does_not_have_an_authority, :stub_local_links_manager_does_not_have_an_authority
-      alias_deprecated :local_links_manager_has_a_local_authority_without_homepage, :stub_local_links_manager_has_a_local_authority_without_homepage
     end
   end
 end

data/lib/gds_api/test_helpers/mapit.rb

@@ -1,16 +1,13 @@
-require "gds_api/test_helpers/alias_deprecated"
-
 module GdsApi
   module TestHelpers
     module Mapit
-      extend AliasDeprecated
       MAPIT_ENDPOINT = Plek.current.find("mapit")
 
       def stub_mapit_has_a_postcode(postcode, coords)
         response = {
           "wgs84_lat" => coords.first,
           "wgs84_lon" => coords.last,
-          "postcode"  => postcode,
+          "postcode" => postcode,
         }
 
         stub_request(:get, "#{MAPIT_ENDPOINT}/postcode/" + postcode.tr(" ", "+") + ".json")
@@ -23,21 +20,22 @@ module GdsApi
         response = {
           "wgs84_lat" => coords.first,
           "wgs84_lon" => coords.last,
-          "postcode"  => postcode,
+          "postcode" => postcode,
         }
 
-        area_response = Hash[areas.map.with_index { |area, i|
-          [i, {
-            "codes" => {
-              "ons" => area["ons"],
-              "gss" => area["gss"],
-              "govuk_slug" => area["govuk_slug"],
-            },
-            "name" => area["name"],
-            "type" => area["type"],
-            "country_name" => area["country_name"],
-          }]
-        }]
+        area_response = Hash[areas.map.with_index do |area, i|
+          [i,
+           {
+             "codes" => {
+               "ons" => area["ons"],
+               "gss" => area["gss"],
+               "govuk_slug" => area["govuk_slug"],
+             },
+             "name" => area["name"],
+             "type" => area["type"],
+             "country_name" => area["country_name"],
+           }]
+        end]
 
         stub_request(:get, "#{MAPIT_ENDPOINT}/postcode/" + postcode.tr(" ", "+") + ".json")
           .to_return(body: response.merge("areas" => area_response).to_json, status: 200)
@@ -74,15 +72,6 @@ module GdsApi
         stub_request(:get, "#{MAPIT_ENDPOINT}/code/#{code_type}/#{code}.json")
         .to_return(body: { "code" => 404, "error" => "No areas were found that matched code #{code_type} = #{code}." }.to_json, status: 404)
       end
-
-      alias_deprecated :mapit_has_a_postcode, :stub_mapit_has_a_postcode
-      alias_deprecated :mapit_has_a_postcode_and_areas, :stub_mapit_has_a_postcode_and_areas
-      alias_deprecated :mapit_does_not_have_a_postcode, :stub_mapit_does_not_have_a_postcode
-      alias_deprecated :mapit_does_not_have_a_bad_postcode, :stub_mapit_does_not_have_a_bad_postcode
-      alias_deprecated :mapit_has_areas, :stub_mapit_has_areas
-      alias_deprecated :mapit_does_not_have_areas, :stub_mapit_does_not_have_areas
-      alias_deprecated :mapit_has_area_for_code, :stub_mapit_has_area_for_code
-      alias_deprecated :mapit_does_not_have_area_for_code, :stub_mapit_does_not_have_area_for_code
     end
   end
 end

data/lib/gds_api/test_helpers/organisations.rb

@@ -1,4 +1,3 @@
-require "gds_api/test_helpers/alias_deprecated"
 require "gds_api/test_helpers/json_client_helper"
 require "gds_api/test_helpers/common_responses"
 require "plek"
@@ -7,7 +6,6 @@ require "securerandom"
 module GdsApi
   module TestHelpers
     module Organisations
-      extend AliasDeprecated
       include GdsApi::TestHelpers::CommonResponses
 
       WEBSITE_ROOT = Plek.new.website_root
@@ -35,12 +33,14 @@ module GdsApi
         end
 
         pages.each_with_index do |page, i|
-          page_details = plural_response_base.merge("results" => page,
+          page_details = plural_response_base.merge(
+            "results" => page,
             "total" => organisation_bodies.size,
             "pages" => pages.size,
             "current_page" => i + 1,
             "page_size" => 20,
-            "start_index" => i * 20 + 1)
+            "start_index" => i * 20 + 1,
+          )
 
           links = { self: "#{WEBSITE_ROOT}/api/organisations?page=#{i + 1}" }
           links[:next] = "#{WEBSITE_ROOT}/api/organisations?page=#{i + 2}" if pages[i + 1]
@@ -52,14 +52,14 @@ module GdsApi
             link_headers << "<#{href}>; rel=\"#{rel}\""
           end
 
-          stub_request(:get, links[:self]).
-            to_return(status: 200, body: page_details.to_json, headers: { "Link" => link_headers.join(", ") })
+          stub_request(:get, links[:self])
+            .to_return(status: 200, body: page_details.to_json, headers: { "Link" => link_headers.join(", ") })
 
-          if i.zero?
-            # First page exists at URL with and without page param
-            stub_request(:get, links[:self].sub(/\?page=1/, "")).
-              to_return(status: 200, body: page_details.to_json, headers: { "Link" => link_headers.join(", ") })
-          end
+          next unless i.zero?
+
+          # First page exists at URL with and without page param
+          stub_request(:get, links[:self].sub(/\?page=1/, ""))
+            .to_return(status: 200, body: page_details.to_json, headers: { "Link" => link_headers.join(", ") })
         end
 
         if pages.empty?
@@ -70,8 +70,8 @@ module GdsApi
 
       def stub_organisations_api_has_organisation(organisation_slug, details = nil)
         details ||= organisation_for_slug(organisation_slug)
-        stub_request(:get, "#{WEBSITE_ROOT}/api/organisations/#{organisation_slug}").
-          to_return(status: 200, body: details.to_json)
+        stub_request(:get, "#{WEBSITE_ROOT}/api/organisations/#{organisation_slug}")
+          .to_return(status: 200, body: details.to_json)
       end
 
       def stub_organisations_api_does_not_have_organisation(organisation_slug)
@@ -117,11 +117,6 @@ module GdsApi
           ],
         }
       end
-
-      alias_deprecated :organisations_api_has_organisations, :stub_organisations_api_has_organisations
-      alias_deprecated :organisations_api_has_organisations_with_bodies, :stub_organisations_api_has_organisations_with_bodies
-      alias_deprecated :organisations_api_has_organisation, :stub_organisations_api_has_organisation
-      alias_deprecated :organisations_api_does_not_have_organisation, :stub_organisations_api_does_not_have_organisation
     end
   end
 end

data/lib/gds_api/test_helpers/performance_platform/data_out.rb

@@ -5,13 +5,13 @@ module GdsApi
         PP_DATA_OUT_ENDPOINT = "https://www.performance.service.gov.uk".freeze
 
         def stub_service_feedback(slug, response_body = {})
-          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction").
-            to_return(status: 200, body: response_body.to_json)
+          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction")
+            .to_return(status: 200, body: response_body.to_json)
         end
 
         def stub_data_set_not_available(slug)
-          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction").
-            to_return(status: 404)
+          stub_http_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/#{slug}/customer-satisfaction")
+            .to_return(status: 404)
         end
 
         def stub_service_not_available
@@ -20,51 +20,51 @@ module GdsApi
 
         def stub_search_terms(slug, response_body = {})
           options = {
-              slug: slug,
-              transaction: "search-terms",
-              group_by: "searchKeyword",
-              collect: "searchUniques:sum",
+            slug: slug,
+            transaction: "search-terms",
+            group_by: "searchKeyword",
+            collect: "searchUniques:sum",
           }
           stub_statistics(options, false, response_body)
         end
 
         def stub_searches(slug, is_multipart, response_body = {})
           options = {
-              slug: slug,
-              transaction: "search-terms",
-              group_by: "pagePath",
-              collect: "searchUniques:sum",
+            slug: slug,
+            transaction: "search-terms",
+            group_by: "pagePath",
+            collect: "searchUniques:sum",
           }
           stub_statistics(options, is_multipart, response_body)
         end
 
         def stub_page_views(slug, is_multipart, response_body = {})
           options = {
-              slug: slug,
-              transaction: "page-statistics",
-              group_by: "pagePath",
-              collect: "uniquePageviews:sum",
+            slug: slug,
+            transaction: "page-statistics",
+            group_by: "pagePath",
+            collect: "uniquePageviews:sum",
           }
           stub_statistics(options, is_multipart, response_body)
         end
 
         def stub_problem_reports(slug, is_multipart, response_body = {})
           options = {
-              slug: slug,
-              transaction: "page-contacts",
-              group_by: "pagePath",
-              collect: "total:sum",
+            slug: slug,
+            transaction: "page-contacts",
+            group_by: "pagePath",
+            collect: "total:sum",
           }
           stub_statistics(options, is_multipart, response_body)
         end
 
         def stub_statistics(options, is_multipart, response_body = {})
           params = {
-              group_by: options[:group_by],
-              collect: options[:collect],
-              duration: 42,
-              period: "day",
-              end_at: Date.today.to_time.getutc.iso8601,
+            group_by: options[:group_by],
+            collect: options[:collect],
+            duration: 42,
+            period: "day",
+            end_at: Date.today.to_time.getutc.iso8601,
           }
 
           filter_param = is_multipart ? :filter_by_prefix : :filter_by
@@ -76,21 +76,21 @@ module GdsApi
         end
 
         def stub_search_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/search-terms").
-              with(query: hash_including(filter_by: slug)).
-              to_return(status: 404, headers: { content_type: "application/json" })
+          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/search-terms")
+              .with(query: hash_including(filter_by: slug))
+              .to_return(status: 404, headers: { content_type: "application/json" })
         end
 
         def stub_page_views_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-statistics").
-              with(query: hash_including(filter_by: slug)).
-              to_return(status: 404, headers: { content_type: "application/json" })
+          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-statistics")
+              .with(query: hash_including(filter_by: slug))
+              .to_return(status: 404, headers: { content_type: "application/json" })
         end
 
         def stub_problem_reports_404(slug)
-          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-contacts").
-              with(query: hash_including(filter_by: slug)).
-              to_return(status: 404, headers: { content_type: "application/json" })
+          stub_request(:get, "#{PP_DATA_OUT_ENDPOINT}/data/govuk-info/page-contacts")
+              .with(query: hash_including(filter_by: slug))
+              .to_return(status: 404, headers: { content_type: "application/json" })
         end
       end
     end