gds-api-adapters 27.2.0 → 27.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dc7475596bb3598a6a5a759f53d4741ca8ff8aea
-  data.tar.gz: 21a71b66b3be97ee6ce8f39af84cc78dc8e0cd0d
+  metadata.gz: e2f279aa3d9a7e19735b40e8bc8c35f6cccbe038
+  data.tar.gz: f3f11d44a629ec3c0b00be1c96a8ce177ddff29c
 SHA512:
-  metadata.gz: e1b8d8c47778a1a2c4042df7e08ff990cd75f190f2156d5d4ffeb568029579de9fb23129419d364f7708de31de303a3abe50ffa78e03ec4bccbf5df0e3fc63ee
-  data.tar.gz: bbe6af24984a932b38a1bf0b46698b647f91f9bfa72aad63f38d18cf75de155cc89f1727b586c9d52589ffe9edfaa7f37d9f528c4ec3f2c6cd9efb4b3619ef08
+  metadata.gz: 8189ca648010ca2a59cb275201bd26ec5638e93593fa89213e49d8bd2af60d883834a24d2c3b49a2cbbb4f19dcd482f1f5f7ba9ae73939a55cc19b7f34bbac36
+  data.tar.gz: 303c315106e8e21598118b975f5defbb5fdd0d0051b7437b316c1a8558cf1bbbeda9a54979b2e22fa3329c71b9b17015f8dfd18cbe6e11f2db14c49e1576b992

data/lib/gds_api/publishing_api_v2.rb

@@ -59,25 +59,30 @@ class GdsApi::PublishingApiV2 < GdsApi::Base
 
   def get_linked_items(content_id, params = {})
     query = query_string(params)
+    validate_content_id(content_id)
     get_json("#{endpoint}/v2/linked/#{content_id}#{query}")
   end
 
 private
 
   def content_url(content_id, params = {})
+    validate_content_id(content_id)
     query = query_string(params)
     "#{endpoint}/v2/content/#{content_id}#{query}"
   end
 
   def links_url(content_id)
+    validate_content_id(content_id)
     "#{endpoint}/v2/links/#{content_id}"
   end
 
   def publish_url(content_id)
+    validate_content_id(content_id)
     "#{endpoint}/v2/content/#{content_id}/publish"
   end
 
   def discard_url(content_id)
+    validate_content_id(content_id)
     "#{endpoint}/v2/content/#{content_id}/discard-draft"
   end
 
@@ -86,4 +91,8 @@ private
       hash.merge!(optional_key => options[optional_key]) if options[optional_key]
     end
   end
+
+  def validate_content_id(content_id)
+    raise ArgumentError, "content_id cannot be nil" unless content_id
+  end
 end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '27.2.0'
+  VERSION = '27.2.1'
 end

data/test/publishing_api_v2_test.rb

@@ -1021,6 +1021,36 @@ describe GdsApi::PublishingApiV2 do
         { 'content_id' => @content_id, 'locale' => 'ar' },
       ], response.to_a
     end
+
+    it "returns details hashes" do
+      publishing_api
+        .given("a content item exists with content_id: #{@content_id} and it has details")
+        .upon_receiving("a get entries request with details field")
+        .with(
+          method: :get,
+          path: "/v2/content",
+          query: "content_format=topic&fields%5B%5D=content_id&fields%5B%5D=details",
+          headers: {
+            "Content-Type" => "application/json",
+          },
+        )
+        .will_respond_with(
+          status: 200,
+          body: [
+            { content_id: @content_id, details: {foo: :bar} },
+          ]
+        )
+
+      response = @api_client.get_content_items(
+        content_format: 'topic',
+        fields: [:content_id, :details],
+      )
+
+      assert_equal 200, response.code
+      assert_equal [
+        { 'content_id' => @content_id, 'details' => {"foo"=>"bar"} },
+      ], response.to_a
+    end
   end
 
   describe "#discard_draft(content_id, options = {})" do
@@ -1202,4 +1232,24 @@ describe GdsApi::PublishingApiV2 do
       end
     end
   end
+
+  describe "content ID validation" do
+    [:get_content, :get_links, :get_linked_items, :discard_draft].each do |method|
+      it "happens on #{method}" do
+        proc { @api_client.send(method, nil) }.must_raise ArgumentError
+      end
+    end
+
+    it "happens on publish" do
+      proc { @api_client.publish(nil, "major") }.must_raise ArgumentError
+    end
+
+    it "happens on put_content" do
+      proc { @api_client.put_content(nil, {}) }.must_raise ArgumentError
+    end
+
+    it "happens on put_links" do
+      proc { @api_client.put_links(nil, links: {}) }.must_raise ArgumentError
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 27.2.0
+  version: 27.2.1
 platform: ruby
 authors:
 - James Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-26 00:00:00.000000000 Z
+date: 2016-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek