gds-api-adapters 24.8.0 → 25.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a073f86ca24d44d7389466bda9ee3c259029df9d
-  data.tar.gz: 609242e328b2e2fb8ec3fbd8c01ea9a399a8aaa8
+  metadata.gz: e7e6dd6ee7232cd76f967088448461c8b572f56d
+  data.tar.gz: 12338e6a3ca65715876c502dfc81d4ca519f2c5f
 SHA512:
-  metadata.gz: d2229ed8f4e1a8ab1a66b8ba34e7ce124b2d3e6ec9154749637b712957c01500a395ac59c8192761bbd441164e2745bb9a281145334ef724f6046efc5c6517c2
-  data.tar.gz: 07af7d58f6d87bad27265de4402be76aab7e208e7c5b8f07556254040e2b7dc32c10194bdfca70fc606c1c97a05465a44dad8e1436b5add0cc213b0e89488acd
+  metadata.gz: 760651cf21cbdaa624527b5f2b9442ac7cf522ac3345aa551235ef28579826ab9e7b39cebffdf514f23658f8099f27b20428622cc951da31fd3d2e7761e63180
+  data.tar.gz: 8fbdf293064d55223de66030d1b47525501f5a48a8f93226fffd6a844ebe873b80736d8ceefd3174e466b95b1c282629016aabfcf631ddefd75378b8d0b2c7a4

data/lib/gds_api/mapit.rb

@@ -5,10 +5,7 @@ class GdsApi::Mapit < GdsApi::Base
 
   def location_for_postcode(postcode)
     response = get_json("#{base_url}/postcode/#{CGI.escape postcode}.json")
-    return Location.new(response) unless response.nil?
-  rescue GdsApi::HTTPErrorResponse => e
-    # allow 400 errors, as they can be invalid postcodes people have entered
-    raise e unless e.code == 400
+    Location.new(response) unless response.nil?
   end
 
   def areas_for_type(type)

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '24.8.0'
+  VERSION = '25.0.0'
 end

data/test/mapit_test.rb

@@ -51,10 +51,12 @@ describe GdsApi::Mapit do
       assert_nil @api.location_for_postcode("SW1A 1AA")
     end
 
-    it "should return nil for an invalid postcode" do
+    it "should return 400 for an invalid postcode" do
       mapit_does_not_have_a_bad_postcode("B4DP05TC0D3")
 
-      assert_nil @api.location_for_postcode("B4DP05TC0D3")
+      assert_raises GdsApi::HTTPClientError do
+        @api.location_for_postcode("B4DP05TC0D3")
+      end
     end
   end
   describe "areas_for_type" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 24.8.0
+  version: 25.0.0
 platform: ruby
 authors:
 - James Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-28 00:00:00.000000000 Z
+date: 2015-11-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek