gds-api-adapters 12.3.0 → 12.4.0

data/lib/gds_api/test_helpers/rummager.rb

@@ -4,13 +4,26 @@ module GdsApi
   module TestHelpers
     module Rummager
       def rummager_has_services_and_info_data_for_organisation
-        stub_request(:get, /example.com\/unified_search/).to_return(body: search_results)
-        client.unified_search(example_query)
+        stub_request_for search_results_found
+        run_example_query
+      end
+
+      def rummager_has_no_services_and_info_data_for_organisation
+        stub_request_for no_search_results_found
+        run_example_query
       end
 
       private
 
-      def search_results
+      def stub_request_for(result_set)
+        stub_request(:get, /example.com\/unified_search/).to_return(body: result_set)
+      end
+
+      def run_example_query
+        client.unified_search(example_query)
+      end
+
+      def search_results_found
         File.read(
           File.expand_path(
             "../../../../test/fixtures/services_and_info_fixture.json",
@@ -19,6 +32,15 @@ module GdsApi
         )
       end
 
+      def no_search_results_found
+        File.read(
+          File.expand_path(
+            "../../../../test/fixtures/no_services_and_info_data_found_fixture.json",
+            __FILE__
+          )
+        )
+      end
+
       def client
         GdsApi::Rummager.new("http://example.com")
       end
@@ -26,7 +48,7 @@ module GdsApi
       def example_query
         {
           filter_organisations: ["an-organisation-slug"],
-          facet_specialist_sectors: "1000,examples:4,example_scope:global"
+          facet_specialist_sectors: "1000,examples:4,example_scope:global,order:value.title"
         }
       end
     end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '12.3.0'
+  VERSION = '12.4.0'
 end

data/test/fixtures/no_services_and_info_data_found_fixture.json

@@ -0,0 +1,14 @@
+{
+  "results": [],
+  "total": 712,
+  "start": 0,
+  "facets": {
+    "specialist_sectors": {
+      "options": [],
+      "documents_with_no_value": 712,
+      "total_options": 0,
+      "missing_options": 0
+    }
+  },
+  "suggested_queries": []
+}

data/test/fixtures/services_and_info_fixture.json

@@ -7,54 +7,55 @@
       "options": [
       {
         "value": {
-          "title": "Waste",
-          "slug": "environmental-management/waste",
+          "link": "/environmental-management/environmental-permits",
+          "title": "Environmental permits",
+          "slug": "environmental-management/environmental-permits",
           "example_info": {
-            "total": 49,
+            "total": 47,
             "examples": [
             {
-              "title": "Register as a waste carrier, broker or dealer (England)",
-              "link": "/waste-carrier-or-broker-registration"
+              "title": "Check if you need an environmental permit",
+              "link": "/environmental-permit-check-if-you-need-one"
             },
             {
-              "title": "Hazardous waste producer registration (England and Wales)",
-              "link": "/hazardous-waste-producer-registration"
+              "title": "Environmental permit: how to apply",
+              "link": "/environmental-permit-how-to-apply"
             },
             {
-              "title": "Check if you need an environmental permit",
-              "link": "/environmental-permit-check-if-you-need-one"
+              "title": "Standard rules: environmental permitting",
+              "link": "/government/collections/standard-rules-environmental-permitting"
             },
             {
-              "title": "Classify different types of waste",
-              "link": "/how-to-classify-different-types-of-waste"
+              "title": "Environmental permitting (EP) charges scheme: April 2014 to March 2015",
+              "link": "/government/publications/environmental-permitting-ep-charges-scheme-april-2014-to-march-2015"
             }
             ]
           }
         },
         "documents": 47
       },
-      {
         "value": {
-          "title": "Environmental permits",
-          "slug": "environmental-management/environmental-permits",
+          "link": "/environmental-management/waste",
+          "title": "Waste",
+          "slug": "environmental-management/waste",
           "example_info": {
-            "total": 47,
+            "total": 49,
             "examples": [
             {
-              "title": "Check if you need an environmental permit",
-              "link": "/environmental-permit-check-if-you-need-one"
+              "title": "Register as a waste carrier, broker or dealer (England)",
+              "link": "/waste-carrier-or-broker-registration"
             },
             {
-              "title": "Environmental permit: how to apply",
-              "link": "/environmental-permit-how-to-apply"
+              "title": "Hazardous waste producer registration (England and Wales)",
+              "link": "/hazardous-waste-producer-registration"
             },
             {
-              "title": "Standard rules: environmental permitting",
-              "link": "/government/collections/standard-rules-environmental-permitting"
+              "title": "Check if you need an environmental permit",
+              "link": "/environmental-permit-check-if-you-need-one"
             },
             {
-              "title": "Environmental permitting (EP) charges scheme: April 2014 to March 2015",
-              "link": "/government/publications/environmental-permitting-ep-charges-scheme-april-2014-to-march-2015"
+              "title": "Classify different types of waste",
+              "link": "/how-to-classify-different-types-of-waste"
             }
             ]
           }

data/test/rummager_helpers_test.rb

@@ -10,4 +10,11 @@ class RummagerHelpersTest < MiniTest::Unit::TestCase
 
     assert_instance_of GdsApi::Response, response
   end
+
+  def test_no_services_and_info_data_found_for_organisation
+    response = rummager_has_no_services_and_info_data_for_organisation
+
+    assert_instance_of GdsApi::Response, response
+    assert_equal 0, response.facets.specialist_sectors.total_options
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 12.3.0
+  version: 12.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -381,6 +381,7 @@ files:
 - test/asset_manager_test.rb
 - test/fixtures/hello.txt
 - test/fixtures/world_organisations_australia.json
+- test/fixtures/no_services_and_info_data_found_fixture.json
 - test/fixtures/services_and_info_fixture.json
 - test/fixtures/finder_api/cma-case-schema.json
 - test/router_test.rb
@@ -404,7 +405,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2677929826004224176
+      hash: -1699944453814934459
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -413,7 +414,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2677929826004224176
+      hash: -1699944453814934459
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -447,6 +448,7 @@ test_files:
 - test/asset_manager_test.rb
 - test/fixtures/hello.txt
 - test/fixtures/world_organisations_australia.json
+- test/fixtures/no_services_and_info_data_found_fixture.json
 - test/fixtures/services_and_info_fixture.json
 - test/fixtures/finder_api/cma-case-schema.json
 - test/router_test.rb