gds-api-adapters 10.14.0 → 10.15.0

data/lib/gds_api/imminence.rb

@@ -2,12 +2,21 @@ require_relative 'base'
 
 class GdsApi::Imminence < GdsApi::Base
 
-  def api_url(type, lat, lon, limit=5)
-    "#{@endpoint}/places/#{type}.json?limit=#{limit}&lat=#{lat}&lng=#{lon}"
+  def api_url(type, params)
+    vals = [:limit, :lat, :lng, :postcode].select{ |p| params.include? p }
+    querystring = URI.encode_www_form vals.map { |p| [p, params[p]] }
+    "#{@endpoint}/places/#{type}.json?#{querystring}"
   end
 
   def places(type, lat, lon, limit=5)
-    places = get_json(api_url(type, lat, lon, limit)) || []
+    url = api_url(type, lat: lat, lng: lon, limit: limit)
+    places = get_json(url) || []
+    places.map { |p| self.class.parse_place_hash(p) }
+  end
+
+  def places_for_postcode(type, postcode, limit=5)
+    url = api_url(type, postcode: postcode, limit: limit)
+    places = get_json(url) || []
     places.map { |p| self.class.parse_place_hash(p) }
   end
 

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '10.14.0'
+  VERSION = '10.15.0'
 end

data/test/imminence_api_test.rb

@@ -98,6 +98,26 @@ class ImminenceApiTest < MiniTest::Unit::TestCase
     assert_equal LONGITUDE, place["longitude"]
   end
 
+  def test_postcode_search
+    # Test behaviour when searching by postcode
+    c = api_client
+    url = "#{ROOT}/places/wibble.json?limit=5&postcode=MK42+9AA"
+    c.expects(:get_json).with(url).returns([dummy_place])
+    places = c.places_for_postcode("wibble", "MK42 9AA")
+
+    assert_equal 1, places.size
+  end
+
+  def test_invalid_postcode_search
+    # Test behaviour when searching by invalid postcode
+    c = api_client
+    url = "#{ROOT}/places/wibble.json?limit=5&postcode=MK99+9AA"
+    c.expects(:get_json).with(url).raises(GdsApi::HTTPErrorResponse.new(400))
+    assert_raises GdsApi::HTTPErrorResponse do
+      c.places_for_postcode("wibble", "MK99 9AA")
+    end
+  end
+
   def test_business_support_schemes
     dummy_schemes = [
       { "business_support_identifier" => "bar-business-award", "title" => "Bar business award." },

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 10.14.0
+  version: 10.15.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-02 00:00:00.000000000 Z
+date: 2014-06-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek
@@ -382,7 +382,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4129704915142926265
+      hash: -1314510237957677542
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -391,7 +391,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4129704915142926265
+      hash: -1314510237957677542
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23