gds-api-adapters 0.0.28 → 0.0.29

data/lib/gds_api/response.rb

@@ -29,10 +29,10 @@ module GdsApi
       end
     end
     
-    def respond_to_missing?(method)
-      true
+    def respond_to_missing?(method, include_private)
+      to_hash.has_key?(method.to_s)
     end
-    
+        
   private
   
     def self.build_ostruct_recursively(value)

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '0.0.28'
+  VERSION = '0.0.29'
 end

data/test/json_client_test.rb

@@ -91,7 +91,14 @@ class JsonClientTest < MiniTest::Spec
     assert_equal nil, response.does_not_exist
   end
   
-
+  def test_response_does_not_claim_to_respond_to_methods_corresponding_to_non_existent_attributes
+    # This mimics the behaviour of OpenStruct
+    url = "http://some.endpoint/some.json"
+    stub_request(:put, url).to_return(:body => '{"a":1}', :status => 200)
+    response = @client.put_json(url, {})
+    assert ! response.respond_to?(:does_not_exist)
+  end
+  
   def test_client_can_use_basic_auth
     client = GdsApi::JsonClient.new(basic_auth: {user: 'user', password: 'password'})
 

metadata

@@ -2,7 +2,7 @@
 name: gds-api-adapters
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.28
+  version: 0.0.29
 platform: ruby
 authors: 
 - James Stewart
@@ -160,7 +160,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 2937289436236187170
+      hash: -2837227603408355889
       segments: 
       - 0
       version: "0"
@@ -169,7 +169,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 2937289436236187170
+      hash: -2837227603408355889
       segments: 
       - 0
       version: "0"