gds-api-adapters 0.0.13 → 0.0.14

data/lib/gds_api/base.rb

@@ -6,7 +6,7 @@ class GdsApi::Base
   include GdsApi::JsonUtils
 
   attr_reader :options
-  
+
   class << self
     attr_writer :logger
   end
@@ -28,7 +28,7 @@ class GdsApi::Base
   def adapter_name
     self.class.to_s.split("::").last.downcase
   end
-    
+
   def url_for_slug(slug, options={})
     base = "#{base_url}/#{slug}.json#{query_string(options)}"
   end
@@ -41,7 +41,7 @@ private
     if platform == 'development'
       "http://#{adapter_name}.dev.gov.uk"
     else
-      "http://#{adapter_name}.#{platform}.alphagov.co.uk"
+      "https://#{adapter_name}.#{platform}.alphagov.co.uk"
     end
   end
 

data/lib/gds_api/exceptions.rb

@@ -1,4 +1,4 @@
 module GdsApi
   class EndpointNotFound < StandardError
   end
-end
+end

data/lib/gds_api/helpers.rb

@@ -15,7 +15,7 @@ module GdsApi
     def panopticon_api
       @panopticon_api ||= GdsApi::Panopticon.new(Plek.current.environment)
     end
-    
+
     def fetch_artefact(params)
       panopticon_api.artefact_for_slug(params[:slug]) || OpenStruct.new(section: 'missing', need_id: 'missing', kind: 'missing')
     end

data/lib/gds_api/json_utils.rb

@@ -7,7 +7,7 @@ require_relative 'exceptions'
 
 module GdsApi::JsonUtils
   REQUEST_HEADERS = {
-    'Accept' => 'application/json', 
+    'Accept' => 'application/json',
     'Content-Type' => 'application/json',
     'User-Agent' => "GDS Api Client v. #{GdsApi::VERSION}"
   }
@@ -69,7 +69,7 @@ module GdsApi::JsonUtils
       http.put(path, params.to_json, REQUEST_HEADERS)
     end
   end
-  
+
   def to_ostruct(object)
     case object
     when Hash

data/lib/gds_api/needotron.rb

@@ -4,14 +4,14 @@ class GdsApi::Needotron < GdsApi::Base
   def need_by_id(id, opts = {})
     need_hash = get_json("#{base_url}/#{id}.json")
     return nil if need_hash.nil? or need_hash['need'].nil?
-    
+
     if opts[:as_hash]
       need_hash
     else
-      to_ostruct(need_hash['need']) 
+      to_ostruct(need_hash['need'])
     end
   end
-  
+
 private
   def base_url
     "#{@endpoint}/needs"

data/lib/gds_api/panopticon.rb

@@ -4,23 +4,23 @@ class GdsApi::Panopticon < GdsApi::Base
 
   def artefact_for_slug(slug, opts = {})
     return nil if slug.nil? or slug == ''
-    
+
     details = get_json(url_for_slug(slug))
     if opts[:as_hash]
       details
     else
-      to_ostruct(details) 
+      to_ostruct(details)
     end
   end
 
   def create_artefact(artefact)
     post_json(base_url + ".json", artefact)
   end
-  
+
   def update_artefact(id_or_slug, artefact)
     put_json("#{base_url}/#{id_or_slug}.json", artefact)
   end
-  
+
 private
   def base_url
     "#{endpoint}/artefacts"

data/lib/gds_api/test_helpers/contactotron.rb

@@ -1,7 +1,7 @@
 module GdsApi
   module TestHelpers
     module Contactotron
-        
+
       def contactotron_has_contact(uri, details)
         json = JSON.dump(details)
         stub_request(:get, uri).to_return(:status => 200, :body => json, :headers => {})

data/lib/gds_api/test_helpers/panopticon.rb

@@ -2,23 +2,23 @@ module GdsApi
   module TestHelpers
     module Panopticon
       PANOPTICON_ENDPOINT = 'http://panopticon.test.alphagov.co.uk'
-  
+
       def stringify_hash_keys(input_hash)
         input_hash.inject({}) do |options, (key, value)|
           options[key.to_s] = value
           options
         end
       end
-        
+
       def panopticon_has_metadata(metadata)
         metadata = stringify_hash_keys(metadata)
-        
+
         json = JSON.dump(metadata)
 
         urls = []
         urls << "#{PANOPTICON_ENDPOINT}/artefacts/#{metadata['id']}.json" if metadata['id']
         urls << "#{PANOPTICON_ENDPOINT}/artefacts/#{metadata['slug']}.json" if metadata['slug']
-        
+
         urls.each { |url| stub_request(:get, url).to_return(:status => 200, :body => json, :headers => {}) }
 
         return urls.first

data/lib/gds_api/test_helpers/publisher.rb

@@ -29,7 +29,7 @@ module GdsApi
         json = JSON.dump(output_details)
         slug = input_details.delete('slug')
         uri = "#{PUBLISHER_ENDPOINT}/local_transactions/#{slug}/verify_snac.json"
-        stub_request(:post, uri).with(:body => JSON.dump(input_details), 
+        stub_request(:post, uri).with(:body => JSON.dump(input_details),
           :headers => GdsApi::JsonUtils::REQUEST_HEADERS).
           to_return(:body => json, :status => 200)
       end

data/lib/gds_api/version.rb

@@ -1,3 +1,3 @@
 module GdsApi
-  VERSION = '0.0.13'
+  VERSION = '0.0.14'
 end

data/test/contactotron_api_test.rb

@@ -4,13 +4,13 @@ require 'gds_api/test_helpers/contactotron'
 
 class ContactotronApiTest < MiniTest::Unit::TestCase
   include GdsApi::TestHelpers::Contactotron
-  
+
   def api
     GdsApi::Contactotron.new "test"
   end
 
   def test_should_fetch_and_parse_JSON_into_ostruct
-    uri = "http://contactotron.platform/contacts/1"    
+    uri = "http://contactotron.platform/contacts/1"
     contactotron_has_contact(uri, {details: 'value'})
     assert_equal OpenStruct, api.contact_for_uri(uri).class
   end

data/test/gds_api_base_test.rb

@@ -54,12 +54,12 @@ class GdsApiBaseTest < MiniTest::Unit::TestCase
     u = URI.parse(url)
     assert_match /^concreteapi\.test/, u.host
   end
-  
+
   def test_should_treat_second_positional_arg_as_endpoint_url_if_string
     api = ConcreteApi.new("test", "endpoint")
     assert_equal "endpoint", api.options[:endpoint_url]
   end
-  
+
   def test_should_accept_options_as_second_arg
     api = ConcreteApi.new("test", {endpoint_url: "endpoint", foo: "bar"})
     assert_equal "endpoint", api.options[:endpoint_url]

data/test/json_utils_test.rb

@@ -47,7 +47,7 @@ class JsonUtilsTest < MiniTest::Unit::TestCase
     stub_request(:post, url).to_raise(Timeout::Error)
     assert_nil post_json(url, {})
   end
-  
+
   def test_should_fetch_and_parse_json_into_hash
     url = "http://some.endpoint/some.json"
     stub_request(:get, url).to_return(:body => "{}",:status => 200)
@@ -59,11 +59,11 @@ class JsonUtilsTest < MiniTest::Unit::TestCase
     stub_request(:get, url).to_return(:body => "{}", :status => 404)
     assert_nil get_json(url)
   end
-    
+
   def test_put_json_does_put_with_json_encoded_packet
     url = "http://some.endpoint/some.json"
     payload = {a:1}
     stub_request(:put, url).with(body: payload.to_json).to_return(:body => "{}", :status => 200)
     assert_equal({}, put_json(url, payload))
   end
-end
+end

data/test/panopticon_api_test.rb

@@ -7,7 +7,7 @@ class PanopticonApiTest < MiniTest::Unit::TestCase
 
   def basic_artefact
     {
-      name: 'An artefact', 
+      name: 'An artefact',
       slug: 'a-basic-artefact'
     }
   end
@@ -29,35 +29,35 @@ class PanopticonApiTest < MiniTest::Unit::TestCase
 
   def test_given_a_slug__should_fetch_artefact_from_panopticon
     panopticon_has_metadata(basic_artefact)
-  
+
     artefact = api.artefact_for_slug(basic_artefact[:slug])
     assert_equal 'An artefact', artefact.name
   end
-  
+
   def test_given_a_slug_can_fetch_artefact_as_hash
     panopticon_has_metadata(basic_artefact)
     artefact = api.artefact_for_slug(basic_artefact[:slug], :as_hash => true)
     assert artefact.is_a?(Hash)
   end
-  
+
   def should_fetch_and_parse_JSON_into_hash
     url = "#{PANOPTICON_ENDPOINT}/some.json"
     stub_request(:get, url).to_return(body: {}.to_json)
-  
+
     assert_equal Hash, api.get_json(url).class
   end
-  
+
   def test_should_return_nil_if_404_returned_from_endpoint
     url = "#{PANOPTICON_ENDPOINT}/some.json"
     stub_request(:get, url).to_return(status: Rack::Utils.status_code(:not_found))
-  
+
     assert_nil api.get_json(url)
   end
-  
+
   def test_should_construct_correct_url_for_a_slug
     assert_equal "#{PANOPTICON_ENDPOINT}/artefacts/slug.json", api.url_for_slug('slug')
   end
-  
+
   def test_contacts_should_be_deserialised_into_whole_objects
     panopticon_has_metadata(artefact_with_contact)
 
@@ -65,22 +65,22 @@ class PanopticonApiTest < MiniTest::Unit::TestCase
     assert_equal 'Department for Environment, Food and Rural Affairs (Defra)', artefact.contact.name
     assert_equal 'helpline@defra.gsi.gov.uk', artefact.contact.email_address
   end
-  
+
   def test_can_create_a_new_artefact
     url = "#{PANOPTICON_ENDPOINT}/artefacts.json"
     stub_request(:post, url)
       .with(body: basic_artefact.to_json)
       .to_return(body: basic_artefact.merge(id: 1).to_json)
-    
+
     api.create_artefact(basic_artefact)
   end
-  
+
   def test_can_update_existing_artefact
     url = "#{PANOPTICON_ENDPOINT}/artefacts/1.json"
     stub_request(:put, url)
       .with(body: basic_artefact.to_json)
       .to_return(status: 200, body: '{}')
-    
+
     api.update_artefact(1, basic_artefact)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gds-api-adapters
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-12-21 00:00:00.000000000Z
+date: 2011-12-29 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plek
-  requirement: &70165614975140 !ruby/object:Gem::Requirement
+  requirement: &70288970799060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70165614975140
+  version_requirements: *70288970799060
 - !ruby/object:Gem::Dependency
   name: null_logger
-  requirement: &70165614974680 !ruby/object:Gem::Requirement
+  requirement: &70288970797800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70165614974680
+  version_requirements: *70288970797800
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70165614974160 !ruby/object:Gem::Requirement
+  requirement: &70288970795860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 0.9.2.2
   type: :development
   prerelease: false
-  version_requirements: *70165614974160
+  version_requirements: *70288970795860
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70165614973620 !ruby/object:Gem::Requirement
+  requirement: &70288970794880 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '1.7'
   type: :development
   prerelease: false
-  version_requirements: *70165614973620
+  version_requirements: *70288970794880
 - !ruby/object:Gem::Dependency
   name: rack
-  requirement: &70165614973220 !ruby/object:Gem::Requirement
+  requirement: &70288970794300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70165614973220
+  version_requirements: *70288970794300
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70165614972680 !ruby/object:Gem::Requirement
+  requirement: &70288970793380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - =
@@ -76,10 +76,10 @@ dependencies:
         version: 0.4.2
   type: :development
   prerelease: false
-  version_requirements: *70165614972680
+  version_requirements: *70288970793380
 - !ruby/object:Gem::Dependency
   name: simplecov-rcov
-  requirement: &70165614972260 !ruby/object:Gem::Requirement
+  requirement: &70288970792900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70165614972260
+  version_requirements: *70288970792900
 description: A set of adapters providing easy access to the GDS gov.uk APIs
 email:
 - jystewart@gmail.com