gdk-toogle 1.0.2 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cacce942effef205bff4a9e31cd15889c6e3faba254dd3efee2e238519940147
-  data.tar.gz: f1e506fe72c8dbe264382fa96544a66e232ea0b40fb0bfb4fb14772b3a0e9702
+  metadata.gz: 977eaeeeceacce09f2f02a5990dbdc7cea1e24cb8f27380aeff745a5f3732119
+  data.tar.gz: d30b7f35dea5420bbec127746d04e2da9acb35a74ab4a0428eaf1655b1a4a32a
 SHA512:
-  metadata.gz: aac129e17fb36ea58e72b2bd12dbf9d90b52d8055ab787146fc3fccaf0eec5cd178d6f1cf21672e0de6fd48aa9ab9ea15fa5a7d328e522ff430286ecf0c49d16
-  data.tar.gz: 83a9942634aab84f4058e743f900f538c5e5bc69c74f8c678c8738b544c96d377ef091cc96302164e33f03bc611db886cd90b10581b47b75a3b5e070ff32173f
+  metadata.gz: abf5c9edc2b9235bd914f031d4f29663f9f4ad07f7d0ed5abe0173e59c8f65f1fc7dc33994dfb050cbebf794b434fba9a2e279793117e40080a55ac7db1bd44e
+  data.tar.gz: 8ef3d8bcc547f4ac8da980bbaa40f866e4b87393b20aaba8ff4e91fa4211d0c94513cc9c6e8c67b3090497f27c7ed5b03547c1950750528e868631594d087bf9

data/README.md

@@ -81,7 +81,8 @@ Keep Ruby and gem versions at or below what GitLab itself runs (see
 One design goal of this little Rails engine was to keep it free of any dependencies, that GitLab uses today.
 Because, tomorrow we might decide to ditch one or the other tech we use today, and Toogle shouldn't break just because GitLab removes `sassc`, as an example (that actually happened during development).
 
-That's why Toogle only depends on the bare basics: `rails`, `sprockets` and `haml`.
+That's why Toogle only depends on the bare basics: `rails` and `haml`.
+It doesn't even use the host's asset pipeline: the engine serves its own CSS and JS files.
 
 ### Javascript
 

data/app/assets/javascript/toogle/application.js

@@ -33,25 +33,20 @@ document.addEventListener("alpine:init", () => {
     definitionsUrl,
 
     init() {
-      const featuresLoaded = this.fetchFeatures();
-
-      const definitionsLoaded = fetch(this.definitionsUrl, {
-        method: "GET",
-        headers: {
-          Accept: "application/json",
-        },
-      })
-        .then((response) => response.json())
-        .then((data) => {
-          this.definitions = data;
-        })
-        .catch(showFetchError);
+      const loading = this.reload();
 
       if (shareName) {
-        Promise.all([featuresLoaded, definitionsLoaded]).then(() =>
+        loading.then(() =>
           this.openDetails(shareName)
         );
       }
+
+      this.onReload = () => this.reload();
+      window.addEventListener("reload", this.onReload);
+    },
+
+    destroy() {
+      window.removeEventListener("reload", this.onReload);
     },
 
     openDetails(name) {
@@ -119,6 +114,27 @@ document.addEventListener("alpine:init", () => {
         .catch(showFetchError);
     },
 
+    fetchDefinitions() {
+      return fetch(this.definitionsUrl, {
+        method: "GET",
+        headers: {
+          Accept: "application/json",
+        },
+      })
+        .then((response) => response.json())
+        .then((data) => {
+          this.definitions = data;
+        })
+        .catch(showFetchError);
+    },
+
+    reload() {
+      const featuresLoaded = this.fetchFeatures();
+      const definitionsLoaded = this.fetchDefinitions();
+
+      return Promise.all([featuresLoaded, definitionsLoaded])
+    },
+
     // Animates the layout change, e.g. a row moving between the sections.
     // Only the moving row gets a view-transition-name (see the view), so the
     // browser snapshots one row, not all ~700 — keeping toggles fast no
@@ -246,4 +262,31 @@ document.addEventListener("alpine:init", () => {
       },
     },
   }));
+
+  Alpine.data("gitBranchWatcher", (branch, branchUrl) => ({
+    branch,
+    branchUrl,
+
+    init() {
+      this.$watch("branch", () => {
+        this.$dispatch("reload")
+      });
+
+      window.addEventListener("focus", () => this.fetchCurrentBranch())
+    },
+
+    fetchCurrentBranch() {
+      fetch(this.branchUrl, {
+        method: "GET",
+        headers: {
+          Accept: "application/json",
+        },
+      })
+        .then((response) => response.json())
+        .then((data) => {
+          this.branch = data;
+        })
+        .catch(showFetchError);
+    },
+  }))
 });

data/app/assets/stylesheets/toogle/application.css

@@ -1,10 +1,10 @@
-@import "variables";
+@import "variables.css";
 
-@import "elements";
-@import "layout";
-@import "utilities";
+@import "elements.css";
+@import "layout.css";
+@import "utilities.css";
 
-@import "components/toggle";
+@import "components/toggle.css";
 
 [x-cloak] {
   display: none !important;

data/app/assets/stylesheets/toogle/layout.css

@@ -51,11 +51,18 @@ body {
 
   > footer {
     display: flex;
-    justify-content: right;
+    justify-content: space-between;
     align-items: center;
     gap: 2em;
     padding: 1rem;
     font-size: smaller;
+
+    code {
+      color: var(--color-text-muted);
+      overflow: hidden;
+      text-overflow: ellipsis;
+      white-space: nowrap;
+    }
   }
 }
 

data/app/controllers/toogle/assets_controller.rb

@@ -0,0 +1,29 @@
+module Toogle
+  # Serves our own CSS and JS instead of going through the host's asset
+  # pipeline: hosts that only serve precompiled assets, or whose web server
+  # answers /assets/* itself, never deliver them otherwise.
+  class AssetsController < ApplicationController
+    ROOT = Engine.root.join("app/assets")
+
+    # Only these files are served, so no path from the URL ever reaches the
+    # filesystem.
+    FILES = Dir[ROOT.join("{stylesheets,javascript}/**/*.{css,js}")]
+      .index_by { Pathname(_1).relative_path_from(ROOT).to_s }
+
+    # Static public files: nothing to protect, and Rails' cross-origin check
+    # would otherwise refuse to serve JavaScript to a <script> tag.
+    skip_forgery_protection
+
+    def show
+      file = FILES[params[:path]]
+      return head :not_found unless file
+
+      # Send the content, not the file: GitLab enables X-Sendfile, which hands
+      # file bodies to Workhorse, and Workhorse may run on another host (as in
+      # Caproni) where this path doesn't exist.
+      send_data File.read(file),
+        type: Mime::Type.lookup_by_extension(File.extname(file).delete(".")),
+        disposition: :inline
+    end
+  end
+end

data/app/controllers/toogle/branches_controller.rb

@@ -0,0 +1,7 @@
+module Toogle
+  class BranchesController < ApplicationController
+    def show
+      render json: GitRepo.current_branch.to_json
+    end
+  end
+end

data/app/services/toogle/git_repo.rb

@@ -0,0 +1,7 @@
+module Toogle
+  class GitRepo
+    def self.current_branch
+      `git rev-parse --abbrev-ref HEAD`.chomp
+    end
+  end
+end

data/app/views/layouts/toogle/application.html.haml

@@ -11,8 +11,8 @@
     %title Feature flags
     = csrf_meta_tags
     = csp_meta_tag
-    = stylesheet_link_tag "toogle/application", media: "all"
-    = javascript_include_tag 'toogle/application'
+    %link(rel="stylesheet" media="all" href="#{asset_file_path("stylesheets/toogle/application.css", v: Toogle::VERSION)}")
+    %script(src="#{asset_file_path("javascript/toogle/application.js", v: Toogle::VERSION)}")
     %script(defer src="https://cdn.jsdelivr.net/npm/alpinejs@3.x.x/dist/cdn.min.js")
 
   %body
@@ -56,5 +56,6 @@
       = yield
 
     %footer
+      %code(x-data="gitBranchWatcher(#{Toogle::GitRepo.current_branch.to_json}, '#{branch_url}')" x-text="branch" title="Current git branch")
       %a(href="https://gitlab.com/thutterer/toogle" target="_blank")
         = Toogle::VERSION

data/config/routes.rb

@@ -1,4 +1,8 @@
 Toogle::Engine.routes.draw do
+  get "assets/*path", to: "assets#show", format: false, as: :asset_file
+
+  resource :branch, only: %i[show]
+
   resources :definitions, only: %i[index]
 
   # Keep this line last as it matches any URL

data/lib/toogle/version.rb

@@ -1,3 +1,3 @@
 module Toogle
-  VERSION = "1.0.2"
+  VERSION = "1.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gdk-toogle
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.2.1
 platform: ruby
 authors:
 - Thomas Hutterer
@@ -90,7 +90,6 @@ files:
 - MIT-LICENSE
 - README.md
 - Rakefile
-- app/assets/config/toogle_manifest.js
 - app/assets/javascript/toogle/application.js
 - app/assets/stylesheets/toogle/application.css
 - app/assets/stylesheets/toogle/components/toggle.css
@@ -99,10 +98,13 @@ files:
 - app/assets/stylesheets/toogle/utilities.css
 - app/assets/stylesheets/toogle/variables.css
 - app/controllers/toogle/application_controller.rb
+- app/controllers/toogle/assets_controller.rb
+- app/controllers/toogle/branches_controller.rb
 - app/controllers/toogle/definitions_controller.rb
 - app/controllers/toogle/features_controller.rb
 - app/models/toogle/definition.rb
 - app/models/toogle/feature.rb
+- app/services/toogle/git_repo.rb
 - app/views/layouts/toogle/application.html.haml
 - app/views/toogle/features/_details_button.html.haml
 - app/views/toogle/features/index.html.haml
@@ -132,7 +134,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.22
 specification_version: 4
 summary: Toogle toggles feature flags
 test_files: []

data/app/assets/config/toogle_manifest.js

@@ -1,2 +0,0 @@
-//= link toogle/application.css
-//= link toogle/application.js