gcra 1.0.3 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0398e02c46f08f3f248e36db5d87bc49c2185531
-  data.tar.gz: 47aee2e95b7267165702aa9350c6b71225b7e8f4
+SHA256:
+  metadata.gz: 4523f1a5f4d9e01c3363bbfd24a1d50f3933799a3ee8ac2774a82de49687344e
+  data.tar.gz: 963f7aaa9d67b39920bedc148d7b5c89d7acc7ec6a538fef58b7f845804e2f05
 SHA512:
-  metadata.gz: 2755f80c4957e77ba5073df77c658263682dbbc92730bb7d4231010cdd379550167cad27a83bf321545c9879a45d7ee992219581e7885eabf1c403774bdbc316
-  data.tar.gz: eb8b0e85d5141fcdf949b428ff930902286c7267d12dd3ae66a3297b58a211d86db03bb8c73cf104ae39cca9e194af1ba093c82c0e2a7a4a65e12ec37153d908
+  metadata.gz: 7b049fed03339f68e9ef24e6c4d715b28a894a990deb3e50d4f9bedc4af621f7440300efe41b519158b982806df9b3495972de367e39ae8c599095a0e42466e8
+  data.tar.gz: 6f65016b71ad0fce7b47e1f5340e04023ba800304404e1d7eb1dcedb6a183e4dfb0550a58a0cf9b326ef5218f06763e6d12b8b11d79055bda19815a669ef867e

data/lib/gcra/rate_limiter.rb

@@ -97,5 +97,30 @@ module GCRA
         "Failed to store updated rate limit data for key '#{key}' after #{MAX_ATTEMPTS} attempts"
       )
     end
+
+    # Overwrite the stored value for key to that of a bucket that has
+    # just overflowed, ignoring any existing stored data.
+    def mark_overflowed(key)
+      key = key.to_s unless key.is_a?(String)
+      i = 0
+      while i < MAX_ATTEMPTS
+        tat_from_store, now = @store.get_with_time(key)
+        new_value = now + @delay_variation_tolerance
+        ttl = @delay_variation_tolerance
+        updated = if tat_from_store.nil?
+                    @store.set_if_not_exists_with_ttl(key, new_value, ttl)
+                  else
+                    @store.compare_and_set_with_ttl(key, tat_from_store, new_value, ttl)
+                  end
+        if updated
+          return true
+        end
+        i += 1
+      end
+
+      raise StoreUpdateFailed.new(
+        "Failed to store updated rate limit data for key '#{key}' after #{MAX_ATTEMPTS} attempts"
+      )
+    end
   end
 end

data/lib/gcra/redis_store.rb

@@ -12,20 +12,30 @@ module GCRA
   redis.call('psetex', KEYS[1], ARGV[3], ARGV[2])
   return 1
   EOF
+
+    # Digest::SHA1.hexdigest(CAS_SCRIPT)
+    CAS_SHA = "89118e702230c0d65969c5fc557a6e942a2f4d31".freeze
     CAS_SCRIPT_MISSING_KEY_RESPONSE = 'key does not exist'.freeze
+    SCRIPT_NOT_IN_CACHE_RESPONSE = 'NOSCRIPT No matching script. Please use EVAL.'.freeze
+
+    CONNECTED_TO_READONLY = "READONLY You can't write against a read only slave.".freeze
 
-    def initialize(redis, key_prefix)
+    def initialize(redis, key_prefix, options = {})
       @redis = redis
       @key_prefix = key_prefix
+
+      @reconnect_on_readonly = options[:reconnect_on_readonly] || false
     end
 
     # Returns the value of the key or nil, if it isn't in the store.
     # Also returns the time from the Redis server, with microsecond precision.
     def get_with_time(key)
-      time_response = @redis.time # returns tuple (seconds since epoch, microseconds)
+      time_response, value = @redis.pipelined do |pipeline|
+        pipeline.time # returns tuple (seconds since epoch, microseconds)
+        pipeline.get(@key_prefix + key)
+      end
       # Convert tuple to nanoseconds
       time = (time_response[0] * 1_000_000 + time_response[1]) * 1_000
-      value = @redis.get(@key_prefix + key)
       if value != nil
         value = value.to_i
       end
@@ -34,17 +44,21 @@ module GCRA
     end
 
     # Set the value of key only if it is not already set. Return whether the value was set.
-    # Also set the key's expiration (ttl, in seconds). The operations are not performed atomically.
+    # Also set the key's expiration (ttl, in seconds).
     def set_if_not_exists_with_ttl(key, value, ttl_nano)
       full_key = @key_prefix + key
-      did_set = @redis.setnx(full_key, value)
-
-      if did_set
+      retried = false
+      begin
         ttl_milli = calculate_ttl_milli(ttl_nano)
-        @redis.pexpire(full_key, ttl_milli)
+        @redis.set(full_key, value, nx: true, px: ttl_milli)
+      rescue Redis::CommandError => e
+        if e.message == CONNECTED_TO_READONLY && @reconnect_on_readonly && !retried
+          @redis.client.reconnect
+          retried = true
+          retry
+        end
+        raise
       end
-
-      return did_set
     end
 
     # Atomically compare the value at key to the old value. If it matches, set it to the new value
@@ -52,12 +66,21 @@ module GCRA
     # return false with no error. If the swap succeeds, update the ttl for the key atomically.
     def compare_and_set_with_ttl(key, old_value, new_value, ttl_nano)
       full_key = @key_prefix + key
+      retried = false
       begin
         ttl_milli = calculate_ttl_milli(ttl_nano)
-        swapped = @redis.eval(CAS_SCRIPT, keys: [full_key], argv: [old_value, new_value, ttl_milli])
+        swapped = @redis.evalsha(CAS_SHA, keys: [full_key], argv: [old_value, new_value, ttl_milli])
       rescue Redis::CommandError => e
         if e.message == CAS_SCRIPT_MISSING_KEY_RESPONSE
           return false
+        elsif e.message == SCRIPT_NOT_IN_CACHE_RESPONSE && !retried
+          @redis.script('load', CAS_SCRIPT)
+          retried = true
+          retry
+        elsif e.message == CONNECTED_TO_READONLY && @reconnect_on_readonly && !retried
+          @redis.client.reconnect
+          retried = true
+          retry
         end
         raise
       end

data/lib/gcra/version.rb

@@ -1,3 +1,3 @@
 module GCRA
-  VERSION = '1.0.3'.freeze
+  VERSION = '1.2.1'.freeze
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: gcra
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.2.1
 platform: ruby
 authors:
 - Michael Frister
-autorequire: 
+- Tobias Schoknecht
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-05-16 00:00:00.000000000 Z
+date: 2022-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -40,7 +41,7 @@ dependencies:
         version: '3.3'
 description: GCRA implementation for rate limiting
 email:
-- michael.frister@barzahlen.de
+- tobias.schoknecht@viafintech.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -48,11 +49,11 @@ files:
 - lib/gcra/rate_limiter.rb
 - lib/gcra/redis_store.rb
 - lib/gcra/version.rb
-homepage: https://github.com/Barzahlen/gcra
+homepage: https://github.com/viafintech/gcra-ruby
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -67,9 +68,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.8
-signing_key: 
+rubygems_version: 3.0.6
+signing_key:
 specification_version: 4
 summary: Ruby implementation of a generic cell rate algorithm (GCRA), ported from
   the Go implementation throttled.