gazer 0.2.59 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b67ec12c5dba850ab2a62f07164e4d051e202cbe0b3b44b50a854499c87f80dc
-  data.tar.gz: 33ffc537d99dd9a184e43b20bc44423a0ed40d11966d1bfde06c637f23b71e5f
+  metadata.gz: 371ab48fd0b84acabc2e3e69475c1091b55249385eb04f7829f0307ebc4f8b2e
+  data.tar.gz: 278b70d24348f197754f917fe9f386c77f46dd8491511379c670b24a0b72403b
 SHA512:
-  metadata.gz: dbcbad1a30333e30a9de999ac7a9a807ed8b306378197a828397c1d7cf00bebec51190b0b3f35dc04828d0c6c8449b2b25f0b1811c85c9db0154abe2ed1b4f69
-  data.tar.gz: dbcc80f63e040184eebbffd1211cc20df0dcd9454277bbb4b71abfa8afbc45dd7fc1a103f0ef2976d5d6ee52e4a8454958b54e9452e645292aba3deaa2bd098a
+  metadata.gz: 52ebaf3617cbf085a9faeb3813e27abfbb603b42343dd61f86bc27b5a742bf3bc101877593c7aee863c87411416d97545c345c20ee45f3bb03319b5161a8e9e7
+  data.tar.gz: 4cb981d34fa562368feb3895ba8de78458237fd5428dec73b8d2c259f44a1fc5e0c07abb8471e2db802c947833573a505e186eeee7fb7170b1ab7a23e8ecd174

data/.github/workflows/lint-pr.yml

@@ -0,0 +1,17 @@
+name: "Lint PR"
+
+on:
+  pull_request_target:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+jobs:
+  main:
+    name: Validate PR title
+    runs-on: ubuntu-latest
+    steps:
+      - uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/release.yml

@@ -11,7 +11,9 @@ jobs:
   release-please:
     runs-on: ubuntu-latest
     steps:
-      - uses: GoogleCloudPlatform/release-please-action@v2
+      # Checkout code
+      - uses: actions/checkout@v3
+      - uses: GoogleCloudPlatform/release-please-action@v3
         id: release
         with:
           release-type: ruby
@@ -20,9 +22,6 @@ jobs:
           bump-patch-for-minor-pre-major: true
           version-file: "lib/gzr/version.rb"
           token: ${{ secrets.LOS_AUTO_BOT_RP_TOKEN }}
-      # Checkout code if release was created
-      - uses: actions/checkout@v2
-        if: ${{ steps.release.outputs.release_created }}
       # Setup ruby if a release was created
       - uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/ruby-ci.yml

@@ -88,7 +88,7 @@ jobs:
 
       - name: Upload ts unit test results
         if: ${{ always() }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: ruby-ci-test-results-${{ matrix.looker }}
           path: rspec.xml
@@ -100,7 +100,7 @@ jobs:
 
     steps:
       - name: Download Artifacts
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v3
         with:
           path: artifacts
 

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # Changelog
 
+## [0.3.0](https://github.com/looker-open-source/gzr/compare/v0.2.60...v0.3.0) (2023-04-13)
+
+
+### Features
+
+* Misc fixes ([#175](https://github.com/looker-open-source/gzr/issues/175)) ([20b334b](https://github.com/looker-open-source/gzr/commit/20b334b3e4d1a76ecef79d5c686f6cf428cdc47d))
+
+
+### Miscellaneous Chores
+
+* release 0.3.0 ([5ed2182](https://github.com/looker-open-source/gzr/commit/5ed2182b94c20126f59b0678671d7c9b81c1c794))
+
+### [0.2.60](https://www.github.com/looker-open-source/gzr/compare/v0.2.59...v0.2.60) (2023-04-11)
+
+
+### Bug Fixes
+
+* quick typo fixes for API 4.0 changes ([#168](https://www.github.com/looker-open-source/gzr/issues/168)) ([82a634e](https://www.github.com/looker-open-source/gzr/commit/82a634e77de0aaee5bd62c84092e827a2f7f6c73))
+
 ### [0.2.59](https://www.github.com/looker-open-source/gzr/compare/v0.2.58...v0.2.59) (2023-03-29)
 
 

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    gazer (0.2.59)
-      looker-sdk (~> 0.1.1, <= 0.1.2)
+    gazer (0.3.0)
+      faraday (~> 1.10.3)
+      looker-sdk (~> 0.1.1)
       net-http-persistent (~> 4.0, >= 4.0.1)
       netrc (~> 0.11.0)
       pastel (~> 0.8.0)
@@ -42,8 +43,8 @@ GEM
     faraday-patron (1.0.0)
     faraday-rack (1.0.0)
     faraday-retry (1.0.3)
-    looker-sdk (0.1.2)
-      faraday (>= 1.2, < 2.0)
+    looker-sdk (0.1.4)
+      faraday (>= 1.2, < 3.0)
       sawyer (~> 0.8)
     multipart-post (2.3.0)
     net-http-persistent (4.0.1)
@@ -51,7 +52,7 @@ GEM
     netrc (0.11.0)
     pastel (0.8.0)
       tty-color (~> 0.5)
-    public_suffix (4.0.7)
+    public_suffix (5.0.1)
     rake (12.3.3)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)

data/gzr.gemspec

@@ -59,7 +59,8 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'thor', '~> 1.1', '>= 1.1.0'
   spec.add_dependency 'netrc', "~> 0.11.0"
   spec.add_runtime_dependency 'rubyzip', '~> 1.3', '>= 1.3.0'
-  spec.add_dependency 'looker-sdk', "~> 0.1.1", "<= 0.1.2"
+  spec.add_dependency 'faraday', "~> 1.10.3"
+  spec.add_dependency 'looker-sdk', "~> 0.1.1"
   spec.add_runtime_dependency 'net-http-persistent', '~> 4.0', '>= 4.0.1'
 
   spec.add_development_dependency 'bundler', '~> 2.2', '>= 2.2.10'

data/lib/gzr/cli.rb

@@ -36,9 +36,8 @@ module Gzr
     class_option :debug, type: :boolean, default: false, desc: 'Run in debug mode'
     class_option :host, type: :string, default: 'localhost', desc: 'Looker Host'
     class_option :port, type: :string, default: '19999', desc: 'Looker API Port'
-    class_option :client_id, type: :string, desc: 'API3 Client Id'
-    class_option :client_secret, type: :string, desc: 'API3 Client Secret'
-    class_option :api_version, type: :string, desc: 'Looker API Version'
+    class_option :client_id, type: :string, desc: 'API Client Id'
+    class_option :client_secret, type: :string, desc: 'API Client Secret'
     class_option :ssl, type: :boolean, default: true, desc: 'Use ssl to communicate with host'
     class_option :verify_ssl, type: :boolean, default: true, desc: 'Verify the SSL certificate of the host'
     class_option :timeout, type: :numeric, default: 60, desc: 'Seconds to wait for a response from the server'
@@ -57,7 +56,7 @@ module Gzr
       puts "v#{Gzr::VERSION}"
     end
     map %w(--version -v) => :version
-    map folder: :space  # Alias folder command to space
+    map space: :folder  # Alias space command to folder
 
     require_relative 'commands/attribute'
     register Gzr::Commands::Attribute, 'attribute', 'attribute [SUBCOMMAND]', 'Command description...'
@@ -92,7 +91,7 @@ module Gzr
     require_relative 'commands/look'
     register Gzr::Commands::Look, 'look', 'look [SUBCOMMAND]', 'Commands pertaining to looks'
 
-    require_relative 'commands/space'
-    register Gzr::Commands::Space, 'space', 'space [SUBCOMMAND]', 'Commands pertaining to spaces'
+    require_relative 'commands/folder'
+    register Gzr::Commands::Folder, 'folder', 'folder [SUBCOMMAND]', 'Commands pertaining to folders'
   end
 end

data/lib/gzr/command.rb

@@ -25,6 +25,7 @@ require 'forwardable'
 require 'tty-reader'
 require 'netrc'
 require 'looker-sdk'
+require 'faraday/multipart'
 
 require_relative 'modules/session'
 
@@ -57,7 +58,7 @@ module Gzr
         data = @sdk.query(query_id)
       rescue LookerSDK::Error => e
         say_error "Error querying query(#{query_id})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -71,7 +72,7 @@ module Gzr
         end
       rescue LookerSDK::Error => e
         say_error "Error creating query(#{JSON.pretty_generate(query)})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -85,7 +86,7 @@ module Gzr
         say_error "The api endpoint merge_query(#{merge_result_id}) is not implemented on this Looker instance"
       rescue LookerSDK::Error => e
         say_error "Error querying merge_query(#{merge_result_id})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -99,7 +100,7 @@ module Gzr
         raise
       rescue LookerSDK::Error => e
         say_error "Error creating merge_query(#{JSON.pretty_generate(merge_query)})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -110,7 +111,7 @@ module Gzr
         data = @sdk.run_inline_query("json",query)
       rescue LookerSDK::Error => e
         say_error "Error running inline_query(#{JSON.pretty_generate(query)})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -126,7 +127,7 @@ module Gzr
         say_warning "The current user can't query all color collections"
       rescue LookerSDK::Error => e
         say_error "Error querying all_color_collections()"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -144,7 +145,7 @@ module Gzr
         say_warning "The current user can't query the default color collection"
       rescue LookerSDK::Error => e
         say_error "Error querying default_color_collection()"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -160,7 +161,7 @@ module Gzr
         say_warning "The color_collection(#{collection_id}) is not found"
       rescue LookerSDK::Error => e
         say_error "Error querying color_collection(#{collection_id})"
-        say_error e.message
+        say_error e
         raise
       end
       data
@@ -182,7 +183,7 @@ module Gzr
           return
         end
         @default_colors=color_palette_lookup!(dcc)
-        say_warning("Default colors #{JSON.pretty_generate @default_colors}") if @options[:debug]
+        #say_warning("Default colors #{JSON.pretty_generate @default_colors}") if @options[:debug]
       end unless @default_colors
 
       if obj.respond_to?(:'has_key?') && obj.has_key?(:collection_id) && obj.has_key?(:palette_id)
@@ -194,13 +195,13 @@ module Gzr
 
     def color_palette_lookup!(obj)
       return nil unless obj.respond_to?(:'has_key?')
-      say_warning("performing color_palette_lookup! on #{JSON.pretty_generate obj}") if @options[:debug]
+      #say_warning("performing color_palette_lookup! on #{JSON.pretty_generate obj}") if @options[:debug]
       palettes = []
       palettes += obj[:categoricalPalettes] if obj[:categoricalPalettes]
       palettes += obj[:sequentialPalettes] if obj[:sequentialPalettes]
       palettes += obj[:divergingPalettes] if obj[:divergingPalettes]
       obj[:palettes]=palettes
-      say_warning("got palettes #{JSON.pretty_generate palettes}") if @options[:debug]
+      #say_warning("got palettes #{JSON.pretty_generate palettes}") if @options[:debug]
       obj
     end
 
@@ -211,11 +212,11 @@ module Gzr
         cc = default_colors
       else
         o[:collection_default] = false
-        say_ok("looking up color collection by id #{o[:collection_id]}") if @options[:debug]
+        #say_ok("looking up color collection by id #{o[:collection_id]}") if @options[:debug]
         cc = color_palette_lookup!(color_collection(o[:collection_id]))
       end
       return unless cc
-      say_warning("got color collection #{JSON.pretty_generate cc}") if @options[:debug]
+      #say_warning("got color collection #{JSON.pretty_generate cc}") if @options[:debug]
       o[:collection_label] = cc[:label]
       ps = cc[:palettes].select { |p| p[:id] == o[:palette_id] }
       if ps.length > 0
@@ -233,11 +234,11 @@ module Gzr
       cc = default_colors
       if !(force_default && o[:collection_default])
         # look up color collection by id
-        say_warning("attempting to match palette on id #{o[:collection_id]}") if @options[:debug]
+        #say_warning("attempting to match palette on id #{o[:collection_id]}") if @options[:debug]
         cc = color_palette_lookup!(color_collection(o[:collection_id]))
         if cc.nil?
           # find color collection by name
-          say_warning("no match on id, attempting to match palette on name #{o[:collection_label]}") if @options[:debug]
+          #say_warning("no match on id, attempting to match palette on name #{o[:collection_label]}") if @options[:debug]
           ccs = all_color_collections()&.select { |cc| o[:collection_label] == cc[:label]}
           if ccs.nil? || ccs.length == 0
             # no color collection found. Use default.
@@ -265,6 +266,7 @@ module Gzr
       end
     end
 
+
     ##
     # This method accepts the name of an sdk operation, then finds the parameter for that
     # operation in the data structures from the swagger.json file. The parameter is a
@@ -281,6 +283,11 @@ module Gzr
     #   end
 
     def keys_to_keep(operation)
+      @keys_to_keep_cache ||= {}
+      @keys_to_keep_cache[operation] ||= keys_to_keep_internal(operation)
+    end
+
+    def keys_to_keep_internal(operation)
       o = @sdk.operations[operation] || @sdk.operations[operation.to_sym]
       begin
         say_error "Operation #{operation} not found"
@@ -291,7 +298,10 @@ module Gzr
 
       say_warning "Expecting exactly one body parameter with a schema for operation #{operation}" unless parameters.length == 1
       schema_ref = parameters[0][:schema][:$ref].split(/\//)
-      return @sdk.swagger[schema_ref[1].to_sym][schema_ref[2].to_sym][:properties].reject { |k,v| v[:readOnly] }.keys
+      key_list = @sdk.swagger[schema_ref[1].to_sym][schema_ref[2].to_sym][:properties].reject { |k,v| v[:readOnly] }.keys
+      say_warning "key_list #{operation} -> #{key_list}" if @options[:debug]
+      return key_list
+
     end
 
     ##
@@ -382,7 +392,7 @@ module Gzr
     ##
     # This method will accept two arrays, a and b, and create a third array
     # like [ [a[0],b[0]], [a[1],b[1]], [a[2],b[2]], ...].
-    # If either array is longer than the other, additional pairs 
+    # If either array is longer than the other, additional pairs
     # will be generated with the shorter array padded out with nil values.
     #
     # Any additional args will be added to each inner array.

data/lib/gzr/commands/attribute/create.rb

@@ -44,11 +44,11 @@ module Gzr
             source[:'value_is_hidden'] = true if @options[:'is-hidden']
             source[:'user_can_view'] = true if @options[:'can-view']
             source[:'user_can_edit'] = true if @options[:'can-edit']
-            source[:'hidden_value_domain_whitelist'] = @options[:'domain-whitelist'] if @options[:'is-hidden'] && @options[:'domain-whitelist']
+            source[:'hidden_value_domain_allowlist'] = @options[:'domain-allowlist'] if @options[:'is-hidden'] && @options[:'domain-allowlist']
 
             attr = upsert_user_attribute(source, @options[:force], output: $stdout)
-            output.puts "Imported attribute #{attr.name} #{attr.id}" unless @options[:plain] 
-            output.puts attr.id if @options[:plain] 
+            output.puts "Imported attribute #{attr.name} #{attr.id}" unless @options[:plain]
+            output.puts attr.id if @options[:plain]
           end
         end
       end

data/lib/gzr/commands/attribute/get_group_value.rb

@@ -40,7 +40,7 @@ module Gzr
 
         def execute(input: $stdin, output: $stdout)
           say_warning(@options) if @options[:debug]
-          with_session("3.1") do
+          with_session do
 
             group_id = @group if /^\d+$/.match @group
             group = nil

data/lib/gzr/commands/attribute/import.rb

@@ -42,8 +42,8 @@ module Gzr
           with_session do
             read_file(@file) do |source|
               attr = upsert_user_attribute(source, @options[:force], output: $stdout)
-              output.puts "Imported attribute #{attr.name} #{attr.id}" unless @options[:plain] 
-              output.puts attr.id if @options[:plain] 
+              output.puts "Imported attribute #{attr.name} #{attr.id}" unless @options[:plain]
+              output.puts attr.id if @options[:plain]
             end
           end
         end

data/lib/gzr/commands/attribute/rm.rb

@@ -52,8 +52,8 @@ module Gzr
 
             delete_user_attribute(attr.id)
 
-            output.puts "Deleted attribute #{attr.name} #{attr.id}" unless @options[:plain] 
-            output.puts attr.id if @options[:plain] 
+            output.puts "Deleted attribute #{attr.name} #{attr.id}" unless @options[:plain]
+            output.puts attr.id if @options[:plain]
           end
         end
       end

data/lib/gzr/commands/attribute/set_group_value.rb

@@ -41,7 +41,7 @@ module Gzr
 
         def execute(input: $stdin, output: $stdout)
           say_warning(@options) if @options[:debug]
-          with_session("3.1") do
+          with_session do
 
             group_id = @group if /^\d+$/.match @group
             group = nil

data/lib/gzr/commands/attribute.rb

@@ -100,8 +100,8 @@ module Gzr
                            desc: 'can a non-admin user view the value'
       method_option :'can-edit', type: :boolean, default: true,
                            desc: 'can a user change the value themself'
-      method_option :'domain-whitelist', type: :string,
-                          desc: 'what domains can receive the value of a hidden attribute.' 
+      method_option :'domain-allowlist', type: :string,
+                          desc: 'what domains can receive the value of a hidden attribute.'
       def create(attr_name, attr_label=nil)
         if options[:help]
           invoke :help, ['create']

data/lib/gzr/commands/connection/ls.rb

@@ -61,7 +61,7 @@ module Gzr
               if @options[:csv] then
                 output.puts render_csv(table)
               else
-                output.puts table.render(if @options[:plain] then :basic else :ascii end, alignments: alignments, width: 1024, width: @options[:width] || TTY::Screen.width)
+                output.puts table.render(if @options[:plain] then :basic else :ascii end, alignments: alignments, width: @options[:width] || TTY::Screen.width)
               end
             end if table
           end

data/lib/gzr/commands/dashboard/cat.rb

@@ -42,7 +42,7 @@ module Gzr
 
         def execute(*args, input: $stdin, output: $stdout)
           say_warning("options: #{@options.inspect}") if @options[:debug]
-          with_session("3.1") do
+          with_session do
             data = cat_dashboard(@dashboard_id)
 
             replacements = {}

data/lib/gzr/commands/dashboard/import.rb

@@ -38,16 +38,16 @@ module Gzr
         include Gzr::User
         include Gzr::Plan
         include Gzr::FileHelper
-        def initialize(file, dest_space_id, options)
+        def initialize(file, dest_folder_id, options)
           super()
           @file = file
-          @dest_space_id = dest_space_id
+          @dest_folder_id = dest_folder_id
           @options = options
         end
 
         def execute(input: $stdin, output: $stdout)
           say_warning("options: #{@options.inspect}", output: output) if @options[:debug]
-          with_session("3.1") do
+          with_session do
 
             @me ||= query_me("id")
 
@@ -63,7 +63,8 @@ module Gzr
                 raise Gzr::CLI::Error, "import file is not a valid dashboard"
               end
 
-              dashboard = sync_dashboard(data,@dest_space_id, output: output)
+              dashboard = sync_dashboard(data,@dest_folder_id, output: output)
+              say_warning "dashboard object #{JSON.pretty_generate dashboard.map(&:to_a).to_json}" if @options[:debug]
 
               dashboard[:dashboard_filters] ||= []
               source_filters = data[:dashboard_filters].sort { |a,b| a[:row] <=> b[:row] }
@@ -79,30 +80,32 @@ module Gzr
               dashboard[:dashboard_elements] ||= []
               elem_table = data[:dashboard_elements].map do |new_element|
                 element = new_element.select do |k,v|
-                  (keys_to_keep('create_dashboard_element') - [:dashboard_id, :look_id, :query_id, :merge_result_id, :result_maker_id]).include? k
+                  (keys_to_keep('create_dashboard_element') - [:dashboard_id, :look_id, :query_id, :merge_result_id, :result_maker_id, :query, :merge_result]).include? k
                 end
-                (element[:query_id],element[:look_id],element[:merge_result_id]) = process_dashboard_element(new_element) 
-                say_warning "Creating dashboard element #{element.inspect}" if @options[:debug]
+                (element[:query_id],element[:look_id],element[:merge_result_id]) = process_dashboard_element(new_element)
+                say_warning "Creating dashboard element #{element.select {|k,v| !v.nil?}.inspect}" if @options[:debug]
                 element[:dashboard_id] = dashboard.id
                 result_maker = copy_result_maker_filterables(new_element)
                 element[:result_maker] = result_maker if result_maker
                 dashboard_element = create_dashboard_element(element)
+                say_warning "dashboard_element #{dashboard_element.inspect}" if @options[:debug]
                 dashboard[:dashboard_elements].push dashboard_element
                 [new_element[:id], dashboard_element.id]
               end
 
               source_dashboard_layouts = data[:dashboard_layouts].map do |new_layout|
                 layout_obj = nil
-                if new_layout[:active] 
+                if new_layout[:active]
                   layout_obj = get_dashboard_layout(dashboard[:dashboard_layouts].first.id)
                   say_warning "Updating layout #{layout_obj.id}" if @options[:debug]
-                else  
+                else
                   layout = new_layout.select do |k,v|
                     (keys_to_keep('create_dashboard_layout') - [:dashboard_id]).include? k
                   end
                   layout[:dashboard_id] = dashboard.id
                   say_warning "Creating dashboard layout #{layout}" if @options[:debug]
                   layout_obj = create_dashboard_layout(layout)
+                  say_warning "Created dashboard layout #{JSON.pretty_generate layout_obj.map(&:to_a).to_json}" if @options[:debug]
                 end
                 layout_components = new_layout[:dashboard_layout_components].zip(layout_obj.dashboard_layout_components)
                 layout_components.each do |source,target|
@@ -121,22 +124,22 @@ module Gzr
                 end
               end
               upsert_plans_for_dashboard(dashboard.id,@me.id,data[:scheduled_plans]) if data[:scheduled_plans]
-              output.puts "Imported dashboard #{dashboard.id}" unless @options[:plain] 
-              output.puts dashboard.id if @options[:plain] 
+              output.puts "Imported dashboard #{dashboard.id}" unless @options[:plain]
+              output.puts dashboard.id if @options[:plain]
             end
           end
         end
 
-        def sync_dashboard(source, target_space_id, output: $stdout)
-          # try to find dashboard by slug in target space
-          existing_dashboard = search_dashboards_by_slug(source[:slug], target_space_id).fetch(0,nil) if source[:slug]
-          # check for dash of same title in target space
-          title_used = search_dashboards_by_title(source[:title], target_space_id).select {|d| !d[:deleted] }.fetch(0,nil)
-
-          # If there is no match by slug in target space or no slug given, then we match by title
+        def sync_dashboard(source, target_folder_id, output: $stdout)
+          # try to find dashboard by slug in target folder
+          existing_dashboard = search_dashboards_by_slug(source[:slug], target_folder_id).fetch(0,nil) if source[:slug]
+          # check for dash of same title in target folder
+          title_used = search_dashboards_by_title(source[:title], target_folder_id).select {|d| !d[:deleted] }.fetch(0,nil)
+          # If there is no match by slug in target folder or no slug given, then we match by title
           existing_dashboard ||= title_used
+          say_warning "existing_dashboard object #{existing_dashboard.inspect}" if @options[:debug]
 
-          # same_title is now a flag indicating that there is already a dash in the same space with
+          # same_title is now a flag indicating that there is already a dash in the same folder with
           # that title, and it is the one we are updating.
           same_title = (title_used&.fetch(:id,nil) == existing_dashboard&.fetch(:id,nil))
 
@@ -148,18 +151,18 @@ module Gzr
           same_slug = (slug_used&.fetch(:id,nil) == existing_dashboard&.fetch(:id,nil))
 
           if slug_used && !same_slug then
-            say_warning "slug #{slug_used.slug} already used for dashboard #{slug_used.title} in space #{slug_used.space_id}", output: output
+            say_warning "slug #{slug_used.slug} already used for dashboard #{slug_used.title} in folder #{slug_used.folder_id}", output: output
             say_warning("That dashboard is in the 'Trash' but not fully deleted yet", output: output) if slug_used.deleted
             say_warning "dashboard will be imported with new slug", output: output
           end
 
           if existing_dashboard then
             if title_used && !same_title then
-              raise Gzr::CLI::Error, "Dashboard #{source[:title]} already exists in space #{target_space_id}\nDelete it before trying to upate another dashboard to have that title."
+              raise Gzr::CLI::Error, "Dashboard #{source[:title]} already exists in folder #{target_folder_id}\nDelete it before trying to upate another dashboard to have that title."
             end
-            raise Gzr::CLI::Error, "Dashboard #{existing_dashboard[:title]} with slug #{existing_dashboard[:slug]} already exists in space #{target_space_id}\nUse --force if you want to overwrite it" unless @options[:force]
+            raise Gzr::CLI::Error, "Dashboard #{existing_dashboard[:title]} with slug #{existing_dashboard[:slug]} already exists in folder #{target_folder_id}\nUse --force if you want to overwrite it" unless @options[:force]
 
-            say_ok "Modifying existing dashboard #{existing_dashboard.id} #{existing_dashboard[:title]} in space #{target_space_id}", output: output
+            say_ok "Modifying existing dashboard #{existing_dashboard.id} #{existing_dashboard[:title]} in folder #{target_folder_id}", output: output
             new_dash = source.select do |k,v|
               (keys_to_keep('update_dashboard') - [:space_id,:folder_id,:user_id,:slug]).include? k
             end
@@ -188,9 +191,13 @@ module Gzr
               (keys_to_keep('create_dashboard') - [:space_id,:folder_id,:user_id,:slug]).include? k
             end
             new_dash[:slug] = source[:slug] unless slug_used
-            new_dash[:space_id] = target_space_id
+            new_dash[:folder_id] = target_folder_id
             new_dash[:user_id] = @me.id
-            return create_dashboard(new_dash)
+            new_dash.select!{|k,v| !v.nil?}
+            say_warning "new dashboard request #{new_dash.inspect}" if @options[:debug]
+            d = create_dashboard(new_dash)
+            say_warning "new dashboard object #{d.inspect}" if @options[:debug]
+            return d
           end
         end
 
@@ -209,7 +216,7 @@ module Gzr
         end
 
         def process_dashboard_element(dash_elem)
-          return [nil, upsert_look(@me.id, create_fetch_query(dash_elem[:look][:query]).id, @dest_space_id, dash_elem[:look]).id, nil] if dash_elem[:look]
+          return [nil, upsert_look(@me.id, create_fetch_query(dash_elem[:look][:query]).id, @dest_folder_id, dash_elem[:look]).id, nil] if dash_elem[:look]
 
           query = dash_elem[:result_maker]&.fetch(:query, false) || dash_elem[:query]
           return [create_fetch_query(query).id, nil, nil] if query

data/lib/gzr/commands/dashboard/mv.rb

@@ -30,10 +30,10 @@ module Gzr
     class Dashboard
       class Mv < Gzr::Command
         include Gzr::Dashboard
-        def initialize(dashboard_id, target_space_id, options)
+        def initialize(dashboard_id, target_folder_id, options)
           super()
           @dashboard_id = dashboard_id
-          @target_space_id = target_space_id
+          @target_folder_id = target_folder_id
           @options = options
         end
 
@@ -44,18 +44,18 @@ module Gzr
             dash = query_dashboard(@dashboard_id)
             raise Gzr::CLI::Error, "Dashboard with id #{@dashboard_id} does not exist" unless dash
 
-            matching_title = search_dashboards_by_title(dash[:title],@target_space_id)
+            matching_title = search_dashboards_by_title(dash[:title],@target_folder_id)
             if matching_title.empty? || matching_title.first[:deleted]
               matching_title = false
             end
-            
+
             if matching_title
-              raise Gzr::CLI::Error, "Dashboard #{dash[:title]} already exists in space #{@target_space_id}\nUse --force if you want to overwrite it" unless @options[:force]
-              say_ok "Deleting existing dashboard #{matching_title.first[:id]} #{matching_title.first[:title]} in space #{@target_space_id}", output: output
+              raise Gzr::CLI::Error, "Dashboard #{dash[:title]} already exists in folder #{@target_folder_id}\nUse --force if you want to overwrite it" unless @options[:force]
+              say_ok "Deleting existing dashboard #{matching_title.first[:id]} #{matching_title.first[:title]} in folder #{@target_folder_id}", output: output
               update_dashboard(matching_title.first[:id],{:deleted=>true})
             end
-            update_dashboard(dash[:id],{:space_id=>@target_space_id})
-            output.puts "Moved dashboard #{dash[:id]} to space #{@target_space_id}" unless @options[:plain] 
+            update_dashboard(dash[:id],{:folder_id=>@target_folder_id})
+            output.puts "Moved dashboard #{dash[:id]} to folder #{@target_folder_id}" unless @options[:plain]
           end
         end
       end