gather 0.0.7 → 0.0.8

data/History.txt

@@ -1,3 +1,7 @@
+== 0.0.8
+* Fix the property accessors. They were returning values inside arrays under
+  some conditions. Write tests to check this.
+
 == 0.0.7
 * Remove Hoe dependency
 * check arity differently with ruby-1.9.2

data/Rakefile

@@ -12,4 +12,5 @@ Bones {
   authors  'John Anderson'
   email    'panic@semiosix.com'
   url      'https://rubygems.org/gems/gather'
+  description 'A gem that provides modules to make working with properties a bit easier.'
 }

data/lib/changes.rb

@@ -163,7 +163,8 @@ module Changes
               if val.empty?
                 @#{property}
               else
-                self.#{property} = *val
+                unwrapped_value = val.size == 1 ? val[0] : val
+                self.#{property} = unwrapped_value
               end
             end
             
@@ -179,7 +180,7 @@ module Changes
               @before_#{property}_block = block
             end
             
-            def #{property}=(*new_value)
+            def #{property}=(*new_value)              
               unwrapped_value = new_value.size == 1 ? new_value[0] : new_value
               return if unwrapped_value == @#{property}
               

data/lib/gather.rb

@@ -122,24 +122,24 @@ module Gather
     def property( *symbols )
       @stripper_re ||= /^([^\= ]+)\s*\=?\s*$/
       symbols.each do |sym|
-        stripped = @stripper_re.match( sym.to_s )[1]
-        own_properties << stripped.to_sym
+        method_name = @stripper_re.match( sym.to_s )[1]
+        own_properties << method_name.to_sym
         line, st = __LINE__, <<-EOF
-          def #{stripped}(*val, &block)
+          def #{method_name}(*val, &block)
             if block.nil?
               if val.empty?
-                @#{stripped}
+                @#{method_name}
               else
                 # use the assignment, so only it has to be overloaded
-                self.#{stripped} = val.size == 1 ? val[0] : val
+                self.#{method_name} = val.size == 1 ? val[0] : val
               end
             else
-              @#{stripped} = block
+              @#{method_name} = block
             end
           end
           
-          def #{stripped}=( value )
-            @#{stripped} = value
+          def #{method_name}=( value )
+            @#{method_name} = value
           end
         EOF
         class_eval st, __FILE__, line + 1

data/test/test_changes.rb

@@ -1,18 +1,30 @@
 require File.dirname(__FILE__) + '/test_helper.rb'
+require 'changes'
 
-class TestChanges < Test::Unit::TestCase
-  def self.startup
-  end
+class SumDumClass
+  include Changes
   
-  def self.shutdown
-  end
-  
-  def setup
-  end
-  
-  should "be true" do
-    assert true
+  property :aac
+  property :ben
+  property :civ
+end
+
+class TestChanges < Test::Unit::TestCase
+  context "instantiated with hash" do
+    setup do
+      @instance = SumDumClass.new(
+        :aac => 'hey',
+        :ben => 'thewre',
+        :civ => 'dude'
+      )
+    end
+    
+    should 'have correct values' do
+      assert_equal 'hey', @instance.aac
+      assert_equal 'thewre', @instance.ben
+      assert_equal 'dude', @instance.civ
+    end
   end
   
-  should_eventually "do some real tests"
+  should_eventually "do more tests"
 end

data/test/test_gather.rb

@@ -103,6 +103,12 @@ class TestGather < Test::Unit::TestCase
       assert_equal arr, @instance.to_a
       assert_equal arr, @instance.values
     end
+    
+    should 'be correct' do
+      assert_equal 'hey', @instance.aac
+      assert_equal 'thewre', @instance.ben
+      assert_equal 'dude', @instance.civ
+    end
   end
   
   should_eventually "test merge with a hash"

data/test/test_helper.rb

@@ -1,3 +1,7 @@
+if defined?( RUBY_VERSION ) && RUBY_VERSION < "1.9.0"
+  require  'rubygems'
+end
+
 require 'test/unit'
 require 'shoulda'
 require 'pathname'

data/version.txt

@@ -1 +1 @@
-0.0.7
+0.0.8

metadata

@@ -1,58 +1,36 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: gather
-version: !ruby/object:Gem::Version 
+version: !ruby/object:Gem::Version
+  version: 0.0.8
   prerelease: 
-  version: 0.0.7
 platform: ruby
-authors: 
+authors:
 - John Anderson
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-06-08 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2011-06-21 00:00:00.000000000 +02:00
+default_executable: 
+dependencies:
+- !ruby/object:Gem::Dependency
   name: bones
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &69263020 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
         version: 3.7.0
   type: :development
-  version_requirements: *id001
-description: |-
-  A gem that provides modules to make working with properties a bit easier.
-  
-  For example:
-  
-    class SumThing
-      include Gather
-      property :thing, :spla, :gumf, :troob
-    end
-   
-    s = SumThing.new.gather :spla => 'five', :thing => 'sigma' do
-      troob %w{one two three four}
-      gumf 15 % 4
-    end
-  
-  Or
-  
-    s = SumThing.new.gather :spla => 'five', :thing => 'sigma' do |s|
-      s.troob = %w{one two three four}
-      s.gumf = 15 % 4
-    end
+  prerelease: false
+  version_requirements: *69263020
+description: A gem that provides modules to make working with properties a bit easier.
 email: panic@semiosix.com
 executables: []
-
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - History.txt
 - Manifest.txt
-files: 
+files:
 - .gitignore
 - History.txt
 - LICENSE
@@ -62,42 +40,40 @@ files:
 - TODO
 - lib/changes.rb
 - lib/gather.rb
-- lib/version.rb
 - script/destroy
 - script/generate
 - test/test_changes.rb
 - test/test_gather.rb
 - test/test_helper.rb
 - version.txt
+has_rdoc: true
 homepage: https://rubygems.org/gems/gather
 licenses: []
-
 post_install_message: 
-rdoc_options: 
+rdoc_options:
 - --main
 - README
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: gather
-rubygems_version: 1.7.2
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: http://gather.
-test_files: 
-- test/test_changes.rb
+test_files:
 - test/test_gather.rb
 - test/test_helper.rb
+- test/test_changes.rb

data/lib/version.rb

@@ -1,3 +0,0 @@
-module Gather
-  VERSION = '0.0.6'
-end