garb 0.8.3 → 0.8.4

data/lib/garb/filter_parameters.rb

@@ -32,7 +32,7 @@ module Garb
         param.map do |k,v|
           next unless k.is_a?(SymbolOperator)
           "#{URI.encode(k.to_google_analytics, /[=<>]/)}#{CGI::escape(v.to_s)}"
-        end.join(';') # Hash AND (no duplicate keys)
+        end.join('%3B') # Hash AND (no duplicate keys), escape char for ';' fixes oauth
       end.join(',') # Array OR
 
       value.empty? ? {} : {'filters' => value}

data/lib/garb/management/profile.rb

@@ -5,7 +5,7 @@ module Garb
       include ProfileReports
 
       attr_reader :session, :path
-      attr_reader :id, :title, :account_id, :web_property_id
+      attr_reader :id, :table_id, :title, :account_id, :web_property_id
 
       def self.all(session = Session, path = '/accounts/~all/webproperties/~all/profiles')
         feed = Feed.new(session, path)
@@ -23,10 +23,11 @@ module Garb
       def initialize(entry, session)
         @session = session
         @path = Garb.parse_link(entry, "self").gsub(Feed::BASE_URL, '')
-        @title = entry['title'].gsub('Google Analytics Profile ', '')
 
         properties = Garb.parse_properties(entry)
         @id = properties['profile_id']
+        @table_id = properties['table_id']
+        @title = properties['profile_name']
         @account_id = properties['account_id']
         @web_property_id = properties['web_property_id']
       end

data/lib/garb/version.rb

@@ -3,7 +3,7 @@ module Garb
 
     MAJOR = 0
     MINOR = 8
-    TINY  = 3
+    TINY  = 4
 
     def self.to_s # :nodoc:
       [MAJOR, MINOR, TINY].join('.')

data/lib/support.rb

@@ -17,18 +17,19 @@ class SymbolOperator
       :does_not_contain => '!~',
       :substring => '=@',
       :not_substring => '!@',
-      :desc => '-'
+      :desc => '-',
+      :descending => '-'
     }
 
     target = Garb.to_google_analytics(@field)
     operator = operators[@operator]
 
-    @operator == :desc ? "#{operator}#{target}" : "#{target}#{operator}"
+    [:desc, :descending].include?(@operator) ? "#{operator}#{target}" : "#{target}#{operator}"
   end
 end
 
 class Symbol
-  [:eql, :not_eql, :gt, :gte, :lt, :lte, :desc,
+  [:eql, :not_eql, :gt, :gte, :lt, :lte, :desc, :descending,
     :matches, :does_not_match, :contains, :does_not_contain,
     :substring, :not_substring].each do |operator|
 

data/test/unit/garb/filter_parameters_test.rb

@@ -42,7 +42,7 @@ module Garb
           end
 
           params = ['ga:city%3D%3DNew+York+City', 'ga:state%3D%3DNew+York']
-          assert_equal params, @filter_parameters.to_params['filters'].split(';').sort
+          assert_equal params, @filter_parameters.to_params['filters'].split('%3B').sort
         end
 
         should "properly encode operators" do

data/test/unit/garb/management/profile_test.rb

@@ -23,12 +23,12 @@ module Garb
       context "A Profile" do
         setup do
           entry = {
-            "title" => "Google Analytics Profile example.com",
             "link" => [{"rel" => "self", "href" => Feed::BASE_URL+"/accounts/1189765/webproperties/UA-1189765-1/profiles/98765"}],
             "dxp:property" => [
               {"name" => "ga:profileId", "value" => "98765"},
               {"name" => "ga:accountId", "value" => "1189765"},
-              {"name" => "ga:webPropertyId", "value" => 'UA-1189765-1'}
+              {"name" => "ga:webPropertyId", "value" => 'UA-1189765-1'},
+              {"name" => "ga:profileName", "value" => "example.com"}
             ]
           }
           @profile = Profile.new(entry, Session)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: garb
 version: !ruby/object:Gem::Version 
-  hash: 57
+  hash: 55
   prerelease: false
   segments: 
   - 0
   - 8
-  - 3
-  version: 0.8.3
+  - 4
+  version: 0.8.4
 platform: ruby
 authors: 
 - Tony Pitale
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-10 00:00:00 -04:00
+date: 2010-10-11 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency