garage_client 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59a22afce362de90c9f060761a53b4606bf76b15
-  data.tar.gz: 1a6688baf001b1d7b056f97c9bd6b6af10556e2b
+  metadata.gz: d9f1a69ba91fc3ac307c8a3fee280e770afa9cb3
+  data.tar.gz: 97ec57d1cb62ce4eb891235aa793885e11a05838
 SHA512:
-  metadata.gz: fbfb76de3ee53fcf0bfa6a0a25e860ce4ab747b52bb265d4dba09edfa8df53ed3e75f6a9a491907b5225dd5165beb5e13394644111400cb87157199608297307
-  data.tar.gz: 9fc1fac781f43df08346dd422db81fad9768ad29227f14fbc434ebf3dcc53eb25a33e82d97f06344cb36c6abac03e81fc23f06c6405a24b07b94069d2dd6769b
+  metadata.gz: bcce64de0d5f23fb06f9859ea1527c5da42dba01e970ea08225e5c148a774ecbecc874cbc1f4ae262f915c453f97acfa63cbc1dc8cf3dab359b887bcf94189da
+  data.tar.gz: c308b58aec27465cb8484252725aa5170d1cfe5ca5b6e263d2a034438e3b19bff1e5f3b2e4857397b7e2104a49b4f4664829a19e1de384fd0a915600ffa02a7c

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.3.2
+- Automatically set `Rails.application.class.parent_name.underscore`
+  to `name` configuration in Rails by default.
+
 ## 2.3.1
 - Raise `GarageClient::GatewayTimeout` for 504 error
 

data/README.md

@@ -92,7 +92,7 @@ There are the following options:
 
 - `adapter` - faraday adapter for http client (default: `:net_http`)
 - `cacher` - take a cacher class in which caching logic is defined (default: nil)
-- `name` - Client's application name, which is embedded in User-Agent by default (default: nil)
+- `name` - Client's application name, which is embedded in User-Agent by default (default: nil. For Rails, `Rails.application.class.parent_name.underscore` is set by default.)
 - `headers` - default http headers (default: `{ "Accept" => "application/json", "User-Agent" => "garage_client #{VERSION} #{name}" }`)
 - `endpoint` - Garage application API endpoint (default: nil)
 - `path_prefix` - API path prefix (default: `'/v1'`)

data/garage_client.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency 'system_timer' if RUBY_VERSION < '1.9'
 
+  s.add_development_dependency "rails"
   s.add_development_dependency "rake", ">= 0.9.2"
   s.add_development_dependency "rspec"
   s.add_development_dependency "json"

data/lib/garage_client/railtie.rb

@@ -0,0 +1,17 @@
+module GarageClient
+  class Railtie < ::Rails::Railtie
+    initializer :garage_client do |app|
+      RailsInitializer.set_default_name
+    end
+  end
+
+  module RailsInitializer
+    def self.set_default_name
+      unless GarageClient.configuration.options[:name]
+        GarageClient.configure do |c|
+          c.name = Rails.application.class.parent_name.underscore
+        end
+      end
+    end
+  end
+end

data/lib/garage_client/version.rb

@@ -1,3 +1,3 @@
 module GarageClient
-  VERSION = '2.3.1'
+  VERSION = '2.3.2'
 end

data/lib/garage_client.rb

@@ -15,6 +15,13 @@ require 'garage_client/response/raise_http_exception'
 require 'garage_client/resource'
 require 'garage_client/client'
 
+begin
+  require 'rails'
+rescue LoadError
+else
+  require 'garage_client/railtie'
+end
+
 module GarageClient
   class << self
     GarageClient::Configuration.keys.each do |key|

data/spec/garage_client/railtie_spec.rb

@@ -0,0 +1,40 @@
+describe GarageClient::Railtie do
+  describe 'initializer' do
+    let(:parent_name) { 'Cookpad' }
+
+    before do
+      allow(Rails).to receive_message_chain(:application, :class, :parent_name).
+        and_return(parent_name)
+    end
+
+    context 'when GarageClient.configuration.name is absent' do
+      before do
+        GarageClient.configuration.name = nil
+      end
+
+      it 'sets name by Rails.application.class.parent_name' do
+        expect {
+          GarageClient::RailsInitializer.set_default_name
+        }.to change {
+          GarageClient.configuration.options[:name]
+        }.from(nil).to(parent_name.underscore)
+      end
+    end
+
+    context 'when GarageClient.configuration.name is present' do
+      let(:name) { 'cookpad2' }
+
+      before do
+        GarageClient.configuration.name = name
+      end
+
+      it 'does not override name' do
+        expect {
+          GarageClient::RailsInitializer.set_default_name
+        }.to_not change {
+          GarageClient.configuration.options[:name]
+        }.from(name)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: garage_client
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Cookpad Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-29 00:00:00.000000000 Z
+date: 2016-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -186,6 +200,7 @@ files:
 - lib/garage_client/client.rb
 - lib/garage_client/configuration.rb
 - lib/garage_client/error.rb
+- lib/garage_client/railtie.rb
 - lib/garage_client/request.rb
 - lib/garage_client/request/json_encoded.rb
 - lib/garage_client/request/propagate_request_id.rb
@@ -205,6 +220,7 @@ files:
 - spec/garage_client/client_spec.rb
 - spec/garage_client/configuration_spec.rb
 - spec/garage_client/error_spec.rb
+- spec/garage_client/railtie_spec.rb
 - spec/garage_client/request/json_encoded_spec.rb
 - spec/garage_client/request/propagate_request_id_spec.rb
 - spec/garage_client/resource_spec.rb
@@ -246,6 +262,7 @@ test_files:
 - spec/garage_client/client_spec.rb
 - spec/garage_client/configuration_spec.rb
 - spec/garage_client/error_spec.rb
+- spec/garage_client/railtie_spec.rb
 - spec/garage_client/request/json_encoded_spec.rb
 - spec/garage_client/request/propagate_request_id_spec.rb
 - spec/garage_client/resource_spec.rb