gandi_v5 0.1.0 → 0.2.0

data/spec/units/gandi_v5/email/slot_spec.rb

@@ -5,19 +5,32 @@ describe GandiV5::Email::Slot do
     described_class.new id: 123, capacity: 1, mailbox_type: :standard, status: :inactive, fqdn: 'example.com'
   end
 
-  it '#delete' do
-    expect(GandiV5).to receive(:delete).with('https://api.gandi.net/v5/email/slots/example.com/123')
-                                       .and_return('message' => 'Confirmation message.')
-    expect(subject.delete).to eq 'Confirmation message.'
+  describe '#delete' do
+    it 'Is deletable' do
+      subject = described_class.new fqdn: 'example.com', id: 123, status: :inactive, refundable: true
+      expect(GandiV5).to receive(:delete).with('https://api.gandi.net/v5/email/slots/example.com/123')
+                                         .and_return([nil, { 'message' => 'Confirmation message.' }])
+      expect(subject.delete).to eq 'Confirmation message.'
+    end
+
+    it 'Is in use' do
+      subject = described_class.new fqdn: 'example.com', id: 123, status: :active, refundable: true
+      expect(GandiV5).to_not receive(:delete)
+      expect { subject.delete }.to raise_error GandiV5::Error, 'slot can\'t be deleted whilst active'
+    end
+
+    it 'Is not refundable' do
+      subject = described_class.new fqdn: 'example.com', id: 123, status: :inactive, refundable: false
+      expect(GandiV5).to_not receive(:delete)
+      expect { subject.delete }.to raise_error GandiV5::Error, 'slot can\'t be deleted if it\'s not refundable'
+    end
   end
-  # TODO: check for inactiveness
-  # TODO: check for refundableness
 
   describe '#refresh' do
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_Email_Slot', 'get.yaml'))
       expect(GandiV5).to receive(:get).with('https://api.gandi.net/v5/email/slots/example.com/123')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
       subject.refresh
     end
 
@@ -44,18 +57,93 @@ describe GandiV5::Email::Slot do
     end
   end
 
+  describe '#inactive?' do
+    it 'When active' do
+      slot = described_class.new status: :active
+      expect(slot.inactive?).to be false
+    end
+
+    it 'When inactive' do
+      slot = described_class.new status: :inactive
+      expect(slot.inactive?).to be true
+    end
+  end
+
+  describe '#free?' do
+    it 'When free' do
+      slot = described_class.new mailbox_type: :free
+      expect(slot.free?).to be true
+    end
+
+    it 'When standard' do
+      slot = described_class.new mailbox_type: :standard
+      expect(slot.free?).to be false
+    end
+
+    it 'When premium' do
+      slot = described_class.new mailbox_type: :premium
+      expect(slot.free?).to be false
+    end
+  end
+
+  describe '#standard?' do
+    it 'When free' do
+      slot = described_class.new mailbox_type: :free
+      expect(slot.standard?).to be false
+    end
+
+    it 'When standard' do
+      slot = described_class.new mailbox_type: :standard
+      expect(slot.standard?).to be true
+    end
+
+    it 'When premium' do
+      slot = described_class.new mailbox_type: :premium
+      expect(slot.standard?).to be false
+    end
+  end
+
+  describe '#premium?' do
+    it 'When free' do
+      slot = described_class.new mailbox_type: :free
+      expect(slot.premium?).to be false
+    end
+
+    it 'When standard' do
+      slot = described_class.new mailbox_type: :standard
+      expect(slot.premium?).to be false
+    end
+
+    it 'When premium' do
+      slot = described_class.new mailbox_type: :premium
+      expect(slot.premium?).to be true
+    end
+  end
+
   describe '.create' do
     let(:url) { 'https://api.gandi.net/v5/email/slots/example.com' }
+    let(:created_response) do
+      double(
+        RestClient::Response,
+        headers: { location: 'https://api.gandi.net/v5/email/slots/example.com/created-slot-uuid' }
+      )
+    end
+    let(:created_slot) { double GandiV5::Email::Slot }
+
     it 'With default type' do
       expect(GandiV5).to receive(:post).with(url, '{"mailbox_type":"standard"}')
-                                       .and_return('message' => 'Confirmation message.')
-      expect(described_class.create('example.com')).to eq 'Confirmation message.'
+                                       .and_return([created_response, { 'message' => 'Confirmation message.' }])
+      expect(described_class).to receive(:fetch).with('example.com', 'created-slot-uuid').and_return(created_slot)
+
+      expect(described_class.create('example.com')).to be created_slot
     end
 
     it 'With passed type' do
       expect(GandiV5).to receive(:post).with(url, '{"mailbox_type":"premium"}')
-                                       .and_return('message' => 'Confirmation message.')
-      expect(described_class.create('example.com', :premium)).to eq 'Confirmation message.'
+                                       .and_return([created_response, { 'message' => 'Confirmation message.' }])
+      expect(described_class).to receive(:fetch).with('example.com', 'created-slot-uuid').and_return(created_slot)
+
+      expect(described_class.create('example.com', :premium)).to be created_slot
     end
   end
 
@@ -65,7 +153,7 @@ describe GandiV5::Email::Slot do
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_Email_Slot', 'get.yaml'))
       expect(GandiV5).to receive(:get).with('https://api.gandi.net/v5/email/slots/example.com/123')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
     end
 
     its('fqdn') { should eq 'example.com' }
@@ -85,7 +173,7 @@ describe GandiV5::Email::Slot do
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_Email_Slot', 'list.yaml'))
       expect(GandiV5).to receive(:get).with('https://api.gandi.net/v5/email/slots/example.com')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
     end
 
     its('count') { should eq 1 }

data/spec/units/gandi_v5/live_dns/domain_spec.rb

@@ -9,7 +9,7 @@ describe GandiV5::LiveDNS::Domain do
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Domain', 'get.yaml'))
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains/example.com')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
       subject.refresh
     end
 
@@ -20,14 +20,14 @@ describe GandiV5::LiveDNS::Domain do
   describe '#fetch_records' do
     it 'All of them' do
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains/example.com/records')
-                                      .and_return([])
+                                      .and_return([nil, []])
 
       expect(subject.fetch_records).to eq []
     end
 
     it 'All for a name' do
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains/example.com/records/name')
-                                      .and_return([])
+                                      .and_return([nil, []])
 
       expect(subject.fetch_records('name')).to eq []
     end
@@ -36,12 +36,15 @@ describe GandiV5::LiveDNS::Domain do
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains/example.com/records/name/TXT')
                                       .and_return(
                                         [
-                                          {
-                                            'rrset_type' => 'TXT',
-                                            'rrset_name' => 'name',
-                                            'rrset_ttl' => 600,
-                                            'rrset_values' => %w[a b]
-                                          }
+                                          nil,
+                                          [
+                                            {
+                                              'rrset_type' => 'TXT',
+                                              'rrset_name' => 'name',
+                                              'rrset_ttl' => 600,
+                                              'rrset_values' => %w[a b]
+                                            }
+                                          ]
                                         ]
                                       )
 
@@ -61,19 +64,19 @@ describe GandiV5::LiveDNS::Domain do
   describe '#fetch_zone_lines' do
     it 'All of them' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records'
-      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return('returned')
+      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return([nil, 'returned'])
       expect(subject.fetch_zone_lines).to eq 'returned'
     end
 
     it 'All for a name' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name'
-      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return('returned')
+      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return([nil, 'returned'])
       expect(subject.fetch_zone_lines('name')).to eq 'returned'
     end
 
     it 'A type for a name' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name/TXT'
-      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return('returned')
+      expect(GandiV5).to receive(:get).with(url, accept: 'text/plain').and_return([nil, 'returned'])
       expect(subject.fetch_zone_lines('name', 'TXT')).to eq 'returned'
     end
 
@@ -86,7 +89,7 @@ describe GandiV5::LiveDNS::Domain do
     it 'Success' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records'
       body = '{"rrset_name":"name","rrset_type":"TXT","rrset_ttl":900,"rrset_values":["a","b"]}'
-      expect(GandiV5).to receive(:post).with(url, body).and_return('message' => 'Confirmation message.')
+      expect(GandiV5).to receive(:post).with(url, body).and_return([nil, { 'message' => 'Confirmation message.' }])
       expect(subject.add_record('name', 'TXT', 900, 'a', 'b')).to eq 'Confirmation message.'
     end
 
@@ -112,19 +115,19 @@ describe GandiV5::LiveDNS::Domain do
   describe '#delete_records' do
     it 'All of them' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records'
-      expect(GandiV5).to receive(:delete).with(url)
+      expect(GandiV5).to receive(:delete).with(url).and_return([nil, nil])
       subject.delete_records
     end
 
     it 'All for a name' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name'
-      expect(GandiV5).to receive(:delete).with(url)
+      expect(GandiV5).to receive(:delete).with(url).and_return([nil, nil])
       subject.delete_records 'name'
     end
 
     it 'A type for a name' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name/TXT'
-      expect(GandiV5).to receive(:delete).with(url)
+      expect(GandiV5).to receive(:delete).with(url).and_return([nil, nil])
       subject.delete_records 'name', 'TXT'
     end
 
@@ -142,7 +145,7 @@ describe GandiV5::LiveDNS::Domain do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records'
       body = '{"items":[{"rrset_name":"name","rrset_ttl":600,"rrset_type":"TXT","rrset_values":["a"]}]}'
       expect(GandiV5).to receive(:put).with(url, body)
-                                      .and_return('message' => 'Confirmation message.')
+                                      .and_return([nil, { 'message' => 'Confirmation message.' }])
       expect(subject.replace_records(records: records)).to eq 'Confirmation message.'
     end
 
@@ -154,7 +157,7 @@ describe GandiV5::LiveDNS::Domain do
 
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records'
       expect(GandiV5).to receive(:put).with(url, records, 'content-type': 'text/plain')
-                                      .and_return('message' => 'Confirmation message.')
+                                      .and_return([nil, { 'message' => 'Confirmation message.' }])
       expect(subject.replace_records(text: records)).to eq 'Confirmation message.'
     end
 
@@ -170,30 +173,35 @@ describe GandiV5::LiveDNS::Domain do
     end
   end
 
-  it '#replace_records_for' do
-    url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name'
-    body = '{"items":[{"rrset_type":"TXT","rrset_values":["a"]}]}'
-    expect(GandiV5).to receive(:put).with(url, body)
-                                    .and_return('message' => 'Confirmation message.')
-    records = { type: 'TXT', values: ['a'] }
-    expect(subject.replace_records_for('name', records)).to eq 'Confirmation message.'
-  end
+  describe '#replace_records_for' do
+    it 'Given no type or ttl' do
+      url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name'
+      body = '{"items":[{"rrset_type":"TXT","rrset_values":["a"]}]}'
+      expect(GandiV5).to receive(:put).with(url, body)
+                                      .and_return([nil, { 'message' => 'Confirmation message.' }])
+      records = [{ type: 'TXT', values: ['a'] }]
+      expect(subject.replace_records_for('name', records)).to eq 'Confirmation message.'
+    end
 
-  describe '#replace_??_records_for' do
-    it '#replace_a_records_for' do
-      url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name/A'
-      body = '{"rrset_ttl":600,"rrset_values":["192.168.0.1","192.168.0.2"]}'
+    it 'Given type and ttl' do
+      url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name/TXT'
+      body = '{"rrset_values":["a"],"rrset_ttl":600}'
       expect(GandiV5).to receive(:put).with(url, body)
-                                      .and_return('message' => 'Confirmation message.')
-      expect(subject.replace_a_records_for('name', 600, '192.168.0.1', '192.168.0.2')).to eq 'Confirmation message.'
+                                      .and_return([nil, { 'message' => 'Confirmation message.' }])
+      expect(subject.replace_records_for('name', ['a'], type: 'TXT', ttl: 600)).to eq 'Confirmation message.'
     end
 
-    it '#replace_txt_records_for' do
+    it 'Given type but no ttl' do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com/records/name/TXT'
-      body = '{"rrset_ttl":600,"rrset_values":["a","b"]}'
+      body = '{"rrset_values":["a"],"rrset_ttl":null}'
       expect(GandiV5).to receive(:put).with(url, body)
-                                      .and_return('message' => 'Confirmation message.')
-      expect(subject.replace_txt_records_for('name', 600, 'a', 'b')).to eq 'Confirmation message.'
+                                      .and_return([nil, { 'message' => 'Confirmation message.' }])
+      expect(subject.replace_records_for('name', ['a'], type: 'TXT')).to eq 'Confirmation message.'
+    end
+
+    it 'Given ttl but no type' do
+      expect(GandiV5).to_not receive(:put)
+      expect { subject.replace_records_for 'name', 'a', ttl: 600 }.to raise_error ArgumentError, 'missing keyword: type'
     end
   end
 
@@ -202,7 +210,7 @@ describe GandiV5::LiveDNS::Domain do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com'
       body = '{"zone_uuid":"zone-uuid"}'
       expect(GandiV5).to receive(:patch).with(url, body)
-                                        .and_return('message' => 'Confirmation message.')
+                                        .and_return([nil, { 'message' => 'Confirmation message.' }])
       expect(subject.change_zone('zone-uuid')).to eq 'Confirmation message.'
       expect(subject.zone_uuid).to eq 'zone-uuid'
     end
@@ -211,20 +219,42 @@ describe GandiV5::LiveDNS::Domain do
       url = 'https://dns.api.gandi.net/api/v5/domains/example.com'
       body = '{"zone_uuid":"zone-uuid"}'
       expect(GandiV5).to receive(:patch).with(url, body)
-                                        .and_return('message' => 'Confirmation message.')
+                                        .and_return([nil, { 'message' => 'Confirmation message.' }])
       zone = double GandiV5::LiveDNS::Zone, uuid: 'zone-uuid'
       expect(subject.change_zone(zone)).to eq 'Confirmation message.'
       expect(subject.zone_uuid).to eq 'zone-uuid'
     end
   end
 
+  it '#fetch_zone' do
+    returns = double GandiV5::LiveDNS::Zone
+    expect(GandiV5::LiveDNS::Zone).to receive(:fetch).with('zone-uuid')
+                                                     .and_return(returns)
+    expect(subject.fetch_zone).to be returns
+  end
+
+  describe '#zone' do
+    it 'Not previously fetched' do
+      returns = double GandiV5::LiveDNS::Zone
+      expect(subject).to receive(:fetch_zone).and_return(returns)
+      expect(subject.zone).to be returns
+    end
+
+    it 'Previously fetched' do
+      returns = double GandiV5::LiveDNS::Zone
+      subject.instance_exec { @zone = returns }
+      expect(subject).to_not receive(:fetch_zone)
+      expect(subject.zone).to be returns
+    end
+  end
+
   describe '.list' do
     subject { described_class.list }
 
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Domain', 'list.yaml'))
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
     end
 
     its('count') { should eq 1 }
@@ -238,7 +268,7 @@ describe GandiV5::LiveDNS::Domain do
     before :each do
       body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Domain', 'get.yaml'))
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/domains/example.com')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
     end
 
     its('fqdn') { should eq 'example.com' }

data/spec/units/gandi_v5/live_dns/zone/snapshot_spec.rb

@@ -12,17 +12,46 @@ describe GandiV5::LiveDNS::Zone::Snapshot do
 
   it '#delete' do
     expect(GandiV5).to receive(:delete).with('https://dns.api.gandi.net/api/v5/zones/zone-uuid/snapshots/snapshot-uuid')
-                                       .and_return('message' => 'Confirmation message.')
+                                       .and_return([nil, { 'message' => 'Confirmation message.' }])
     expect(subject.delete).to eq 'Confirmation message.'
   end
 
+  it '#fetch_zone' do
+    returns = double GandiV5::LiveDNS::Zone
+    expect(GandiV5::LiveDNS::Zone).to receive(:fetch).with('zone-uuid')
+                                                     .and_return(returns)
+    expect(subject.fetch_zone).to be returns
+  end
+
+  describe '#zone' do
+    it 'Not previously fetched' do
+      returns = double GandiV5::LiveDNS::Zone
+      expect(subject).to receive(:fetch_zone).and_return(returns)
+      expect(subject.zone).to be returns
+    end
+
+    it 'Previously fetched' do
+      returns = double GandiV5::LiveDNS::Zone
+      subject.instance_exec { @zone = returns }
+      expect(subject).to_not receive(:fetch_zone)
+      expect(subject.zone).to be returns
+    end
+  end
+
+  it '.list' do
+    body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Zone_Snapshot', 'list.yaml'))
+    expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/zones/zone-uuid/snapshots')
+                                    .and_return([nil, YAML.load_file(body_fixture)])
+    expect(described_class.list('zone-uuid')).to eq('snapshot-uuid' => Time.new(2016, 12, 16, 16, 51, 26, 0))
+  end
+
   describe '.fetch' do
     subject { described_class.fetch 'zone-uuid', 'snapshot-uuid' }
 
     before :each do
-      body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Zone_Snapshot', 'get.yaml'))
+      body_fixture = File.expand_path(File.join('spec', 'fixtures', 'bodies', 'GandiV5_LiveDNS_Zone_Snapshot', 'fetch.yaml'))
       expect(GandiV5).to receive(:get).with('https://dns.api.gandi.net/api/v5/zones/zone-uuid/snapshots/snapshot-uuid')
-                                      .and_return(YAML.load_file(body_fixture))
+                                      .and_return([nil, YAML.load_file(body_fixture)])
     end
 
     its('created_at') { should eq Time.new(2016, 12, 16, 16, 51, 26, 0) }