gamefic-standard 3.2.0 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 93e0b9232ad79263ae86444d04d4c9a4fefa4f1b4502d2fcb8275263fc6a9401
-  data.tar.gz: 0fcd39f5dbdd99d94fd9525d188e29ada3d89d0545e6dc2455d695e5faf060ea
+  metadata.gz: 934c9793a332bc51d87f3643530112bf53930955a012cbaaa8c20b9b652347f1
+  data.tar.gz: 5d7afbc7b668390a80ed5784921f872dacf5c51a741b0bf0b2a584b152e156d2
 SHA512:
-  metadata.gz: 8d500f2938e3475dea1e00c926b3dcec159ba76565c435f8590a317a316883b3c5ad2e7a8e01dc26eff1f9393680af8c925db42e26e57ba2d31aebcf2c5b3071
-  data.tar.gz: 34bb09d0c1a814c6e2f6febc04a1e8b959b78d8b0a1a17ffb42477ba110f4880ff24707f62255cc9c73c6602476d63abb79d496d79dafe394d3af3b6d4a36389
+  metadata.gz: 19c479b2c1c2f6ca1deae46644056c3ee24e9a5b19f084b758e2caeaff3e13e149593deaf0d9b37af2c8b04b1fe42dfe51567b6712b3a2c2b18d3910eb416d32
+  data.tar.gz: 928429f5cb51bec69403e17797f9117368b9e847973a1c430b180b2d3567ac9b1d97948908c7f7ccf7221627452aaa160fd528a89a12346cde74dc9cc5737bce

data/.github/workflows/rspec.yml

@@ -22,7 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: ['2.7', '3.0', '3.1']
+        ruby-version: ['2.7', '3.0', '3.1', '3.3']
 
     steps:
     - uses: actions/checkout@v3

data/CHANGELOG.md

@@ -1,4 +1,15 @@
-## 3.2.0
+## 3.2.2 - September 1, 2024
+- Move help commands to their own extension
+- get inside -> enter
+- Use definite names in leave error
+- Report commands that do not accept arguments
+- Require gamefic ~> 3.3
+
+## 3.2.1 - July 23, 2024
+- Help actions are meta
+- Ignore empty commands
+
+## 3.2.0 - July 10, 2024
 - Recognize pronouns in commands
 
 ## 3.1.0 - April 8, 2024

data/gamefic-standard.gemspec

@@ -37,7 +37,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.7.0'
 
-  spec.add_dependency 'gamefic', '~> 3.1'
+  spec.add_dependency 'gamefic', '~> 3.3'
 
   spec.add_development_dependency 'opal', '~> 1.7'
   spec.add_development_dependency 'opal-rspec', '~> 1.0'

data/lib/gamefic-standard/actions/enter.rb

@@ -24,6 +24,7 @@ module Gamefic
 
       interpret "get on :thing", "enter :thing"
       interpret "get in :thing", "enter :thing"
+      interpret "get inside :thing", "enter :thing"
       interpret "sit on :thing", "enter :thing"
       interpret "sit in :thing", "enter :thing"
       interpret "lie on :thing", "enter :thing"

data/lib/gamefic-standard/actions/leave.rb

@@ -22,7 +22,7 @@ module Gamefic
         elsif portals.length == 1
           actor.execute :go, portals[0]
         else
-          actor.tell "I don't know which way you want to go: #{portals.join_or}."
+          actor.tell "I don't know which way you want to go: #{portals.map(&:definitely).join_or}."
         end
       end
 

data/lib/gamefic-standard/actions/nil.rb

@@ -1,24 +1,54 @@
 Gamefic::Standard.script do
   meta nil, plaintext do |actor, string|
+    next if string.strip.empty?
+
     words = string.keywords
     list = actor.epic.synonyms
     if list.include?(words[0]&.to_sym)
       if words.length > 1
-        found = []
+        result = myself.query(actor, words[1..-1].join(' '))
+        found = [result.match].compact
         avail = available(ambiguous: true)
-        result = avail.query(actor, words[1..-1].join(' '))
+        result = avail.query(actor, result.remainder)
         until result.match.nil?
           found.concat result.match
           result = avail.query(actor, result.remainder)
         end
         if found.empty?
-          actor.tell %(I recognize "#{words[0]}" as a verb but don't know what you mean by "#{words[1..-1].join(' ')}.")
+          verbs = actor.epic
+                       .syntaxes
+                       .select { |syn| syn.synonym == words[0].to_sym }
+                       .map(&:verb)
+          resps = actor.epic.responses_for(*verbs)
+          if resps.any? { |resp| !resp.queries.empty? }
+            actor.tell %(I recognize "#{words[0]}" as a verb but don't know what you mean by "#{words[1..-1].join(' ')}.")
+          else
+            actor.tell %[I recognize "#{words[0]}" but not with the rest of your sentence. (Maybe it's a one-word command?)]
+          end
         elsif result.remainder != ''
           actor.tell %(I recognize "#{words[0]}" as a verb but was confused by "#{result.remainder}.")
         elsif found.one?
-          actor.tell %(I recognize "#{words[0]}" and "#{found.first.name}" but could not understand them together.)
+          verbs = actor.epic
+                       .syntaxes
+                       .select { |syn| syn.synonym == words[0].to_sym }
+                       .map(&:verb)
+          resps = actor.epic.responses_for(*verbs)
+          if resps.any? { |resp| !resp.queries.empty? }
+            actor.tell %(I recognize "#{words[0]}" and "#{found.first.name}" but could not understand them together.)
+          else
+            actor.tell %[I recognize "#{words[0]}" and "#{found.first.name}" but could not understand them together. (Maybe "#{words[0]}" is a one-word command?)]
+          end
         else
-          actor.tell %(I recognize "#{words[0]}" but I'm not sure if "#{words[1..-1].join(' ')}" means #{found.map(&:definitely).join_or}.)
+          verbs = actor.epic
+                       .syntaxes
+                       .select { |syn| syn.synonym == words[0].to_sym }
+                       .map(&:verb)
+          resps = actor.epic.responses_for(*verbs)
+          if resps.any? { |resp| !resp.queries.empty? }
+            actor.tell %(I recognize "#{words[0]}" but I'm not sure if "#{words[1..-1].join(' ')}" means #{found.map(&:definitely).join_or}.)
+          else
+            actor.tell %[I recognize "#{words[0]}" but not with the rest of your sentence. (Maybe it's a one-word command?)]
+          end
         end
       else
         actor.tell %(I recognize "#{words[0]}" as a verb but could not understand it in this context.)

data/lib/gamefic-standard/actions.rb

@@ -19,6 +19,5 @@ require 'gamefic-standard/actions/move'
 require 'gamefic-standard/actions/talk'
 require 'gamefic-standard/actions/wait'
 require 'gamefic-standard/actions/repeat'
-require 'gamefic-standard/actions/help'
 require 'gamefic-standard/actions/save-restore-undo'
 require 'gamefic-standard/actions/pronouns'

data/lib/gamefic-standard/entities/portal.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# An entity that provides access from one room to another.
+#
 class Portal < Thing
   # @return [Gamefic::Entity]
   attr_accessor :destination
@@ -19,6 +21,7 @@ class Portal < Thing
   # @return [Room, nil]
   def reverse
     return nil if destination.nil?
+
     destination.children.that_are(Portal).find do |portal|
       portal.destination == parent
     end
@@ -30,7 +33,7 @@ class Portal < Thing
   end
 
   def name
-    @name || (direction.nil? ? destination.name : direction.name)
+    @name || direction&.name || destination.name
   end
 
   def instruction

data/lib/gamefic-standard/version.rb

@@ -2,6 +2,6 @@
 
 module Gamefic
   module Standard
-    VERSION = '3.2.0'
+    VERSION = '3.2.2'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gamefic-standard
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.2
 platform: ruby
 authors:
 - Fred Snyder
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-10 00:00:00.000000000 Z
+date: 2024-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gamefic
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: opal
   requirement: !ruby/object:Gem::Requirement
@@ -115,6 +115,7 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
+- gamefic-standard-3.2.1.gem
 - gamefic-standard.gemspec
 - lib/gamefic-standard.rb
 - lib/gamefic-standard/actions.rb
@@ -123,7 +124,6 @@ files:
 - lib/gamefic-standard/actions/drop.rb
 - lib/gamefic-standard/actions/enter.rb
 - lib/gamefic-standard/actions/go.rb
-- lib/gamefic-standard/actions/help.rb
 - lib/gamefic-standard/actions/insert.rb
 - lib/gamefic-standard/actions/inventory.rb
 - lib/gamefic-standard/actions/leave.rb

data/lib/gamefic-standard/actions/help.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-module Gamefic
-  module Standard
-    script do
-      respond :verbs do |actor|
-        list = rulebook.synonyms.reject { |syn| syn.to_s.start_with?('_') }
-                      .map { |syn| "<kbd>#{syn}</kbd>"}
-                      .join_and
-        actor.tell "I understand the following commands: #{list}."
-        actor.tell "Try using commands in plain sentences like <kbd>go north</kbd> or <kbd>take the coin</kbd>."
-        actor.tell "For more information about a specific command, try <kbd>help [command]</kbd>, e.g., <kbd>help go</kbd>."
-      end
-
-      interpret 'commands', 'verbs'
-      interpret 'help', 'verbs'
-
-      respond :help, plaintext do |actor, command|
-        if rulebook.synonyms.include?(command.to_sym) && !command.start_with?('_')
-          available = rulebook.syntaxes.select { |syntax| syntax.synonym == command.to_sym }
-                              .uniq(&:signature)
-          examples = available.map(&:template)
-                              .map do |tmpl|
-                                tmpl.text
-                                    .gsub(/:character/i, '[someone]')
-                                    .gsub(/:var[0-9]?/i, '[something]')
-                                    .gsub(/:([a-z0-9]+)/i, "[\\1]")
-                              end
-                              .reject { |tmpl| tmpl.include?('[something] [something]') }
-          actor.tell 'Examples:'
-          actor.stream '<ul>'
-          examples.each do |xmpl|
-            actor.stream "<li><kbd>#{xmpl}</kbd></li>"
-          end
-          actor.stream '</ul>'
-          related = available.map(&:verb)
-                              .uniq
-                              .that_are_not(command.to_sym)
-                              .sort
-                              .map { |sym| "<kbd>#{sym}</kbd>"}
-          next if related.empty?
-
-          actor.tell "Related: #{related.join(', ')}"
-        elsif command =~ /[^a-z]/i
-          actor.tell "Try asking for help with a specific command, e.g., <kbd>help go</kbd>"
-        else
-          actor.tell "\"#{command.cap_first}\" is not a verb I understand."
-        end
-      end
-    end
-  end
-end