gaku 0.1.1 → 0.2.0

data/core/spec/models/contact_spec.rb

@@ -12,12 +12,19 @@ describe Gaku::Contact do
     it { should validate_presence_of :contact_type }
   end
 
-  describe 'methods' do
+  describe 'instance methods' do
     it { should respond_to :name }
     it { should respond_to :primary? }
     it { should respond_to :make_primary }
-    xit 'ensure_first_is_primary'
-    xit 'remove_other_primary'
+  end
+
+  describe 'class methods' do
+    it('responds to .teachers') { expect(Gaku::Contact).to respond_to(:teachers) }
+    it('responds to .students') { expect(Gaku::Contact).to respond_to(:students) }
+    it('responds to .guardians') { expect(Gaku::Contact).to respond_to(:guardians) }
+    it('responds to .primary_email') { expect(Gaku::Contact).to respond_to(:primary_email) }
+    it('responds to .primary') { expect(Gaku::Contact).to respond_to(:primary) }
+    it('responds to .secondary') { expect(Gaku::Contact).to respond_to(:secondary) }
   end
 
 end

data/core/spec/models/course_group_enrollment_spec.rb

@@ -10,7 +10,10 @@ describe Gaku::CourseGroupEnrollment do
   describe 'validations' do
     it { should validate_presence_of :course_group_id }
     it { should validate_presence_of :course_id }
-    it { should validate_uniqueness_of(:course_id).scoped_to(:course_group_id).with_message(/Already enrolled to this course group!/) }
+    it do
+      should validate_uniqueness_of(:course_id).scoped_to(:course_group_id)
+                                               .with_message(/Already enrolled to this course group!/)
+    end
   end
 
 end

data/core/spec/models/course_spec.rb

@@ -2,42 +2,40 @@ require 'spec_helper_models'
 
 describe Gaku::Course do
 
+  describe 'concerns' do
+    it_behaves_like 'gradable'
+    it_behaves_like 'enrollmentable'
+    it_behaves_like 'semesterable'
+  end
+
   describe 'associations' do
-    it { should have_many :enrollments }
-    it { should have_many(:students).through(:enrollments) }
 
     it { should have_many :course_group_enrollments }
     it { should have_many(:course_groups).through(:course_group_enrollments) }
 
-    it { should have_many :class_group_course_enrollments }
-    it { should have_many(:class_groups).through(:class_group_course_enrollments) }
-
-    it { should have_many(:semester_courses).dependent(:destroy) }
-    it { should have_many(:semesters).through(:semester_courses) }
-
     it { should belong_to :syllabus }
     it { should belong_to :class_group }
     it { should have_many :exam_schedules }
 
-    it { should accept_nested_attributes_for :enrollments }
+    # it { should accept_nested_attributes_for :enrollments }
   end
 
   describe 'validations' do
     it { should validate_presence_of :code }
   end
 
-  context 'enroll_class_group' do
-  	it 'should enroll class group to course' do
-			course = create(:course)
-			student1, student2 = create(:student), create(:student, name: 'gaku')
-      class_group = create(:class_group)
-      create(:class_group_enrollment, student_id: student1.id, class_group_id: class_group.id)
-      create(:class_group_enrollment, student_id: student2.id, class_group_id: class_group.id)
-  		course.enroll_class_group(class_group)
-  		course.student_ids.include?(student1.id)
-  		course.student_ids.include?(student2.id)
-  	end
-  end
+  # context 'enroll_class_group' do
+  #   it 'should enroll class group to course' do
+  #     course = create(:course)
+  #     student1, student2 = create(:student), create(:student, name: 'gaku')
+  #     class_group = create(:class_group)
+  #     create(:class_group_enrollment, student_id: student1.id, class_group_id: class_group.id)
+  #     create(:class_group_enrollment, student_id: student2.id, class_group_id: class_group.id)
+  #     course.enroll_class_group(class_group)
+  #     course.student_ids.include?(student1.id)
+  #     course.student_ids.include?(student2.id)
+  #   end
+  # end
 
   context 'counter_cache' do
 
@@ -51,31 +49,31 @@ describe Gaku::Course do
       it 'increments notes_count' do
         expect do
           course.notes << note
-        end.to change { course.reload.notes_count }.by 1
+        end.to change { course.reload.notes_count }.by(1)
       end
 
       it 'decrements notes_count' do
         expect do
           course_with_note.notes.last.destroy
-        end.to change { course_with_note.reload.notes_count }.by -1
+        end.to change { course_with_note.reload.notes_count }.by(-1)
       end
     end
 
-    context 'students_count' do
+    context 'enrollments_count' do
 
       let(:student) { build(:student) }
-      let(:course_with_student) { create(:course, :with_student) }
+      let(:course_with_enrollment) { create(:course, :with_enrollment) }
 
-      it 'increments students_count' do
+      it 'increments enrollments_count' do
         expect do
           course.students << student
-        end.to change { course.reload.students_count }.by 1
+        end.to change { course.reload.enrollments_count }.by(1)
       end
 
-      it 'decrements students_count' do
+      it 'decrements enrollments_count' do
         expect do
-          course_with_student.students.last.destroy
-        end.to change { course_with_student.reload.students_count }.by -1
+          course_with_enrollment.students.last.destroy
+        end.to change { course_with_enrollment.reload.enrollments_count }.by(-1)
       end
     end
 

data/core/spec/models/enrollment_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper_models'
+
+describe Gaku::Enrollment do
+
+  describe 'associations' do
+    it { should belong_to :student }
+    it { should belong_to :enrollmentable }
+  end
+
+  describe 'validations' do
+    it { should validate_presence_of :student_id }
+    it { should validate_presence_of :enrollmentable_id }
+    it { should validate_presence_of :enrollmentable_type }
+
+    it do
+      should validate_uniqueness_of(:student_id).scoped_to([:enrollmentable_id, :enrollmentable_type])
+                                                .with_message(/already enrolled/)
+    end
+
+    it('ensures inclusion') do
+      should validate_inclusion_of(:enrollmentable_type)
+        .in_array(%w(Gaku::Course Gaku::ClassGroup Gaku::ExtracurricularActivity))
+    end
+  end
+
+  describe 'class_group_semesters_overlap validation' do
+    it 'add message to base if semester overlapping' do
+      student  = create(:student)
+      semester = create(:active_semester)
+
+      class_group  = create(:class_group_with_active_semester, semester: semester)
+      class_group2 = create(:class_group_with_active_semester, semester: semester)
+
+      create(:class_group_enrollment, enrollmentable: class_group, student: student)
+
+      enrollment = build(:class_group_enrollment, enrollmentable: class_group2, student: student)
+
+      enrollment.valid?
+
+      expect(enrollment.errors[:base]).to include 'A student cannot belong to two Class Groups with overlapping semesters'
+    end
+  end
+
+end

data/core/spec/models/exam_portion_score_spec.rb

@@ -10,7 +10,7 @@ describe Gaku::ExamPortionScore do
 
   describe 'validations' do
     it { should validate_presence_of :student }
-    it { should validate_presence_of :exam_portion}
+    it { should validate_presence_of :exam_portion }
   end
 
 end

data/core/spec/models/exam_portion_spec.rb

@@ -13,7 +13,7 @@ describe Gaku::ExamPortion do
   end
 
   describe 'validations' do
-  	let(:exam_portion) { create(:exam_portion) }
+    let(:exam_portion) { create(:exam_portion) }
 
     it { should validate_presence_of :max_score }
     it { should validate_numericality_of :max_score }

data/core/spec/models/exam_session_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper_models'
+
+describe Gaku::ExamSession do
+
+  # describe 'validations' do
+  # end
+
+  describe 'relations' do
+    it { should belong_to :exam }
+    it { should have_many(:student_exam_sessions) }
+    it { should have_many(:students).through(:student_exam_sessions) }
+
+  end
+
+  describe '#to_s' do
+    let(:exam_session) { build(:exam_session) }
+    specify { exam_session.to_s.should eq exam_session.name }
+  end
+
+end

data/core/spec/models/exam_spec.rb

@@ -6,6 +6,7 @@ describe Gaku::Exam do
 
   describe 'concerns' do
     it_behaves_like 'notable'
+    it_behaves_like 'gradable'
   end
 
   describe 'associations' do
@@ -20,6 +21,8 @@ describe Gaku::Exam do
     it { should belong_to :grading_method }
     it { should belong_to :department }
 
+    it { should have_many :exam_sessions }
+
     it { should accept_nested_attributes_for :exam_portions }
   end
 
@@ -52,17 +55,16 @@ describe Gaku::Exam do
       it 'increments exam_portions_count' do
         expect do
           exam.exam_portions << exam_portion
-        end.to change { exam.reload.exam_portions_count }.by 1
+        end.to change { exam.reload.exam_portions_count }.by(1)
       end
 
       it 'decrements exam_portions_count' do
         expect do
           exam_with_portions.exam_portions.last.destroy
-        end.to change { exam_with_portions.reload.exam_portions_count }.by -1
+        end.to change { exam_with_portions.reload.exam_portions_count }.by(-1)
       end
     end
 
-
     context 'notes_count' do
 
       let(:note) { build(:note) }
@@ -71,13 +73,13 @@ describe Gaku::Exam do
       it 'increments notes_count' do
         expect do
           exam.notes << note
-        end.to change { exam.reload.notes_count }.by 1
+        end.to change { exam.reload.notes_count }.by(1)
       end
 
       it 'decrements notes_count' do
         expect do
           exam_with_note.notes.last.destroy
-        end.to change { exam_with_note.reload.notes_count }.by -1
+        end.to change { exam_with_note.reload.notes_count }.by(-1)
       end
     end
   end

data/core/spec/models/external_school_record_spec.rb

@@ -5,8 +5,6 @@ describe Gaku::ExternalSchoolRecord do
   describe 'associations' do
     it { should belong_to :school }
     it { should belong_to :student }
-
-    xit { should have_many :simple_grades }
   end
 
   describe 'validations' do
@@ -15,9 +13,10 @@ describe Gaku::ExternalSchoolRecord do
   end
 
   describe '#attendance_rate' do
-    let(:external_school_record) { build(:external_school_record,
-                                            total_units:16,
-                                            units_absent: 13) }
+    let(:external_school_record) do
+      build(:external_school_record, total_units: 16, units_absent: 13)
+    end
+
     let(:external_school_record2) { build(:external_school_record) }
 
     it 'return attendance rate if total_units and units_absent are present' do

data/core/spec/models/extracurricular_activity_spec.rb

@@ -2,9 +2,11 @@ require 'spec_helper_models'
 
 describe Gaku::ExtracurricularActivity do
 
+  describe 'concerns' do
+    it_behaves_like 'enrollmentable'
+  end
+
   describe 'associations' do
-    it { should have_many :enrollments }
-    it { should have_many(:students).through(:enrollments) }
   end
 
   describe 'validations' do
@@ -17,4 +19,27 @@ describe Gaku::ExtracurricularActivity do
     specify { extracurricular_activity.to_s.should eq extracurricular_activity.name }
   end
 
+  context 'counter_cache' do
+
+    let!(:extracurricular_activity) { create(:extracurricular_activity) }
+
+    context 'enrollments_count' do
+
+      let(:student) { build(:student) }
+      let(:extracurricular_activity_with_enrollment) { create(:extracurricular_activity, :with_enrollment) }
+
+      it 'increments enrollments_count' do
+        expect do
+          extracurricular_activity.students << student
+        end.to change { extracurricular_activity.reload.enrollments_count }.by(1)
+      end
+
+      it 'decrements enrollments_count' do
+        expect do
+          extracurricular_activity_with_enrollment.students.last.destroy
+        end.to change { extracurricular_activity_with_enrollment.reload.enrollments_count }.by(-1)
+      end
+    end
+  end
+
 end

data/core/spec/models/factories_spec.rb

@@ -1,9 +1,10 @@
-require 'spec_helper_models'
+# require 'spec_helper_models'
 
 FactoryGirl.factories.each do |factory|
   describe "Factory for :#{factory.name}" do
     if factory.name.to_s.include? 'invalid'
       it('is invalid') { build(factory.name).should be_invalid }
+    elsif factory.name.to_s.include?('creation')
     else
       it('is valid') { build(factory.name).should be_valid }
     end

data/core/spec/models/grading_method_connector_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper_models'
+
+describe Gaku::GradingMethodConnector do
+
+  describe 'associations' do
+    it { should belong_to :gradable }
+    it { should belong_to :grading_method }
+  end
+
+  describe 'validations' do
+    it { should validate_presence_of :grading_method_id }
+    it { should validate_presence_of :gradable_id }
+    it { should validate_presence_of :gradable_type }
+    it { should validate_inclusion_of(:gradable_type).in_array(%w(Gaku::Exam Gaku::Course)) }
+    it { should validate_uniqueness_of(:grading_method_id).scoped_to([:gradable_type, :gradable_id]) }
+
+  end
+
+end

data/core/spec/models/grading_method_set_item_spec.rb

@@ -9,8 +9,9 @@ describe Gaku::GradingMethodSetItem do
 
   describe 'validations' do
     it do
-      should validate_uniqueness_of(:grading_method_id).scoped_to(:grading_method_set_id)
-                                                       .with_message('Grading Method already added to Grading Method Set')
+      should validate_uniqueness_of(:grading_method_id)
+                .scoped_to(:grading_method_set_id)
+                .with_message('Grading Method already added to Grading Method Set')
     end
 
     it { should validate_presence_of :grading_method_id }

data/core/spec/models/grading_method_spec.rb

@@ -3,11 +3,12 @@ require 'spec_helper_models'
 describe Gaku::GradingMethod do
 
   describe 'relations' do
-  	it { should have_one :exam }
-  	it { should have_one :exam_portion }
-  	it { should have_one :assignment }
+    it { should have_one :exam }
+    it { should have_one :exam_portion }
+    it { should have_one :assignment }
 
     it { should have_many :simple_grade_types }
+    it { should have_many :grading_method_connectors }
 
     it { should have_many :grading_method_set_items }
     it { should have_many(:grading_method_sets).through(:grading_method_set_items) }
@@ -16,6 +17,9 @@ describe Gaku::GradingMethod do
   describe 'validations' do
     it { should validate_presence_of :name }
     it { should validate_uniqueness_of :name }
+    it { should validate_presence_of :grading_type }
+    it { should validate_inclusion_of(:grading_type).in_array(Gaku::GradingMethod::Types) }
+
   end
 
   describe '#to_s' do

data/core/spec/models/guardian_spec.rb

@@ -15,8 +15,15 @@ describe Gaku::Guardian do
     it { should have_many(:students).through(:student_guardians) }
   end
 
-  context 'counter_cache' do
+  describe '#primary_contact' do
+    it('responds to primary_contact') { should respond_to(:primary_contact) }
+  end
+
+  describe '#primary_address' do
+    it('responds to primary_address') { should respond_to(:primary_address) }
+  end
 
+  context 'counter_cache' do
     let!(:guardian) { create(:guardian) }
 
     context 'addresses_count' do
@@ -27,13 +34,13 @@ describe Gaku::Guardian do
       it 'increments addresses_count' do
         expect do
           guardian.addresses << address
-        end.to change { guardian.reload.addresses_count }.by 1
+        end.to change { guardian.reload.addresses_count }.by(1)
       end
 
       it 'decrements addresses_count' do
         expect do
           guardian_with_address.addresses.last.destroy
-        end.to change { guardian_with_address.reload.addresses_count }.by -1
+        end.to change { guardian_with_address.reload.addresses_count }.by(-1)
       end
     end
 
@@ -45,20 +52,15 @@ describe Gaku::Guardian do
       it 'increments contacts_count' do
         expect do
           guardian.contacts << contact
-        end.to change { guardian.reload.contacts_count }.by 1
+        end.to change { guardian.reload.contacts_count }.by(1)
       end
 
       it 'decrements contacts_count' do
         expect do
           guardian_with_contact.contacts.last.destroy
-        end.to change { guardian_with_contact.reload.contacts_count }.by -1
+        end.to change { guardian_with_contact.reload.contacts_count }.by(-1)
       end
     end
   end
 
-  context 'methods' do
-    xit 'primary_contact'
-    xit 'primary_address'
-  end
-
 end