gaapi 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0914cccbcf5b4f4cb35cc2b5a3bb7fbb10ed6841b32da74b06e71711502a334
-  data.tar.gz: 1f82f69edfc7dcdb6a686802572b0a75236ad32203916754c89dfb598c281457
+  metadata.gz: a1e443de1393667d61dfc7dbabbcf862766d64991b0ac0c9aaa29f9ab44d5f98
+  data.tar.gz: e94d135a613c50b21aa9e9f91c67d383222d3383843b1edbfa12a7575fc09ecd
 SHA512:
-  metadata.gz: 69a7cddacdc469a00868f72360d65daf18d6f3be811954935a1508f6ac065911267211682bbbfe640a2a8d0a8dd123f66671be0485430922f47abadcea9556a8
-  data.tar.gz: 61bb45745f7d30ea713911e27b1410f8657b27606a189d1faca2e530c17725980612530a9f33f7bb45a076b765d896313d524c125b0edf886edbbfc99cd5e8ad
+  metadata.gz: 430315aa8a05fb701c2ea587c9f921e372290d26aa86710930f537f6251fcfd0805d7e499a16f0046cf3fb613196d486d02ba9f7c44f6c90d57b4d47c388ccf2
+  data.tar.gz: 5b8d4fa04a11ae96f9eec3c5719e719f6ba70a52b92e68c66b5f0442d380e1041d7d0a4193f81a897cad70e700bd6824f50daf3a42fd9689982cd007e4037e4a

data/CHANGELOG.md

@@ -12,6 +12,12 @@
 
 * Your contribution here!
 
+## [0.4.2][](2018-11-06)
+
+### Bugfixes
+
+* [#6] Correct the conversion of TIME metrics.
+
 ## [0.4.1][](2018-10-31)
 
 ### Bugfixes

data/lib/gaapi/row.rb

@@ -70,11 +70,15 @@ module GAAPI
         # TODO: Do this better.
         metrics[i].to_f
       when "TIME"
+        # Google documentation claims to following:
         # TIME  Time metric in HH:MM:SS format.
-        # Time in fraction of a day.
-        (metrics[i][0..1].to_i +
-          metrics[i][3..4].to_i * 60 +
-          metrics[i][6..7].to_i * 24 * 60) / 86_400
+        # It also says it's seconds, and that's what I see in real results.
+        # So comment out the following:
+        # (metrics[i][0..1].to_i +
+        #   metrics[i][3..4].to_i * 60 +
+        #   metrics[i][6..7].to_i * 24 * 60)
+        # Simply make it a float.
+        metrics[i].to_f
       else
         # METRIC_TYPE_UNSPECIFIED  Metric type is unspecified.
         metric[i]

data/lib/gaapi/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GAAPI
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gaapi
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Larry Reid
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-01 00:00:00.000000000 Z
+date: 2018-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chandler