g5_updatable 0.3.1 → 0.3.2

data/spec/lib/g5_updatable/client_feed_processor_spec.rb

@@ -43,21 +43,18 @@ describe G5Updatable::ClientFeedProcessor do
   describe "#work" do
     let(:client_updater) { double(update: nil) }
     let(:locations_updater) { double(update: nil) }
-    let(:integration_settings_updater) { double(update: nil) }
 
     let(:client) { G5FoundationClient::Client.new(uid:       client_uid,
                                                   urn:       "urn",
                                                   name:      "Client Name",
-                                                  locations: [{uid: location_uid, locations_integration_settings: [{uid: integration_setting_uid, vendor_action: 'inventory'}]}]) }
+                                                  locations: [{uid: location_uid}]) }
     let(:client_uid) { "http://example.com/cilent_uid" }
     let(:location_uid) { "http://example.com/cilent_uid/locations/location_uid" }
-    let(:integration_setting_uid) { "http://example.com/cilent_uid/locations/location_uid/integration_setting_uid" }
 
     before do
       stub_client_for_uid(client_uid, client)
       allow(G5Updatable::ClientUpdater).to receive(:new) { client_updater }
       allow(G5Updatable::LocationsUpdater).to receive(:new) { locations_updater }
-      allow(G5Updatable::IntegrationSettingsUpdater).to receive(:new) { integration_settings_updater }
       G5Updatable::ClientFeedProcessor.new(client_uid).work
     end
 
@@ -70,11 +67,6 @@ describe G5Updatable::ClientFeedProcessor do
       expect(G5Updatable::LocationsUpdater).to have_received(:new).with(client.locations)
       expect(locations_updater).to have_received(:update)
     end
-
-    it "updates with location's associated integration settings" do
-      expect(G5Updatable::IntegrationSettingsUpdater).to have_received(:new).with(client.locations.first.integration_settings)
-      expect(integration_settings_updater).to have_received(:update)
-    end
   end
 
   describe :load_all_clients do

data/spec/models/g5_updatable/location_spec.rb

@@ -24,11 +24,4 @@ describe G5Updatable::Location do
 
     it { should eq(client) }
   end
-
-  describe :integration_settings do
-    let!(:integration_setting) { create(:integration_setting, location_uid: subject.uid) }
-    subject { create(:location) }
-
-    its(:integration_settings) { is_expected.to eq([integration_setting]) }
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: g5_updatable
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Brian Bauer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.2.0
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -155,18 +155,17 @@ files:
 - app/controllers/g5_updatable/feed_controller.rb
 - app/helpers/g5_updatable/application_helper.rb
 - app/models/g5_updatable/client.rb
-- app/models/g5_updatable/integration_setting.rb
 - app/models/g5_updatable/location.rb
 - app/serializers/g5_updatable/location_serializer.rb
 - app/views/layouts/g5_updatable/application.html.erb
 - config/routes.rb
 - db/migrate/20140709222005_create_g5_updatable_clients_and_locations.rb
 - db/migrate/20141030211945_create_integration_setting.rb
+- db/migrate/20141122211945_remove_integration_setting.rb
 - lib/g5_updatable.rb
 - lib/g5_updatable/client_feed_processor.rb
 - lib/g5_updatable/client_updater.rb
 - lib/g5_updatable/engine.rb
-- lib/g5_updatable/integration_settings_updater.rb
 - lib/g5_updatable/locations_updater.rb
 - lib/g5_updatable/rspec.rb
 - lib/g5_updatable/rspec/factories.rb
@@ -193,6 +192,7 @@ files:
 - spec/dummy/config/boot.rb
 - spec/dummy/config/database.sample.yml
 - spec/dummy/config/database.travis.yml
+- spec/dummy/config/database.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
@@ -222,14 +222,12 @@ files:
 - spec/dummy/tmp/pids/server.pid
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
-- spec/lib/g5_updatable/integration_settings_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
 - spec/lib/g5_updatable/version.rb
 - spec/lib/generators/g5_updatable/install_generator_spec.rb
 - spec/lib/generators/tmp/config/routes.rb
 - spec/lib/tmp/config/routes.rb
 - spec/models/g5_updatable/client_spec.rb
-- spec/models/g5_updatable/integration_setting_spec.rb
 - spec/models/g5_updatable/location_spec.rb
 - spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb
@@ -276,6 +274,7 @@ test_files:
 - spec/dummy/config/boot.rb
 - spec/dummy/config/database.sample.yml
 - spec/dummy/config/database.travis.yml
+- spec/dummy/config/database.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
@@ -308,14 +307,12 @@ test_files:
 - spec/dummy/tmp/pids/server.pid
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
-- spec/lib/g5_updatable/integration_settings_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
 - spec/lib/g5_updatable/version.rb
 - spec/lib/generators/g5_updatable/install_generator_spec.rb
 - spec/lib/generators/tmp/config/routes.rb
 - spec/lib/tmp/config/routes.rb
 - spec/models/g5_updatable/client_spec.rb
-- spec/models/g5_updatable/integration_setting_spec.rb
 - spec/models/g5_updatable/location_spec.rb
 - spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb

data/app/models/g5_updatable/integration_setting.rb

@@ -1,20 +0,0 @@
-module G5Updatable
-  class IntegrationSetting < ActiveRecord::Base
-    include G5Updatable::FirstClassProperties
-    include G5Updatable::UrnAsParameter
-
-    validates :uid, presence: true
-    validates :location_uid, presence: true
-
-    INVENTORY = 'inventory'
-    LEAD      = 'lead'
-
-    scope :by_vendor_action, -> (vendor_action) { where(vendor_action: vendor_action) }
-    scope :by_inventory, -> { by_vendor_action(INVENTORY) }
-    scope :by_lead, -> { by_vendor_action(LEAD) }
-
-    def location
-      @client ||= G5Updatable::Location.find_by_uid(location_uid)
-    end
-  end
-end

data/lib/g5_updatable/integration_settings_updater.rb

@@ -1,21 +0,0 @@
-class G5Updatable::IntegrationSettingsUpdater
-  def initialize(g5_integration_settings)
-    @g5_integration_settings = g5_integration_settings
-  end
-
-  def update
-    @g5_integration_settings.each do |g5_integration_setting|
-      attributes = g5_integration_setting.integration_setting_hash.dup
-
-      G5Updatable::IntegrationSetting.
-          find_or_initialize_by(uid: attributes[:uid]).
-          update_attributes!(
-          urn:                      attributes[:urn],
-          location_uid:             attributes[:location_uid],
-          vendor_action:            attributes[:vendor_action],
-          job_frequency_in_minutes: attributes[:job_frequency_in_minutes],
-          properties:               attributes
-      )
-    end
-  end
-end

data/spec/lib/g5_updatable/integration_settings_updater_spec.rb

@@ -1,48 +0,0 @@
-require "spec_helper"
-
-describe G5Updatable::IntegrationSettingsUpdater do
-  let(:uid) { "http://example.com/uid" }
-  let(:name) { "integration setting name" }
-  let(:properties) { {uid:           uid,
-                      urn:           "urn",
-                      vendor_action: "inventory",
-                      location_uid:  "location_uid",
-                      job_frequency_in_minutes: 22,
-                      name:          name} }
-  let(:integration_setting) { G5FoundationClient::IntegrationSetting.new(properties) }
-
-  let(:updater) { described_class.new([integration_setting]) }
-
-  describe "#update" do
-    subject { G5Updatable::IntegrationSetting.first }
-
-    context "with no existing integration-setting records" do
-      before { updater.update }
-
-      it "creates a Location" do
-        expect(G5Updatable::IntegrationSetting.count).to eq(1)
-      end
-
-      its(:job_frequency_in_minutes) { should eq(22) }
-      its(:uid) { should eq(uid) }
-      its(:urn) { should eq("urn") }
-      its(:location_uid) { should eq("location_uid") }
-      its(:name) { should eq(name) }
-      its(:vendor_action) { should eq("inventory") }
-    end
-
-    context "with an existing integration-setting record" do
-      before do
-        create(:integration_setting, uid: uid, urn: "old")
-        updater.update
-      end
-
-      it "does not create a new IntegrationSetting" do
-        expect(G5Updatable::IntegrationSetting.count).to eq(1)
-      end
-
-      its(:urn) { should eq("urn") }
-      its(:name) { should eq(name) }
-    end
-  end
-end

data/spec/models/g5_updatable/integration_setting_spec.rb

@@ -1,33 +0,0 @@
-require 'spec_helper'
-
-describe G5Updatable::IntegrationSetting do
-  describe 'validations' do
-    subject(:integration_setting) { G5Updatable::IntegrationSetting.new }
-    it { expect(integration_setting).to validate_presence_of(:location_uid) }
-    it { expect(integration_setting).to validate_presence_of(:uid) }
-  end
-
-  it_behaves_like 'a model with first-class properties' do
-    let(:instance_factory_name) { :integration_setting }
-  end
-
-  it_behaves_like 'a model that uses its URN as its parameter' do
-    let(:instance_factory_name) { :client }
-  end
-
-  describe "#location" do
-    let(:integration_setting) { create(:integration_setting, location_uid: location.uid) }
-    let(:location) { create(:location) }
-    subject { integration_setting.location }
-
-    it { should eq(location) }
-  end
-
-  describe :by_vendor_action do
-    let!(:inventory) { create(:integration_setting, vendor_action: G5Updatable::IntegrationSetting::INVENTORY) }
-    let!(:lead) { create(:integration_setting, vendor_action: G5Updatable::IntegrationSetting::LEAD) }
-
-    it { expect(G5Updatable::IntegrationSetting.by_lead).to eq([lead]) }
-    it { expect(G5Updatable::IntegrationSetting.by_inventory).to eq([inventory]) }
-  end
-end