g5_updatable 0.2.1 → 0.3.1

data/spec/serializers/g5_updatable/location_serializer_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe G5Updatable::LocationSerializer do
+  let(:location) do
+    FactoryGirl.build(
+      :location,
+      uid: "https://example.com/locations/test-urn",
+      urn: "test-urn",
+      client_uid: "https://example.com/client",
+      properties: {
+        name: "Test Name"
+      }
+    )
+  end
+  subject { G5Updatable::LocationSerializer.new(location).as_json["location"] }
+
+  its([:uid]) { is_expected.to eq("https://example.com/locations/test-urn") }
+  its([:urn]) { is_expected.to eq("test-urn") }
+  its([:client_uid]) { is_expected.to eq("https://example.com/client") }
+  its([:name]) { is_expected.to eq("Test Name") }
+end

data/spec/spec_helper.rb

@@ -1,20 +1,28 @@
 # This file is copied to spec/ when you run 'rails generate rspec:install'
 ENV["RAILS_ENV"] ||= 'test'
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require File.expand_path("../dummy/config/environment.rb", __FILE__)
 require 'rspec/rails'
+require 'rspec/its'
+
+require 'generator_spec'
+require 'factory_girl'
+require 'g5_updatable/rspec'
+require 'shoulda/matchers'
+require 'g5_foundation_client/rspec'
 
 Rails.backtrace_cleaner.remove_silencers!
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
+Dir[G5Updatable::Engine.root.join("spec/support/**/*.rb")].each { |f| require f }
 
 # Checks for pending migrations before tests are run.
 # If you are not using ActiveRecord, you can remove this line.
 ActiveRecord::Migration.check_pending! if defined?(ActiveRecord::Migration)
 
 RSpec.configure do |config|
+  config.include FactoryGirl::Syntax::Methods
   # ## Mock Framework
   #
   # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
@@ -24,12 +32,12 @@ RSpec.configure do |config|
   # config.mock_with :rr
 
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
-  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+  config.fixture_path                               = "#{::Rails.root}/spec/fixtures"
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, remove the following line or assign false
   # instead of true.
-  config.use_transactional_fixtures = true
+  config.use_transactional_fixtures                 = true
 
   # If true, the base class of anonymous controllers will be inferred
   # automatically. This will be the default behavior in future versions of
@@ -40,5 +48,5 @@ RSpec.configure do |config|
   # order dependency and want to debug it, you can fix the order by providing
   # the seed, which is printed after each run.
   #     --seed 1234
-  config.order = "random"
+  config.order                                      = "random"
 end

data/spec/support/shared_example_for_urn_as_parameter.rb

@@ -0,0 +1,7 @@
+shared_examples_for "a model that uses its URN as its parameter" do
+  let(:model) { FactoryGirl.build(instance_factory_name, urn: "test-urn") }
+
+  it "returns the URN as the param" do
+    expect(model.to_param).to eq("test-urn")
+  end
+end

data/spec/support/shared_examples_for_first_class_properties_json.rb

@@ -0,0 +1,29 @@
+shared_examples_for "a model with first-class properties" do
+  describe "properties" do
+    let(:instance) { FactoryGirl.build(instance_factory_name, properties: { key: "value" }) }
+
+    context "when properties are on an instance from the database" do
+      before do
+        instance.save!
+      end
+      subject { instance.class.find(instance.id) }
+
+      its(:key) { should eq("value") }
+    end
+
+    context "when properties were set on an in-memory instance" do
+      context "trying to access an existing property" do
+        subject { instance.key }
+        it { should eq("value") }
+      end
+
+      context "trying to access an nonexistent property" do
+        subject { instance.bad }
+
+        it "blows up normally" do
+          expect { subject }.to raise_error(NoMethodError)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: g5_updatable
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.1
 platform: ruby
 authors:
 - Brian Bauer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-19 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -16,30 +16,30 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.5
+        version: 4.1.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.5
+        version: 4.1.7
 - !ruby/object:Gem::Dependency
-  name: microformats2
+  name: g5_foundation_client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.0
 - !ruby/object:Gem::Dependency
-  name: virtus
+  name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,13 +53,27 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: active_model_serializers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: virtus
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -80,6 +94,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.0.0
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: factory_girl
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: generator_spec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Client/Locations data update engine for G5 applications
 email:
 - brian.bauer@getg5.com
@@ -92,24 +148,33 @@ files:
 - Rakefile
 - app/assets/javascripts/g5_updatable/application.js
 - app/assets/stylesheets/g5_updatable/application.css
+- app/concerns/g5_updatable/belongs_to_location.rb
+- app/concerns/g5_updatable/first_class_properties.rb
+- app/concerns/g5_updatable/urn_as_parameter.rb
 - app/controllers/g5_updatable/application_controller.rb
 - app/controllers/g5_updatable/feed_controller.rb
 - app/helpers/g5_updatable/application_helper.rb
+- app/models/g5_updatable/client.rb
+- app/models/g5_updatable/integration_setting.rb
+- app/models/g5_updatable/location.rb
+- app/serializers/g5_updatable/location_serializer.rb
 - app/views/layouts/g5_updatable/application.html.erb
 - config/routes.rb
+- db/migrate/20140709222005_create_g5_updatable_clients_and_locations.rb
+- db/migrate/20141030211945_create_integration_setting.rb
 - lib/g5_updatable.rb
 - lib/g5_updatable/client_feed_processor.rb
 - lib/g5_updatable/client_updater.rb
 - lib/g5_updatable/engine.rb
-- lib/g5_updatable/feed_mapper.rb
-- lib/g5_updatable/g5_client.rb
-- lib/g5_updatable/g5_location.rb
+- lib/g5_updatable/integration_settings_updater.rb
 - lib/g5_updatable/locations_updater.rb
+- lib/g5_updatable/rspec.rb
+- lib/g5_updatable/rspec/factories.rb
 - lib/g5_updatable/version.rb
 - lib/generators/g5_updatable/install/USAGE
 - lib/generators/g5_updatable/install/install_generator.rb
-- lib/generators/g5_updatable/install/templates/g5_updatable.rb
 - lib/tasks/g5_updatable_tasks.rake
+- spec/concerns/g5_updatable/belongs_to_location_spec.rb
 - spec/dummy/README.rdoc
 - spec/dummy/Rakefile
 - spec/dummy/app/assets/javascripts/application.js
@@ -117,6 +182,7 @@ files:
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/client.rb
+- spec/dummy/app/models/favorite_food.rb
 - spec/dummy/app/models/location.rb
 - spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/bin/bundle
@@ -125,7 +191,8 @@ files:
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
-- spec/dummy/config/database.yml
+- spec/dummy/config/database.sample.yml
+- spec/dummy/config/database.travis.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
@@ -134,7 +201,6 @@ files:
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/initializers/g5_updatable.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
@@ -142,36 +208,33 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
-- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20140630175259_create_locations.rb
 - spec/dummy/db/migrate/20140630175330_create_clients.rb
+- spec/dummy/db/migrate/20140709220627_drop_clients_and_locations.rb
+- spec/dummy/db/migrate/20140714225203_create_favorite_foods.rb
 - spec/dummy/db/schema.rb
 - spec/dummy/db/test.sqlite3
-- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
-- spec/dummy/spec/fabricators/client_fabricator.rb
-- spec/dummy/spec/fabricators/location_fabricator.rb
-- spec/dummy/spec/models/client_spec.rb
-- spec/dummy/spec/models/location_spec.rb
-- spec/dummy/spec/support/client_feed.html
-- spec/dummy/spec/support/updated_client_feed.html
 - spec/dummy/tmp/pids/server.pid
-- spec/fabricators/client_fabricator.rb
-- spec/fabricators/location_fabricator.rb
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
-- spec/lib/g5_updatable/feed_mapper_spec.rb
+- spec/lib/g5_updatable/integration_settings_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
 - spec/lib/g5_updatable/version.rb
 - spec/lib/generators/g5_updatable/install_generator_spec.rb
 - spec/lib/generators/tmp/config/routes.rb
-- spec/lib/tmp/config/initializers/g5_updatable.rb
 - spec/lib/tmp/config/routes.rb
+- spec/models/g5_updatable/client_spec.rb
+- spec/models/g5_updatable/integration_setting_spec.rb
+- spec/models/g5_updatable/location_spec.rb
+- spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_example_for_urn_as_parameter.rb
+- spec/support/shared_examples_for_first_class_properties_json.rb
 homepage: https://github.com/G5/g5_updatable
 licenses:
 - MIT
@@ -197,11 +260,13 @@ signing_key:
 specification_version: 4
 summary: Client/Locations data update engine for G5 applications
 test_files:
+- spec/concerns/g5_updatable/belongs_to_location_spec.rb
 - spec/dummy/app/assets/javascripts/application.js
 - spec/dummy/app/assets/stylesheets/application.css
 - spec/dummy/app/controllers/application_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/models/client.rb
+- spec/dummy/app/models/favorite_food.rb
 - spec/dummy/app/models/location.rb
 - spec/dummy/app/views/layouts/application.html.erb
 - spec/dummy/bin/bundle
@@ -209,7 +274,8 @@ test_files:
 - spec/dummy/bin/rake
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
-- spec/dummy/config/database.yml
+- spec/dummy/config/database.sample.yml
+- spec/dummy/config/database.travis.yml
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
@@ -218,7 +284,6 @@ test_files:
 - spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
 - spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/initializers/g5_updatable.rb
 - spec/dummy/config/initializers/inflections.rb
 - spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/session_store.rb
@@ -227,12 +292,12 @@ test_files:
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
 - spec/dummy/config.ru
-- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20140630175259_create_locations.rb
 - spec/dummy/db/migrate/20140630175330_create_clients.rb
+- spec/dummy/db/migrate/20140709220627_drop_clients_and_locations.rb
+- spec/dummy/db/migrate/20140714225203_create_favorite_foods.rb
 - spec/dummy/db/schema.rb
 - spec/dummy/db/test.sqlite3
-- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
@@ -240,22 +305,19 @@ test_files:
 - spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
-- spec/dummy/spec/fabricators/client_fabricator.rb
-- spec/dummy/spec/fabricators/location_fabricator.rb
-- spec/dummy/spec/models/client_spec.rb
-- spec/dummy/spec/models/location_spec.rb
-- spec/dummy/spec/support/client_feed.html
-- spec/dummy/spec/support/updated_client_feed.html
 - spec/dummy/tmp/pids/server.pid
-- spec/fabricators/client_fabricator.rb
-- spec/fabricators/location_fabricator.rb
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
-- spec/lib/g5_updatable/feed_mapper_spec.rb
+- spec/lib/g5_updatable/integration_settings_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
 - spec/lib/g5_updatable/version.rb
 - spec/lib/generators/g5_updatable/install_generator_spec.rb
 - spec/lib/generators/tmp/config/routes.rb
-- spec/lib/tmp/config/initializers/g5_updatable.rb
 - spec/lib/tmp/config/routes.rb
+- spec/models/g5_updatable/client_spec.rb
+- spec/models/g5_updatable/integration_setting_spec.rb
+- spec/models/g5_updatable/location_spec.rb
+- spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_example_for_urn_as_parameter.rb
+- spec/support/shared_examples_for_first_class_properties_json.rb

data/lib/g5_updatable/feed_mapper.rb

@@ -1,58 +0,0 @@
-require "g5_updatable/g5_client"
-require "g5_updatable/g5_location"
-require "microformats2"
-
-class G5Updatable::FeedMapper
-  def initialize(urn)
-    @urn  = urn
-    @feed = Microformats2.parse(client_uid).first if @urn
-  end
-
-  def client
-    G5Updatable::G5Client.new(client_parameters) if @feed
-  end
-
-  def locations
-    return [] if @feed.blank?
-
-    @feed.orgs.map do |location|
-      G5Updatable::G5Location.new(location_parameters(location.format))
-    end
-  end
-
-private
-
-  def client_uid
-    "#{G5Updatable.feed_endpoint}#{@urn}" if @urn.present?
-  end
-
-  def client_parameters
-    {
-      name:  @feed.name.to_s,
-      vertical:  @feed.g5_vertical.to_s,
-      domain:  @feed.g5_domain.to_s,
-      type:  @feed.g5_domain_type.to_s
-    }
-  end
-
-  def location_parameters(location)
-    {
-      uid: location.uid.to_s,
-      urn: location.uid.to_s.split("/").last,
-      name: location.name.to_s,
-      domain: location.g5_domain.to_s,
-      street_address: location.adr.try(:format).try(:street_address).to_s,
-      state: location.adr.try(:format).try(:region).to_s,
-      city: location.adr.try(:format).try(:locality).to_s,
-      neighborhood: location.adr.try(:format).try(:g5_neighborhood).to_s,
-      postal_code: location.adr.try(:format).try(:postal_code).to_s,
-      phone_number: location.adr.try(:format).try(:tel).to_s,
-      default_number: location.adr.try(:format).try(:tel).to_s,
-      corporate: location.g5_corporate.to_s,
-      floor_plans: location.g5_floorplan.to_s,
-      primary_amenity: location.g5_aparment_amenity_1.to_s,
-      qualifier: location.g5_aparment_feature_1.to_s,
-      primary_landmark: location.g5_landmark_1.to_s
-    }
-  end
-end