g5_updatable 0.10.3 → 0.20.3.pre.1

data/spec/models/g5_updatable/location_spec.rb

@@ -6,9 +6,16 @@ describe G5Updatable::Location do
 
     it { expect(location).to validate_presence_of(:uid) }
     it { expect(location).to validate_presence_of(:urn) }
+    it { expect(location).to validate_uniqueness_of(:urn) }
     it { expect(location).to validate_presence_of(:client_uid) }
+    it { expect(location).to validate_presence_of(:client_urn) }
+    it { expect(location).to have_attribute(:latitude) }
+    it { expect(location).to have_attribute(:longitude) }
   end
 
+  it { is_expected.to have_many(:hub_amenities_locations).dependent(:destroy) }
+  it { is_expected.to have_many(:hub_amenities).through(:hub_amenities_locations) }
+
   it_behaves_like 'a model with first-class properties' do
     let(:instance_factory_name) { :location }
   end
@@ -19,25 +26,22 @@ describe G5Updatable::Location do
 
   describe '#client' do
     let(:client) { create(:client) }
-    let(:location) { create(:location, client_uid: client.uid) }
+    let(:location) { create(:location, client_uid: client.uid, client_urn: nil) }
     subject { location.client }
 
-    it { should eq(client) }
+    it { is_expected.to eq(client) }
 
     describe 'client_urn' do
-      it 'delegates client_urn to client' do
-        expect(location.client_urn).to eq(client.urn)
-      end
-
-      it 'returns nil if client not found' do
-        expect(create(:location, client_uid: 'madeup').client_urn).to be_nil
+      it 'uses client_uid to set client_urn if not present' do
+        expect(location.client_urn).to eq(client.uid.split('/').last)
       end
     end
   end
 
   context 'scopes' do
-    let!(:location) { create(:location) }
-    let!(:location2) { create(:location, client_uid: 'something_else', urn: 'another_urn') }
+    let(:client) { create(:client) }
+    let!(:location) { create(:location, client_urn: 'a client urn', client_uid: 'a client uid') }
+    let!(:location2) { create(:g5mf_location, :all_properties) }
 
     describe '.by_client_uid' do
       it 'returns locations' do
@@ -45,6 +49,12 @@ describe G5Updatable::Location do
       end
     end
 
+    describe '.by_client_urn' do
+      it 'returns locations' do
+        expect(described_class.by_client_urn(location.client_urn)).to eq [location]
+      end
+    end
+
     describe '.max_updated_at' do
       it 'returns locations' do
         expect(described_class.max_updated_at.to_s).to eq location2.updated_at.to_s
@@ -56,6 +66,56 @@ describe G5Updatable::Location do
         expect(described_class.by_urn(location.urn)).to eq [location]
       end
     end
+
+    describe '.in_status' do
+      it 'returns locations matching status' do
+        expect(described_class.in_status(location2.status)).to eq [location2]
+      end
+
+      it 'returns locations with one of the statuses' do
+        expect(described_class.in_status([location2.status, 'madeup'])).to eq [location2]
+      end
+    end
+
+    describe '.by_postal_code' do
+      it 'returns locations with matching postal code' do
+        expect(described_class.by_postal_code(location2.postal_code)).to eq [location2]
+      end
+    end
+
+    describe '.by_city' do
+      it 'returns locations with matching city' do
+        expect(described_class.by_city(location2.city)).to eq [location2]
+      end
+    end
+
+    describe '.by_state' do
+      it 'returns locations with matching state' do
+        expect(described_class.by_state(location2.state)).to eq [location2]
+      end
+    end
+
+    describe '.by_neighborhood' do
+      it 'returns locations with neighborhood' do
+        expect(described_class.by_neighborhood(location2.neighborhood)).to eq [location2]
+        expect(described_class.by_neighborhood(location2.neighborhood_2)).to eq [location2]
+      end
+    end
+
+    describe '#neighborhoods' do
+      it 'returns all neighborhoods' do
+        expect(location2.neighborhoods).to eq([location2.neighborhood, location2.neighborhood_2])
+      end
+
+      it 'return empty array if no neighborhoods' do
+        expect(location.neighborhoods).to be_empty
+      end
+
+      it 'ignores blank neighborhoods' do
+        location_with_blank = create(:g5mf_location, urn: 'sumpn', uid: 'http://sumpn', properties: {neighborhood: ''})
+        expect(location_with_blank.neighborhoods).to be_empty
+      end
+    end
   end
 
   describe '#display_name' do
@@ -76,4 +136,174 @@ describe G5Updatable::Location do
       its(:display_name) { is_expected.to be_nil }
     end
   end
+
+  describe "#live?" do
+    subject { described_class.new(properties: properties) }
+    context "status is Live" do
+      let(:properties) { {'status' => 'Live'} }
+      its(:live?) { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Pending'} }
+      its(:live?) { is_expected.to eq false }
+    end
+  end
+
+  context "#no_deploy?" do
+    subject { described_class.new(properties: properties) }
+    context "status is No Deploy" do
+      let(:properties) { {'status' => 'No Deploy'} }
+      its(:no_deploy?) { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Pending'} }
+      its(:no_deploy?) { is_expected.to eq false }
+    end
+  end
+
+  context "#pending?" do
+    subject { described_class.new(properties: properties) }
+    context "status is Pending" do
+      let(:properties) { {'status' => 'Pending'} }
+      its(:pending?) { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Live'} }
+      its(:pending?) { is_expected.to eq false }
+    end
+  end
+
+  context "#deleted?" do
+    subject { described_class.new(properties: properties) }
+    context "status is Deleted" do
+      let(:properties) { {'status' => 'Deleted'} }
+      its(:deleted?) { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Live'} }
+      its(:deleted?) { is_expected.to eq false }
+    end
+  end
+
+  context "#suspended?" do
+    subject { described_class.new(properties: properties) }
+    context "status is Suspended" do
+      let(:properties) { {'status' => 'Suspended'} }
+      its(:suspended?) { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Live'} }
+      its(:suspended?) { is_expected.to eq false }
+    end
+  end
+
+  context "#status?" do
+    subject { location.status?(status_parameter) }
+    let(:location) { described_class.new(properties: properties) }
+    let(:status_parameter) { "Given Status" }
+
+    context "status property matches the given status parameter" do
+      let(:properties) { {"status" => "Given Status"} }
+      it { is_expected.to eq true }
+    end
+
+    context "status property matches the given status parameter regardless of letter case" do
+      let(:properties) { {"status" => "giveN StAtus"} }
+      it { is_expected.to eq true }
+    end
+
+    context "status property matches the given status parameter, regardless of leading/trailing whitespace" do
+      let(:properties) { {"status" => " Given Status   \t"} }
+      let(:status_parameter) { "  Given Status \t\n" }
+      it { is_expected.to eq true }
+    end
+
+    context "status is something else" do
+      let(:properties) { {'status' => 'Live'} }
+      it { is_expected.to eq false }
+    end
+
+    context "no status" do
+      let(:properties) { {} }
+      it { is_expected.to eq false }
+    end
+
+    context "no properties attribute" do
+      let(:properties) { nil }
+      it { is_expected.to eq false }
+    end
+  end
+
+  describe '#amenities' do
+    let!(:location) { create(:location) }
+    let!(:amenity) { create(:hub_amenity) }
+    let!(:amenity2) { create(:hub_amenity) }
+
+    before do
+      location.hub_amenities << amenity
+      location.hub_amenities << amenity2
+      location.refresh_flat_amenity_names!
+      location.reload
+    end
+
+    it 'associates amenities' do
+      expect(location.hub_amenities).to match_array([amenity, amenity2])
+      expect(location.hub_amenities_locations.collect(&:location)).to eq([location, location])
+    end
+
+    it 'sets the flat amenity names' do
+      expect(location.flat_amenity_names).to eq("|#{location.hub_amenities.collect(&:name).sort.join('|')}|")
+    end
+  end
+
+  describe 'amenity scopes' do
+    let!(:location) { create(:location, properties: {city: 'mycity', state: 'AK', status: 'Pending'}, amenity_names_array: ['a', 'b', 'c', 'z']) }
+    let!(:location2) { create(:location, urn: 'adiffurn', uid: 'adiffuid', amenity_names_array: ['b', 'c', 'd', 'z']) }
+
+    describe '#by_amenity_names' do
+      it 'finds by one matching amenity' do
+        expect(described_class.by_amenity_names('a')).to eq([location])
+        expect(described_class.by_amenity_names('a', 'b')).to eq([location])
+        expect(described_class.by_amenity_names('b', 'a')).to eq([location])
+      end
+
+      it 'finds by multiple matching amenities' do
+        expect(described_class.by_amenity_names(['b', 'c'])).to match_array([location, location2])
+        expect(described_class.by_amenity_names('c', 'b')).to match_array([location, location2])
+        expect(described_class.by_amenity_names(['c', 'b'])).to match_array([location, location2])
+      end
+
+      it 'finds by multiple matching amenities that are not in order' do
+        expect(described_class.by_amenity_names(['a', 'c'])).to match_array([location])
+        expect(described_class.by_amenity_names('d', 'b')).to match_array([location2])
+        expect(described_class.by_amenity_names(['z', 'b'])).to match_array([location, location2])
+      end
+
+      it 'does not match if one amenity does not match' do
+        expect(described_class.by_amenity_names('b', 'y')).to be_empty
+      end
+
+      it 'is chainable' do
+        expect(described_class.by_city('mycity').by_amenity_names(['a', 'c']).by_state('AK').in_status('Pending')).to match_array([location])
+      end
+    end
+  end
+
+  describe '#amenity_names_to_tokenized_string' do
+    [{input: ['a'], expected: '|a|'},
+     {input: ['b', 'a'], expected: '|a|b|'},
+     {input: 'b', expected: '|b|'},
+     {input: '', expected: nil},
+     {input: nil, expected: nil}
+    ].each do |test_hash|
+      it "converts #{test_hash[:input]} to #{test_hash[:expected]}" do
+        expect(described_class.amenity_names_to_tokenized_string(test_hash[:input])).to eq(test_hash[:expected])
+      end
+    end
+  end
 end

data/spec/serializers/g5_updatable/location_serializer_spec.rb

@@ -7,12 +7,13 @@ describe G5Updatable::LocationSerializer do
       uid: "https://example.com/locations/test-urn",
       urn: "test-urn",
       client_uid: "https://example.com/client",
+      name: "Test Name",
       properties: {
         name: "Test Name"
       }
     )
   end
-  subject { G5Updatable::LocationSerializer.new(location).as_json["location"] }
+  subject { G5Updatable::LocationSerializer.new(location).as_json }
 
   its([:uid]) { is_expected.to eq("https://example.com/locations/test-urn") }
   its([:urn]) { is_expected.to eq("test-urn") }

data/spec/spec_helper.rb

@@ -4,12 +4,12 @@ ENV["RAILS_ENV"] ||= 'test'
 require File.expand_path("../dummy/config/environment.rb", __FILE__)
 require 'rspec/rails'
 require 'rspec/its'
+require 'webmock/rspec'
 
 require 'generator_spec'
 require 'factory_girl'
 require 'g5_updatable/rspec'
 require 'shoulda/matchers'
-require 'g5_foundation_client/rspec'
 
 Rails.backtrace_cleaner.remove_silencers!
 
@@ -23,6 +23,7 @@ ActiveRecord::Migration.check_pending! if defined?(ActiveRecord::Migration)
 
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
+  config.include FixturesHelper
   # ## Mock Framework
   #
   # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:

data/spec/support/fixture_helper.rb

@@ -0,0 +1,5 @@
+module FixturesHelper
+  def fixture(fixture_path)
+    open(File.join("spec", "fixtures", fixture_path)).read
+  end
+end

data/spec/support/shared_examples/belongs_to_client.rb

@@ -1,9 +1,8 @@
-RSpec.shared_examples "belongs to client" do
-
+RSpec.shared_examples 'belongs to client' do
   subject { described_class.new }
+
   it do
-    is_expected.to belong_to(:client).class_name("G5Updatable::Client").
-      with_foreign_key(:client_uid).with_primary_key(:uid)
+    is_expected.to belong_to(:client).class_name('G5Updatable::Client').
+        with_foreign_key(:client_urn).with_primary_key(:urn)
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: g5_updatable
 version: !ruby/object:Gem::Version
-  version: 0.10.3
+  version: 0.20.3.pre.1
 platform: ruby
 authors:
 - Brian Bauer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-16 00:00:00.000000000 Z
+date: 2017-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -25,19 +25,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: g5_foundation_client
+  name: g5_authentication_client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.3
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -56,18 +56,18 @@ dependencies:
   name: active_model_serializers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: virtus
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +150,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: shoulda-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.1'
 description: Client/Locations data update engine for G5 applications
 email:
 - brian.bauer@getg5.com
@@ -172,6 +200,8 @@ files:
 - app/controllers/g5_updatable/syncs_controller.rb
 - app/helpers/g5_updatable/base_updatable_helper.rb
 - app/models/g5_updatable/client.rb
+- app/models/g5_updatable/hub_amenities_location.rb
+- app/models/g5_updatable/hub_amenity.rb
 - app/models/g5_updatable/location.rb
 - app/serializers/g5_updatable/location_serializer.rb
 - app/views/layouts/g5_updatable/base_updatable.html.erb
@@ -181,11 +211,19 @@ files:
 - db/migrate/20141122211945_remove_integration_setting.rb
 - db/migrate/20141211211945_add_name_to_clients_and_locations.rb
 - db/migrate/20141211711945_update_names.rb
+- db/migrate/20151103043916_add_latitude_and_longitude_to_location.rb
+- db/migrate/20151103050229_copy_lat_long_props_to_lat_long_columns.rb
+- db/migrate/20151106070749_add_latitude_longitude_indexes_to_location.rb
+- db/migrate/20161122070749_add_amenities.rb
+- db/migrate/20161209070749_add_client_urn_to_locations.rb
 - lib/g5_updatable.rb
+- lib/g5_updatable/all_client_urns_fetcher.rb
 - lib/g5_updatable/client_feed_processor.rb
 - lib/g5_updatable/client_updater.rb
 - lib/g5_updatable/engine.rb
 - lib/g5_updatable/factories.rb
+- lib/g5_updatable/fetcher.rb
+- lib/g5_updatable/indifferentizer.rb
 - lib/g5_updatable/locations_updater.rb
 - lib/g5_updatable/rspec.rb
 - lib/g5_updatable/rspec/factories.rb
@@ -195,6 +233,7 @@ files:
 - lib/tasks/g5_updatable_tasks.rake
 - spec/concerns/g5_updatable/belongs_to_client_spec.rb
 - spec/concerns/g5_updatable/belongs_to_location_spec.rb
+- spec/controllers/feed_controller_spec.rb
 - spec/controllers/locations_controller_spec.rb
 - spec/controllers/syncs_controller_spec.rb
 - spec/dummy/README.rdoc
@@ -241,11 +280,21 @@ files:
 - spec/dummy/db/test.sqlite3
 - spec/dummy/log/development.log
 - spec/dummy/log/test.log
+- spec/dummy/log/tests.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/tmp/pids/server.pid
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily-missing-locations.json
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily-no-locations.json
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily.json
+- spec/fixtures/hub-client.json
+- spec/fixtures/hub-clients.json
+- spec/fixtures/hub-location.json
+- spec/fixtures/location-g5-cl-1soj9pe2-541-apartments.json
+- spec/fixtures/urns.json
+- spec/lib/g5_updatable/all_client_urns_fetcher_spec.rb
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
@@ -254,9 +303,12 @@ files:
 - spec/lib/generators/tmp/config/routes.rb
 - spec/lib/tmp/config/routes.rb
 - spec/models/g5_updatable/client_spec.rb
+- spec/models/g5_updatable/hub_amenities_location_spec.rb
+- spec/models/g5_updatable/hub_amenity_spec.rb
 - spec/models/g5_updatable/location_spec.rb
 - spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/fixture_helper.rb
 - spec/support/shared_example_for_urn_as_parameter.rb
 - spec/support/shared_examples/belongs_to_client.rb
 - spec/support/shared_examples_for_first_class_properties_json.rb
@@ -275,18 +327,19 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Client/Locations data update engine for G5 applications
 test_files:
 - spec/concerns/g5_updatable/belongs_to_client_spec.rb
 - spec/concerns/g5_updatable/belongs_to_location_spec.rb
+- spec/controllers/feed_controller_spec.rb
 - spec/controllers/locations_controller_spec.rb
 - spec/controllers/syncs_controller_spec.rb
 - spec/dummy/app/assets/javascripts/application.js
@@ -331,6 +384,7 @@ test_files:
 - spec/dummy/db/test.sqlite3
 - spec/dummy/log/development.log
 - spec/dummy/log/test.log
+- spec/dummy/log/tests.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
@@ -338,6 +392,15 @@ test_files:
 - spec/dummy/Rakefile
 - spec/dummy/README.rdoc
 - spec/dummy/tmp/pids/server.pid
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily-missing-locations.json
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily-no-locations.json
+- spec/fixtures/client-g5-c-1soj8m6e-g5-multifamily.json
+- spec/fixtures/hub-client.json
+- spec/fixtures/hub-clients.json
+- spec/fixtures/hub-location.json
+- spec/fixtures/location-g5-cl-1soj9pe2-541-apartments.json
+- spec/fixtures/urns.json
+- spec/lib/g5_updatable/all_client_urns_fetcher_spec.rb
 - spec/lib/g5_updatable/client_feed_processor_spec.rb
 - spec/lib/g5_updatable/client_updater_spec.rb
 - spec/lib/g5_updatable/locations_updater_spec.rb
@@ -346,9 +409,13 @@ test_files:
 - spec/lib/generators/tmp/config/routes.rb
 - spec/lib/tmp/config/routes.rb
 - spec/models/g5_updatable/client_spec.rb
+- spec/models/g5_updatable/hub_amenities_location_spec.rb
+- spec/models/g5_updatable/hub_amenity_spec.rb
 - spec/models/g5_updatable/location_spec.rb
 - spec/serializers/g5_updatable/location_serializer_spec.rb
 - spec/spec_helper.rb
+- spec/support/fixture_helper.rb
 - spec/support/shared_example_for_urn_as_parameter.rb
 - spec/support/shared_examples/belongs_to_client.rb
 - spec/support/shared_examples_for_first_class_properties_json.rb
+has_rdoc: