g5_authentication_client 0.5.5 → 1.0.0.pre.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7523b2253fa2e4cfdfe44aa19f90dd2fd723b145
-  data.tar.gz: 1a6c444984028cd945ea9b5655406eabf265435c
+  metadata.gz: ec977846ba08302b591fe6ad9f7b14029df428da
+  data.tar.gz: c4a075849add4076e9a11d8ca1eb9ad609c5b146
 SHA512:
-  metadata.gz: 472b9698483a47e942b7759d40fe27fb0da0b58007fbe998aa3e2235c870e27596c904ddf6a91e4bbd757131a5d0b73b4200c5428007fff61ed99a54c136c93a
-  data.tar.gz: 03f326c50c7bca637cb5c2173eed08e4983137aff76ec753239c79e985174a5911012a1b79c21678482c7affe0844322cd85f6e2d23cfd23cce849287d992d15
+  metadata.gz: 01163f1a683de2961d057164a3d43ae83c783ba2f23c4c26656458547d2fbd84dbaff09a26db98a74ef97e88dc542043d311f677bb416c22ba57d76e5f0044dc
+  data.tar.gz: b00e09b45f75ed1aad18bf5c554d7b77fe79970ab0eea6be53920db1176810820a4a245bf4c9aba0f81eae7d20b23dbc9368f028e64ab31ad6f9624bb4165fb4

data/.ruby-version

@@ -1 +1 @@
-2.3.3
+2.3.4

data/.travis.yml

@@ -1,6 +1,13 @@
 language: ruby
 rvm:
-  - 2.2.6
-  - 2.3.3
+  - 2.2.7
+  - 2.3.4
+  - 2.4.1
 script:
   - bundle exec rspec spec
+after_script:
+  - bundle exec codeclimate-test-reporter
+addons:
+  code_climate:
+    repo_token:
+      secure: "o57YVn0CkxJwlVfYv2faFKT3sF3Xlio21piMFhNu828lkWxmnHREKt89UioQSVtAJWRkAC9dQL24YdsItNEunxozPQ/appw6UfJTNTDP8HrUg3rQjdimryzKFFr731ztpHs12q+PgbRt+WXIl/PW8w6haHf6m6pEsDkt364z8So="

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## v1.0.0.pre.1 (2017-06-08)
+
+* **Backwards incompatible changes**
+  * Drop support for ruby < 2.2
+* Enhancements
+  * Upgrade modelish to ensure compatibility with ruby 2.4 and
+  rails 5.x
+
 ## v0.5.5 (2017-01-30)
 
  * RestClient raises errors on 401.

data/README.md

@@ -4,11 +4,11 @@ A client library for the g5-authentication service.
 
 ## Current version ##
 
-0.5.4
+1.0.0.pre.1
 
 ## Requirements ##
 
-* Ruby >= 1.9.3
+* Ruby >= 2.2.2
 
 ## Installation ##
 

data/g5_authentication_client.gemspec

@@ -1,23 +1,25 @@
-$:.push File.expand_path("../lib", __FILE__)
-require "g5_authentication_client/version"
+# frozen_string_literal: true
+
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+require 'g5_authentication_client/version'
 
 Gem::Specification.new do |s|
-  s.name        = "g5_authentication_client"
+  s.name        = 'g5_authentication_client'
   s.version     = G5AuthenticationClient::VERSION
-  s.authors     = ["Rob Revels", "Maeve Revels"]
-  s.email       = ["rob.revels@getg5.com", "maeve.revels@getg5.com"]
-  s.homepage    = "https://github.com/G5/g5_authentication_client"
-  s.summary     = "Client for the G5 Auth service"
-  s.description = "Client for the G5 Auth service"
+  s.authors     = ['Rob Revels', 'Maeve Revels']
+  s.email       = ['rob.revels@getg5.com', 'maeve.revels@getg5.com']
+  s.homepage    = 'https://github.com/G5/g5_authentication_client'
+  s.summary     = 'Client for the G5 Auth service'
+  s.description = 'Client for the G5 Auth service'
 
-  s.rubyforge_project = "g5_authentication_client"
+  s.rubyforge_project = 'g5_authentication_client'
 
   s.files = `git ls-files`.split("\n")
   s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
 
-  s.add_dependency('modelish', '~> 0.3')
+  s.add_dependency('modelish', '~> 0.4')
   s.add_dependency('configlet', '~> 2.1')
   s.add_dependency('oauth2')
   s.add_dependency('addressable')
@@ -27,7 +29,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('webmock')
   s.add_development_dependency('fakefs')
   s.add_development_dependency('simplecov')
-  s.add_development_dependency('codeclimate-test-reporter')
+  s.add_development_dependency('codeclimate-test-reporter', '~> 1.0')
   s.add_development_dependency('yard')
   s.add_development_dependency('rdiscount')
   s.add_development_dependency('vcr')

data/lib/g5_authentication_client/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module G5AuthenticationClient
-  VERSION = '0.5.5'
+  VERSION = '1.0.0.pre.1'
 end

data/spec/g5_authentication_client/role_spec.rb

@@ -1,13 +1,14 @@
+# frozen_string_literal: false
+
 require 'spec_helper'
 
 describe G5AuthenticationClient::Role do
   subject(:role) { G5AuthenticationClient::Role.new(attributes) }
 
-  let(:attributes) do {
-    name: name,
-    type: type,
-    urn: urn,
-  }
+  let(:attributes) do
+    { name: name,
+      type: type,
+      urn: urn }
   end
 
   let(:name) { 'awesome_role' }
@@ -41,7 +42,7 @@ describe G5AuthenticationClient::Role do
   end
 
   context 'when attributes include unknown properties' do
-    let(:attributes) { {name: name, resource: 'Application'} }
+    let(:attributes) { { name: name, resource: 'Application' } }
 
     it 'should not raise an error' do
       expect { role }.to_not raise_error
@@ -69,28 +70,27 @@ describe G5AuthenticationClient::Role do
       let(:name) {}
 
       it 'should raise an error' do
-        expect { validate! }.to raise_error
+        expect { validate! }.to raise_error(ArgumentError,
+                                            'name must not be nil or blank')
       end
     end
   end
 
   describe '#validate_for_create!' do
-    subject(:validate_for_create) {role.validate_for_create!}
+    subject(:validate_for_create) { role.validate_for_create! }
 
     context 'when type not GLOBAL and no urn' do
-
       let(:type) { 'not_global' }
-      let(:urn) {  }
+      let(:urn) {}
 
       it 'will raise an error' do
-        expect { validate_for_create }.to raise_error
+        expect { validate_for_create }.to raise_error(ArgumentError)
       end
     end
 
     context 'when type GLOBAL and no urn' do
-
       let(:type) { 'GLOBAL' }
-      let(:urn) {  }
+      let(:urn) {}
 
       it 'will raise an error' do
         expect { validate_for_create }.to_not raise_error
@@ -98,7 +98,6 @@ describe G5AuthenticationClient::Role do
     end
 
     context 'when type not GLOBAL and existing urn' do
-
       let(:type) { 'NOT_GLOBAL' }
       let(:urn) { 'some_urn' }
 
@@ -106,7 +105,6 @@ describe G5AuthenticationClient::Role do
         expect { validate_for_create }.to_not raise_error
       end
     end
-
   end
 
   describe '#to_hash' do

data/spec/g5_authentication_client/user_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe G5AuthenticationClient::User do
@@ -13,23 +15,24 @@ describe G5AuthenticationClient::User do
       title: title,
       organization_name: organization_name,
       phone_number: phone_number,
-      roles: [{name: role_name, type:'G5Updatable::Client', urn:'someurn'}]
-    }
+      roles: [{ name: role_name,
+                type: 'G5Updatable::Client',
+                urn: 'someurn' }] }
   end
 
   let(:email) { 'foo@blah.com' }
   let(:password) { 'foobarbaz' }
   let(:password_confirmation) { 'notamatch' }
-  let(:id) {1}
+  let(:id) { 1 }
   let(:first_name) { 'Joe' }
   let(:last_name) { 'Person' }
   let(:organization_name) { 'Things, Inc.' }
   let(:phone_number) { '8675309123' }
   let(:title) { 'Developer' }
-  let(:role_name)  { 'Editor' }
+  let(:role_name) { 'Editor' }
 
   context 'with default initialization' do
-    let(:attributes){}
+    let(:attributes) {}
 
     it 'should have nil email' do
       expect(user.email).to be_nil
@@ -102,15 +105,18 @@ describe G5AuthenticationClient::User do
     subject(:validate!) { user.validate! }
 
     context 'without email' do
-      let(:email){}
+      let(:email) {}
 
       it 'should raise an error' do
-        expect { validate! }.to raise_error
+        expect { validate! }.to raise_error(
+          ArgumentError,
+          'email must not be nil or blank'
+        )
       end
     end
 
     context 'without password' do
-      let(:password){}
+      let(:password) {}
 
       it 'should not raise an error' do
         expect { validate! }.to_not raise_error
@@ -118,7 +124,7 @@ describe G5AuthenticationClient::User do
     end
 
     context 'without id' do
-      let(:id){}
+      let(:id) {}
 
       it 'should not raise an error' do
         expect { validate! }.to_not raise_error
@@ -185,28 +191,35 @@ describe G5AuthenticationClient::User do
       let(:role_name) {}
 
       it 'should raise an error' do
-        expect { validate! }.to raise_error
+        expect { validate! }.to raise_error(ArgumentError,
+                                            'User roles must be valid')
       end
     end
   end
 
   describe '#validate_for_create!' do
-    subject(:validate_for_create) {user.validate_for_create!}
+    subject(:validate_for_create) { user.validate_for_create! }
 
     context 'without a password' do
-      let(:password){}
+      let(:password) {}
 
       it 'should be invalid' do
-        expect { validate_for_create }.to raise_error
+        expect { validate_for_create }.to raise_error(
+          ArgumentError,
+          'Password required for new user.'
+        )
       end
     end
 
     context 'without an email' do
-      let(:email){}
-      let(:password){'foo'}
+      let(:email) {}
+      let(:password) { 'foo' }
 
       it 'should be invalid' do
-        expect { validate_for_create }.to raise_error
+        expect { validate_for_create }.to raise_error(
+          ArgumentError,
+          'email must not be nil or blank'
+        )
       end
     end
   end
@@ -243,7 +256,11 @@ describe G5AuthenticationClient::User do
     end
 
     it 'should have roles' do
-      expect(to_hash['roles']).to eq([{'name' => role_name, 'type'=>'G5Updatable::Client', 'urn'=>'someurn'}])
+      expect(to_hash['roles']).to eq(
+        [{ 'name' => role_name,
+           'type' => 'G5Updatable::Client',
+           'urn' => 'someurn' }]
+      )
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 require 'simplecov'
-require 'codeclimate-test-reporter'
 SimpleCov.start 'test_frameworks'
 
 require 'rspec'
@@ -11,10 +12,6 @@ Dir[File.join(File.dirname(__FILE__), 'support', '*.rb')].each { |f| require f }
 
 RSpec.configure do |config|
   config.include FakeFS::SpecHelpers
-
-  # We need to explicitly disable webmock to report
-  # coverage data to Code Climate
-  config.after(:suite) { WebMock.disable! }
 end
 
 require 'g5_authentication_client'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: g5_authentication_client
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 1.0.0.pre.1
 platform: ruby
 authors:
 - Rob Revels
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-12 00:00:00.000000000 Z
+date: 2017-06-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: modelish
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: configlet
   requirement: !ruby/object:Gem::Requirement
@@ -141,16 +141,16 @@ dependencies:
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
@@ -244,12 +244,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: g5_authentication_client
-rubygems_version: 2.6.8
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Client for the G5 Auth service