g5_authenticatable_api 0.4.1 → 1.0.0.pre.1

data/lib/g5_authenticatable_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support'
 require 'active_support/core_ext/module/attribute_accessors'
 
@@ -7,6 +9,7 @@ require 'g5_authenticatable_api/railtie' if defined?(Rails)
 
 require 'g5_authentication_client'
 
+# Token-based authentication for protecting rails API endpoints with G5 Auth
 module G5AuthenticatableApi
   # When enabled, strict token validation will validate the session user's
   # access_token against the auth server for every request (if there is

data/spec/dummy/app/controllers/rails_api/articles_controller.rb

@@ -1,6 +1,6 @@
 module RailsApi
   class ArticlesController < ApplicationController
-    before_filter :authenticate_api_user!
+    before_action :authenticate_api_user!
 
     respond_to :json
 

data/spec/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dummy::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
@@ -13,8 +15,22 @@ Dummy::Application.configure do
   config.eager_load = false
 
   # Configure static asset server for tests with Cache-Control for performance.
-  config.serve_static_assets  = true
-  config.static_cache_control = "public, max-age=3600"
+  cache_header_value = 'public, max-age=3600'
+
+  if config.respond_to?(:public_file_server)
+    config.public_file_server.enabled = true
+    config.public_file_server.headers = {
+      'Cache-Control' => cache_header_value
+    }
+  else
+    config.static_cache_control = cache_header_value
+
+    if config.respond_to?(:serve_static_files=)
+      config.serve_static_files = true
+    else
+      config.serve_static_assets = true
+    end
+  end
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true

data/spec/dummy/config/initializers/rails_compatibility.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+# Support migration version syntax in rails 4
+ActiveSupport.on_load(:active_record) do
+  unless ActiveRecord::Migration.respond_to?(:[])
+    ActiveRecord::Migration.define_singleton_method(:[]) do |version|
+      self if version.to_s.starts_with?('4')
+    end
+  end
+end

data/spec/dummy/db/migrate/20140217124048_devise_create_users.rb

@@ -1,4 +1,6 @@
-class DeviseCreateUsers < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class DeviseCreateUsers < ActiveRecord::Migration[4.2]
   def change
     create_table(:users) do |t|
       t.string :email,              null: false, default: ''
@@ -10,6 +12,6 @@ class DeviseCreateUsers < ActiveRecord::Migration
     end
 
     add_index :users, :email, unique: true
-    add_index :users, [:provider, :uid], unique: true
+    add_index :users, %i[provider uid], unique: true
   end
 end

data/spec/dummy/db/migrate/20140223194521_create_articles.rb

@@ -1,4 +1,6 @@
-class CreateArticles < ActiveRecord::Migration
+# frozen_string_literal: true
+
+class CreateArticles < ActiveRecord::Migration[4.2]
   def change
     create_table :articles do |t|
       t.string :title

data/spec/dummy/db/schema.rb

@@ -1,4 +1,3 @@
-# encoding: UTF-8
 # This file is auto-generated from the current state of the database. Instead
 # of editing this file, please use the migrations feature of Active Record to
 # incrementally modify your database, and then regenerate this schema definition.
@@ -16,24 +15,23 @@ ActiveRecord::Schema.define(version: 20140223194521) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
-  create_table "articles", force: true do |t|
-    t.string   "title"
-    t.text     "body"
-    t.string   "tags"
+  create_table "articles", id: :serial, force: :cascade do |t|
+    t.string "title"
+    t.text "body"
+    t.string "tags"
     t.datetime "created_at"
     t.datetime "updated_at"
   end
 
-  create_table "users", force: true do |t|
-    t.string   "email",           default: "",   null: false
-    t.string   "provider",        default: "g5", null: false
-    t.string   "uid",                            null: false
-    t.string   "g5_access_token"
+  create_table "users", id: :serial, force: :cascade do |t|
+    t.string "email", default: "", null: false
+    t.string "provider", default: "g5", null: false
+    t.string "uid", null: false
+    t.string "g5_access_token"
     t.datetime "created_at"
     t.datetime "updated_at"
+    t.index ["email"], name: "index_users_on_email", unique: true
+    t.index ["provider", "uid"], name: "index_users_on_provider_and_uid", unique: true
   end
 
-  add_index "users", ["email"], name: "index_users_on_email", unique: true, using: :btree
-  add_index "users", ["provider", "uid"], name: "index_users_on_provider_and_uid", unique: true, using: :btree
-
 end

data/spec/factories/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryGirl.define do
   factory :user do
     sequence(:email) { |n| "user.#{n}@test.host" }

data/spec/lib/g5_authenticatable_api/helpers/grape_spec.rb

@@ -1,9 +1,11 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi::Helpers::Grape do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi::Helpers::Grape do
   include Rack::Test::Methods
 
-  def app
+  let(:app) do
     Class.new(Grape::API) do
       helpers G5AuthenticatableApi::Helpers::Grape
 
@@ -26,13 +28,15 @@ describe G5AuthenticatableApi::Helpers::Grape do
     end
   end
 
-  let(:env) { {'warden' => warden} }
+  let(:env) { { 'warden' => warden } }
   let(:warden) { double(:warden) }
 
-  let(:params) { {'access_token' => token_value} }
+  let(:params) { { 'access_token' => token_value } }
   let(:token_value) { 'abc123' }
 
-  let(:headers) { {'Host'=>'example.org', 'Cookie'=>''} }
+  let(:headers) do
+    { 'Host' => 'example.org', 'Cookie' => '' }
+  end
 
   describe '#authenticate_user!' do
     subject(:authenticate_user!) { get '/authenticate', params, env }
@@ -43,8 +47,8 @@ describe G5AuthenticatableApi::Helpers::Grape do
                                access_token: token_value)
     end
     before do
-      allow(G5AuthenticatableApi::Services::TokenValidator).to receive(:new).
-        and_return(token_validator)
+      allow(G5AuthenticatableApi::Services::TokenValidator).to receive(:new)
+        .and_return(token_validator)
     end
 
     context 'when token is valid' do
@@ -53,18 +57,19 @@ describe G5AuthenticatableApi::Helpers::Grape do
 
       it 'initializes the token validator correctly' do
         authenticate_user!
-        expect(G5AuthenticatableApi::Services::TokenValidator).to have_received(:new).
-          with(params, headers, warden)
+        expect(G5AuthenticatableApi::Services::TokenValidator)
+          .to have_received(:new)
+          .with(params, headers, warden)
       end
 
       it 'is successful' do
         authenticate_user!
-        expect(last_response).to be_http_ok
+        expect(last_response.status).to eq(200)
       end
 
       it 'does not set the authenticate response header' do
         authenticate_user!
-        expect(last_response).to_not have_header('WWW-Authenticate')
+        expect(last_response.headers).to_not have_key('WWW-Authenticate')
       end
     end
 
@@ -74,7 +79,7 @@ describe G5AuthenticatableApi::Helpers::Grape do
 
       it 'is unauthorized' do
         authenticate_user!
-        expect(last_response).to be_http_unauthorized
+        expect(last_response.status).to eq(401)
       end
 
       it 'renders an error message' do
@@ -84,25 +89,28 @@ describe G5AuthenticatableApi::Helpers::Grape do
 
       it 'sets the authenticate response header' do
         authenticate_user!
-        expect(last_response).to have_header('WWW-Authenticate' => auth_response_header)
+        expect(last_response.headers).to include(
+          'WWW-Authenticate' => auth_response_header
+        )
       end
     end
   end
 
   describe '#token_data' do
     subject(:token_data) { get '/token_data', params, env }
-
     before do
-      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new).
-        and_return(token_info)
+      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new)
+        .and_return(token_info)
     end
     let(:token_info) { double(:token_info, token_data: mock_token_data) }
-    let(:mock_token_data) { double(:token_data, to_json: '{result: mock_token_data_json}') }
+    let(:mock_token_data) do
+      double(:token_data, to_json: '{result: mock_token_data_json}')
+    end
 
     it 'initializes the token info service correctly' do
       token_data
-      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new).
-        with(params, headers, warden)
+      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new)
+        .with(params, headers, warden)
     end
 
     it 'returns the token info from the service' do
@@ -115,16 +123,16 @@ describe G5AuthenticatableApi::Helpers::Grape do
     subject(:current_user) { get '/current_user', params, env }
 
     before do
-      allow(G5AuthenticatableApi::Services::UserFetcher).to receive(:new).
-        and_return(user_fetcher)
+      allow(G5AuthenticatableApi::Services::UserFetcher).to receive(:new)
+        .and_return(user_fetcher)
     end
     let(:user_fetcher) { double(:user_fetcher, current_user: user) }
     let(:user) { double(:user, to_json: '{result: mock_user_json}') }
 
     it 'initializes the user fetcher service correctly' do
       current_user
-      expect(G5AuthenticatableApi::Services::UserFetcher).to have_received(:new).
-        with(params, headers, warden)
+      expect(G5AuthenticatableApi::Services::UserFetcher).to have_received(:new)
+        .with(params, headers, warden)
     end
 
     it 'returns the user from the service' do
@@ -137,15 +145,15 @@ describe G5AuthenticatableApi::Helpers::Grape do
     subject(:access_token) { get '/access_token', params, env }
 
     before do
-      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new).
-        and_return(token_info)
+      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new)
+        .and_return(token_info)
     end
     let(:token_info) { double(:token_info, access_token: token_value) }
 
     it 'initializes the token info service correctly' do
       access_token
-      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new).
-        with(params, headers, warden)
+      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new)
+        .with(params, headers, warden)
     end
 
     it 'returns the access token from the service' do

data/spec/lib/g5_authenticatable_api/helpers/rails_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
   controller(ActionController::Base) do
     before_action :authenticate_api_user!, only: :index
 
@@ -17,7 +19,9 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
   before { request.env['warden'] = warden }
 
   describe '#authenticate_api_user!' do
-    subject(:authenticate_api_user!) { get :index, access_token: token_value }
+    subject(:authenticate_api_user!) do
+      safe_get :index, access_token: token_value
+    end
 
     let(:token_value) { 'abc123' }
 
@@ -27,8 +31,8 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
                                access_token: token_value)
     end
     before do
-      allow(G5AuthenticatableApi::Services::TokenValidator).to receive(:new).
-        and_return(token_validator)
+      allow(G5AuthenticatableApi::Services::TokenValidator).to receive(:new)
+        .and_return(token_validator)
     end
 
     context 'when token is valid' do
@@ -37,10 +41,11 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
 
       it 'initializes the token validator correctly' do
         authenticate_api_user!
-        expect(G5AuthenticatableApi::Services::TokenValidator).to have_received(:new).
-          with(request.params,
-               an_instance_of(ActionDispatch::Http::Headers),
-               warden)
+        expect(G5AuthenticatableApi::Services::TokenValidator)
+          .to have_received(:new)
+          .with(request.params,
+                an_instance_of(ActionDispatch::Http::Headers),
+                warden)
       end
 
       it 'is successful' do
@@ -50,9 +55,8 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
 
       it 'does not set the authenticate response header' do
         authenticate_api_user!
-        expect(response).to_not have_header('WWW-Authenticate')
+        expect(response.headers).to_not have_key('WWW-Authenticate')
       end
-
     end
 
     context 'when token is invalid' do
@@ -61,7 +65,7 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
 
       it 'is unauthorized' do
         authenticate_api_user!
-        expect(response).to be_unauthorized
+        expect(response.status).to eq(401)
       end
 
       it 'renders an error message' do
@@ -75,20 +79,21 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
     subject(:token_data) { controller.token_data }
 
     before do
-      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new).
-        and_return(token_info)
+      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new)
+        .and_return(token_info)
     end
     let(:token_info) { double(:user_fetcher, token_data: mock_token_data) }
     let(:mock_token_data) { double(:token_info) }
 
-    before { get :new, access_token: 'abc123' }
+    before { safe_get :new, access_token: 'abc123' }
 
     it 'initializes the token info service correctly' do
       token_data
-      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new).
-        with(request.params,
-             an_instance_of(ActionDispatch::Http::Headers),
-             warden)
+      expect(G5AuthenticatableApi::Services::TokenInfo)
+        .to have_received(:new)
+        .with(request.params,
+              an_instance_of(ActionDispatch::Http::Headers),
+              warden)
     end
 
     it 'returns the token data from the service' do
@@ -100,20 +105,21 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
     subject(:access_token) { controller.access_token }
 
     before do
-      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new).
-        and_return(token_info)
+      allow(G5AuthenticatableApi::Services::TokenInfo).to receive(:new)
+        .and_return(token_info)
     end
     let(:token_info) { double(:token_info, access_token: token_value) }
     let(:token_value) { 'abc123' }
 
-    before { get :new, access_token: token_value }
+    before { safe_get :new, access_token: token_value }
 
     it 'initializes the token info service correctly' do
       access_token
-      expect(G5AuthenticatableApi::Services::TokenInfo).to have_received(:new).
-        with(request.params,
-             an_instance_of(ActionDispatch::Http::Headers),
-             warden)
+      expect(G5AuthenticatableApi::Services::TokenInfo)
+        .to have_received(:new)
+        .with(request.params,
+              an_instance_of(ActionDispatch::Http::Headers),
+              warden)
     end
 
     it 'returns the access token from the service' do
@@ -125,20 +131,20 @@ describe G5AuthenticatableApi::Helpers::Rails, type: :controller do
     subject(:current_api_user) { controller.current_api_user }
 
     before do
-      allow(G5AuthenticatableApi::Services::UserFetcher).to receive(:new).
-        and_return(user_fetcher)
+      allow(G5AuthenticatableApi::Services::UserFetcher).to receive(:new)
+        .and_return(user_fetcher)
     end
     let(:user_fetcher) { double(:user_fetcher, current_user: user) }
     let(:user) { double(:user) }
 
-    before { get :new, access_token: 'abc123' }
+    before { safe_get :new, access_token: 'abc123' }
 
     it 'initializes the user fetcher service correctly' do
       current_api_user
-      expect(G5AuthenticatableApi::Services::UserFetcher).to have_received(:new).
-        with(request.params,
-             an_instance_of(ActionDispatch::Http::Headers),
-             warden)
+      expect(G5AuthenticatableApi::Services::UserFetcher).to have_received(:new)
+        .with(request.params,
+              an_instance_of(ActionDispatch::Http::Headers),
+              warden)
     end
 
     it 'returns the user from the service' do

data/spec/lib/g5_authenticatable_api/services/token_info_spec.rb

@@ -1,16 +1,18 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi::Services::TokenInfo do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi::Services::TokenInfo do
   subject(:token_info) { described_class.new(params, headers, warden) }
-  let(:params) { {'access_token' => token_value} }
-  let(:headers) { Hash.new }
+  let(:params) { { 'access_token' => token_value } }
+  let(:headers) { {} }
   let(:warden) {}
 
   let(:token_value) { 'abc123' }
 
   describe '#initialize' do
-    let(:params) { {'foo' => 'bar'} }
-    let(:headers) { {'Content-Type' => 'application/json'} }
+    let(:params) { { 'foo' => 'bar' } }
+    let(:headers) { { 'Content-Type' => 'application/json' } }
 
     context 'with warden' do
       let(:warden) { double(:warden) }
@@ -49,7 +51,7 @@ describe G5AuthenticatableApi::Services::TokenInfo do
     subject(:access_token) { token_info.access_token }
 
     context 'with auth header' do
-      let(:headers) { {'Authorization' => "Bearer #{token_value}"} }
+      let(:headers) { { 'Authorization' => "Bearer #{token_value}" } }
       let(:params) {}
 
       it 'should extract the token value from the header' do
@@ -58,7 +60,7 @@ describe G5AuthenticatableApi::Services::TokenInfo do
     end
 
     context 'with all caps authorization key' do
-      let(:headers) { {'AUTHORIZATION' => "Bearer #{token_value}"} }
+      let(:headers) { { 'AUTHORIZATION' => "Bearer #{token_value}" } }
       let(:params) {}
 
       it 'should extract the token value from the header' do
@@ -67,7 +69,7 @@ describe G5AuthenticatableApi::Services::TokenInfo do
     end
 
     context 'with auth param' do
-      let(:params) { {'access_token' => token_value} }
+      let(:params) { { 'access_token' => token_value } }
       let(:headers) {}
 
       it 'should extract the token value from the access_token parameter' do
@@ -89,7 +91,7 @@ describe G5AuthenticatableApi::Services::TokenInfo do
       end
 
       context 'with auth param' do
-        let(:params) { {'access_token' => token_value} }
+        let(:params) { { 'access_token' => token_value } }
         let(:headers) {}
 
         it 'should give precedence to the token on the request' do
@@ -106,19 +108,23 @@ describe G5AuthenticatableApi::Services::TokenInfo do
       include_context 'valid access token'
 
       it 'includes the resource_owner_id' do
-        expect(token_data.resource_owner_id).to eq(raw_token_info['resource_owner_id'])
+        expect(token_data.resource_owner_id)
+          .to eq(raw_token_info['resource_owner_id'])
       end
 
       it 'includes the expires_in_seconds' do
-        expect(token_data.expires_in_seconds).to eq(raw_token_info['expires_in_seconds'])
+        expect(token_data.expires_in_seconds)
+          .to eq(raw_token_info['expires_in_seconds'])
       end
 
       it 'includes the application_uid' do
-        expect(token_data.application_uid).to eq(raw_token_info['application']['uid'])
+        expect(token_data.application_uid)
+          .to eq(raw_token_info['application']['uid'])
       end
 
       it 'includes the scopes' do
-        expect(token_data.scopes). to eq(raw_token_info['scopes'])
+        expect(token_data.scopes)
+          .to eq(raw_token_info['scopes'])
       end
     end
 
@@ -126,7 +132,7 @@ describe G5AuthenticatableApi::Services::TokenInfo do
       include_context 'invalid access token'
 
       it 'raises an error' do
-        expect { token_data }.to raise_error
+        expect { token_data }.to raise_error(OAuth2::Error)
       end
     end
   end
@@ -145,14 +151,14 @@ describe G5AuthenticatableApi::Services::TokenInfo do
 
     it 'initializes the client with the token' do
       auth_client
-      expect(G5AuthenticationClient::Client).to have_received(:new).
-        with(hash_including(access_token: token_value))
+      expect(G5AuthenticationClient::Client).to have_received(:new)
+        .with(hash_including(access_token: token_value))
     end
 
     it 'disables password access on the client' do
       auth_client
-      expect(G5AuthenticationClient::Client).to have_received(:new).
-        with(hash_including(allow_password_credentials: 'false'))
+      expect(G5AuthenticationClient::Client).to have_received(:new)
+        .with(hash_including(allow_password_credentials: 'false'))
     end
   end
 end

data/spec/lib/g5_authenticatable_api/services/token_validator_spec.rb

@@ -1,12 +1,14 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi::Services::TokenValidator do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi::Services::TokenValidator do
   subject { validator }
 
   let(:validator) { described_class.new(params, headers, warden) }
 
   let(:headers) {}
-  let(:params) { {'access_token' => token_value} }
+  let(:params) { { 'access_token' => token_value } }
   let(:token_value) { 'abc123' }
   let(:warden) {}
 
@@ -19,8 +21,9 @@ describe G5AuthenticatableApi::Services::TokenValidator do
 
         it 'should initialize the auth client with the access token' do
           validate!
-          expect(a_request(:get, 'auth.g5search.com/oauth/token/info').
-                 with(headers: {'Authorization' => "Bearer #{token_value}"})).to have_been_made
+          expect(a_request(:get, 'auth.g5search.com/oauth/token/info')
+            .with(headers: { 'Authorization' => "Bearer #{token_value}" }))
+            .to have_been_made
         end
 
         it 'should not raise errors during validation' do
@@ -52,7 +55,9 @@ describe G5AuthenticatableApi::Services::TokenValidator do
 
     context 'when token is on the warden user' do
       let(:warden) { double(:warden, user: user) }
-      let(:user) { FactoryGirl.build_stubbed(:user, g5_access_token: token_value) }
+      let(:user) do
+        FactoryGirl.build_stubbed(:user, g5_access_token: token_value)
+      end
       let(:params) {}
       let(:headers) {}
 
@@ -64,8 +69,9 @@ describe G5AuthenticatableApi::Services::TokenValidator do
 
           it 'should validate the access token against the auth server' do
             validate!
-            expect(a_request(:get, 'auth.g5search.com/oauth/token/info').
-                  with(headers: {'Authorization' => "Bearer #{token_value}"})).to have_been_made
+            expect(a_request(:get, 'auth.g5search.com/oauth/token/info')
+              .with(headers: { 'Authorization' => "Bearer #{token_value}" }))
+              .to have_been_made
           end
 
           it 'should not raise errors during validation' do
@@ -87,7 +93,8 @@ describe G5AuthenticatableApi::Services::TokenValidator do
 
         it 'should not validate the access token against the auth server' do
           validate!
-          expect(a_request(:get, 'authg5search.com/oauth/token/info')).to_not have_been_made
+          expect(a_request(:get, 'authg5search.com/oauth/token/info'))
+            .to_not have_been_made
         end
 
         it 'should not raise errors during validation' do
@@ -138,7 +145,8 @@ describe G5AuthenticatableApi::Services::TokenValidator do
       end
 
       it 'should set an error on the validator' do
-        expect { valid? }.to change { validator.error }.from(nil).to(an_instance_of(OAuth2::Error))
+        expect { valid? }.to change { validator.error }
+          .from(nil).to(an_instance_of(OAuth2::Error))
       end
     end
 
@@ -151,8 +159,8 @@ describe G5AuthenticatableApi::Services::TokenValidator do
       end
 
       it 'should set an error on the validator' do
-        expect { valid? }.to change { validator.error }.
-          from(nil).to(an_instance_of(RuntimeError))
+        expect { valid? }.to change { validator.error }
+          .from(nil).to(an_instance_of(RuntimeError))
       end
     end
   end

data/spec/lib/g5_authenticatable_api/services/user_fetcher_spec.rb

@@ -1,8 +1,10 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi::Services::UserFetcher do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi::Services::UserFetcher do
   subject(:user_fetcher) { described_class.new(params, headers, warden) }
-  let(:params) { {'access_token' => token_value} }
+  let(:params) { { 'access_token' => token_value } }
   let(:token_value) { 'abc123' }
   let(:headers) {}
   let(:warden) {}

data/spec/lib/g5_authenticatable_api/version_spec.rb

@@ -1,6 +1,8 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
-describe G5AuthenticatableApi do
+require 'rails_helper'
+
+RSpec.describe G5AuthenticatableApi do
   it 'should have a version' do
     expect(G5AuthenticatableApi::VERSION).to be
   end