fxpotato 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 96bf1466205c0392c90b1ba4756c74b9a54d674f
-  data.tar.gz: 8db3edee83c0397ed6802bcdaf0d5242e74e4449
+  metadata.gz: 4dc221a4fe6ed20600d9588fec08eb89c9fc587a
+  data.tar.gz: e5e02f7941cdc9a2321a57238cc92e4edbc471fc
 SHA512:
-  metadata.gz: d334930ca7e6a9c78bed5abbf01aea3ecd4475d6109ae5626c9f67d563a998a924809b99011eb14eea2068f126c9c265833be9ec54a052d5a150f3c9181d44ad
-  data.tar.gz: 34a0381d4baf8ad59f18143e075fbcc5e51ca1e47383411124fc3827d9eb7f311a1b855c22c99eae1dc710e466508e73e131b8497a7ae01adf709ea9747192be
+  metadata.gz: 1bc64f9b24257b055faea693b8a752ad31c7064348e910d788c25fc6c89d4667d0d269677e03edaa324c29754d2dae87fa658e0b2eeaa754f7df33e3a23a6929
+  data.tar.gz: 61d2c2c95b29822e01fc9d917f473ab5ed7e54fda7d72efc233b58c751ed69d97808f754fe14191ce09b46ae51e611ef3393694255b37c8ed5bd9cd62182a39a

data/Dockerfile

@@ -15,4 +15,4 @@ RUN bundle install
 
 COPY . /usr/src/app/
 
-CMD bundle exec cucumber features && rake test
+CMD rake test

data/Rakefile

@@ -2,7 +2,7 @@ require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'fxpotato'
 
-Rake::TestTask.new(:test) do |t|
+Rake::TestTask.new(:unit_test) do |t|
   t.libs << 'test'
   t.libs << 'lib'
   t.test_files = FileList['test/**/*_test.rb']
@@ -25,7 +25,12 @@ end
 
 desc "Build, test, bump version, and release in a container"
 task :docker_release do
-  sh %{ docker build --force-rm -t fx-potato . && docker run --rm fx-potato bundle exec cucumber features && rake test && gem bump && rake release }
+  sh %{ docker build --force-rm -t fx-potato . && docker run --rm fx-potato rake test && gem bump && rake release }
 end
 
-task :default => :test
+desc "Run feature and unit tests"
+task :test => :unit_test do
+  sh %{ bundle exec cucumber features }
+end
+
+task :default => :unit_test

data/lib/fxpotato/cli.rb

@@ -1,12 +1,14 @@
 require 'thor'
 require 'fxpotato'
+require 'date'
 
 module FxPotato
   class CLI < Thor
     desc "getrate BASE TARGET", "Gets the foreign exchange rate for the given currencies on the chosen date."
-    method_option :date, :aliases => "-d"
+    method_option :date, :aliases => "-d", :desc => "A specific date to get the rate for, e.g. -d 2017-05-29"
     def getrate(base, target)
-      puts FxPotato.at(options[:date] || Date.today, base, target)
+      date = options[:date] || Date.today
+      puts "Exchange rate from #{base} to #{target} on #{date}: #{FxPotato.at(date, base, target)}"
     end
   end
 end

data/lib/fxpotato/version.rb

@@ -1,3 +1,3 @@
 module FxPotato
-  VERSION = '0.2.5'
+  VERSION = '0.2.6'
 end

data/lib/fxpotato/xml_repo.rb

@@ -15,7 +15,8 @@ module FxPotato
 
     def find(date, currency)
       query = "//Cube[@time=\'#{date.to_s}\']//Cube[@currency=\'#{currency}\']"
-      @data.at_xpath(query)["rate"].to_f
+      result = @data.at_xpath(query)
+      result ? result["rate"].to_f : nil
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fxpotato
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Liam Stupid Name Humphreys