furnish 0.0.2 → 0.0.3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+* 0.0.3 (03/21/2013)
+  * Fix an issue where state wasn't tracked for provisioners themselves after the provisioning process had started.
+
 * 0.0.2 (03/20/2013)
   * Extract Furnish::TestCase into gem for consumption by other gems that need to test against furnish.
 

data/lib/furnish/provisioner_group.rb

@@ -65,6 +65,9 @@ module Furnish
     # provisioning halts, effectively creating a chain of responsibility
     # pattern.
     #
+    # If a block is provided, will yield self to it for each step through the
+    # group.
+    #
     def startup(*args)
       each do |this_prov|
         unless args = this_prov.startup(args)
@@ -74,6 +77,8 @@ module Furnish
 
           raise "Could not provision #{this_prov.name} with provisioner #{this_prov.class.name}"
         end
+
+        yield self if block_given?
       end
 
       return true

data/lib/furnish/provisioners/dummy.rb

@@ -46,7 +46,7 @@ module Furnish
       #
       def report
         do_delegate(__method__) do
-          [name]
+          [name, @persist]
         end
       end
 
@@ -54,6 +54,7 @@ module Furnish
       # startup shim
       #
       def startup(*args)
+        @persist = "floop"
         do_delegate(__method__) do
           true
         end

data/lib/furnish/scheduler.rb

@@ -338,7 +338,13 @@ module Furnish
 
       # FIXME maybe a way to specify initial args?
       args = nil
-      provisioner.startup
+
+      provisioner.startup do |this_prov|
+        vm.groups[group_name] = this_prov
+      end
+
+      vm.groups[group_name] = provisioner
+
       @queue << group_name
     end
 

data/lib/furnish/version.rb

@@ -1,4 +1,4 @@
 module Furnish
   # The current version of Furnish.
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/mt_cases.rb

@@ -49,6 +49,34 @@ module Furnish
       assert(provisioner.store[ [name, "shutdown"].join("-") ], "dummy provisioner for #{name} recorded the shutdown run")
     end
 
+    def test_run_tracking
+      #--
+      # This is a tad convoluted. Dummy's startup method sets an ivar which
+      # should be persisted. Then, we retrieve it by examining the result of
+      # the report method, which regurgitates it.
+      #
+      # This ensures that after startup, the provisioner has had its state
+      # tracked, ensuring the correct state.
+      #++
+
+      assert(sched.schedule_provision('test1', Dummy.new))
+      sched.run
+      sched.wait_for('test1')
+      assert_started('test1')
+      assert_equal("floop", sched.vm.groups['test1'].first.report.last, 'state was stored after provision success')
+
+      assert(sched.schedule_provision('test2', [Dummy.new, StartFailDummy.new], []))
+
+      # the next few lines are an unfortunate necessity, sorry.
+      @monitor.kill rescue nil
+      assert_raises(RuntimeError) do
+        sched.run
+        sleep 0.1 while sched.running?
+      end
+
+      assert_equal("floop", sched.vm.groups['test2'].first.report.last, "provision failed but state is still stored for the provisions that succeeded")
+    end
+
     def test_provision_cycle
       machine_names = %w[blarg blarg2 blarg3]
 

data/test/test_dummy.rb

@@ -17,7 +17,7 @@ class TestDummy < Furnish::TestCase
     dummy.name = 'dummy_test'
     assert(dummy.startup, 'startup returns true by default')
     assert(dummy.shutdown, 'shutdown returns true by default')
-    assert_equal(['dummy_test'], dummy.report, 'report returns boxed name by default')
+    assert_equal(['dummy_test', 'floop'], dummy.report, 'report returns boxed name and ivar by default')
 
     obj = Palsy::Object.new('dummy')
     %w[startup shutdown report].each do |meth|
@@ -75,7 +75,7 @@ class TestDummy < Furnish::TestCase
     dummy.name = "dummy_marshal_test"
     assert(dummy.startup)
     assert(dummy.shutdown)
-    assert_equal([dummy.name], dummy.report)
+    assert_equal([dummy.name, 'floop'], dummy.report)
 
     obj = Palsy::Object.new('dummy')
     %w[startup shutdown report].each do |meth|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: furnish
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-20 00:00:00.000000000 Z
+date: 2013-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: palsy