functional-light-service 0.5.4 → 6.0.0

data/spec/testing/context_factory_spec.rb

@@ -4,6 +4,10 @@ require "test_doubles"
 describe "ContextFactory - used with AdditionOrganizer" do
   let(:organizer) { TestDoubles::AdditionOrganizer }
 
+  after do
+    TestDoubles::AdditionOrganizer.before_actions = nil
+  end
+
   context "when called with the first action" do
     it "does not alter the context" do
       ctx = FunctionalLightService::Testing::ContextFactory
@@ -52,4 +56,21 @@ describe "ContextFactory - used with AdditionOrganizer" do
       expect(context[:_before_actions].length).to eq(1)
     end
   end
+
+  context "when used repeatedly" do
+    it "does not leave its temporary hook on the organizer class" do
+      2.times do
+        FunctionalLightService::Testing::ContextFactory
+          .make_from(organizer)
+          .for(TestDoubles::AddsTwoAction)
+          .with(1)
+      end
+
+      hooks = organizer.instance_variable_get(:@before_actions)
+      expect(hooks.nil? || hooks.empty?).to be(true)
+
+      # e l'organizer continua a funzionare normalmente
+      expect(organizer.call(1).fetch(:number)).to eq(7)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: functional-light-service
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 6.0.0
 platform: ruby
 authors:
 - Boscolo Michele
@@ -13,22 +13,22 @@ dependencies:
   name: dry-inflector
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.2.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -50,207 +50,149 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.8.11
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: logger
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.0.6
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.6
-  type: :development
+        version: '1.5'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 13.0.6
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.6
+        version: '1.5'
 - !ruby/object:Gem::Dependency
-  name: i18n
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.8.11
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.8.11
-- !ruby/object:Gem::Dependency
-  name: dry-inflector
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.2.1
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
+        version: '3.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.10.0
-- !ruby/object:Gem::Dependency
-  name: rspec-mocks
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.10.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 3.10.2
+        version: '3.13'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.2
+        version: '0.22'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.21.2
+        version: '0.22'
 - !ruby/object:Gem::Dependency
   name: simplecov-cobertura
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
-- !ruby/object:Gem::Dependency
-  name: rexml
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: '1.75'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: '1.75'
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.2
+        version: '1.20'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.2
+        version: '1.20'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '0.15'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.1
+        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: solargraph
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.44.2
+        version: '0.50'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.44.2
+        version: '0.50'
 - !ruby/object:Gem::Dependency
-  name: nokogiri
+  name: benchmark-ips
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.5
+        version: '2.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.12.5
-description: A service skeleton with an emphasis on simplicity with a pinch a functional
-  programming
+        version: '2.13'
+description: 'FunctionalLightService combines the Organizer/Action/Context pattern
+  of LightService with functional programming constructs (Result/Option monads, pattern
+  matching) inspired by Deterministic: complex workflows are organized into small
+  single-purpose actions with functional error handling.'
 email:
 - miboscol@gmail.com
 executables: []
@@ -262,6 +204,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".solargraph.yml"
+- AUDIT-functional-light-service.md
 - Appraisals
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -270,6 +213,8 @@ files:
 - README.md
 - Rakefile
 - VERSION
+- audit/bench.rb
+- audit/verify_findings.rb
 - functional-light-service.gemspec
 - gemfiles/dry_inflector_0_2_1.gemfile
 - gemfiles/i18n_1_8_11.gemfile
@@ -278,6 +223,7 @@ files:
 - lib/functional-light-service/configuration.rb
 - lib/functional-light-service/context.rb
 - lib/functional-light-service/context/key_verifier.rb
+- lib/functional-light-service/deprecations.rb
 - lib/functional-light-service/errors.rb
 - lib/functional-light-service/functional/enum.rb
 - lib/functional-light-service/functional/maybe.rb
@@ -292,7 +238,6 @@ files:
 - lib/functional-light-service/organizer/reduce_if.rb
 - lib/functional-light-service/organizer/reduce_until.rb
 - lib/functional-light-service/organizer/scoped_reducable.rb
-- lib/functional-light-service/organizer/verify_call_method_exists.rb
 - lib/functional-light-service/organizer/with_callback.rb
 - lib/functional-light-service/organizer/with_reducer.rb
 - lib/functional-light-service/organizer/with_reducer_factory.rb
@@ -309,11 +254,10 @@ files:
 - spec/acceptance/around_each_spec.rb
 - spec/acceptance/before_actions_spec.rb
 - spec/acceptance/custom_log_from_organizer_spec.rb
+- spec/acceptance/deprecation_warnings_spec.rb
 - spec/acceptance/fail_spec.rb
-- spec/acceptance/include_warning_spec.rb
 - spec/acceptance/log_from_organizer_spec.rb
 - spec/acceptance/message_localization_spec.rb
-- spec/acceptance/not_having_call_method_warning_spec.rb
 - spec/acceptance/organizer/add_aliases_spec.rb
 - spec/acceptance/organizer/add_to_context_spec.rb
 - spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
@@ -323,6 +267,7 @@ files:
 - spec/acceptance/organizer/reduce_if_spec.rb
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
+- spec/acceptance/organizer_entry_point_spec.rb
 - spec/acceptance/rollback_spec.rb
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
@@ -345,7 +290,9 @@ files:
 - spec/lib/deterministic/result/result_shared.rb
 - spec/lib/deterministic/result/success_spec.rb
 - spec/lib/deterministic/result_spec.rb
+- spec/lib/edge_cases_spec.rb
 - spec/lib/enum_spec.rb
+- spec/lib/native_pattern_matching_spec.rb
 - spec/localization_adapter_spec.rb
 - spec/organizer/with_reducer_spec.rb
 - spec/organizer_key_aliases_spec.rb
@@ -378,7 +325,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.6.0
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -389,67 +336,4 @@ rubygems_version: 3.6.9
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity with a pinch a functional
   programming
-test_files:
-- spec/acceptance/add_numbers_spec.rb
-- spec/acceptance/after_actions_spec.rb
-- spec/acceptance/around_each_spec.rb
-- spec/acceptance/before_actions_spec.rb
-- spec/acceptance/custom_log_from_organizer_spec.rb
-- spec/acceptance/fail_spec.rb
-- spec/acceptance/include_warning_spec.rb
-- spec/acceptance/log_from_organizer_spec.rb
-- spec/acceptance/message_localization_spec.rb
-- spec/acceptance/not_having_call_method_warning_spec.rb
-- spec/acceptance/organizer/add_aliases_spec.rb
-- spec/acceptance/organizer/add_to_context_spec.rb
-- spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
-- spec/acceptance/organizer/context_failure_and_skipping_spec.rb
-- spec/acceptance/organizer/execute_spec.rb
-- spec/acceptance/organizer/iterate_spec.rb
-- spec/acceptance/organizer/reduce_if_spec.rb
-- spec/acceptance/organizer/reduce_until_spec.rb
-- spec/acceptance/organizer/with_callback_spec.rb
-- spec/acceptance/rollback_spec.rb
-- spec/acceptance/testing/context_factory_spec.rb
-- spec/action_expected_keys_spec.rb
-- spec/action_expects_and_promises_spec.rb
-- spec/action_promised_keys_spec.rb
-- spec/action_spec.rb
-- spec/context/inspect_spec.rb
-- spec/context_spec.rb
-- spec/examples/amount_spec.rb
-- spec/examples/controller_spec.rb
-- spec/examples/validate_address_spec.rb
-- spec/lib/deterministic/class_mixin_spec.rb
-- spec/lib/deterministic/currify_spec.rb
-- spec/lib/deterministic/monad_axioms.rb
-- spec/lib/deterministic/monad_spec.rb
-- spec/lib/deterministic/null_spec.rb
-- spec/lib/deterministic/option_spec.rb
-- spec/lib/deterministic/result/failure_spec.rb
-- spec/lib/deterministic/result/result_map_spec.rb
-- spec/lib/deterministic/result/result_shared.rb
-- spec/lib/deterministic/result/success_spec.rb
-- spec/lib/deterministic/result_spec.rb
-- spec/lib/enum_spec.rb
-- spec/localization_adapter_spec.rb
-- spec/organizer/with_reducer_spec.rb
-- spec/organizer_key_aliases_spec.rb
-- spec/organizer_spec.rb
-- spec/readme_spec.rb
-- spec/sample/calculates_order_tax_action_spec.rb
-- spec/sample/calculates_tax_spec.rb
-- spec/sample/looks_up_tax_percentage_action_spec.rb
-- spec/sample/provides_free_shipping_action_spec.rb
-- spec/sample/tax/calculates_order_tax_action.rb
-- spec/sample/tax/calculates_tax.rb
-- spec/sample/tax/looks_up_tax_percentage_action.rb
-- spec/sample/tax/provides_free_shipping_action.rb
-- spec/spec_helper.rb
-- spec/support.rb
-- spec/test_doubles.rb
-- spec/testing/context_factory/iterate_spec.rb
-- spec/testing/context_factory/reduce_if_spec.rb
-- spec/testing/context_factory/reduce_until_spec.rb
-- spec/testing/context_factory/with_callback_spec.rb
-- spec/testing/context_factory_spec.rb
+test_files: []

data/lib/functional-light-service/organizer/verify_call_method_exists.rb

@@ -1,29 +0,0 @@
-module FunctionalLightService
-  module Organizer
-    # We need to make sure existing users will
-    # use `call` method name going forward.
-    # This should be removed eventually.
-    class VerifyCallMethodExists
-      def self.run(klass, first_caller = '')
-        invoker_method = caller_method(first_caller)
-        return if invoker_method == 'call'
-
-        call_method_exists = klass.methods.include?(:call)
-        return if call_method_exists
-
-        warning_msg = "DEPRECATION WARNING:" \
-                      "The <#{klass.name}> class is an organizer, " \
-                      "its entry method (the one that calls with & reduce) " \
-                      "should be named `call`. " \
-                      "Please use #{klass}.call going forward."
-        print warning_msg
-      end
-
-      def self.caller_method(first_caller)
-        return nil unless first_caller =~ /`(.*)'/
-
-        Regexp.last_match[1]
-      end
-    end
-  end
-end

data/spec/acceptance/include_warning_spec.rb

@@ -1,29 +0,0 @@
-require 'spec_helper'
-
-describe "Including is discouraged" do
-  context "when including FunctionalLightService::Organizer" do
-    it "gives warning" do
-      expected_msg = "DEPRECATION WARNING:\n" \
-                     "Including FunctionalLightService::Organizer is deprecated\n" \
-                     "Please use `extend FunctionalLightService::Organizer` instead"
-      expect do
-        class OrganizerIncludingLS
-          include FunctionalLightService::Organizer
-        end
-      end.to output(expected_msg).to_stdout
-    end
-  end
-
-  context "when including FunctionalLightService::Action" do
-    it "gives warning" do
-      expected_msg = "DEPRECATION WARNING:\n" \
-                     "Including FunctionalLightService::Action is deprecated\n" \
-                     "Please use `extend FunctionalLightService::Action` instead"
-      expect do
-        class ActionIncludingLS
-          include FunctionalLightService::Action
-        end
-      end.to output(expected_msg).to_stdout
-    end
-  end
-end