functional-light-service 0.4.4 → 0.5.4

data/Rakefile

@@ -9,4 +9,4 @@ RuboCop::RakeTask.new
 RSpec::Core::RakeTask.new(:spec)
 
 task(:default).clear
-task :default => %i[spec rubocop]
+task :default => %i[spec rubocop]

data/VERSION

@@ -1 +1 @@
-0.4.4
+0.5.4

data/functional-light-service.gemspec

@@ -21,11 +21,16 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency("i18n", "~> 1.8", ">= 1.8.11")
   
 
+  gem.add_development_dependency("rake", "~> 13.0.6", ">= 13.0.6")
   gem.add_development_dependency("i18n", "~> 1.8", ">= 1.8.11")
   gem.add_development_dependency("dry-inflector", "~> 0.2", ">= 0.2.1")
   gem.add_development_dependency("rspec", "~> 3.10.0")
+  gem.add_development_dependency("rspec-mocks", "= 3.10.2")
   gem.add_development_dependency("simplecov", "~> 0.21.2")
   gem.add_development_dependency("simplecov-cobertura", "~> 2.1.0")
+  # rexml >= 3.3 ha un parser XML piu severo che rompe simplecov-cobertura 2.1.0
+  # (Malformed XML: No root element). Blocco alla 3.2.x compatibile.
+  gem.add_development_dependency("rexml", "< 3.3")
   gem.add_development_dependency("rubocop", "~> 1.25.0")
   gem.add_development_dependency("rubocop-performance", "~> 1.13.2")
   gem.add_development_dependency("pry", "~> 0.14.1")

data/lib/functional-light-service/context.rb

@@ -3,7 +3,7 @@ module FunctionalLightService
   class Context < Hash
     include FunctionalLightService::Prelude::Option
     include FunctionalLightService::Prelude::Result
-    attr_accessor :outcome, :current_action
+    attr_accessor :outcome, :current_action, :organized_by
 
     # rubocop:disable Lint/MissingSuper
     def initialize(context = {},

data/lib/functional-light-service/organizer/with_reducer.rb

@@ -2,9 +2,15 @@ module FunctionalLightService
   module Organizer
     class WithReducer
       attr_reader :context
+      attr_accessor :organizer
+
+      def initialize(monitored_organizer = nil)
+        @organizer = monitored_organizer
+      end
 
       def with(data = {})
         @context = FunctionalLightService::Context.make(data)
+        @context.organized_by = organizer
         self
       end
 

data/lib/functional-light-service/organizer/with_reducer_factory.rb

@@ -3,7 +3,7 @@ module FunctionalLightService
     class WithReducerFactory
       def self.make(monitored_organizer)
         logger = monitored_organizer.logger || FunctionalLightService::Configuration.logger
-        decorated = WithReducer.new
+        decorated = WithReducer.new(monitored_organizer)
 
         return decorated if logger.nil?
 

data/lib/functional-light-service/organizer/with_reducer_log_decorator.rb

@@ -8,6 +8,9 @@ module FunctionalLightService
       def initialize(organizer, logger:, decorated: WithReducer.new)
         @decorated = decorated
         @organizer = organizer
+
+        decorated.organizer = organizer
+
         @logger = logger
         @logged = false
       end

data/lib/functional-light-service/organizer.rb

@@ -63,6 +63,16 @@ module FunctionalLightService
       def logger
         @logger
       end
+
+      def add_to_context(**args)
+        args.map do |key, value|
+          execute(->(ctx) { ctx[key.to_sym] = value })
+        end
+      end
+
+      def add_aliases(args)
+        execute(->(ctx) { ctx.assign_aliases(ctx.aliases.merge(args)) })
+      end
     end
 
     module Macros

data/lib/functional-light-service/version.rb

@@ -1,3 +1,3 @@
 module FunctionalLightService
-  VERSION = "0.4.4".freeze
+  VERSION = "0.5.4".freeze
 end

data/spec/acceptance/organizer/add_aliases_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+RSpec.describe FunctionalLightService::Organizer do
+  class TestAddAliases
+    extend FunctionalLightService::Organizer
+
+    def self.call(context = FunctionalLightService::Context.make)
+      with(context).reduce(steps)
+    end
+
+    def self.steps
+      [
+        add_to_context(:my_message => "Hello There"),
+        # This will add the alias `:a_message` which points
+        # to the :my_message key's value
+        add_aliases(:my_message => :a_message),
+        TestDoubles::CapitalizeMessage
+      ]
+    end
+  end
+
+  it "adds aliases to the context embedded in the series of actions" do
+    result = TestAddAliases.call
+
+    expect(result).to be_success
+    expect(result.final_message).to eq("HELLO THERE")
+  end
+end

data/spec/acceptance/organizer/add_to_context_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+RSpec.describe FunctionalLightService::Organizer do
+  class TestAddToContext
+    extend FunctionalLightService::Organizer
+
+    def self.call(context = FunctionalLightService::Context.make)
+      with(context).reduce(steps)
+    end
+
+    def self.steps
+      [
+        # This will add the `:number` key to the context
+        # with the value of 0, so it's available for
+        # AddsOneAction
+        add_to_context(:number => 0),
+        TestDoubles::AddsOneAction,
+        add_to_context(:something => "hello")
+      ]
+    end
+  end
+
+  it "adds items to the context on the fly" do
+    result = TestAddToContext.call
+
+    expect(result).to be_success
+    expect(result.number).to eq(1)
+    expect(result[:something]).to eq("hello")
+  end
+end

data/spec/acceptance/organizer/iterate_spec.rb

@@ -20,6 +20,13 @@ RSpec.describe FunctionalLightService::Organizer do
     expect(result.number).to eq(5)
   end
 
+  it "knows that it's being iterated from within an organizer" do
+    result = TestDoubles::TestIterate.call(:number => 1,
+                                           :counters => [1, 2, 3, 4])
+
+    expect(result.organized_by).to eq TestDoubles::TestIterate
+  end
+
   it 'will not iterate over a failed context' do
     empty_context.fail!('Something bad happened')
 

data/spec/acceptance/organizer/reduce_if_spec.rb

@@ -49,6 +49,12 @@ RSpec.describe FunctionalLightService::Organizer do
     expect(result).to be_success
   end
 
+  it "knows that it's being conditionally reduced from within an organizer" do
+    result = TestReduceIf.call(:number => 2)
+
+    expect(result.organized_by).to eq TestReduceIf
+  end
+
   it 'skips actions within in its own scope' do
     org = Class.new do
       extend FunctionalLightService::Organizer

data/spec/acceptance/organizer/reduce_until_spec.rb

@@ -40,4 +40,10 @@ RSpec.describe FunctionalLightService::Organizer do
     result = TestReduceUntil.call(empty_context)
     expect(result).to be_success
   end
+
+  it "is expected to know its organizer when reducing until a condition" do
+    result = TestReduceUntil.call(:number => 1)
+
+    expect(result.organized_by).to eq TestReduceUntil
+  end
 end

data/spec/action_spec.rb

@@ -68,6 +68,14 @@ describe FunctionalLightService::Action do
     expect(result.to_hash).to eq(:number => 2)
   end
 
+  context "when called directly" do
+    it "is expected to not be organized" do
+      result = TestDoubles::AddsTwoActionWithFetch.execute(context)
+
+      expect(result.organized_by).to be_nil
+    end
+  end
+
   context "when invoked with hash" do
     it "creates FunctionalLightService::Context implicitly" do
       ctx = { :some_key => "some value" }

data/spec/lib/deterministic/option_spec.rb

@@ -72,27 +72,31 @@ describe FunctionalLightService::Option do
   end
 
   it "match" do
-    # expect(
-    #   Some(0).match do
-    #     Some(where { s == 1 }) { |_s| 99 }
-    #     Some(where { s == 0 }) { |s| s + 1 }
-    #     None() {}
-    #   end
-    # ).to eq 1
+    expect(
+      # rubocop:disable Lint/UnusedBlockArgument
+      # rubocop:disable Lint/EmptyBlock
+      Some(0).match do
+        Some(where { s == 1 }) { |s| 99 }
+        Some(where { s == 0 }) { |s| s + 1 }
+        None() {}
+      end
+    ).to eq 1
 
     expect(
       Some(1).match do
         None() { 0 }
-        Some() { |_s| 1 }
+        Some() { |s| 1 }
       end
     ).to eq 1
 
-    # expect(
-    #   Some(1).match do
-    #     None() { 0 }
-    #     Some(where { s.is_a? Integer }) { |_s| 1 }
-    #   end
-    # ).to eq 1
+    expect(
+      Some(1).match do
+        None() { 0 }
+        Some(where { s.is_a? Integer }) { |s| 1 }
+      end
+      # rubocop:enable Lint/UnusedBlockArgument
+      # rubocop:enable Lint/EmptyBlock
+    ).to eq 1
 
     expect(
       None.match do

data/spec/organizer_spec.rb

@@ -19,6 +19,11 @@ describe FunctionalLightService::Organizer do
       result = TestDoubles::AnOrganizer.call(:user => user)
       expect(result).to eq(ctx)
     end
+
+    it "sets itself as the organizer" do
+      result = TestDoubles::AnOrganizer.call(:user => user)
+      expect(result.organized_by).to eq TestDoubles::AnOrganizer
+    end
   end
 
   context "when #with is called with Context" do
@@ -90,4 +95,20 @@ describe FunctionalLightService::Organizer do
       expect(reduced).to eq(ctx)
     end
   end
+
+  context "can add items to the context" do
+    specify 'with #add_to_context' do
+      result = TestDoubles::AnOrganizerThatAddsToContext.call
+      expect(result[:strongest_avenger]).to eq :thor
+      expect(result[:last_jedi]).to eq "Rey"
+    end
+  end
+
+  context "can assign key aliaeses" do
+    it 'with #add_aliases' do
+      result = TestDoubles::AnOrganizerThatAddsAliases.call
+      expect(result[:foo]).to eq :bar
+      expect(result[:baz]).to eq :bar
+    end
+  end
 end

data/spec/sample/provides_free_shipping_action_spec.rb

@@ -15,7 +15,7 @@ describe ProvidesFreeShippingAction do
   end
 
   context "when the order total with tax is <= 200" do
-    specify "order gets free shipping" do
+    specify "order does not get free shipping" do
       allow(order).to receive_messages(:total_with_tax => 200)
       expect(order).not_to receive(:provide_free_shipping!)
 

data/spec/spec_helper.rb

@@ -1,21 +1,23 @@
 $LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
 $LOAD_PATH << File.join(File.dirname(__FILE__))
 
-require 'simplecov'
+if ENV['RUN_COVERAGE_REPORT']
+  require 'simplecov'
 
-SimpleCov.start do
-  add_filter 'vendor/'
-  add_filter %r{^/spec/}
-end
+  SimpleCov.start do
+    add_filter 'vendor/'
+    add_filter %r{^/spec/}
+  end
 
-SimpleCov.minimum_coverage_by_file 90
+  SimpleCov.minimum_coverage_by_file 90
 
-require 'simplecov-cobertura'
-SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter
+  require "simplecov-cobertura"
+  SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter
+end
 
-require 'functional-light-service'
-require 'functional-light-service/testing'
+require "functional-light-service"
+require "functional-light-service/testing"
 require "functional-light-service/functional/null"
-require 'support'
-require 'test_doubles'
-require 'stringio'
+require "support"
+require "test_doubles"
+require "stringio"

data/spec/test_doubles.rb

@@ -561,4 +561,39 @@ module TestDoubles
       ctx.total += ctx.number
     end
   end
+
+  class CapitalizeMessage
+    extend FunctionalLightService::Action
+    expects :a_message
+    promises :final_message
+
+    executed do |ctx|
+      ctx.final_message = ctx.a_message.upcase
+    end
+  end
+
+  class AnOrganizerThatAddsToContext
+    extend FunctionalLightService::Organizer
+    def self.call
+      with.reduce(actions)
+    end
+
+    def self.actions
+      [add_to_context(
+        :strongest_avenger => :thor,
+        :last_jedi => "Rey"
+      )]
+    end
+  end
+
+  class AnOrganizerThatAddsAliases
+    extend FunctionalLightService::Organizer
+    def self.call
+      with(:foo => :bar).reduce(actions)
+    end
+
+    def self.actions
+      [add_aliases(:foo => :baz)]
+    end
+  end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: functional-light-service
 version: !ruby/object:Gem::Version
-  version: 0.4.4
+  version: 0.5.4
 platform: ruby
 authors:
 - Boscolo Michele
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-27 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-inflector
@@ -50,6 +49,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.8.11
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 13.0.6
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 13.0.6
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 13.0.6
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 13.0.6
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
@@ -104,6 +123,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.10.0
+- !ruby/object:Gem::Dependency
+  name: rspec-mocks
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.10.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 3.10.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -132,6 +165,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.1.0
+- !ruby/object:Gem::Dependency
+  name: rexml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.3'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -215,7 +262,6 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".solargraph.yml"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -268,6 +314,8 @@ files:
 - spec/acceptance/log_from_organizer_spec.rb
 - spec/acceptance/message_localization_spec.rb
 - spec/acceptance/not_having_call_method_warning_spec.rb
+- spec/acceptance/organizer/add_aliases_spec.rb
+- spec/acceptance/organizer/add_to_context_spec.rb
 - spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
 - spec/acceptance/organizer/context_failure_and_skipping_spec.rb
 - spec/acceptance/organizer/execute_spec.rb
@@ -323,7 +371,6 @@ homepage: https://github.com/sphynx79/functional-light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -338,8 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.28
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity with a pinch a functional
   programming
@@ -354,6 +400,8 @@ test_files:
 - spec/acceptance/log_from_organizer_spec.rb
 - spec/acceptance/message_localization_spec.rb
 - spec/acceptance/not_having_call_method_warning_spec.rb
+- spec/acceptance/organizer/add_aliases_spec.rb
+- spec/acceptance/organizer/add_to_context_spec.rb
 - spec/acceptance/organizer/around_each_with_reduce_if_spec.rb
 - spec/acceptance/organizer/context_failure_and_skipping_spec.rb
 - spec/acceptance/organizer/execute_spec.rb

data/.travis.yml

@@ -1,24 +0,0 @@
-language: ruby
-
-env:
-  - RUN_COVERAGE_REPORT=true
-
-rvm:
-  - 2.6.6
-  - 2.7.2
-  - 3.0.0
-
-before_install:
-  - 'echo ''gem: --no-ri --no-rdoc'' > ~/.gemrc'
-  - yes | gem update --system --force
-  - gem install bundler
-  - bundle install --gemfile=Gemfile --clean --path vendor/bundle
-
-# uncomment this line if your project needs to run something other than `rake`:
-script:
-  - bundle exec rspec spec
-  - bundle exec rubocop
-
-gemfile:
-  - gemfiles/dry_inflector_0_2_1.gemfile
-  - gemfiles/i18n_1_8_11.gemfile