functional-light-service 0.2.5 → 0.4.4

data/spec/acceptance/not_having_call_method_warning_spec.rb

@@ -4,10 +4,6 @@ require 'test_doubles'
 describe "Organizer should invoke with/reduce from a call method" do
   context "when the organizer does not have a `call` method" do
     it "gives warning" do
-      expect(ActiveSupport::Deprecation)
-        .to receive(:warn)
-        .with(/^The <OrganizerWithoutCallMethod> class is an organizer/)
-
       class OrganizerWithoutCallMethod
         extend FunctionalLightService::Organizer
 
@@ -15,16 +11,14 @@ describe "Organizer should invoke with/reduce from a call method" do
           reduce([])
         end
       end
-
-      OrganizerWithoutCallMethod.do_something
+      expect do
+        OrganizerWithoutCallMethod.do_something
+      end.to output(/The <OrganizerWithoutCallMethod> class is an organizer/).to_stdout
     end
   end
 
   context "when the organizer has the `call` method" do
     it "does not issue a warning" do
-      expect(ActiveSupport::Deprecation)
-        .not_to receive(:warn)
-
       class OrganizerWithCallMethod
         extend FunctionalLightService::Organizer
 
@@ -32,8 +26,7 @@ describe "Organizer should invoke with/reduce from a call method" do
           reduce([])
         end
       end
-
-      OrganizerWithCallMethod.call
+      expect(OrganizerWithCallMethod.call).to be_a_kind_of(FunctionalLightService::Context)
     end
   end
 end

data/spec/acceptance/organizer/reduce_if_spec.rb

@@ -48,4 +48,36 @@ RSpec.describe FunctionalLightService::Organizer do
     result = TestReduceIf.call(empty_context)
     expect(result).to be_success
   end
+
+  it 'skips actions within in its own scope' do
+    org = Class.new do
+      extend FunctionalLightService::Organizer
+
+      def self.call
+        reduce(actions)
+      end
+
+      def self.actions
+        [
+          reduce_if(
+            ->(c) { !c.nil? },
+            [
+              execute(->(c) { c[:first_reduce_if] = true }),
+              execute(->(c) { c.skip_remaining! }),
+              execute(->(c) { c[:second_reduce_if] = true })
+            ]
+          ),
+          execute(->(c) { c[:last_outside] = true })
+        ]
+      end
+    end
+
+    result = org.call
+
+    aggregate_failures do
+      expect(result[:first_reduce_if]).to be true
+      expect(result[:second_reduce_if]).to be_nil
+      expect(result[:last_outside]).to be true
+    end
+  end
 end

data/spec/context/inspect_spec.rb

@@ -13,13 +13,8 @@ RSpec.describe FunctionalLightService::Context do
   describe '#inspect' do
     it 'inspects the hash with all the fields' do
       inspected_context =
-        'FunctionalLightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "FunctionalLightService::Context({}, success: true, message: '', error_code: nil, " \
+        "skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -28,13 +23,8 @@ RSpec.describe FunctionalLightService::Context do
       context.fail!('There was an error')
 
       inspected_context =
-        'FunctionalLightService::Context({}, ' \
-        + 'success: false, ' \
-        + 'message: \'There was an error\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: false, ' \
-        + 'aliases: {}' \
-        + ')'
+        "FunctionalLightService::Context({}, success: false, message: 'There was an error', " \
+        "error_code: nil, skip_remaining: false, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end
@@ -43,13 +33,8 @@ RSpec.describe FunctionalLightService::Context do
       context.skip_remaining!('No need to process')
 
       inspected_context =
-        'FunctionalLightService::Context({}, ' \
-        + 'success: true, ' \
-        + 'message: \'No need to process\', ' \
-        + 'error_code: nil, ' \
-        + 'skip_remaining: true, ' \
-        + 'aliases: {}' \
-        + ')'
+        "FunctionalLightService::Context({}, success: true, message: 'No need to process', " \
+        "error_code: nil, skip_remaining: true, aliases: {})"
 
       expect(context.inspect).to eq(inspected_context)
     end

data/spec/context_spec.rb

@@ -167,7 +167,7 @@ RSpec.describe FunctionalLightService::Context do
   end
 
   it "allows a default block value for #fetch" do
-    expect(context.fetch(:madeup) { :default }).to eq(:default)
+    expect(context.fetch(:madeup, :default)).to eq(:default)
   end
 
   context "when aliases are included via .make" do

data/spec/lib/deterministic/monad_axioms.rb

@@ -34,7 +34,9 @@ shared_examples 'a Monad' do
 
     it '#bind must return a monad' do
       expect(monad.new(1).bind { |v| monad.new(v) }).to eq monad.new(1)
+      # rubocop:disable Lint/EmptyBlock
       expect { monad.new(1).bind {} }.to raise_error(FunctionalLightService::Monad::NotMonadError)
+      # rubocop:enable Lint/EmptyBlock
     end
 
     it '#new must return a monad' do

data/spec/lib/deterministic/monad_spec.rb

@@ -21,8 +21,10 @@ describe FunctionalLightService::Monad do
 
   context '#bind' do
     it "raises an error if the passed function does not return a monad of the same class" do
+      # rubocop:disable Lint/EmptyBlock
       expect { Identity.new(1).bind {} }.to \
         raise_error(FunctionalLightService::Monad::NotMonadError)
+      # rubocop:enable Lint/EmptyBlock
     end
     specify { expect(Identity.new(1).bind { |value| Identity.new(value) }).to eq Identity.new(1) }
 

data/spec/lib/deterministic/null_spec.rb

@@ -38,7 +38,9 @@ describe Null do
     null = Null.instance
     expect(null.to_str).to eq ""
     expect(null.to_ary).to eq []
+    # rubocop:disable Style/StringConcatenation
     expect("" + null).to eq ""
+    # rubocop:enable Style/StringConcatenation
 
     a, b, c = null
     expect(a).to be_nil

data/spec/lib/enum_spec.rb

@@ -8,7 +8,7 @@ describe FunctionalLightService::Enum do
       InvalidEnum = FunctionalLightService.enum do
         Unary(:value)
       end
-    end .to raise_error ArgumentError
+    end.to raise_error ArgumentError
   end
 
   context "Nullary, Unary, Binary" do
@@ -32,7 +32,9 @@ describe FunctionalLightService::Enum do
       expect { n.value }.to raise_error NoMethodError
       expect(n.inspect).to eq "Nullary"
       expect(n.to_s).to eq ""
+      # rubocop:disable Lint/EmptyBlock
       expect(n.fmap {}).to eq n
+      # rubocop:enable Lint/EmptyBlock
     end
 
     it "Unary" do

data/spec/sample/looks_up_tax_percentage_action_spec.rb

@@ -1,7 +1,9 @@
 require 'spec_helper'
 require_relative 'tax/looks_up_tax_percentage_action'
 
-class TaxRange; end
+class TaxRange
+  extend FunctionalLightService::Action
+end
 
 describe LooksUpTaxPercentageAction do
   let(:region) { double('region') }

data/spec/spec_helper.rb

@@ -1,24 +1,21 @@
 $LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
 $LOAD_PATH << File.join(File.dirname(__FILE__))
 
-if ENV['RUN_COVERAGE_REPORT']
-  require 'simplecov'
+require 'simplecov'
 
-  SimpleCov.start do
-    add_filter 'vendor/'
-    add_filter %r{^/spec/}
-  end
-
-  SimpleCov.minimum_coverage_by_file 90
+SimpleCov.start do
+  add_filter 'vendor/'
+  add_filter %r{^/spec/}
 end
 
+SimpleCov.minimum_coverage_by_file 90
+
+require 'simplecov-cobertura'
+SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter
+
 require 'functional-light-service'
 require 'functional-light-service/testing'
 require "functional-light-service/functional/null"
-require 'ostruct'
-require 'pry'
 require 'support'
 require 'test_doubles'
 require 'stringio'
-
-I18n.enforce_available_locales = true

data/spec/test_doubles.rb

@@ -45,6 +45,7 @@ module TestDoubles
 
   class TestLogger
     attr_accessor :logs
+
     def initialize
       @logs = []
     end
@@ -83,8 +84,13 @@ module TestDoubles
     end
   end
 
-  class AnAction; end
-  class AnotherAction; end
+  class AnAction
+    extend FunctionalLightService::Action
+  end
+
+  class AnotherAction
+    extend FunctionalLightService::Action
+  end
 
   class AnOrganizer
     extend FunctionalLightService::Organizer
@@ -166,14 +172,18 @@ module TestDoubles
     promises :latte
 
     executed do |context|
+      context.fail!("Can't make a latte from a milk that's very hot!") if context.milk == :very_hot
+
+      if context.milk == :super_hot
+        error_message = "Can't make a latte from a milk that's super hot!"
+        context.fail_with_rollback!(error_message)
+      end
+
       context[:latte] = "#{context.coffee} - with lots of #{context.milk}"
-      case context.milk
-      when :very_hot then
-        context.fail!("Can't make a latte from a milk that's very hot!")
-      when :super_hot then
-        context.fail_with_rollback!("Can't make a latte from a milk that's super hot!")
-      when "5%" then
-        context.skip_remaining!("Can't make a latte with a fatty milk like that!")
+
+      if context.milk == "5%"
+        msg = "Can't make a latte with a fatty milk like that!"
+        context.skip_remaining!(msg)
         next context
       end
     end
@@ -472,7 +482,9 @@ module TestDoubles
   class NullAction
     extend FunctionalLightService::Action
 
+    # rubocop:disable Lint/EmptyBlock
     executed { |_ctx| }
+    # rubocop:enable Lint/EmptyBlock
   end
 
   class TestIterate

metadata

@@ -1,85 +1,207 @@
 --- !ruby/object:Gem::Specification
 name: functional-light-service
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.4.4
 platform: ruby
 authors:
 - Boscolo Michele
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-02-24 00:00:00.000000000 Z
+date: 2022-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
+  name: dry-inflector
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.1
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.11
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.11
+- !ruby/object:Gem::Dependency
+  name: i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.11
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 5.2.0
+        version: '1.8'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.8.11
+- !ruby/object:Gem::Dependency
+  name: dry-inflector
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.2.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 3.10.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.1
+        version: 0.21.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.21.2
+- !ruby/object:Gem::Dependency
+  name: simplecov-cobertura
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.16.1
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 1.25.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.63.1
+        version: 1.25.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.13.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.13.2
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: 0.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.14.1
+- !ruby/object:Gem::Dependency
+  name: solargraph
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.44.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.12.2
+        version: 0.44.2
+- !ruby/object:Gem::Dependency
+  name: nokogiri
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.5
 description: A service skeleton with an emphasis on simplicity with a pinch a functional
   programming
 email:
@@ -88,9 +210,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/project-build.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".solargraph.yml"
 - ".travis.yml"
 - Appraisals
 - CHANGELOG.md
@@ -101,8 +225,8 @@ files:
 - Rakefile
 - VERSION
 - functional-light-service.gemspec
-- gemfiles/activesupport_5.gemfile
-- gemfiles/activesupport_5.gemfile.lock
+- gemfiles/dry_inflector_0_2_1.gemfile
+- gemfiles/i18n_1_8_11.gemfile
 - lib/functional-light-service.rb
 - lib/functional-light-service/action.rb
 - lib/functional-light-service/configuration.rb
@@ -152,7 +276,6 @@ files:
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
 - spec/acceptance/rollback_spec.rb
-- spec/acceptance/skip_all_warning_spec.rb
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb
@@ -200,7 +323,7 @@ homepage: https://github.com/sphynx79/functional-light-service
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -208,15 +331,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
-signing_key: 
+rubygems_version: 3.2.28
+signing_key:
 specification_version: 4
 summary: A service skeleton with an emphasis on simplicity with a pinch a functional
   programming
@@ -239,7 +362,6 @@ test_files:
 - spec/acceptance/organizer/reduce_until_spec.rb
 - spec/acceptance/organizer/with_callback_spec.rb
 - spec/acceptance/rollback_spec.rb
-- spec/acceptance/skip_all_warning_spec.rb
 - spec/acceptance/testing/context_factory_spec.rb
 - spec/action_expected_keys_spec.rb
 - spec/action_expects_and_promises_spec.rb

data/gemfiles/activesupport_5.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "activesupport", "~> 5.0"
-gem "appraisal", "~> 2.0"
-
-gemspec :path => "../"

data/gemfiles/activesupport_5.gemfile.lock

@@ -1,82 +0,0 @@
-PATH
-  remote: ../
-  specs:
-    light-service (0.6.1)
-      activesupport (>= 3.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    activesupport (5.0.0.1)
-      concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-    appraisal (2.1.0)
-      bundler
-      rake
-      thor (>= 0.14.0)
-    ast (2.3.0)
-    coderay (1.1.1)
-    concurrent-ruby (1.0.2)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
-    i18n (0.7.0)
-    json (2.0.2)
-    method_source (0.8.2)
-    minitest (5.9.0)
-    parser (2.3.1.2)
-      ast (~> 2.2)
-    powerpack (0.1.1)
-    pry (0.10.4)
-      coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    rainbow (2.1.0)
-    rake (11.2.2)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.2)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    rubocop (0.42.0)
-      parser (>= 2.3.1.1, < 3.0)
-      powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
-    simplecov (0.12.0)
-      docile (~> 1.1.0)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slop (3.6.0)
-    thor (0.19.1)
-    thread_safe (0.3.5)
-    tzinfo (1.2.2)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.1.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  activesupport (~> 5.0)
-  appraisal (~> 2.0)
-  light-service!
-  pry (~> 0.10)
-  rspec (~> 3.0)
-  rubocop (~> 0.36)
-  simplecov (~> 0.11)
-
-BUNDLED WITH
-   1.12.5