fun_with_json_api 0.0.8.2 → 0.0.9

data/spec/fun_with_json_api/schema_validators/check_attributes_spec.rb

@@ -25,26 +25,64 @@ describe FunWithJsonApi::SchemaValidators::CheckAttributes do
       end
     end
 
-    context 'when the document contains an unsupported attribute' do
-      before { allow(deserializer).to receive(:attributes).and_return([]) }
+    context 'when the document contains an disabled attribute' do
+      before do
+        deserializer_class = class_double(
+          'FunWithJsonApi::Deserializer',
+          attribute_names: %i(foobar)
+        )
+        allow(deserializer).to receive(:class).and_return(deserializer_class)
+        allow(deserializer).to receive(:attributes).and_return([])
+      end
 
       it 'raises a UnknownAttribute error' do
         expect do
           subject
         end.to raise_error(FunWithJsonApi::Exceptions::UnknownAttribute) do |e|
+          expect(e.http_status).to eq 403
           expect(e.payload.size).to eq 1
 
           payload = e.payload.first
           expect(payload.code).to eq 'unknown_attribute'
           expect(payload.pointer).to eq '/data/attributes/foobar'
           expect(payload.title).to eq(
-            'Request json_api attribute is unsupported by the current endpoint'
+            'Request json_api attribute is not recognised by the current endpoint'
           )
           expect(payload.detail).to eq(
             "The provided attribute 'foobar' can not be assigned to a 'examples' resource"\
             ' from the current endpoint'
           )
-          expect(payload.status).to eq '422'
+          expect(payload.status).to eq '403'
+        end
+      end
+    end
+
+    context 'when the document contains an unknown attribute' do
+      before do
+        deserializer_class = class_double(
+          'FunWithJsonApi::Deserializer',
+          attribute_names: %i(blargh)
+        )
+        allow(deserializer).to receive(:class).and_return(deserializer_class)
+        allow(deserializer).to receive(:attributes).and_return([])
+      end
+
+      it 'raises a UnknownAttribute error' do
+        expect do
+          subject
+        end.to raise_error(FunWithJsonApi::Exceptions::UnknownAttribute) do |e|
+          expect(e.payload.size).to eq 1
+
+          payload = e.payload.first
+          expect(payload.code).to eq 'unknown_attribute'
+          expect(payload.pointer).to eq '/data/attributes/foobar'
+          expect(payload.title).to eq(
+            'Request json_api attribute is not recognised by the current endpoint'
+          )
+          expect(payload.detail).to eq(
+            "The provided attribute 'foobar' can not be assigned to a 'examples' resource"
+          )
+          expect(payload.status).to eq '400'
         end
       end
     end

data/spec/fun_with_json_api/schema_validators/check_relationships_spec.rb

@@ -140,26 +140,66 @@ describe FunWithJsonApi::SchemaValidators::CheckRelationships do
       it { is_expected.to eq true }
     end
 
-    context 'when the document contains an unsupported relationships' do
-      before { allow(deserializer).to receive(:relationships).and_return([]) }
+    context 'when the document contains an excluded relationship' do
+      before do
+        deserializer_class = class_double(
+          'FunWithJsonApi::Deserializer',
+          relationship_names: %i(foobar)
+        )
+        allow(deserializer).to receive(:class).and_return(deserializer_class)
+        allow(deserializer).to receive(:relationships).and_return([])
+      end
 
       it 'raises a UnknownRelationship error' do
         expect do
           subject
         end.to raise_error(FunWithJsonApi::Exceptions::UnknownRelationship) do |e|
+          # expect(e.http_status).to eq 403
           expect(e.payload.size).to eq 1
 
           payload = e.payload.first
           expect(payload.code).to eq 'unknown_relationship'
           expect(payload.pointer).to eq '/data/relationships/foobar'
           expect(payload.title).to eq(
-            'Request json_api relationship is unsupported by the current endpoint'
+            'Request json_api relationship is not recognised by the current endpoint'
           )
           expect(payload.detail).to eq(
             "The provided relationship 'foobar' can not be assigned to a 'examples' resource"\
             ' from the current endpoint'
           )
-          expect(payload.status).to eq '422'
+          expect(payload.status).to eq '403'
+        end
+      end
+    end
+
+    context 'when the document contains an unknown relationship' do
+      before do
+        deserializer_class = class_double(
+          'FunWithJsonApi::Deserializer',
+          relationship_names: %i(blargh)
+        )
+        allow(deserializer).to receive(:class).and_return(deserializer_class)
+        allow(deserializer).to receive(:relationships).and_return([])
+      end
+
+      it 'raises a UnknownRelationship error' do
+        expect do
+          subject
+        end.to raise_error(FunWithJsonApi::Exceptions::UnknownRelationship) do |e|
+          expect(e.http_status).to eq 400
+          expect(e.payload.size).to eq 1
+
+          payload = e.payload.first
+          expect(payload.code).to eq 'unknown_relationship'
+          expect(payload.pointer).to eq '/data/relationships/foobar'
+          expect(payload.title).to eq(
+            'Request json_api relationship is not recognised by the current endpoint'
+          )
+          expect(payload.detail).to eq(
+            "The provided relationship 'foobar' can not be directly assigned to a 'examples'"\
+            ' resource'
+          )
+          expect(payload.status).to eq '400'
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fun_with_json_api
 version: !ruby/object:Gem::Version
-  version: 0.0.8.2
+  version: 0.0.9
 platform: ruby
 authors:
 - Ben Morrall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-04 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -194,6 +194,7 @@ files:
 - lib/fun_with_json_api/schema_validators/check_collection_is_authorized.rb
 - lib/fun_with_json_api/schema_validators/check_document_id_matches_resource.rb
 - lib/fun_with_json_api/schema_validators/check_document_type_matches_resource.rb
+- lib/fun_with_json_api/schema_validators/check_relationship_names.rb
 - lib/fun_with_json_api/schema_validators/check_relationships.rb
 - lib/fun_with_json_api/schema_validators/check_resource_is_authorized.rb
 - lib/fun_with_json_api/version.rb