fun_with_json_api 0.0.10.4 → 0.0.11

data/spec/fun_with_json_api/configuration_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe FunWithJsonApi::Configuration do
+  describe '#force_render_parse_errors_as_json_api?' do
+    it 'has a writer method' do
+      instance = described_class.new
+
+      instance.force_render_parse_errors_as_json_api = true
+      expect(instance.force_render_parse_errors_as_json_api?).to be true
+
+      instance.force_render_parse_errors_as_json_api = false
+      expect(instance.force_render_parse_errors_as_json_api?).to be false
+    end
+
+    it 'defaults to false by default' do
+      expect(described_class.new.force_render_parse_errors_as_json_api?).to be false
+    end
+  end
+end

data/spec/fun_with_json_api/railtie_spec.rb

@@ -23,8 +23,8 @@ describe FunWithJsonApi::Railtie do
       controller do
         def index
           respond_to do |format|
-            format.json_api { render text: 'passed' }
-            format.all { render text: 'failed' }
+            format.json_api { render plain: 'passed' }
+            format.all { render plain: 'failed' }
           end
         end
       end

data/spec/fun_with_json_api/schema_validators/check_document_id_matches_resource_spec.rb

@@ -32,6 +32,27 @@ describe FunWithJsonApi::SchemaValidators::CheckDocumentIdMatchesResource do
           end
         end
       end
+
+      context 'when /data/id is not a string' do
+        before do
+          allow(schema_validator).to receive(:document_id).and_return(42)
+        end
+
+        it 'raises a InvalidDocument error' do
+          expect do
+            subject
+          end.to raise_error(FunWithJsonApi::Exceptions::InvalidDocumentIdentifier) do |e|
+            expect(e.payload.size).to eq 1
+
+            payload = e.payload.first
+            expect(payload.code).to eq 'invalid_document_identifier'
+            expect(payload.pointer).to eq '/data/id'
+            expect(payload.title).to eq 'Request json_api data id is invalid'
+            expect(payload.detail).to eq 'data id value must be a JSON String (i.e. "1234")'
+            expect(payload.status).to eq '409'
+          end
+        end
+      end
     end
 
     context 'when the resource is not persisted' do
@@ -78,6 +99,27 @@ describe FunWithJsonApi::SchemaValidators::CheckDocumentIdMatchesResource do
             )
           end
 
+          context 'when /data/id is not a string' do
+            before do
+              allow(schema_validator).to receive(:document_id).and_return(42)
+            end
+
+            it 'raises a InvalidDocument error' do
+              expect do
+                subject
+              end.to raise_error(FunWithJsonApi::Exceptions::InvalidDocumentIdentifier) do |e|
+                expect(e.payload.size).to eq 1
+
+                payload = e.payload.first
+                expect(payload.code).to eq 'invalid_document_identifier'
+                expect(payload.pointer).to eq '/data/id'
+                expect(payload.title).to eq 'Request json_api data id is invalid'
+                expect(payload.detail).to eq 'data id value must be a JSON String (i.e. "1234")'
+                expect(payload.status).to eq '409'
+              end
+            end
+          end
+
           context 'when a resource matching id exists' do
             before do
               allow(deserializer).to receive(:load_resource_from_id_value)

data/spec/requests/request_parsing_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+describe 'Request Parsing', type: :request do
+  it 'converts a json_api request body into param values' do
+    request_data = '{"data":{"id":"42","type":"foobar"}}'
+
+    post '/echo', request_data, 'Accept': 'application/vnd.api+json',
+                                'Content-Type': 'application/vnd.api+json'
+    expect(
+      JSON.parse(response.body, symbolize_names: true)
+    ).to eq(data: { id: '42', type: 'foobar' })
+  end
+
+  context 'with invalid json api request data' do
+    let(:invalid_request_data) { '{"data":{"id":"42","type":"foobar",}}' } # extra comma
+
+    context 'when force_render_parse_errors_as_json_api? is true' do
+      before do
+        FunWithJsonApi.configure do |config|
+          config.force_render_parse_errors_as_json_api = true
+        end
+      end
+
+      context 'when the request has a json api accept header' do
+        it 'renders a json api invalid document response' do
+          post '/echo',
+               invalid_request_data,
+               'Accept': 'application/vnd.api+json',
+               'Content-Type': 'application/vnd.api+json'
+
+          expect(response.status).to eq 400
+          expect(JSON.parse(response.body, symbolize_names: true)).to eq(
+            errors: [{
+              code: 'invalid_request_body',
+              title: 'Request json_api body could not be parsed',
+              status: '400'
+            }])
+        end
+      end
+
+      context 'when the request does not have a json api accept header' do
+        it 'renders a json api invalid document response' do
+          invalid_request_data = '{"data":{"id":"42","type":"foobar",}}' # extra comma
+
+          post '/echo', invalid_request_data, 'Content-Type': 'application/vnd.api+json'
+
+          expect(response.status).to eq 400
+        end
+      end
+    end
+
+    context 'when force_render_parse_errors_as_json_api? is false' do
+      before do
+        FunWithJsonApi.configure do |config|
+          config.force_render_parse_errors_as_json_api = false
+        end
+      end
+
+      context 'when the request has a json api accept header' do
+        it 'renders a json api invalid document response' do
+          post '/echo',
+               invalid_request_data,
+               'Accept': 'application/vnd.api+json',
+               'Content-Type': 'application/vnd.api+json'
+
+          expect(response.status).to eq 400
+        end
+      end
+
+      context 'when the request does not have a json api accept header' do
+        it 'raises a ActionDispatch::ParamsParser::ParseError' do
+          expect do
+            post '/echo', invalid_request_data, 'Content-Type': 'application/vnd.api+json'
+          end.to raise_error(ActionDispatch::ParamsParser::ParseError)
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: fun_with_json_api
 version: !ruby/object:Gem::Version
-  version: 0.0.10.4
+  version: 0.0.11
 platform: ruby
 authors:
 - Ben Morrall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-19 00:00:00.000000000 Z
+date: 2016-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: '4.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.5
+        version: '4.2'
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
   requirement: !ruby/object:Gem::Requirement
@@ -161,6 +161,7 @@ files:
 - lib/fun_with_json_api/attributes/string_attribute.rb
 - lib/fun_with_json_api/attributes/uuid_v4_attribute.rb
 - lib/fun_with_json_api/collection_manager.rb
+- lib/fun_with_json_api/configuration.rb
 - lib/fun_with_json_api/controller_methods.rb
 - lib/fun_with_json_api/deserializer.rb
 - lib/fun_with_json_api/deserializer_class_methods.rb
@@ -188,6 +189,7 @@ files:
 - lib/fun_with_json_api/exceptions/unknown_relationship.rb
 - lib/fun_with_json_api/find_collection_from_document.rb
 - lib/fun_with_json_api/find_resource_from_document.rb
+- lib/fun_with_json_api/middleware/catch_json_api_parse_errors.rb
 - lib/fun_with_json_api/pre_deserializer.rb
 - lib/fun_with_json_api/railtie.rb
 - lib/fun_with_json_api/schema_validator.rb
@@ -238,6 +240,7 @@ files:
 - spec/dummy/public/favicon.ico
 - spec/fixtures/active_record.rb
 - spec/fun_with_json_api/collection_manager_spec.rb
+- spec/fun_with_json_api/configuration_spec.rb
 - spec/fun_with_json_api/controller_methods_spec.rb
 - spec/fun_with_json_api/deserializer_class_methods_spec.rb
 - spec/fun_with_json_api/deserializer_spec.rb
@@ -252,6 +255,7 @@ files:
 - spec/fun_with_json_api/schema_validators/check_document_type_matches_resource_spec.rb
 - spec/fun_with_json_api/schema_validators/check_relationships_spec.rb
 - spec/fun_with_json_api_spec.rb
+- spec/requests/request_parsing_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bmorrall/fun_with_json_api
 licenses:
@@ -315,6 +319,7 @@ test_files:
 - spec/dummy/README.rdoc
 - spec/fixtures/active_record.rb
 - spec/fun_with_json_api/collection_manager_spec.rb
+- spec/fun_with_json_api/configuration_spec.rb
 - spec/fun_with_json_api/controller_methods_spec.rb
 - spec/fun_with_json_api/deserializer_class_methods_spec.rb
 - spec/fun_with_json_api/deserializer_spec.rb
@@ -329,4 +334,5 @@ test_files:
 - spec/fun_with_json_api/schema_validators/check_document_type_matches_resource_spec.rb
 - spec/fun_with_json_api/schema_validators/check_relationships_spec.rb
 - spec/fun_with_json_api_spec.rb
+- spec/requests/request_parsing_spec.rb
 - spec/spec_helper.rb