fun_html 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4fe70a0317730c02b34d0727a50c3cec42e8e0125a9da574ed0626b3e8f64432
-  data.tar.gz: 92a2bdc05ab5fdc34db3d6c284a34237f0218e6abc506d226351ac550805966f
+  metadata.gz: 5bf8ac3683a1e55c9178d17d85703ec445c26f8a544db4a778252fa3128eb333
+  data.tar.gz: 8213e1aec0fff6f4357721ed1df892a3b31069ad2c93a53b0a64c2c40c4a87ad
 SHA512:
-  metadata.gz: cf86a98a685339cbcad38e55c9f3ce8dfe05e109c1acd42c470038a0ffa2211e6008ad690abe014e7173ce89dfa085e0be1e1822ba5d9d1fc09c93b8c8e6d70d
-  data.tar.gz: f942f6395d3f5ef8f00db4a26c1a615d4c210502b20b08c62e9c4c1162a56e1da721df1d30178ae151cab8ea6e8a8055546ca0c70884254d9ea3dd16c995a715
+  metadata.gz: f7373307fa00fad6e75bf8db7b0c490dd1b808d37b05c3406c5a862c39b8170befef1057b01e1c9577966ed11b1d1bf4ada88741ac5bd213314fb241de656fea
+  data.tar.gz: 13b9377037fd8be26000f9bf746d858645f4326423139beee6a7032f1c37e19fc7290baf10572be84aa3d7c2a303086dc18b5697ec215b8c11c7d0796085bfb9

data/lib/fun_html/attribute.rb

@@ -32,7 +32,9 @@ module FunHtml
 
     # only allow nil or objects that respond to `safe_attribute`
     def self.to_html(attr)
-      attr&.safe_attribute.to_s
+      return '' if attr.nil?
+
+      attr.safe_attribute
     end
 
     # create a new Attribute object to create reuseable attributes

data/lib/fun_html/template.rb

@@ -55,9 +55,26 @@ module FunHtml
       obj
     end
 
+    JOIN_ERROR = <<~TXT.freeze
+      You can not join templates which are created by the parent template.
+
+      This will fail:
+
+        FunHtml::Template.start { |t| t.join [t.text("hello")] }
+
+      Instead only join new templates
+        FunHtml::Template.start do |t|
+          t.join [FunHtml::Template.start { |x| x.text('hello') }]
+        end
+    TXT
+
     # join an array of other templates into this template.
     def join(templates)
-      templates.each { @__buffer << _1.render }
+      templates.each do |t|
+        raise JOIN_ERROR if t == self
+
+        @__buffer << t.render
+      end
       self
     end
 

data/lib/fun_html/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FunHtml
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/lib/fun_html/writer.rb

@@ -10,15 +10,15 @@ module FunHtml
     include Kernel
 
     def initialize
-      @__buffer = +''
+      @__buffer = String.new(capacity: 1024)
     end
 
     # Render produces the HTML string and clears the buffer.
     def render
-      @__buffer
-    ensure
+      result = @__buffer
       # empty the buffer to prevent double rendering
-      @__buffer = +''
+      @__buffer = String.new(capacity: 1024)
+      result
     end
 
     private
@@ -33,9 +33,12 @@ module FunHtml
     CLOSE_VOID = '/>'
 
     def write(open, close, attr = nil, closing_char: CLOSE, &block)
-      @__buffer << open << Attribute.to_html(attr)
+      if attr
+        @__buffer << open << Attribute.to_html(attr) << closing_char
+      else
+        @__buffer << open << closing_char
+      end
 
-      @__buffer << closing_char
       yield self if block
       @__buffer << close
 

data/rbi/fun_html.rbi

@@ -3,6 +3,8 @@
 
 module FunHtml
   class Template
+    JOIN_ERROR = T.let(T.unsafe(nil), String)
+
     include FunHtml::Writer
     include FunHtml::SpecElements::HTMLAllElements
 

data/rbi/fun_html.rbx

@@ -3,6 +3,8 @@
 
 module FunHtml
   class Template
+    JOIN_ERROR = T.let(T.unsafe(nil), String)
+
     include FunHtml::Writer
     include FunHtml::SpecElements::HTMLAllElements
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fun_html
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - John Weir
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-05 00:00:00.000000000 Z
+date: 2025-04-22 00:00:00.000000000 Z
 dependencies: []
 description: It probably is not much fun, despite the name.
 email: