fullcontact 0.12.0 → 0.13.0

data/LICENSE.md

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2014 FullContact Inc. and contributors
+Copyright (c) 2016 FullContact Inc. and contributors
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -9,6 +9,9 @@ A Ruby wrapper for the [FullContact API](http://www.fullcontact.com/)
 
 Changes
 -------
+- 0.13.0
+    - Raise `ArgumentError` if query by Facebook ID/username is used.
+    - Remove deprecated messages.
 - 0.12.0 - `include_headers_in_response = true` includes response headers in returned payload
  - Accessible as `http_headers` in response. Also accessible on thrown errors (e.g. RateLimited)
 - 0.11.0 - Plisskin transformation can be disabled by specifying a `skip_rubyize = true` in config block.
@@ -70,9 +73,6 @@ There's other ways you can query the Person API:
     
     # Get information about a twitter handle
     person4 = FullContact.person(twitter: "bartlorang")
-
-    # Get information about a facebook username
-    person5 = FullContact.person(facebookUsername: 'bart.lorang')
     
     # Get information from a phone number
     person6 = FullContact.person(phone:13037170414)
@@ -113,7 +113,7 @@ A full list of contributors can be found in
 
 License
 ---------
-Copyright (c) 2015 FullContact Inc. and contributors
+Copyright (c) 2016 FullContact Inc. and contributors
 
 
 

data/lib/fullcontact/client/person.rb

@@ -5,13 +5,11 @@ module FullContact
       #
       def person(options={}, faraday_options={})
         if options.is_a?(String)
-          warn "[DEPRECATION] supplying an email address directly is deprecated. Please use {email: #{options}} instead. This will be removed in 0.9.0."
-          options = {:email => options}
+          raise ArgumentError, "Supplying an email address directly is not supported. Please use {email: #{options}} instead."
         end
 
-        if options.has_key?(:timeoutSeconds)
-          options.delete(:timeoutSeconds)
-          warn '[DEPRECATION] timeoutSeconds is no longer a supported parameter. It has been removed from your request.'
+        if options.has_key?(:facebookUsername) || options.has_key?(:facebookId)
+          raise ArgumentError, "Querying by Facebook ID or username is no longer supported. Please contact support@fullcontact.com for more information."
         end
 
         response = get('person', options, false, faraday_options)

data/lib/fullcontact/version.rb

@@ -1,3 +1,3 @@
 module FullContact
-  VERSION = '0.12.0'
+  VERSION = '0.13.0'
 end

data/spec/fullcontact_spec.rb

@@ -29,13 +29,6 @@ describe FullContact do
           .should have_been_made
     end
 
-    it "should strip the timeoutSeconds parameter" do
-      FullContact.person(email: "brawest@gmail.com", timeoutSeconds: 30)
-      a_get("person.json")
-          .with(:query => {:apiKey => "api_key", :email => "brawest@gmail.com"})
-          .should have_been_made
-    end
-
     it "should return the same results as a client by email" do
       FullContact.person(:email => "brawest@gmail.com").should == FullContact::Client.new.person(:email => "brawest@gmail.com")
     end

data/spec/ruby_fullcontact/client/person_spec.rb

@@ -71,4 +71,23 @@ describe FullContact::Client::Person do
           .to(eq("application/json; charset=utf-8"))
     end
   end
+
+  context "facebook queries removed" do
+
+    before do
+      FullContact.configure do |config|
+        config.api_key = "api_key"
+      end
+    end
+
+    it 'should not allow querying by facebookUsername' do
+      expect { FullContact.person(facebookUsername: "brawest") }.to raise_error(ArgumentError)
+
+    end
+
+    it 'should not allow querying by facebookId' do
+      expect { FullContact.person(facebookId: "123") }.to raise_error(ArgumentError)
+
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fullcontact
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.13.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-10 00:00:00.000000000 Z
+date: 2016-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: maruku
-  requirement: &70200921792780 !ruby/object:Gem::Requirement
+  requirement: &70101799106340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,10 +21,10 @@ dependencies:
         version: '0.7'
   type: :development
   prerelease: false
-  version_requirements: *70200921792780
+  version_requirements: *70101799106340
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70200921791920 !ruby/object:Gem::Requirement
+  requirement: &70101799105820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '1.4'
   type: :development
   prerelease: false
-  version_requirements: *70200921791920
+  version_requirements: *70101799105820
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70200921791200 !ruby/object:Gem::Requirement
+  requirement: &70101799105340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '0.9'
   type: :development
   prerelease: false
-  version_requirements: *70200921791200
+  version_requirements: *70101799105340
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70200921790200 !ruby/object:Gem::Requirement
+  requirement: &70101799104860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '3.1'
   type: :development
   prerelease: false
-  version_requirements: *70200921790200
+  version_requirements: *70101799104860
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70200921789020 !ruby/object:Gem::Requirement
+  requirement: &70101799104380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '0.4'
   type: :development
   prerelease: false
-  version_requirements: *70200921789020
+  version_requirements: *70101799104380
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70200921787660 !ruby/object:Gem::Requirement
+  requirement: &70101799103860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +76,10 @@ dependencies:
         version: '1.6'
   type: :development
   prerelease: false
-  version_requirements: *70200921787660
+  version_requirements: *70101799103860
 - !ruby/object:Gem::Dependency
   name: yard
-  requirement: &70200921784940 !ruby/object:Gem::Requirement
+  requirement: &70101799103400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -87,10 +87,10 @@ dependencies:
         version: '0.7'
   type: :development
   prerelease: false
-  version_requirements: *70200921784940
+  version_requirements: *70101799103400
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &70200921781340 !ruby/object:Gem::Requirement
+  requirement: &70101799102900 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -101,10 +101,10 @@ dependencies:
         version: '4.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70200921781340
+  version_requirements: *70101799102900
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70200921776380 !ruby/object:Gem::Requirement
+  requirement: &70101799102000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -112,10 +112,10 @@ dependencies:
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *70200921776380
+  version_requirements: *70101799102000
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
-  requirement: &70200921775220 !ruby/object:Gem::Requirement
+  requirement: &70101799101220 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -123,10 +123,10 @@ dependencies:
         version: '0.9'
   type: :runtime
   prerelease: false
-  version_requirements: *70200921775220
+  version_requirements: *70101799101220
 - !ruby/object:Gem::Dependency
   name: plissken
-  requirement: &70200921774140 !ruby/object:Gem::Requirement
+  requirement: &70101799100840 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -134,7 +134,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70200921774140
+  version_requirements: *70101799100840
 description: A Ruby wrapper for the FullContact API
 email:
 - support@fullcontact.com
@@ -191,7 +191,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -928837889352333457
+      hash: -1493741065031286870
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: