full_dup 0.0.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 20cf85cb4234f06a7460867e7ea8106d39354c23
-  data.tar.gz: d6a798fe6cd7b325372d97b70b1502229f30fb09
+  metadata.gz: 86a384fd1d302d5e4aa4d0c559f7e54eef928dd2
+  data.tar.gz: 9323bcec6d5768a83462ead3fb90bc41274dee70
 SHA512:
-  metadata.gz: 1dfd98c630f82771af60cc0edc6db998258e1e6dcdbc39062a8129194244c34e725df68bfaa12b63a5feb1d8d10fd5e16c0b707902e1ed7a1de716d697ccb344
-  data.tar.gz: e47dcb7ba1044b94894e45c2241722dfee313b5b51ae93e32a1865945b6fa3d1221425e14a39704dd4402d383d392683095337df49557fca9225aac55611955e
+  metadata.gz: e0d14dfe054b64f3c6ab38cacb3d3fb5a81f8a32e6e633b3c50a7adf43cb27b6d5dcf9eb37e12eaf8868591c301af4eae80cc5b8ad527a43e0a357b3f5aefb71
+  data.tar.gz: 7ba748574f0bda5729bb178a318be629687b1f10ae673d92769b94eed6253fb74d43ea52203208c0845e7acaef6ddae1c58b5de23e76fef71a6d9b04d3a34189

data/full_dup.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency 'minitest', "~> 5.7"
   spec.add_development_dependency 'minitest_visible', "~> 0.1"
+  spec.add_development_dependency 'reek', "~> 5.0.2"
 end

data/lib/full_dup/array.rb

@@ -1,29 +1,26 @@
 # coding: utf-8
 
+# Add full_dup support to the array class.
 class Array
 
-  #The full_dup method for arrays.
-  def full_dup(progress={})
-    progress[object_id] = result = dup
-    exclude = full_dup_exclude
+  # Do a full_dup with no exclusions
+  def full_dup_no_exclusions(progress)
+    each_index do |name|
+      value = self[name]
+      value = progress[value.object_id] || value.full_dup(progress)
+      self[name] = value
+    end
+  end
 
-    if exclude.empty?
-      each_index do |name|
-        value = result[name]
+  # Do a full_dup with exclusions
+  def full_dup_with_exclusions(progress, exclude)
+    each_index do |name|
+      unless exclude.include?(name)
+        value = self[name]
         value = progress[value.object_id] || value.full_dup(progress)
-        result[name] = value
-      end
-    else
-      each_index do |name|
-        unless exclude.include?(name)
-          value = result[name]
-          value = progress[value.object_id] || value.full_dup(progress)
-          result[name] = value
-        end
+        self[name] = value
       end
     end
-
-    result
   end
 
 end

data/lib/full_dup/hash.rb

@@ -1,29 +1,26 @@
-# coding: utf-8
-
-class Hash
-
-  #The full_dup method for hashes.
-  def full_dup(progress={})
-    progress[object_id] = result = dup
-    exclude = full_dup_exclude
-
-    if exclude.empty?
-      each_key do |name|
-        value = result[name]
-        value = progress[value.object_id] || value.full_dup(progress)
-        result[name] = value
-      end
-    else
-      each_key do |name|
-        unless exclude.include?(name)
-          value = result[name]
-          value = progress[value.object_id] || value.full_dup(progress)
-          result[name] = value
-        end
-      end
-    end
-
-    result
-  end
-
-end
+# coding: utf-8
+
+# Add full_dup support to the hash class.
+class Hash
+
+  # Do a full_dup with no exclusions
+  def full_dup_no_exclusions(progress)
+    each_key do |name|
+      value = self[name]
+      value = progress[value.object_id] || value.full_dup(progress)
+      self[name] = value
+    end
+  end
+
+  # Do a full_dup with exclusions
+  def full_dup_with_exclusions(progress, exclude)
+    each_key do |name|
+      unless exclude.include?(name)
+        value = self[name]
+        value = progress[value.object_id] || value.full_dup(progress)
+        self[name] = value
+      end
+    end
+  end
+
+end

data/lib/full_dup/object.rb

@@ -1,5 +1,6 @@
 # coding: utf-8
 
+# Add full_dup support to the object class.
 class Object
 
   #By default, no instance variables are excluded.
@@ -7,28 +8,38 @@ class Object
     []
   end
 
-  #The full_dup method for most objects.
+  #The common part of the full_dup.
   def full_dup(progress={})
     progress[object_id] = result = dup
     exclude = full_dup_exclude
 
     if exclude.empty?
-      instance_variables.each do |name|
-        value = result.instance_variable_get(name)
-        value = progress[value.object_id] || value.full_dup(progress)
-        result.instance_variable_set(name, value)
-      end
+      result.full_dup_no_exclusions(progress)
     else
-      instance_variables.each do |name|
-        unless exclude.include?(name)
-          value = result.instance_variable_get(name)
-          value = progress[value.object_id] || value.full_dup(progress)
-          result.instance_variable_set(name, value)
-        end
-      end
+      result.full_dup_with_exclusions(progress, exclude)
     end
 
     result
   end
 
+  # Do a full_dup with no exclusions
+  def full_dup_no_exclusions(progress)
+    instance_variables.each do |name|
+      value = instance_variable_get(name)
+      value = progress[value.object_id] || value.full_dup(progress)
+      instance_variable_set(name, value)
+    end
+  end
+
+  # Do a full_dup with exclusions
+  def full_dup_with_exclusions(progress, exclude)
+    instance_variables.each do |name|
+      unless exclude.include?(name)
+        value = instance_variable_get(name)
+        value = progress[value.object_id] || value.full_dup(progress)
+        instance_variable_set(name, value)
+      end
+    end
+  end
+
 end

data/lib/full_dup/struct.rb

@@ -1,29 +1,26 @@
 # coding: utf-8
 
+# Add full_dup support to the struct class.
 class Struct
 
-  #The full_dup method for structs.
-  def full_dup(progress={})
-    progress[object_id] = result = dup
-    exclude = full_dup_exclude
+  # Do a full_dup with no exclusions
+  def full_dup_no_exclusions(progress)
+    members.each do |name|
+      value = self[name]
+      value = progress[value.object_id] || value.full_dup(progress)
+      self[name] = value
+    end
+  end
 
-    if exclude.empty?
-      members.each do |name|
-        value = result[name]
+  # Do a full_dup with exclusions
+  def full_dup_with_exclusions(progress, exclude)
+    members.each do |name|
+      unless exclude.include?(name)
+        value = self[name]
         value = progress[value.object_id] || value.full_dup(progress)
-        result[name] = value
-      end
-    else
-      members.each do |name|
-        unless exclude.include?(name)
-          value = result[name]
-          value = progress[value.object_id] || value.full_dup(progress)
-          result[name] = value
-        end
+        self[name] = value
       end
     end
-
-    result
   end
 
 end

data/lib/full_dup/use_dup.rb

@@ -1,19 +1,23 @@
 # coding: utf-8
 
+# The mixin for classes where dup is just simple dup.
 module FullDupDup
   def full_dup(_progress=nil)
     dup
   end
 end
 
+# Strings answer dup.
 class String
   include FullDupDup
 end
 
+# Enumerators answer dup.
 class Enumerator
   include FullDupDup
 end
 
+# MatchData answer dup.
 class MatchData
   include FullDupDup
 end

data/lib/full_dup/use_self.rb

@@ -1,35 +1,43 @@
 # coding: utf-8
 
+# A mixin for classes where the dup is the object itself.
 module FullDupSelf
   def full_dup(_progress=nil)
     self
   end
 end
 
+# Numerics answer self.
 class Numeric
   include FullDupSelf
 end
 
+# NilClass objects (nil) answer self.
 class NilClass
   include FullDupSelf
 end
 
+# TrueClass objects (true) answer self.
 class TrueClass
   include FullDupSelf
 end
 
+# FalseClass objects (false) answer self.
 class FalseClass
   include FullDupSelf
 end
 
+# Symbols answer self.
 class Symbol
   include FullDupSelf
 end
 
+# Regular expressions answer self.
 class Regexp
   include FullDupSelf
 end
 
+# Threads answer self.
 class Thread
   include FullDupSelf
 end

data/lib/full_dup/version.rb

@@ -1,5 +1,5 @@
 # coding: utf-8
 
 module FullDup
-  VERSION = "0.0.6"
+  VERSION = "1.0.0"
 end

data/rakefile.rb

@@ -14,6 +14,11 @@ Rake::TestTask.new do |t|
   t.warning = true
 end
 
+desc "Run a scan for smelly code!"
+task :reek do |t|
+  `reek --no-color lib > reek.txt`
+end
+
 desc "Fire up an IRB session with full_dup preloaded."
 task :console do
   system "ruby irbt.rb local"

data/reek.txt

@@ -0,0 +1 @@
+0 total warnings

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: full_dup
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 1.0.0
 platform: ruby
 authors:
 - Peter Camilleri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-05 00:00:00.000000000 Z
+date: 2018-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.1'
+- !ruby/object:Gem::Dependency
+  name: reek
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.0.2
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 5.0.2
 description: A (safe/no exceptions) dup variant that performs a deep, recursive copy.
 email:
 - peter.c.camilleri@gmail.com
@@ -89,6 +103,7 @@ files:
 - lib/full_dup/use_self.rb
 - lib/full_dup/version.rb
 - rakefile.rb
+- reek.txt
 homepage: https://github.com/PeterCamilleri/full_dup
 licenses:
 - MIT