fugit 1.10.1 → 1.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dfedcc6bdc1657d09a8c7a4dc23ad0cdb7abe7a78d5ec007477794361f678aaf
-  data.tar.gz: 617b8fb21468bb4a6c17294a9c856b2975dd67f5cb6add6569047545a92305ee
+  metadata.gz: da93feee9bdfd44a793ce2b45b81109c0f7cd08ff9a930d15629a29c6a381e07
+  data.tar.gz: 32d9b447734805d3b58ae64c70a6699b931ef4fb4e6a76d8f279e66d4b5cb7df
 SHA512:
-  metadata.gz: c22968c95e4986b091ed498a848a1f18800cb3217af2e1a1a999ac15a979c8fce8243672f33704e125e09c4dde1adb38b33c0ee3c639f355003d00e734e097a1
-  data.tar.gz: 99f6e2170a616663f536ddf9d1b627130ff0e4f20277a2b7011b24ecaa50e43ad2a9ce944c51ace296a6151df71583d7f6e921023a91e9aa82c7820389b39abb
+  metadata.gz: e7ac7afec4cfdcfdac22e5d2113892a0c7cb1f790d205bc32ecaea75c30f6ceb73af811824712c6781b480831f2a09479a6344af0d9b3c0ee92ae5cff7ef6c38
+  data.tar.gz: d87ecc490a49f19680891a82979903987843b5853ecfdc9ebee57d0b047fa4dffa96dfbbde43ef5d3011dbd07d492ac8f7a151fa6354478050c18efae9b911e4

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 # CHANGELOG.md
 
 
+## fugit 1.11.1 released 2024-08-15
+
+* Prevent nat parsing chocking on long input (> 256 chars), gh-104
+
+
+## fugit 1.11.0 released 2024-04-24
+
+* Revert gh-86 ban on `every 27 hours` / `* */27 * * *` for gh-103
+
+
 ## fugit 1.10.1 released 2024-02-29
 
 * Fix on Ruby 2.2.6 thanks to @aunghtain, gh-93

data/CREDITS.md

@@ -1,6 +1,10 @@
 
 # fugit credits
 
+* https://github.com/personnumber3377, gh-104 Fugit.parse choke on long input
+* Michael Scrivo, https://github.com/mscrivo, gh-103
+* Benjamin Darcet, https://github.com/bdarcet gh-95 gh-96 et-orbi #rweek
+* https://github.com/franckduche gh-95 gh-96 et-orbi #rweek
 * https://hithub.com/aunghtain, gh-93, include oneliner vs Ruby 2.6.6
 * Marcos Belluci, https://github.com/delbetu, gh-88, 1st and last nat
 * Michael Reinsch, https://github.com/mreinsch, gh-84 and gh-85

data/README.md

@@ -34,13 +34,14 @@ The intersection of those two projects is where fugit is born:
 ### Projects using fugit
 
 * [arask](https://github.com/Ebbe/arask) - "Automatic RAils taSKs" uses fugit to parse cron strings
-* [sidekiq-cron](https://github.com/ondrejbartas/sidekiq-cron) - recent versions of Sidekiq-Cron use fugit to parse cron strings
+* [sidekiq-cron](https://github.com/ondrejbartas/sidekiq-cron) - uses fugit to parse cron strings since version 1.0.0, it was using rufus-scheduler previously
 * [rufus-scheduler](https://github.com/jmettraux/rufus-scheduler) - as seen above
 * [flor](https://github.com/floraison/flor) - used in the [cron](https://github.com/floraison/flor/blob/master/doc/procedures/cron.md) procedure
 * [que-scheduler](https://github.com/hlascelles/que-scheduler) - a reliable job scheduler for [que](https://github.com/chanks/que)
 * [serial_scheduler](https://github.com/grosser/serial_scheduler) - ruby task scheduler without threading
 * [delayed_cron_job](https://github.com/codez/delayed_cron_job) - an extension to Delayed::Job that allows you to set cron expressions for your jobs
 * [GoodJob](https://github.com/bensheldon/good_job) - a multithreaded, Postgres-based, Active Job backend for Ruby on Rails
+* [Solid Queue](https://github.com/rails/solid_queue) - a DB-based queuing backend for Active Job, designed with simplicity and performance in mind
 * ...
 
 ## `Fugit.parse(s)`
@@ -140,6 +141,8 @@ c = Fugit.parse_cron('0 12 * * mon#2')
 
   # `#next` and `#prev` return Enumerable instances
   #
+  # These two methods are available since fugit 1.10.0.
+  #
 c.next(Time.parse('2024-02-16 12:00:00'))
   .take(3)
   .map(&:to_s)
@@ -157,6 +160,8 @@ c.prev(Time.parse('2024-02-16 12:00:00'))
   # instances that correspond to the occurrences of the cron within
   # the time range
   #
+  # This method is available since fugit 1.10.0.
+  #
 c.within(Time.parse('2024-02-16 12:00')..Time.parse('2024-08-01 12:00'))
   .map(&:to_s)
     # => [ '2024-03-11 12:00:00',
@@ -251,6 +256,8 @@ p Fugit.parse_cron('59 6 1-7& * 2&').next_time('2020-03-15').to_s
 
 Fugit understands `0 5 * * 1#1` or `0 5 * * mon#1` as "each first Monday of the month, at 05:00".
 
+The hash extension can only be used in the day-of-week field.
+
 ```ruby
 '0 5 * * 1#1'    #
 '0 5 * * mon#1'  # the first Monday of the month at 05:00
@@ -273,6 +280,8 @@ Fugit understands `0 5 * * 1#1` or `0 5 * * mon#1` as "each first Monday of the
 
 Fugit, since 1.1.10, also understands cron strings like "`9 0 * * sun%2`" which can be read as "every other Sunday at 9am".
 
+The modulo extension can only be used in the day-of-week field.
+
 For odd Sundays, one can write `9 0 * * sun%2+1`.
 
 It can be combined, as in `9 0 * * sun%2,tue%3+2`
@@ -465,6 +474,8 @@ Fugit::Nat.parse('every day at 16:15 nada 18:30', multi: true)
 
 `multi: false` is the default behaviour, return a single `Fugit::Cron` instance or nil when it cannot parse.
 
+Please note that "nat" input is limited to 256 characters (fugit 1.11.1).
+
 ### Nat Midnight
 
 `"Every day at midnight"` is supported, but `"Every monday at midnight"` will be interpreted (as of Fugit <= 1.4.x) as `"Every monday at 00:00"`. Sorry about that.

data/fugit.gemspec

@@ -41,7 +41,7 @@ Time tools for flor and the floraison project. Cron parsing and occurrence compu
     # this dependency appears in 'et-orbi'
 
   s.add_runtime_dependency 'raabro', '~> 1.4'
-  s.add_runtime_dependency 'et-orbi', '~> 1', '>= 1.2.7'
+  s.add_runtime_dependency 'et-orbi', '~> 1', '>= 1.2.11'
 
   s.add_development_dependency 'rspec', '~> 3.8'
   s.add_development_dependency 'chronic', '~> 0.10'

data/lib/fugit/cron.rb

@@ -46,7 +46,20 @@ module Fugit
       def do_parse(s)
 
         parse(s) ||
-        fail(ArgumentError.new("invalid cron string #{s.inspect}"))
+        fail(ArgumentError.new("invalid cron string #{trunc(s)}"))
+      end
+
+      protected
+
+      def trunc(s)
+
+        if s.is_a?(String)
+          r = s.length > 28 ? s[0, 28] + "... len #{s.length}" : s
+          r.inspect
+        else
+          r = s.inspect
+          r.length > 35 ? s[0, 35] + '...' : r
+        end
       end
     end
 
@@ -264,6 +277,8 @@ module Fugit
           "please fill an issue at https://git.io/fjJC9"
         ) if (i += 1) > MAX_ITERATION_COUNT
 
+#tt = t.time;
+#puts "  #{tt.strftime('%F %T %:z %A')} #{tt.rweek} #{tt.rweek % 2}"
         (ifrom == t.to_i) && (t.inc(1); next)
         month_match?(t) || (t.inc_month; next)
         day_match?(t) || (t.inc_day; next)
@@ -307,6 +322,8 @@ module Fugit
           "please fill an issue at https://git.io/fjJCQ"
         ) if (i += 1) > MAX_ITERATION_COUNT
 
+#tt = t.time;
+#puts "  #{tt.strftime('%F %T %:z %A')} #{tt.rweek} #{tt.rweek % 4}"
         month_match?(t) || (t.dec_month; next)
         day_match?(t) || (t.dec_day; next)
         hour_match?(t) || (t.dec_hour; next)
@@ -565,7 +582,10 @@ module Fugit
 
       sta, edn, sla = r
 
-      return false if sla && sla > max
+      #return false if sla && sla > max
+        #
+        # let it go, "* */24 * * *" and "* */27 * * *" are okay
+        # gh-86 and gh-103
 
       edn = max if sla && edn.nil?
 

data/lib/fugit/duration.rb

@@ -258,7 +258,7 @@ module Fugit
       when Numeric then add_numeric(a)
       when Fugit::Duration then add_duration(a)
       when String then add_duration(self.class.parse(a))
-      when ::Time, EtOrbi::EoTime then add_to_time(a)
+      when ::Time, ::EtOrbi::EoTime then add_to_time(a)
       else fail ArgumentError.new(
         "cannot add #{a.class} instance to a Fugit::Duration")
       end

data/lib/fugit/nat.rb

@@ -7,6 +7,8 @@ module Fugit
   #
   module Nat
 
+    MAX_INPUT_LENGTH = 256
+
     class << self
 
       def parse(s, opts={})
@@ -17,6 +19,16 @@ module Fugit
 
         s = s.strip
 
+        if s.length > MAX_INPUT_LENGTH
+
+          fail ArgumentError.new(
+            "input too long for a nat string, " +
+            "#{s.length} > #{MAX_INPUT_LENGTH}"
+          ) if opts[:do_parse]
+
+          return nil
+        end
+
 #p s; Raabro.pp(Parser.parse(s, debug: 3), colours: true)
 #(p s; Raabro.pp(Parser.parse(s, debug: 1), colours: true)) rescue nil
 
@@ -29,7 +41,7 @@ module Fugit
 
       def do_parse(s, opts={})
 
-        parse(s, opts) ||
+        parse(s, opts.merge(do_parse: true)) ||
         fail(ArgumentError.new("could not parse a nat #{s.inspect}"))
       end
     end

data/lib/fugit/parse.rb

@@ -20,17 +20,34 @@ module Fugit
 
       opts[:at] = opts[:in] if opts.has_key?(:in)
 
-      (opts[:cron] != false && parse_cron(s)) ||
-      (opts[:duration] != false && parse_duration(s)) ||
-      (opts[:nat] != false && parse_nat(s, opts)) ||
-      (opts[:at] != false && parse_at(s)) ||
+      (opts[:cron] != false && parse_cron(s)) || # 542ms 616ms
+      (opts[:duration] != false && parse_duration(s)) || # 645ms # 534ms
+      (opts[:nat] != false && parse_nat(s, opts)) || # 2s # 35s
+      (opts[:at] != false && parse_at(s)) || # 568ms 622ms
       nil
     end
 
     def do_parse(s, opts={})
 
-      parse(s, opts) ||
-      fail(ArgumentError.new("found no time information in #{s.inspect}"))
+      opts[:at] = opts[:in] if opts.has_key?(:in)
+
+      result = nil
+      errors = []
+
+      %i[ cron duration nat at ]
+        .each { |k|
+          begin
+            result ||= (opts[k] != false && self.send("do_parse_#{k}", s))
+          rescue => err
+            errors << err
+          end }
+
+      return result if result
+
+      raise(
+        errors.find { |r| r.class != ArgumentError } ||
+        errors.first ||
+        ArgumentError.new("found no time information in #{s.inspect}"))
     end
 
     def parse_cronish(s, opts={})

data/lib/fugit.rb

@@ -3,7 +3,7 @@
 
 module Fugit
 
-  VERSION = '1.10.1'
+  VERSION = '1.11.1'
 end
 
 require 'time'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fugit
 version: !ruby/object:Gem::Version
-  version: 1.10.1
+  version: 1.11.1
 platform: ruby
 authors:
 - John Mettraux
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-28 00:00:00.000000000 Z
+date: 2024-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: raabro
@@ -33,7 +33,7 @@ dependencies:
         version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.7
+        version: 1.2.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: '1'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.7
+        version: 1.2.11
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement