fuey_client 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f079db9962809a0e42b00bd385b9184a132ee771
-  data.tar.gz: d86dfd426a5db986e654829d8f7877693bf8c8c6
+  metadata.gz: 495dc67e99ddd7c14963c64ab490cfb1c6852731
+  data.tar.gz: d3bc7df65ad943b288a1346c815ec207729fefaf
 SHA512:
-  metadata.gz: 25383482a7ffc6050a40a19dca2618195e2fa1f2418215a6b758c9d3ebddd9a530fecd945248dd01009a290f3834e75e43ce45146aa322edd186d2f48b604d55
-  data.tar.gz: c92968edaffae7143578e0dbacfcc14303e41438acb063ef90b9bbb43e02de4ffeb111e5c7003161c5adee2cbbca48e0bbc09f5c3d97833553e96ce473881326
+  metadata.gz: 33b22f4767a69e9b8960fd51143e4ae0c41fc0eabdec71ef7130322418e6fc25113009b460d9cc29356c5dfe7bf9c40b73f9462ee9c4ed3020ad401a48790ebe
+  data.tar.gz: 53e23f3935bf6a51b51af9f17026fa750e3c73938fb7347afa5841b59bae5193aa10c6ffc8efcf3e03bbe0eb73e91d04a442af9705f801068e6f1637e686a4d8

data/lib/fuey_client/fuey/client.rb

@@ -4,6 +4,7 @@ require "fuey_client/fuey/null_object"
 require "fuey_client/fuey/trace"
 require "fuey_client/fuey/inspections"
 require "fuey_client/fuey/reporters"
+require "fuey_client/fuey/trace_repository"
 
 require "active_support"
 
@@ -17,12 +18,12 @@ module Fuey
     end
 
     def reporter
-      @_reporter ||= Reporters::Redis.new
+      @_reporter ||= Reporters::NotificationQueue.new(Fuey::Redis.instance)
     end
 
     def run
-      Trace.all.each do |trace|
-        trace.add_observer reporter
+      TraceRepository.new.all.each do |trace|
+        trace.receiver = reporter
         output = trace.run
         Log.write %([#{trace.name}] #{output})
       end

data/lib/fuey_client/fuey/inspections/inspection.rb

@@ -1,6 +1,7 @@
 require "observer"
 require "stately"
 require "fuey_client/fuey/model_initializer"
+require "fuey_client/fuey/inspections/support/status"
 
 module Fuey
   module Inspections
@@ -13,17 +14,30 @@ module Fuey
       stately :start => :pending, :attr => :state do
         state :executed, :action => :execute  do
           before_transition :do => :notify
-          after_transition :do => :notify
-          after_transition :do => :_execute
+          after_transition  :do => :notify
+          after_transition  :do => :_execute
         end
         state :passed, :action => :pass do
-          after_transition :do => :notify
+          after_transition  :do => :notify
         end
         state :failed, :action => :fail do
-          after_transition :do => :notify
+          after_transition  :do => :notify
         end
       end
 
+      def status
+        Support::Status.new(
+                            :type => self.class.to_s.split('::').last,
+                            :name => name,
+                            :status => state,
+                            :settings => settings, # defined in child class
+                            :status_message => status_message # defined in child class
+                            )
+      end
+
+      def settings; end
+      def status_message; end
+
       def passed?
         state == 'passed'
       end
@@ -37,14 +51,6 @@ module Fuey
         notify_observers status
       end
 
-      def status
-        {
-          :type => self.class.to_s.split('::').last,
-          :name => name,
-          :status => self.state
-        }
-      end
-
     end
   end
 end

data/lib/fuey_client/fuey/inspections/ping.rb

@@ -18,12 +18,14 @@ module Fuey
         %(Ping #{name} #{host})
       end
 
-      def status
-        {
-          :settings => host || "",
-          :statusMessage => %(#{state} ping for #{host}),
-        }.merge(super)
+      def settings
+        host || ""
       end
+
+      def status_message
+        %(#{state} ping for #{host})
+      end
+
     end
   end
 end

data/lib/fuey_client/fuey/inspections/rfc_ping.rb

@@ -23,11 +23,8 @@ module Fuey
         %(RFCPing #{state} for #{ashost}.)
       end
 
-      def status
-        {
-          :settings => config.reject{|k,v| k == 'passwd'},
-          :statusMessage => status_message
-        }.merge(super)
+      def settings
+        config.reject{|k,v| k == 'passwd'}
       end
 
       def config

data/lib/fuey_client/fuey/inspections/snmp_walk.rb

@@ -27,11 +27,8 @@ module Fuey
         %(SNMPWalk #{state}. #{response})
       end
 
-      def status
-        {
-          :settings => snmp_walk_command,
-          :statusMessage => status_message
-        }.merge(super)
+      def settings
+        snmp_walk_command || ""
       end
 
       def to_s

data/lib/fuey_client/fuey/inspections/support/status.rb

@@ -0,0 +1,33 @@
+require "fuey_client/fuey/model_initializer"
+
+module Fuey
+  module Inspections
+    module Support
+      class Status
+        include ModelInitializer
+        include Comparable
+
+        attr_accessor :type, :name, :status, :settings, :status_message
+
+        def passed?
+          status == 'passed'
+        end
+
+        def failed?
+          status == 'failed'
+        end
+
+        def attributes
+          [:type, :name, :status, :settings, :status_message].inject(Hash.new) do |memo, attr|
+            memo[attr] = self.send(attr)
+            memo
+          end
+        end
+
+        def <=>(another)
+          attributes.hash <=> another.attributes.hash
+        end
+      end
+    end
+  end
+end

data/lib/fuey_client/fuey/redis.rb

@@ -0,0 +1,11 @@
+require "redis"
+
+module Fuey
+  class Redis
+    def self.instance
+      @@redis ||= ::Redis.new(
+                              :host => Config::Redis.host,
+                              :port => Config::Redis.port )
+    end
+  end
+end

data/lib/fuey_client/fuey/reporters.rb

@@ -1,2 +1,2 @@
-require "fuey_client/fuey/reporters/redis"
+require "fuey_client/fuey/reporters/notification_queue"
 require "fuey_client/fuey/reporters/error_logger"

data/lib/fuey_client/fuey/reporters/error_logger.rb

@@ -4,8 +4,8 @@ module Fuey
   module Reporters
     class ErrorLogger
       def update(status)
-        if status[:status] == 'failed'
-          Log.alert "#{status[:name]} failed. #{status[:statusMessage]}"
+        if status.failed?
+          Log.alert "#{status.name} failed. #{status.status_message}"
         end
       end
     end

data/lib/fuey_client/fuey/reporters/notification_queue.rb

@@ -0,0 +1,47 @@
+require "json"
+require "fuey_client/fuey/redis"
+
+module Fuey
+  module Reporters
+    class NotificationQueue
+      def initialize(redis)
+        @_redis = redis
+      end
+
+      def update(type, *args)
+        self.send("publish_#{type}", args)
+        true
+      end
+
+      def publish_update(args)
+        trace_name, statuses = args[0], args[1]
+        status = statuses.first
+        message = [ trace_name, status.attributes ]
+        @_redis.publish "fuey.trace.update", message.to_json
+      end
+
+      def publish_complete(args)
+        trace = args.first
+        message = {
+          :time => Time.now.strftime("%Y%m%d%H%M%S"),
+          :name => trace.name,
+          :status => trace.status,
+          :status_message => trace.status_message,
+          :steps => trace.steps.map(&:status).map(&:attributes)
+        }
+        @_redis.lpush trace.name.downcase, message.to_json
+      end
+
+      def publish_new(args)
+        trace_name, statuses = args[0], args[1]
+        message = {
+          :name => trace_name,
+          :status => "executed",
+          :status_message => "",
+          :steps => statuses.map(&:attributes)
+        }
+        @_redis.publish "fuey.trace.new", message.to_json
+      end
+    end
+  end
+end

data/lib/fuey_client/fuey/trace.rb

@@ -3,36 +3,36 @@ require "fuey_client/fuey/reporters"
 require "active_support"
 require "observer"
 
-
 module Fuey
   class Trace
     include ModelInitializer
     include Observable
 
-    attr_accessor :name, :steps
+    attr_accessor :name
 
     def initialize(args)
       super(args)
-      @steps ||= Array.new
     end
 
-    def self.all
-      Config::Fuey.traces.keys.map do |trace_name|
-        trace = Trace.new :name => trace_name
-        Config::Fuey.traces.send(trace_name).each do |step|
-          inspection_class = ActiveSupport::Inflector.constantize %(Fuey::Inspections::#{step.keys.first})
-          inspection = inspection_class.new(step.values.first)
-          inspection.add_observer(trace)
-          inspection.add_observer(error_logger)
-          trace.steps.push inspection
-        end
-        trace
-      end
+    def receiver=(observer)
+      add_observer observer
+    end
+
+    def add_step(inspection)
+      inspection.add_observer(self)
+      inspection.add_observer(error_logger)
+      steps.push inspection
+      inspection
+    end
+
+    def steps
+      @_steps ||= Array.new
     end
 
-    def self.error_logger
-      @@error_logger ||= Fuey::Reporters::ErrorLogger.new
+    def error_logger
+      @_error_logger ||= Fuey::Reporters::ErrorLogger.new
     end
+    private :error_logger
 
     def to_s
       %(#{name}: [#{steps.join(', ')}])
@@ -41,42 +41,40 @@ module Fuey
     # Handle updates from inpsections via observation
     def update(status)
       changed
-      notify_observers(
-                       "fuey.trace.update",
-                       {
-                         :name => name,
-                         :status => status[:status],
-                         :statusMessage => status[:statusMessage],
-                         :steps => [ status ]
-                       })
+      notify_observers :update, name, [status]
+      true
+    end
+
+    def status
+      @_current ? @_current.state : "pending"
+    end
+
+    def status_message
+      @_current.failed? ? @_current.status_message : ""
     end
 
     def run
       changed
-      notify_observers(
-                       "fuey.trace.new",
-                       {
-                         :name => name,
-                         :status => "executed",
-                         :statusMessage => "",
-                         :steps => steps.map(&:status)
-                       }
-                       )
+      notify_observers :new, name, steps.map(&:status)
+
       ActiveSupport::Notifications.instrument("run.trace", {:trace => self.to_s}) do
-        run, failed, current = 0, 0, ""
+        run, failed, @_current = 0, 0, nil
         steps.each do |step|
           run += 1
-          current = step.name
+          @_current = step
           step.execute
           if step.failed?
             failed += 1
             break
           end
         end
+
+        changed
+        notify_observers :complete, self
         if failed == 0
           %(#{name} passed. #{steps.size} steps, #{run} executed, #{failed} failed.)
         else
-          %(#{name} failed on #{current}. #{steps.size} steps, #{run} executed, #{failed} failed.)
+          %(#{name} failed on #{@_current.name}. #{steps.size} steps, #{run} executed, #{failed} failed.)
         end
       end
     end

data/lib/fuey_client/fuey/trace_repository.rb

@@ -0,0 +1,21 @@
+require "fuey_client/fuey/trace"
+
+module Fuey
+  class TraceRepository
+    def all
+      traces ||= Config::Fuey.traces.keys.map do |trace_name|
+        fetch trace_name
+      end
+    end
+
+    def fetch(trace_name)
+      trace = Trace.new :name => trace_name
+      Config::Fuey.traces.send(trace_name).each do |step|
+        inspection_class = ActiveSupport::Inflector.constantize %(Fuey::Inspections::#{step.keys.first})
+        inspection = inspection_class.new(step.values.first)
+        trace.add_step inspection
+      end
+      trace
+    end
+  end
+end

data/lib/fuey_client/version.rb

@@ -1,3 +1,3 @@
 module FueyClient
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/spec/fuey_client/fuey/inspections/inspection_spec.rb

@@ -29,11 +29,14 @@ describe Fuey::Inspections::Inspection do
     def expects_notification_of(*states)
       states.each do |state|
         self.should_receive(:update).
-          with({
-                 :type => @inspection.class.to_s,
-                 :name => @inspection.name,
-                 :status => state
-               })
+          with(Fuey::Inspections::Support::Status.new(
+                                                      :type => @inspection.class.to_s,
+                                                      :name => @inspection.name,
+                                                      :status => state,
+                                                      :settings => nil,
+                                                      :status_message => nil
+                                                      )
+               )
       end
     end
   end

data/spec/fuey_client/fuey/inspections/rfc_ping_spec.rb

@@ -16,7 +16,7 @@ describe Fuey::Inspections::RFCPing do
   Given (:rfc_ping) { Fuey::Inspections::RFCPing.new config }
 
   describe "status" do
-    Then { expect( rfc_ping.status[:settings] ).to_not include('passwd') }
+    Then { expect( rfc_ping.status.settings ).to_not include('passwd') }
   end
 
   context "when the ping fails" do

data/spec/fuey_client/fuey/inspections/support/status_spec.rb

@@ -0,0 +1,54 @@
+require 'spec_helper'
+
+describe Fuey::Inspections::Support::Status do
+
+  describe "attributes" do
+    Then { expect( subject ).to respond_to(:type) }
+    Then { expect( subject ).to respond_to(:name) }
+    Then { expect( subject ).to respond_to(:status) }
+    Then { expect( subject ).to respond_to(:settings) }
+    Then { expect( subject ).to respond_to(:status_message) }
+  end
+
+  describe "passed?" do
+    Given (:status) { Fuey::Inspections::Support::Status.new :status => 'passed' }
+    Then  { expect( status ).to be_passed }
+    Then  { expect( status ).to_not be_failed }
+  end
+
+  describe "failed?" do
+    Given (:status) { Fuey::Inspections::Support::Status.new :status => 'failed' }
+    Then  { expect( status ).to_not be_passed }
+    Then  { expect( status ).to be_failed }
+  end
+
+  describe "equality" do
+    Given (:attributes) { { :name => "Status 1", :status => "pending", :type => "Inspection" } }
+
+    context "when both have same attributes" do
+      Given (:status1) { Fuey::Inspections::Support::Status.new attributes.clone }
+      Given (:status2) { Fuey::Inspections::Support::Status.new attributes.clone }
+      Then  { expect( status1 ).to eq( status2 ) }
+    end
+
+    context "when both have same values, but one has additional key with a nil value" do
+      Given (:status1) { Fuey::Inspections::Support::Status.new attributes.clone }
+      Given (:status2) { Fuey::Inspections::Support::Status.new attributes.clone.merge({:settings => nil}) }
+      Then  { expect( status1 ).to eq( status2 ) }
+    end
+
+    context "when both only have a different status" do
+      Given (:status1) { Fuey::Inspections::Support::Status.new attributes.clone }
+      Given (:status2) { Fuey::Inspections::Support::Status.new attributes.clone.merge({:status => 'failed'}) }
+      Then  { expect( status1 ).to_not eq( status2 ) }
+    end
+
+    context "when both only have a different name" do
+      Given (:status1) { Fuey::Inspections::Support::Status.new attributes.clone }
+      Given (:status2) { Fuey::Inspections::Support::Status.new attributes.clone.merge({:name => 'Status X'}) }
+      Then  { expect( status1 ).to_not eq( status2 ) }
+    end
+  end
+
+
+end

data/spec/fuey_client/fuey/reporters/notification_queue_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe Fuey::Reporters::NotificationQueue do
+  Given (:redis) { double "Redis" }
+  Given (:q) { Fuey::Reporters::NotificationQueue.new redis }
+
+  describe "receiving updates for new traces" do
+    Given (:statuses)    { [create_status("Ping 1"), create_status("Ping 2")] }
+    Given (:json_string) { {
+            :name => "QA Alpha Trace",
+            :status => "executed",
+            :status_message => "",
+            :steps => statuses.map(&:attributes)
+          }.to_json }
+    Given { redis.should_receive(:publish).with("fuey.trace.new", json_string) }
+    When  (:result) { q.update :new, "QA Alpha Trace", statuses }
+    Then  { expect( result ).to be_true, "and publish to Redis" }
+  end
+
+  describe "receiving updates for existing traces" do
+    Given (:statuses)    { [create_status("Ping 1")] }
+    Given (:json_string) {
+      ["QA Alpha Trace", statuses.first.attributes].to_json
+    }
+    Given { redis.should_receive(:publish).with("fuey.trace.update", json_string) }
+    When  (:result) { q.update :update, "QA Alpha Trace", statuses }
+    Then  { expect( result ).to be_true, "and publish to Redis" }
+  end
+
+  def create_status(name)
+    Fuey::Inspections::Support::Status.new :name => name
+  end
+end

data/spec/fuey_client/fuey/trace_repository_spec.rb

@@ -0,0 +1,73 @@
+require 'spec_helper'
+
+describe Fuey::TraceRepository do
+  after(:each) { Fuey::Config::Fuey.reload_configuration }
+
+  describe "retrieving all configured traces" do
+    context "when configured for no traces" do
+      Given { Fuey::Config::Fuey.test_with(no_traces) }
+      When  (:result) { Fuey::TraceRepository.new.all }
+      Then  { expect( result ).to be_empty }
+    end
+
+    context "when configured with one trace" do
+      Given { Fuey::Config::Fuey.test_with(two_pings) }
+      When  (:result) { Fuey::TraceRepository.new.all }
+      Then  { expect( result ).to have(1).items }
+      And   { expect( result.first ).to be_a(Fuey::Trace) }
+      And   { expect( result.first ).to have(2).steps }
+      And   { expect( result.first.steps[0] ).to  ping("Google").at("8.8.8.8") }
+      And   { expect( result.first.steps[1] ).to  ping("Self").at("172.0.0.1") }
+    end
+  end
+
+  RSpec::Matchers.define :ping do |name|
+    match do |actual|
+      (actual.name == name) && (actual.host == @host)
+    end
+
+    chain :at do |host|
+      @host = host
+    end
+
+    failure_message_for_should do
+      %(should have pinged #{name} at #{@host}, but was #{actual.name} and #{actual.host})
+    end
+
+    failure_message_for_should_not do
+      %(should not have pinged #{actual.host})
+    end
+
+    description do
+      %(should ping #{name} at #{@host})
+    end
+  end
+
+  def two_pings
+    {
+      "traces" => {
+        "two_pings" =>
+        [
+         {
+           "Ping" => {
+             "name" => "Google",
+             "host" => "8.8.8.8"
+           }
+         },
+         {
+           "Ping" => {
+             "name" => "Self",
+             "host" => "172.0.0.1"
+           }
+         }
+        ]
+      }
+    }
+  end
+
+  def no_traces
+    {
+      "traces" => {}
+    }
+  end
+end

data/spec/fuey_client/fuey/trace_spec.rb

@@ -1,90 +1,47 @@
 require 'spec_helper'
 
 describe Fuey::Trace do
-  after(:each) { Fuey::Config::Fuey.reload_configuration }
-
-  describe "retrieving all configured traces" do
-    context "when configured for no traces" do
-      Given { Fuey::Config::Fuey.test_with(no_traces) }
-      When  (:result) { Fuey::Trace.all }
-      Then  { expect( result ).to be_empty }
-    end
-
-    context "when configured with one trace" do
-      Given { Fuey::Config::Fuey.test_with(two_pings) }
-      When  (:result) { Fuey::Trace.all }
-      Then  { expect( result ).to have(1).items }
-      And   { expect( result.first ).to be_a(Fuey::Trace) }
-      And   { expect( result.first ).to have(2).steps }
-      And   { expect( result.first.steps[0] ).to  ping("Google").at("8.8.8.8") }
-      And   { expect( result.first.steps[1] ).to  ping("Self").at("172.0.0.1") }
-    end
-  end
-
   describe "running a trace" do
     context "when the first step fails" do
-      Given (:step1) { double(Fuey::Inspections::Ping, :name => "step1", :execute => nil, :failed? => true, :status => {}) }
-      Given (:step2) { double(Fuey::Inspections::Ping, :status => {}) }
-      Given { step2.should_not_receive(:execute) }
-      When  (:result) { Fuey::Trace.new(:name => "trace1", :steps => [step1, step2]).run }
-      Then  { expect( result ).to eql(%[trace1 failed on step1. 2 steps, 1 executed, 1 failed.]) }
+      Given  (:trace) { Fuey::Trace.new :name => "trace1" }
+      Given! (:step1) { trace.add_step failed_inspection.new :name => "step1" }
+      Given! (:step2) { trace.add_step successful_inspection.new :name => "step2" }
+      Given  { step2.should_not_receive(:execute) }
+      When   (:result) { trace.run }
+      Then   { expect( result ).to eql(%[trace1 failed on step1. 2 steps, 1 executed, 1 failed.]) }
     end
 
     context "when all steps pass" do
-      Given (:step1) { double(Fuey::Inspections::Ping, :name => "step1", :execute => nil, :failed? => false, :status => {}) }
-      Given (:step2) { double(Fuey::Inspections::Ping, :name => "step2", :execute => nil, :failed? => false, :status => {}) }
-      When  (:result) { Fuey::Trace.new(:name => "trace1", :steps => [step1, step2]).run }
-      Then  { expect( result ).to eql(%[trace1 passed. 2 steps, 2 executed, 0 failed.]) }
+      Given  (:trace) { Fuey::Trace.new :name => "trace1" }
+      Given! (:step1) { trace.add_step successful_inspection.new :name => "step1" }
+      Given! (:step2) { trace.add_step successful_inspection.new :name => "step2" }
+      When   (:result){ trace.run }
+      Then   { expect( result ).to eql(%[trace1 passed. 2 steps, 2 executed, 0 failed.]) }
     end
   end
 
-  RSpec::Matchers.define :ping do |name|
-    match do |actual|
-      (actual.name == name) && (actual.host == @host)
-    end
-
-    chain :at do |host|
-      @host = host
-    end
+  def successful_inspection
+    Class.new(Fuey::Inspections::Inspection) do
+      def _execute
+        self.pass
+      end
 
-    failure_message_for_should do
-      %(should have pinged #{name} at #{@host}, but was #{actual.name} and #{actual.host})
+      def add_observer(observer)
+        # dont observe
+      end
     end
+  end
 
-    failure_message_for_should_not do
-      %(should not have pinged #{actual.host})
-    end
+  def failed_inspection
+    Class.new(Fuey::Inspections::Inspection) do
+      def _execute
+        self.fail
+      end
 
-    description do
-      %(should ping #{name} at #{@host})
+      def add_observer(observer)
+        # dont observe
+      end
     end
   end
 
-  def two_pings
-    {
-      "traces" => {
-                   "two_pings" =>
-                   [
-                    {
-                      "Ping" => {
-                        "name" => "Google",
-                        "host" => "8.8.8.8"
-                      }
-                    },
-                    {
-                      "Ping" => {
-                        "name" => "Self",
-                        "host" => "172.0.0.1"
-                      }
-                    }
-                   ]
-      }
-    }
-  end
-
-  def no_traces
-    {
-      "traces" => {}
-    }
-  end
 end

data/spec/matchers/inspection_shared_examples.rb

@@ -17,11 +17,11 @@ shared_examples "an inspection" do
 
     describe "and have specific pieces of information" do
       When (:status) { described_class.new({:name => 'descriptive'}).status }
-      Then { expect( status[:type] ).to eql(described_class.to_s.split('::').last) }
-      And  { expect( status[:name] ).to eql('descriptive') }
-      And  { expect( status[:settings] ).to_not be_nil }
-      And  { expect( status[:status] ).to eql("pending") }
-      And  { expect( status[:statusMessage] ).to_not be_nil }
+      Then { expect( status.type ).to eql(described_class.to_s.split('::').last) }
+      And  { expect( status.name ).to eql('descriptive') }
+      And  { expect( status.settings ).to_not be_nil }
+      And  { expect( status.status ).to eql("pending") }
+      And  { expect( status.status_message ).to_not be_nil }
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fuey_client
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Matt Snyder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-04 00:00:00.000000000 Z
+date: 2013-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: configurethis
@@ -141,20 +141,25 @@ files:
 - lib/fuey_client/fuey/inspections/snmp_walk.rb
 - lib/fuey_client/fuey/inspections/support/sap.rb
 - lib/fuey_client/fuey/inspections/support/shell_command.rb
+- lib/fuey_client/fuey/inspections/support/status.rb
 - lib/fuey_client/fuey/log.rb
 - lib/fuey_client/fuey/model_initializer.rb
 - lib/fuey_client/fuey/null_object.rb
+- lib/fuey_client/fuey/redis.rb
 - lib/fuey_client/fuey/reporters.rb
 - lib/fuey_client/fuey/reporters/error_logger.rb
-- lib/fuey_client/fuey/reporters/redis.rb
+- lib/fuey_client/fuey/reporters/notification_queue.rb
 - lib/fuey_client/fuey/trace.rb
+- lib/fuey_client/fuey/trace_repository.rb
 - lib/fuey_client/version.rb
-- spec/fuey_client/fuey/#trace_spec.rb#
 - spec/fuey_client/fuey/client_spec.rb
 - spec/fuey_client/fuey/inspections/inspection_spec.rb
 - spec/fuey_client/fuey/inspections/ping_spec.rb
 - spec/fuey_client/fuey/inspections/rfc_ping_spec.rb
 - spec/fuey_client/fuey/inspections/snmpwalk_spec.rb
+- spec/fuey_client/fuey/inspections/support/status_spec.rb
+- spec/fuey_client/fuey/reporters/notification_queue_spec.rb
+- spec/fuey_client/fuey/trace_repository_spec.rb
 - spec/fuey_client/fuey/trace_spec.rb
 - spec/matchers/inspection_shared_examples.rb
 - spec/matchers/pass_fail.rb
@@ -187,12 +192,14 @@ specification_version: 4
 summary: Client for inspecting server state and reports it back to Fuey. Requires
   the Fuey web app to have any value.
 test_files:
-- spec/fuey_client/fuey/#trace_spec.rb#
 - spec/fuey_client/fuey/client_spec.rb
 - spec/fuey_client/fuey/inspections/inspection_spec.rb
 - spec/fuey_client/fuey/inspections/ping_spec.rb
 - spec/fuey_client/fuey/inspections/rfc_ping_spec.rb
 - spec/fuey_client/fuey/inspections/snmpwalk_spec.rb
+- spec/fuey_client/fuey/inspections/support/status_spec.rb
+- spec/fuey_client/fuey/reporters/notification_queue_spec.rb
+- spec/fuey_client/fuey/trace_repository_spec.rb
 - spec/fuey_client/fuey/trace_spec.rb
 - spec/matchers/inspection_shared_examples.rb
 - spec/matchers/pass_fail.rb

data/lib/fuey_client/fuey/reporters/redis.rb

@@ -1,20 +0,0 @@
-require "redis"
-require "json"
-
-module Fuey
-  module Reporters
-    class Redis
-      def redis
-        @@redis ||= ::Redis.new(
-                                :host => Config::Redis.host,
-                                :port => Config::Redis.port )
-      end
-      private :redis
-
-      # Handles update from observable
-      def update(channel, message)
-        redis.publish channel, message.to_json
-      end
-    end
-  end
-end

data/spec/fuey_client/fuey/#trace_spec.rb#

@@ -1,90 +0,0 @@
-require 'spec_helper'
-
-describe Fuey::Trace do
-  after(:each) { Fuey::Config.reload_configuration }
-
-  describe "retrieving all configured traces" do
-    context "when configured for no traces" do
-      Given { Fuey::Config.test_with(no_traces) }
-      When  (:result) { Fuey::Trace.all }
-      Then  { expect( result ).to be_empty }
-    end
-
-    context "when configured with one trace" do
-      Given { Fuey::Config.test_with(two_pings) }
-      When  (:result) { Fuey::Trace.all }
-      Then  { expect( result ).to have(1).items }
-      And   { expect( result.first ).to be_a(Fuey::Trace) }
-      And   { expect( result.first ).to have(2).steps }
-      And   { expect( result.first.steps[0] ).to  ping("Google").at("8.8.8.8") }
-      And   { expect( result.first.steps[1] ).to  ping("Self").at("172.0.0.1") }
-    end
-  end
-
-  describe "running a trace" do
-    context "when the first step fails" do
-      Given (:step1) { double(Fuey::Inspections::Ping, :name => "step1", :execute => false) }
-      Given (:step2) { double(Fuey::Inspections::Ping) }
-      Given { step2.should_not_receive(:execute) }
-      When  (:result) { Fuey::Trace.new(:name => "trace1", :steps => [step1, step2]).run }
-      Then  { expect( result ).to eql(%[trace1 failed on step1. 2 steps, 1 executed, 1 failed.]) }
-    end
-
-    context "when all steps pass" do
-      Given (:step1) { double(Fuey::Inspections::Ping, :name => "step1", :execute => true) }
-      Given (:step2) { double(Fuey::Inspections::Ping, :name => "step2", :execute => true) }
-      When  (:result) { Fuey::Trace.new(:name => "trace1", :steps => [step1, step2]).run }
-      Then  { expect( result ).to eql(%[trace1 passed. 2 steps, 2 executed, 0 failed.]) }
-    end
-  end
-
-  RSpec::Matchers.define :ping do |name|
-    match do |actual|
-      (actual.name == name) && (actual.host == @host)
-    end
-
-    chain :at do |host|
-      @host = host
-    end
-
-    failure_message_for_should do
-      %(should have pinged #{name} at #{@host}, but was #{actual.name} and #{actual.host})
-    end
-
-    failure_message_for_should_not do
-      %(should not have pinged #{actual.host})
-    end
-
-    description do
-      %(should ping #{name} at #{@host})
-    end
-  end
-
-  def two_pings
-    {
-      "traces" => {
-                   "two_pings" =>
-                   [
-                    {
-                      "Ping" => {
-                        "name" => "Google",
-                        "host" => "8.8.8.8"
-                      }
-                    },
-                    {
-                      "Ping" => {
-                        "name" => "Self",
-                        "host" => "172.0.0.1"
-                      }
-                    }
-                   ]
-      }
-    }
-  end
-
-  def no_traces
-    {
-      "traces" => {}
-    }
-  end
-end