fudge 0.2.3 → 0.3.0

data/lib/fudge/tasks.rb

@@ -31,5 +31,6 @@ module Fudge
     require 'fudge/tasks/cane'
     require 'fudge/tasks/flog'
     require 'fudge/tasks/flay'
+    require 'fudge/tasks/brakeman'
   end
 end

data/lib/fudge/tasks/brakeman.rb

@@ -0,0 +1,50 @@
+module Fudge
+  module Tasks
+    # Allow use of Brakeman securty scanner
+    #
+    #    task :brakeman
+    # runs brakeman with max score of 0
+    #
+    #    task :brakeman, :max => 2
+    #
+    # sets max score to 2
+    #
+    # Any and all options can be defined
+    #
+    # task :brakeman
+    class Brakeman < Shell
+      include Helpers::BundleAware
+
+      private
+
+      def cmd(options={})
+        bundle_cmd("brakeman #{arguments}", options)
+      end
+
+
+      def check_for
+        [check_regex, method(:brakeman_checker)]
+      end
+
+      def check_regex
+        /\| Security Warnings \| (?<score>\d+) /
+      end
+
+      def brakeman_checker(matches)
+        score = matches[:score].to_i
+        if score > max_score
+          "Brakeman reported more than #{max_score} issues."
+        else
+          true
+        end
+      end
+
+      def max_score
+        options.fetch(:max, 0)
+      end
+
+    end
+
+    register Brakeman
+  end
+end

data/lib/fudge/version.rb

@@ -1,4 +1,4 @@
 module Fudge
   # Define gem version
-  VERSION = '0.2.3'
+  VERSION = '0.3.0'
 end

data/spec/lib/fudge/tasks/brakeman_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe Fudge::Tasks::Brakeman do
+  it { should be_registered_as :brakeman }
+
+  it_should_behave_like 'bundle aware'
+
+
+  let(:output_good) do
+    <<-EOF
+| Errors            | 0     |
+| Security Warnings | 0 (0) |
++-------------------+-------+
+
+EOF
+  end
+
+  let(:output_bad) do
+    <<-EOF
+| Errors            | 0     |
+| Security Warnings | 1 (0) |
++-------------------+-------+
+
++-----------------+-------+
+| Warning Type    | Total |
++-----------------+-------+
+| Mass Assignment | 1     |
++-----------------+-------+
+
+
+
+Model Warnings:
+
++------------+---------+-----------------+----------------------------------------------------------------------------+
+| Confidence | Model   | Warning Type    | Message                                                                    |
++------------+---------+-----------------+----------------------------------------------------------------------------+
+| Weak       | Address | Mass Assignment | Potentially dangerous attribute via_type_id available for mass assignment. |
++------------+---------+-----------------+----------------------------------------------------------------------------+
+
+EOF
+  end
+
+  describe :run do
+    it 'runs brakeman on the codebase' do
+      subject.should run_command 'brakeman '
+    end
+
+    it { should_not succeed_with_output output_bad }
+    it { should succeed_with_output output_good }
+
+    context 'when :max score is supplied' do
+      it 'fails when score is higher than max' do
+        task = described_class.new :max => 0
+        task.should_not succeed_with_output output_bad
+
+        task = described_class.new :max => 1
+        task.should succeed_with_output output_bad
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fudge
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
   prerelease: 
 platform: ruby
 authors:
@@ -332,6 +332,7 @@ files:
 - lib/fudge/tasks/composite_task.rb
 - lib/fudge/tasks/each_directory.rb
 - lib/fudge/tasks/shell.rb
+- lib/fudge/tasks/brakeman.rb
 - lib/fudge/tasks/rspec.rb
 - lib/fudge/tasks/flog.rb
 - lib/fudge/tasks/in_directory.rb
@@ -362,6 +363,7 @@ files:
 - spec/lib/fudge/with_directory_spec.rb
 - spec/lib/fudge/tasks/in_directory_spec.rb
 - spec/lib/fudge/tasks/cane_spec.rb
+- spec/lib/fudge/tasks/brakeman_spec.rb
 - spec/lib/fudge/tasks/bundler_spec.rb
 - spec/lib/fudge/tasks/rspec_spec.rb
 - spec/lib/fudge/tasks/flog_spec.rb
@@ -391,7 +393,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2538137383962249377
+      hash: 2966992207496478267
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -400,7 +402,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2538137383962249377
+      hash: 2966992207496478267
 requirements: []
 rubyforge_project: fudge
 rubygems_version: 1.8.23
@@ -419,6 +421,7 @@ test_files:
 - spec/lib/fudge/with_directory_spec.rb
 - spec/lib/fudge/tasks/in_directory_spec.rb
 - spec/lib/fudge/tasks/cane_spec.rb
+- spec/lib/fudge/tasks/brakeman_spec.rb
 - spec/lib/fudge/tasks/bundler_spec.rb
 - spec/lib/fudge/tasks/rspec_spec.rb
 - spec/lib/fudge/tasks/flog_spec.rb