ftpmvc 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d700986fcf31bb2aa4321ab798886546bd8d018
-  data.tar.gz: 1fa9c85f95fb7d60956c0a68f2a4d3177d7469f1
+  metadata.gz: c1ce45b7b3c0fff939bd7cc90a3806c70b41eb18
+  data.tar.gz: 45757c6f7f22060f65a9862bb965e0800df7f937
 SHA512:
-  metadata.gz: 4408ed3ff3689c6ade5af7946a9825fe20227684a3564ec910e156c0ec5b70c31f21afa9b46a8a534537a13ac3ba131a0d623a6a4a34904846fe4767fc39560c
-  data.tar.gz: bda295c20d059283c9c448059be5fd07e9f27873bd85c97b5525d5f1d8e888374f8d1a6aab6786d84936adc93d1a52f58708674895222ab3f752ae044d2d64b8
+  metadata.gz: 454896b3e3856d5ab9dc01035d002acb2d9b5962c424574e1e77fe621b86e48ff4dd5fe1c7ebb71124e6b9d317d1e2c04292951328a717e3af4c7e83adf31482
+  data.tar.gz: ff6da3c34fa074407dce7f2601ad0445b73b6002ce31fed4f05feab0a9096df96be7bdd66b9611cf9b9b3b853cdfbffa50cabb5f975ff43b608ed1265c53af32

data/lib/ftpmvc/application.rb

@@ -6,6 +6,7 @@ require 'ftpmvc/authenticator/promiscuous'
 
 module FTPMVC
   class Application
+    include Logger
     extend Forwardable
 
     def_delegators :@filter_chain, :index, :get, :directory?, :exists?, :put
@@ -21,8 +22,17 @@ module FTPMVC
       @authenticator ||= Authenticator::Promiscuous.new
     end
 
+    def handle_exception(e)
+      logger.error %Q[#{e.class}: #{e.message}\n#{e.backtrace.join("\n")}]
+      @exception_handler.call(e) unless @exception_handler.nil?
+    end
+
     protected
 
+    def on_exception(&block)
+      @exception_handler = block
+    end
+
     def filter(filter_class, options={})
       @filter_chain = filter_class.new(@fs, @filter_chain, options)
     end

data/lib/ftpmvc/server.rb

@@ -14,10 +14,7 @@ module FTPMVC
       driver = Ftpd::Driver.new(application)
       @server = ::Ftpd::FtpServer.new(driver)
       @server.interface, @server.port = @address, @port
-      @server.on_exception do |e|
-        puts e
-        puts e.backtrace
-      end
+      @server.on_exception { |e| application.handle_exception(e) }
       @server.start
       @port = @server.bound_port
       self

data/lib/ftpmvc/version.rb

@@ -1,3 +1,3 @@
 module FTPMVC
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/spec/lib/ftpmvc/application_spec.rb

@@ -93,4 +93,29 @@ describe FTPMVC::Application do
       expect(application.authenticate('fabio', 'iS2grails')).to be true
     end
   end
+
+  describe '#handle_exception' do
+    let(:exception) { Exception.new }
+    let(:application) do
+      handler = lambda { |e| @exception_handler_executed = true }
+      FTPMVC::Application.new do
+        on_exception(&handler)
+      end
+    end
+    before do
+      exception.set_backtrace([])
+    end
+    it 'calls exception handler' do
+      application.handle_exception(exception)
+      expect(@exception_handler_executed).to be true
+    end
+    context 'when exception handler is not defined' do
+      let(:application) do
+        FTPMVC::Application.new
+      end
+      it 'does not call nil' do
+        expect { application.handle_exception(exception) }.to_not raise_error
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ftpmvc
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - André Aizim Kelmanson