ftpmvc 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c44c716cbea576f3370d4ca4e9558cd6d574760d
-  data.tar.gz: b9df269b3d01e96c29aa18cb264f61fc3f7ad4e7
+  metadata.gz: d6d7ed7fa4e8b557a99a8bf78cedd55871cbeaa2
+  data.tar.gz: 235185d4a033567403ac021cc7e2a68b7a7d2447
 SHA512:
-  metadata.gz: 9d85dc01c5c985c153213a5619b9462748cd229cde5885ffe01e1a87d7db2c0782a0a1ca8ac1462c5d507ef608f6205dcb659d8eabaa71c6e146bbf22ba33f5e
-  data.tar.gz: 74aec4ff03549eebf18a81cd85c2dff53c35ef131520c89739fd71e0fa402afc53c5c8337ef605b3a0a0f5acd94a00660d234485f9f04d5e8d5b485a2b6643ad
+  metadata.gz: f9379f74972eb4bca4bbccd5144d0ed62ca32646269d4ec81c055b1e949125342186329653a0fe7d5c6c13c1b4d5834adb89c860622eb0a513fa490c31efb758
+  data.tar.gz: 83709da24052ac97688dcba8698267470828fcd74815d2b4129f763e1107b00a6bf6c27005fb7ab0c9eb05c401af58521947a97139e4182f827c45752a047180

data/lib/ftpmvc/application.rb

@@ -17,17 +17,23 @@ module FTPMVC
       instance_eval(&block) if block_given?
     end
 
-    protected
-
     def auth
       @authenticator ||= Authenticator::Promiscuous.new
     end
 
+    protected
+
     def filter(filter_class, options={})
       @filter_chain = filter_class.new(@fs, @filter_chain, options)
     end
 
-    def authenticator(authenticator)
+    def authenticator(authenticator, options={})
+      if authenticator.kind_of?(Symbol)
+        authenticator = FTPMVC::Authenticator.const_get(authenticator.to_s.camelize)
+      end
+      if authenticator.kind_of?(Class)
+        authenticator = authenticator.new(options)
+      end
       @authenticator = authenticator
     end
 

data/lib/ftpmvc/authenticator/basic.rb

@@ -1,12 +1,12 @@
 module FTPMVC
   module Authenticator
-    class Basic
+    class Basic < Struct.new(:users)
       def initialize(options={})
-        @users = options[:users]
+        super options[:users]
       end
 
       def authenticate(username, password)
-        @users[username] == password
+        users[username] == password
       end
     end
   end

data/lib/ftpmvc/authenticator.rb

@@ -1 +1,2 @@
-include 'ftpmvc/authenticator/promiscuous'
+require 'ftpmvc/authenticator/promiscuous'
+require 'ftpmvc/authenticator/basic'

data/lib/ftpmvc/driver.rb

@@ -12,7 +12,7 @@ module FTPMVC
     end
 
     def authenticate(username, password)
-      yield true
+      yield @application.authenticate(username, password)
     end
 
     def change_dir(path)

data/lib/ftpmvc/version.rb

@@ -1,3 +1,3 @@
 module FTPMVC
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/spec/integration/authentication_spec.rb

@@ -0,0 +1,28 @@
+require './spec/spec_helper'
+
+require 'ftpmvc'
+
+describe 'Authentication' do
+  let(:app) do
+    FTPMVC::Application.new do
+      authenticator :basic, users: { 'fabio' => 'iS2grails' }
+    end
+  end
+
+  describe 'LOGIN' do
+    context 'when user/password is valid' do
+      it 'authenticates' do
+        with_application(app) do |ftp|
+          expect(ftp.login('fabio', 'iS2grails')).to be true
+        end
+      end
+    end
+    context 'when user/password is valid' do
+      it 'does not authenticate' do
+        with_application(app) do |ftp|
+          expect { ftp.login('lucas', 'pwd') }.to raise_error Net::FTPPermError
+        end
+      end
+    end
+  end
+end

data/spec/lib/ftpmvc/application_spec.rb

@@ -2,6 +2,7 @@ require './spec/spec_helper'
 
 require 'ftpmvc/application'
 require 'ftpmvc/file'
+require 'ftpmvc/authenticator/basic'
 
 describe FTPMVC::Application do
   describe '#filter' do
@@ -38,6 +39,39 @@ describe FTPMVC::Application do
     end
   end
 
+  describe '#authenticator' do
+    context 'when an instance is given' do
+      let(:application) do
+        FTPMVC::Application.new do
+          authenticator FTPMVC::Authenticator::Basic.new users: {}
+        end
+      end
+      it 'sets auth as that' do
+        expect(application.auth).to be_a_kind_of(FTPMVC::Authenticator::Basic)
+      end
+    end
+    context 'when a symbol is given' do
+      let(:application) do
+        FTPMVC::Application.new do
+          authenticator :basic, users: { 'a' => 'b' }
+        end
+      end
+      it 'initializes a class on FTPMVC::Authenticator with given options' do
+        expect(application.auth).to eq FTPMVC::Authenticator::Basic.new users: { 'a' => 'b' }
+      end
+    end
+    context 'when a class is given' do
+      let(:application) do
+        FTPMVC::Application.new do
+          authenticator FTPMVC::Authenticator::Basic, users: { 'a' => 'b' }
+        end
+      end
+      it 'initializes that class with given options' do
+        expect(application.auth).to eq FTPMVC::Authenticator::Basic.new users: { 'a' => 'b' }
+      end
+    end
+  end
+
   describe '#authenticate' do
     let(:custom_authenticator) { double('custom_authenticator') }
     let(:application) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ftpmvc
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - André Aizim Kelmanson
@@ -14,98 +14,98 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: terminal-notifier-guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: em-ftpd
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: FTP MVC framework
@@ -115,9 +115,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -143,6 +143,7 @@ files:
 - lib/ftpmvc/server.rb
 - lib/ftpmvc/test_helpers.rb
 - lib/ftpmvc/version.rb
+- spec/integration/authentication_spec.rb
 - spec/integration/operation_spec.rb
 - spec/lib/ftpmvc/access_filesystem_filter_spec.rb
 - spec/lib/ftpmvc/application_spec.rb
@@ -161,12 +162,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -176,6 +177,7 @@ signing_key:
 specification_version: 4
 summary: FTP MVC framework
 test_files:
+- spec/integration/authentication_spec.rb
 - spec/integration/operation_spec.rb
 - spec/lib/ftpmvc/access_filesystem_filter_spec.rb
 - spec/lib/ftpmvc/application_spec.rb