ftpd 0.3.2 → 0.4.0

data/features/ftp_server/append.feature

@@ -0,0 +1,94 @@
+Feature: Append
+
+  As a client
+  I want to append to a file
+  Because it is a log
+
+  Background:
+    Given the test server is started
+
+  Scenario: ASCII file with *nix line endings
+    Given a successful login
+    And the server has file "foo"
+    And the client has file "ascii_unix"
+    When the client successfully appends text "ascii_unix" onto "foo"
+    Then the remote file "foo" should match "foo" + "ascii_unix"
+
+  Scenario: ASCII file with windows line endings
+    Given a successful login
+    And the server has file "foo"
+    And the client has file "ascii_windows"
+    When the client successfully appends text "ascii_windows" onto "foo"
+    Then the remote file "foo" should match "foo" + "ascii_unix"
+
+  Scenario: Binary file
+    Given a successful login
+    And the server has file "foo"
+    And the client has file "binary"
+    When the client successfully appends binary "binary" onto "foo"
+    Then the remote file "foo" should match "foo" + "binary"
+
+  Scenario: Passive
+    Given a successful login
+    And the server has file "foo"
+    And the client has file "binary"
+    And the client is in passive mode
+    When the client successfully appends binary "binary" onto "foo"
+    Then the remote file "foo" should match "foo" + "binary"
+
+  Scenario: Destination missing
+    Given a successful login
+    And the client has file "binary"
+    When the client successfully appends binary "binary" onto "foo"
+    Then the remote file "foo" should match "binary"
+
+  Scenario: Subdir
+    Given a successful login
+    And the server has file "subdir/foo"
+    And the client has file "binary"
+    When the client successfully appends binary "binary" onto "subdir/foo"
+    Then the remote file "subdir/foo" should match "foo" + "binary"
+
+  Scenario: Non-root working directory
+    Given a successful login
+    And the server has file "subdir/foo"
+    And the client has file "binary"
+    And the client successfully cd's to "subdir"
+    When the client successfully appends binary "binary" onto "foo"
+    Then the remote file "subdir/foo" should match "foo" + "binary"
+
+  Scenario: Access denied
+    Given a successful login
+    And the client has file "foo"
+    When the client appends binary "foo" onto "forbidden"
+    Then the server returns an access denied error
+
+  Scenario: Missing directory
+    Given a successful login
+    And the client has file "binary"
+    When the client appends binary "binary" onto "subdir/foo"
+    Then the server returns a not found error
+
+  Scenario: Not logged in
+    Given a successful connection
+    And the client has file "foo"
+    When the client appends binary "foo" onto "foo"
+    Then the server returns a not logged in error
+
+  Scenario: Missing path
+    Given a successful login
+    When the client sends "APPE"
+    Then the server returns a syntax error
+
+  Scenario: File system error
+    Given a successful login
+    And the client has file "foo"
+    When the client appends text "foo" onto "unable"
+    Then the server returns an action not taken error
+
+  Scenario: Append not enabled
+    Given the test server lacks append
+    And a successful login
+    And the client has file "foo"
+    When the client appends text "foo" onto "bar"
+    Then the server returns an unimplemented command error

data/features/ftp_server/command_errors.feature

@@ -19,8 +19,6 @@ Feature: Command Errors
     Examples:
       | command |
       | ABOR    |
-      | ACCT    |
-      | APPE    |
       | REIN    |
       | REST    |
       | SITE    |

data/features/ftp_server/concurrent_sessions.feature

@@ -1,4 +1,4 @@
-Feature: Mode
+Feature: Concurrent Sessions
 
   As a client
   I want to start a session when there is another session

data/features/ftp_server/debug.feature

@@ -5,11 +5,13 @@ Feature: Debug
   So that I can fix FTP protocol problems
 
   Scenario: Debug enabled
-    Given the test server is started with debug
+    Given the test server has debug enabled
+    And the test server is started
     And a successful login
     Then the server should have written debug output
 
   Scenario: Debug disabled
-    Given the test server is started
+    Given the test server has debug disabled
+    And the test server is started
     And a successful login
     Then the server should have written no debug output

data/features/ftp_server/delete.feature

@@ -53,7 +53,7 @@ Feature: Delete
     Then the server returns a not logged in error
 
   Scenario: Delete not enabled
-    Given the test server is started without delete
+    Given the test server lacks delete
     And a successful login
     And the server has file "foo"
     When the client deletes "foo"

data/features/ftp_server/get.feature

@@ -73,7 +73,7 @@ Feature: Get
     Then the server returns an action not taken error
 
   Scenario: Read not enabled
-    Given the test server is started without read
+    Given the test server lacks read
     And a successful login
     And the server has file "foo"
     When the client gets text "foo"

data/features/ftp_server/get_tls.feature

@@ -5,7 +5,8 @@ Feature: Get TLS
   So that I have it on my computer
 
   Background:
-    Given the test server is started with explicit TLS
+    Given the test server has TLS mode "explicit"
+    And the test server is started
 
   Scenario: TLS
     pending "TLS not supported in active mode (see README)"

data/features/ftp_server/implicit_tls.feature

@@ -5,7 +5,8 @@ Feature: Put TLS
   Because I must serve out-of-date clients
 
   Background:
-    Given the test server is started with implicit TLS
+    Given the test server has TLS mode "implicit"
+    And the test server is started
 
   Scenario: Get
     pending "TLS not supported in active mode (see README)"

data/features/ftp_server/invertability.feature

@@ -0,0 +1,15 @@
+Feature: Get
+
+  As a client
+  I want a file to be the same when I get it as it was when I put it
+  So that I can use the FTP server for storage
+
+  Background:
+    Given the test server is started
+
+  Scenario: Binary file
+    Given a successful login
+    And the client has file "binary"
+    When the client successfully puts binary "binary"
+    And the client successfully gets binary "binary"
+    Then the local file "binary" should match its template

data/features/ftp_server/list.feature

@@ -79,7 +79,7 @@ Feature: List
     Then the server returns a not logged in error
 
   Scenario: List not enabled
-    Given the test server is started without list
+    Given the test server lacks list
     And a successful login
     When the client lists the directory
     Then the server returns an unimplemented command error

data/features/ftp_server/list_tls.feature

@@ -5,7 +5,8 @@ Feature: List TLS
   So that I can see what file to transfer
 
   Background:
-    Given the test server is started with explicit TLS
+    Given the test server has TLS mode "explicit"
+    And the test server is started
 
   Scenario: TLS
     pending "TLS not supported in active mode (see README)"

data/features/ftp_server/login_auth_level_account.feature

@@ -0,0 +1,51 @@
+Feature: Login
+
+  As a client
+  I want to log in
+  So that I can transfer files
+
+  Background:
+    Given the test server has auth level "AUTH_ACCOUNT"
+    And the test server is started
+
+  Scenario: Normal connection
+    Given a successful login
+    Then the server returns no error
+    And the client should be logged in
+
+  Scenario: Bad user
+    Given the client connects
+    When the client logs in with bad user
+    Then the server returns a login incorrect error
+    And the client should not be logged in
+
+  Scenario: Bad password
+    Given a successful connection
+    When the client logs in with bad password
+    Then the server returns a login incorrect error
+    And the client should not be logged in
+
+  Scenario: Bad account
+    Given a successful connection
+    When the client logs in with bad account
+    Then the server returns a login incorrect error
+    And the client should not be logged in
+
+  Scenario: ACCT without parameter
+    Given a successful connection
+    And the client sends a user
+    And the client sends a password
+    When the client sends "ACCT"
+    Then the server returns a syntax error
+
+  Scenario: PASS not followed by ACCT
+    Given a successful connection
+    And the client sends a user
+    And the client sends a password
+    When the client sends "NOOP"
+    Then the server returns a bad sequence error
+
+  Scenario: ACCT out of sequence
+    Given a successful connection
+    When the client sends "ACCT"
+    Then the server returns a bad sequence error

data/features/ftp_server/{login.feature → login_auth_level_password.feature}

@@ -5,7 +5,8 @@ Feature: Login
   So that I can transfer files
 
   Background:
-    Given the test server is started
+    Given the test server has auth level "AUTH_PASSWORD"
+    And the test server is started
 
   Scenario: Normal connection
     Given a successful login
@@ -14,13 +15,13 @@ Feature: Login
 
   Scenario: Bad user
     Given the client connects
-    When the client logs in with a bad user
+    When the client logs in with bad user
     Then the server returns a login incorrect error
     And the client should not be logged in
 
   Scenario: Bad password
     Given a successful connection
-    When the client logs in with a bad password
+    When the client logs in with bad password
     Then the server returns a login incorrect error
     And the client should not be logged in
 
@@ -51,11 +52,6 @@ Feature: Login
     When the client sends a password with no parameter
     Then the server returns a syntax error
 
-  Scenario: USER without parameter
-    Given a successful connection
-    And the client sends a user with no parameter
-    Then the server returns a syntax error
-
   Scenario: USER not followed by PASS
     Given a successful connection
     And the client sends a user

data/features/ftp_server/login_auth_level_user.feature

@@ -0,0 +1,31 @@
+Feature: Login
+
+  As a client
+  I want to log in
+  So that I can transfer files
+
+  Background:
+    Given the test server has auth level "AUTH_USER"
+    And the test server is started
+
+  Scenario: Normal connection
+    Given a successful login
+    Then the server returns no error
+    And the client should be logged in
+
+  Scenario: Bad user
+    Given the client connects
+    When the client logs in with bad user
+    Then the server returns a login incorrect error
+    And the client should not be logged in
+
+  Scenario: Already logged in
+    Given a successful login
+    When the client logs in
+    Then the server returns a bad sequence error
+    And the client should be logged in
+
+  Scenario: USER without parameter
+    Given a successful connection
+    And the client sends a user with no parameter
+    Then the server returns a syntax error

data/features/ftp_server/mkdir.feature

@@ -53,7 +53,7 @@ Feature: Make directory
     Then the server returns a not a directory error
 
   Scenario: Mkdir not enabled
-    Given the test server is started without mkdir
+    Given the test server lacks mkdir
     And a successful login
     When the client makes directory "foo"
     Then the server returns an unimplemented command error

data/features/ftp_server/name_list.feature

@@ -62,7 +62,7 @@ Feature: Name List
     Then the server returns a not logged in error
 
   Scenario: List not enabled
-    Given the test server is started without list
+    Given the test server lacks list
     And a successful login
     When the client name-lists the directory
     Then the server returns an unimplemented command error

data/features/ftp_server/name_list_tls.feature

@@ -6,7 +6,8 @@ Feature: Name List TLS
   And nobody else can
 
   Background:
-    Given the test server is started with explicit TLS
+    Given the test server has TLS mode "explicit"
+    And the test server is started
 
   Scenario: TLS
     pending "TLS not supported in active mode (see README)"

data/features/ftp_server/put.feature

@@ -72,7 +72,7 @@ Feature: Put
     Then the server returns an action not taken error
 
   Scenario: Write not enabled
-    Given the test server is started without write
+    Given the test server lacks write
     And a successful login
     And the client has file "foo"
     When the client puts text "foo"

data/features/ftp_server/put_tls.feature

@@ -5,7 +5,8 @@ Feature: Put TLS
   So that nobody can intercept it
 
   Background:
-    Given the test server is started with explicit TLS
+    Given the test server has TLS mode "explicit"
+    And the test server is started
 
   Scenario: TLS
     pending "TLS not supported in active mode (see README)"

data/features/ftp_server/put_unique.feature

@@ -49,7 +49,7 @@ Feature: Put Unique
     Then the server returns a not logged in error
 
   Scenario: Write not enabled
-    Given the test server is started without write
+    Given the test server lacks write
     And a successful login
     And the client has file "foo"
     When the client stores unique "foo"

data/features/ftp_server/rename.feature

@@ -78,7 +78,7 @@ Feature: Rename
     Then the server returns a syntax error
 
   Scenario: Rename not enabled
-    Given the test server is started without rename
+    Given the test server lacks rename
     And a successful login
     And the server has file "foo"
     When the client renames "foo" to "bar"

data/features/ftp_server/rmdir.feature

@@ -55,7 +55,7 @@ Feature: Remove directory
     Then the server returns a not a directory error
 
   Scenario: Rmdir not enabled
-    Given the test server is started without rmdir
+    Given the test server lacks rmdir
     And a successful login
     When the client removes directory "foo"
     Then the server returns an unimplemented command error

data/features/ftp_server/step_definitions/debug.rb

@@ -4,5 +4,5 @@ Then /^the server should have written( no)? debug output$/ do |neg|
            else
              :should_not
            end
-  @server.debug_output.send(method) == ''
+  server.debug_output.send(method) == ''
 end

data/features/ftp_server/step_definitions/test_server.rb

@@ -1,23 +1,24 @@
+def server
+  @server ||= TestServer.new
+end
+
 Given /^the test server is started$/ do
-  @server = TestServer.new
-  @server.start
+  server.start
+end
+
+Given /^the test server has TLS mode "(\w+)"$/ do |mode|
+  server.tls = mode.to_sym
 end
 
-Given /^the test server is started with(?: (\w+) TLS)?$/ do |mode|
-  mode ||= 'explicit'
-  @server = TestServer.new
-  @server.tls = mode.to_sym
-  @server.start
+Given /^the test server has debug (enabled|disabled)$/ do |state|
+  server.debug = state == 'enabled'
 end
 
-Given /^the test server is started with debug$/ do
-  @server = TestServer.new
-  @server.debug = true
-  @server.start
+Given /^the test server lacks (\w+)$/ do |feature|
+  server.send "#{feature}=", false
 end
 
-Given /^the test server is started without (\w+)$/ do |feature|
-  @server = TestServer.new
-  @server.send "#{feature}=", false
-  @server.start
+Given /^the test server has auth level "(.*?)"$/ do |auth_level|
+  auth_level = Ftpd.const_get(auth_level)
+  server.auth_level = auth_level
 end