RubyGems - ftpd - Versions diffs - 0.0.1.pre → 0.1.0 - Mend

ftpd 0.0.1.pre → 0.1.0

Potentially problematic release.

This version of ftpd might be problematic. Click here for more details.

Files changed (70) hide show

data/Gemfile +3 -1
data/Gemfile.lock +14 -14
data/README.md +71 -23
data/Rakefile +9 -3
data/VERSION +1 -1
data/examples/example.rb +132 -53
data/examples/hello_world.rb +32 -0
data/features/example/example.feature +18 -0
data/features/example/step_definitions/example_server.rb +3 -0
data/features/{command_errors.feature → ftp_server/command_errors.feature} +3 -0
data/features/ftp_server/concurrent_sessions.feature +14 -0
data/features/ftp_server/debug.feature +15 -0
data/features/{delete.feature → ftp_server/delete.feature} +23 -2
data/features/{directory_navigation.feature → ftp_server/directory_navigation.feature} +17 -4
data/features/ftp_server/file_structure.feature +43 -0
data/features/{get.feature → ftp_server/get.feature} +21 -10
data/features/ftp_server/get_tls.feature +18 -0
data/features/{list.feature → ftp_server/list.feature} +24 -30
data/features/ftp_server/list_tls.feature +21 -0
data/features/{login.feature → ftp_server/login.feature} +4 -2
data/features/ftp_server/mode.feature +43 -0
data/features/{name_list.feature → ftp_server/name_list.feature} +25 -31
data/features/ftp_server/name_list_tls.feature +22 -0
data/features/{noop.feature → ftp_server/noop.feature} +3 -0
data/features/{port.feature → ftp_server/port.feature} +3 -0
data/features/{put.feature → ftp_server/put.feature} +19 -11
data/features/ftp_server/put_tls.feature +18 -0
data/features/{quit.feature → ftp_server/quit.feature} +3 -0
data/features/ftp_server/step_definitions/debug.rb +8 -0
data/features/ftp_server/step_definitions/test_server.rb +12 -0
data/features/{syntax_errors.feature → ftp_server/syntax_errors.feature} +3 -0
data/features/ftp_server/type.feature +56 -0
data/features/step_definitions/error.rb +10 -3
data/features/step_definitions/list.rb +21 -4
data/features/step_definitions/login.rb +0 -2
data/features/step_definitions/server_files.rb +4 -0
data/features/step_definitions/stop_server.rb +3 -0
data/features/support/example_server.rb +58 -0
data/features/support/test_client.rb +1 -1
data/features/support/test_server.rb +106 -24
data/features/support/test_server_files.rb +30 -0
data/ftpd.gemspec +56 -25
data/lib/ftpd.rb +22 -4
data/lib/ftpd/disk_file_system.rb +137 -0
data/lib/ftpd/error.rb +9 -0
data/lib/ftpd/exception_translator.rb +29 -0
data/lib/ftpd/exceptions.rb +13 -0
data/lib/ftpd/file_system_error_translator.rb +21 -0
data/lib/ftpd/ftp_server.rb +8 -645
data/lib/ftpd/insecure_certificate.rb +10 -0
data/lib/ftpd/server.rb +15 -12
data/lib/ftpd/session.rb +569 -0
data/lib/ftpd/temp_dir.rb +10 -11
data/lib/ftpd/tls_server.rb +27 -15
data/lib/ftpd/translate_exceptions.rb +44 -0
data/rake_tasks/cucumber.rake +4 -2
data/rake_tasks/default.rake +1 -0
data/rake_tasks/spec.rake +3 -0
data/rake_tasks/test.rake +2 -0
data/sandbox/em-server.rb +37 -0
data/spec/disk_file_system_spec.rb +239 -0
data/spec/exception_translator_spec.rb +35 -0
data/spec/spec_helper.rb +5 -0
data/spec/translate_exceptions_spec.rb +40 -0
metadata +143 -115
data/features/concurrent_sessions.feature +0 -11
data/features/file_structure.feature +0 -40
data/features/mode.feature +0 -40
data/features/step_definitions/server.rb +0 -7
data/features/type.feature +0 -53

data/features/example/example.feature ADDED

@@ -0,0 +1,18 @@
+Feature: Example
+  As a programmer
+  I want to connect to the example
+  So that I can try this libary with an arbitrary FTP client
+  Background:
+    Given the example server is started
+  Scenario: Normal connection
+    Given a successful login
+    Then the server returns no error
+    And the client should be logged in
+  Scenario: Fetch README
+    Given a successful login
+    When the client successfully gets text "README"
+    Then the local file "README" should match the remote file

data/features/example/step_definitions/example_server.rb ADDED

@@ -0,0 +1,3 @@
+Given /^the example server is started$/ do
+  @server = ExampleServer.new
+end

data/features/{command_errors.feature → ftp_server/command_errors.feature} RENAMED

@@ -4,6 +4,9 @@ Feature: Command Errors
   I want good error messages
   So that I can figure out what went wrong
+  Background:
+    Given the test server is started
   Scenario: Unknown command
     Given a successful connection
     When the client sends command "foo"

data/features/ftp_server/concurrent_sessions.feature ADDED

@@ -0,0 +1,14 @@
+Feature: Mode
+  As a client
+  I want to start a session when there is another session
+  So that my session doesn't have to wait on the other
+  Background:
+    Given the test server is started
+  Scenario: Stream
+    Given a successful login
+    And the server has file "ascii_unix"
+    And the second client connects and logs in
+    Then the second client successfully does nothing

data/features/ftp_server/debug.feature ADDED

@@ -0,0 +1,15 @@
+Feature: Debug
+  As a client
+  I want to see debug output
+  So that I can fix FTP protocol problems
+  Scenario: Debug enabled
+    Given the test server is started with debug
+    And a successful login
+    Then the server should have written debug output
+  Scenario: Debug disabled
+    Given the test server is started
+    And a successful login
+    Then the server should have written no debug output

data/features/{delete.feature → ftp_server/delete.feature} RENAMED

@@ -4,12 +4,28 @@ Feature: Delete
   I want to delete files
   So that nobody can fetch them from the server
+  Background:
+    Given the test server is started
   Scenario: Delete a file
     Given a successful login
     And the server has file "foo"
     When the client successfully deletes "foo"
     Then the server should not have file "foo"
+  Scenario: Delete a file in a subdirectory
+    Given a successful login
+    And the server has file "foo/bar"
+    When the client successfully deletes "foo/bar"
+    Then the server should not have file "foo/bar"
+  Scenario: Change current directory
+    Given a successful login
+    And the server has file "foo/bar"
+    And the client successfully cd's to "foo"
+    When the client successfully deletes "bar"
+    Then the server should not have file "foo/bar"
   Scenario: Missing path
     Given a successful login
     And the server has file "foo"
@@ -21,11 +37,16 @@ Feature: Delete
     When the client deletes "foo"
     Then the server returns a not found error
-  Scenario: Path outside tree
+  Scenario: Access denied
     Given a successful login
-    When the client deletes "../usr/bin"
+    When the client deletes "forbidden"
     Then the server returns an access denied error
+  Scenario: File system error
+    Given a successful login
+    When the client deletes "unable"
+    Then the server returns an action not taken error
   Scenario: Not logged in
     Given a successful connection
     When the client deletes "foo"

data/features/{directory_navigation.feature → ftp_server/directory_navigation.feature} RENAMED

@@ -4,28 +4,41 @@ Feature: Change Directory
   I want to change the current directory
   So that I can use shorter paths
+  Background:
+    Given the test server is started
   Scenario: Change to subdirectory
     Given a successful login
     And the server has file "subdir/bar"
     When the client successfully cd's to "subdir"
     Then the current directory should be "/subdir"
-  Scenario: Change to parent
+  Scenario: Change to parent from subdir
     Given a successful login
     And the server has file "subdir/bar"
-    And the server has file "baz"
     And the client successfully cd's to "subdir"
     When the client successfully cd's up
     Then the current directory should be "/"
+  Scenario: Change to parent from root
+    Given a successful login
+    When the client successfully cd's up
+    Then the current directory should be "/"
+  Scenario: Change to file
+    Given a successful login
+    And the server has file "baz"
+    When the client cd's to "baz"
+    Then the server returns a not a directory error
   Scenario: No such directory
     Given a successful login
     When the client cd's to "subdir"
     Then the server returns a no such file error
-  Scenario: Path outside tree
+  Scenario: Access denied
     Given a successful login
-    When the client cd's to "../usr/bin"
+    When the client cd's to "forbidden"
     Then the server returns an access denied error
   Scenario: Not logged in

data/features/ftp_server/file_structure.feature ADDED

@@ -0,0 +1,43 @@
+Feature: File Structure
+  As a server
+  I want to accept the obsolute file structure (STRU) command
+  For compatability
+  Background:
+    Given the test server is started
+  Scenario: File
+  Given a successful login
+  And the server has file "ascii_unix"
+  When the client successfully sets file structure "F"
+  And the client successfully gets text "ascii_unix"
+  Then the remote file "ascii_unix" should match the local file
+  Scenario: Record
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets file structure "R"
+    Then the server returns a file structure not implemented error
+  Scenario: Page
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets file structure "P"
+    Then the server returns a file structure not implemented error
+  Scenario: Invalid
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets file structure "*"
+    Then the server returns an invalid file structure error
+  Scenario: Not logged in
+    Given a successful connection
+    When the client sets file structure "F"
+    Then the server returns a not logged in error
+  Scenario: Missing parameter
+    Given a successful login
+    When the client sets file structure with no parameter
+    Then the server returns a syntax error

data/features/{get.feature → ftp_server/get.feature} RENAMED

@@ -1,8 +1,12 @@
 Feature: Get
   As a client
-  I want to get a file
+  I want to securely get a file
   So that I have it on my computer
+  But nobody else can
+  Background:
+    Given the test server is started
   Scenario: ASCII file with *nix line endings
     Given a successful login
@@ -31,19 +35,21 @@ Feature: Get
     When the client successfully gets text "ascii_unix"
     Then the local file "ascii_unix" should match the remote file
-  Scenario: TLS
-    pending "TLS not supported in active mode (see README)"
+  Scenario: File in subdirectory
+    Given a successful login
+    And the server has file "foo/ascii_unix"
+    Then the client successfully gets text "foo/ascii_unix"
-  Scenario: TLS, Passive
-    Given a successful login with TLS
-    And the server has file "ascii_unix"
-    And the client is in passive mode
+  Scenario: Non-root working directory
+    Given a successful login
+    And the server has file "foo/ascii_unix"
+    And the client successfully cd's to "foo"
     When the client successfully gets text "ascii_unix"
-    Then the local file "ascii_unix" should match the remote file
+    Then the remote file "foo/ascii_unix" should match the local file
-  Scenario: Path outside tree
+  Scenario: Access denied
     Given a successful login
-    When the client gets text "../foo"
+    When the client gets text "forbidden"
     Then the server returns an access denied error
   Scenario: Missing file
@@ -60,3 +66,8 @@ Feature: Get
     Given a successful login
     When the client gets with no path
     Then the server returns a syntax error
+  Scenario: File system error
+    Given a successful login
+    When the client gets text "unable"
+    Then the server returns an action not taken error

data/features/ftp_server/get_tls.feature ADDED

@@ -0,0 +1,18 @@
+Feature: Get TLS
+  As a client
+  I want to get a file
+  So that I have it on my computer
+  Background:
+    Given the test server is started with TLS
+  Scenario: TLS
+    pending "TLS not supported in active mode (see README)"
+  Scenario: TLS, Passive
+    Given a successful login with TLS
+    And the server has file "ascii_unix"
+    And the client is in passive mode
+    When the client successfully gets text "ascii_unix"
+    Then the local file "ascii_unix" should match the remote file

data/features/{list.feature → ftp_server/list.feature} RENAMED

@@ -4,72 +4,66 @@ Feature: List
   I want to list files
   So that I can see what file to transfer
-  Scenario: List implicit
+  Background:
+    Given the test server is started
+  Scenario: Implicit
     Given a successful login
     And the server has file "foo"
     And the server has file "bar"
-    When the client lists the directory
+    When the client successfully lists the directory
     Then the file list should be in long form
     And the file list should contain "foo"
     And the file list should contain "bar"
-  Scenario: List root
+  Scenario: Root
     Given a successful login
     And the server has file "foo"
     And the server has file "bar"
-    When the client lists the directory "/"
+    When the client successfully lists the directory "/"
     Then the file list should be in long form
     And the file list should contain "foo"
     And the file list should contain "bar"
-  Scenario: List subdir
+  Scenario: Parent of root
     Given a successful login
-    And the server has file "subdir/foo"
-    When the client lists the directory "subdir"
+    And the server has file "foo"
+    And the server has file "bar"
+    When the client successfully lists the directory "/.."
     Then the file list should be in long form
     And the file list should contain "foo"
+    And the file list should contain "bar"
-  Scenario: List glob
+  Scenario: Subdir
     Given a successful login
-    And the server has file "foo"
-    And the server has file "bar"
-    When the client lists the directory "f*"
+    And the server has file "subdir/foo"
+    When the client successfully lists the directory "subdir"
     Then the file list should be in long form
     And the file list should contain "foo"
-    And the file list should not contain "bar"
-  Scenario: Passive
+  Scenario: Glob
     Given a successful login
     And the server has file "foo"
     And the server has file "bar"
-    And the client is in passive mode
-    When the client lists the directory
+    When the client successfully lists the directory "f*"
     Then the file list should be in long form
     And the file list should contain "foo"
-    And the file list should contain "bar"
-  Scenario: TLS
-    pending "TLS not supported in active mode (see README)"
+    And the file list should not contain "bar"
-  Scenario: TLS, Passive
-    Given a successful login with TLS
+  Scenario: Passive
+    Given a successful login
     And the server has file "foo"
     And the server has file "bar"
     And the client is in passive mode
-    When the client lists the directory
+    When the client successfully lists the directory
     Then the file list should be in long form
     And the file list should contain "foo"
     And the file list should contain "bar"
-  Scenario: Path outside tree
-    Given a successful login
-    When the client lists the directory ".."
-    Then the server returns an access denied error
-  Scenario: Missing file
+  Scenario: Missing directory
     Given a successful login
-    When the client lists the directory "missing/file"
-    Then the server returns a no such file error
+    When the client successfully lists the directory "missing/file"
+    Then the file list should be empty
   Scenario: Not logged in
     Given a successful connection

data/features/ftp_server/list_tls.feature ADDED

@@ -0,0 +1,21 @@
+Feature: List TLS
+  As a client
+  I want to list files
+  So that I can see what file to transfer
+  Background:
+    Given the test server is started with TLS
+  Scenario: TLS
+    pending "TLS not supported in active mode (see README)"
+  Scenario: TLS, Passive
+    Given a successful login with TLS
+    And the server has file "foo"
+    And the server has file "bar"
+    And the client is in passive mode
+    When the client successfully lists the directory
+    Then the file list should be in long form
+    And the file list should contain "foo"
+    And the file list should contain "bar"

data/features/{login.feature → ftp_server/login.feature} RENAMED

@@ -4,14 +4,16 @@ Feature: Login
   I want to log in
   So that I can transfer files
+  Background:
+    Given the test server is started
   Scenario: Normal connection
     Given a successful login
     Then the server returns no error
     And the client should be logged in
   Scenario: Bad user
-    Given the server is started
-    And the client connects
+    Given the client connects
     When the client logs in with a bad user
     Then the server returns a login incorrect error
     And the client should not be logged in

data/features/ftp_server/mode.feature ADDED

@@ -0,0 +1,43 @@
+Feature: Mode
+  As a client
+  I want to set the file transfer mode
+  So that can optimize the transfer
+  Background:
+    Given the test server is started
+  Scenario: Stream
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client successfully sets mode "S"
+    And the client successfully gets text "ascii_unix"
+    Then the remote file "ascii_unix" should match the local file
+  Scenario: Block
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets mode "B"
+    Then the server returns a mode not implemented error
+  Scenario: Compressed
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets mode "C"
+    Then the server returns a mode not implemented error
+  Scenario: Invalid
+    Given a successful login
+    And the server has file "ascii_unix"
+    When the client sets mode "*"
+    Then the server returns an invalid mode error
+  Scenario: Not logged in
+    Given a successful connection
+    When the client sets mode "S"
+    Then the server returns a not logged in error
+  Scenario: Missing parameter
+    Given a successful login
+    When the client sets mode with no parameter
+    Then the server returns a syntax error