fruit_to_lime 2.7.0 → 2.7.1

data/lib/fruit_to_lime/errors.rb

@@ -16,4 +16,7 @@ module FruitToLime
 
     class InvalidDealStatusError < StandardError
     end
+
+    class InvalidNoteClassificationError < StandardError
+    end
 end

data/lib/fruit_to_lime/model/note.rb

@@ -1,10 +1,14 @@
 module FruitToLime
     class Note
         include SerializeHelper
-        attr_accessor :id, :text, :integration_id, :classification, :date
+        attr_accessor :id, :text, :integration_id, :date
 
         attr_reader :organization, :created_by, :person, :deal
 
+        # The note's classification. It should be a value from
+        # {#NoteClassification}. The default value is Comment.
+        attr_reader :classification
+
         def initialize(opt = nil)
             if !opt.nil?
                 serialize_variables.each do |myattr|
@@ -12,6 +16,8 @@ module FruitToLime
                     instance_variable_set("@" + myattr[:id].to_s, val) if val != nil
                 end
             end
+
+            @classification = NoteClassification::Comment if @classification.nil?
         end
 
         def serialize_variables
@@ -59,6 +65,17 @@ module FruitToLime
             @deal = DealReference.from_deal(deal)
         end
 
+        def classification=(classification)
+            if classification == NoteClassification::Comment || classification == NoteClassification::SalesCall ||
+                    classification == NoteClassification::TalkedTo || classification == NoteClassification::TriedToReach ||
+                    classification == NoteClassification::ClientVisit
+                @classification = classification
+            else
+                raise InvalidNoteClassificationError
+            end
+
+        end
+
         def validate
             error = String.new
 

data/lib/fruit_to_lime/model/note_classification.rb

@@ -0,0 +1,25 @@
+module FruitToLime
+    # Defines a note's classification. This defines what kind of
+    # action that happened before the note was written.
+    module NoteClassification
+        # We talked to the client about a sale. This might be a phone call
+        # or a talk in person.
+        SalesCall = 0
+
+        # This is a general comment about the organization or deal.
+        Comment = 1
+
+        # This is a general comment regarding a talk we had with
+        # someone at the client.
+        TalkedTo = 2
+
+        # We tried to reach someone but failed.
+        TriedToReach = 3
+
+        # We had a meeting at the client's site.
+        ClientVisit = 4
+    end
+end
+
+
+

data/spec/note_spec.rb

@@ -95,4 +95,16 @@ describe "Note" do
         # then
         note.deal.is_a?(FruitToLime::DealReference).should eq true
     end
+
+    it "should have Comment as default classification" do
+        # then
+        note.classification.should eq FruitToLime::NoteClassification::Comment
+    end
+
+    it "should not accept invalid classifications" do
+        # when, then
+        expect {
+            note.classification = "hubbabubba"
+        }.to raise_error(FruitToLime::InvalidNoteClassificationError)
+    end
 end

data/templates/VISMA/lib/tomodel.rb

@@ -85,7 +85,7 @@ class Converter
         # Set note properties from the row.
         organization = @rootmodel.find_organization_by_integration_id(row['KUNDNR'])
         unless organization.nil?
-            note.organization = organization.to_reference
+            note.organization = organization
         end
         note.created_by = @rootmodel.import_coworker
         note.text = row['ANTECK_1']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fruit_to_lime
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-02 00:00:00.000000000 Z
+date: 2014-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes
@@ -186,6 +186,7 @@ files:
 - lib/fruit_to_lime/model/documents.rb
 - lib/fruit_to_lime/model/link.rb
 - lib/fruit_to_lime/model/note.rb
+- lib/fruit_to_lime/model/note_classification.rb
 - lib/fruit_to_lime/model/organization.rb
 - lib/fruit_to_lime/model/person.rb
 - lib/fruit_to_lime/model/referencetosource.rb