fruit_to_lime 2.5.3 → 2.5.5

data/spec/helpers/xsd_validate_spec.rb

@@ -1,58 +1,58 @@
-
-require 'spec_helper'
-require 'fruit_to_lime'
-require 'nokogiri'
-describe FruitToLime::SerializeHelper do
-
-    describe "Validate according to xsd" do
-        let(:validate_result) {
-            i = FruitToLime::RootModel.new
-            i.settings.with_organization do |s|
-                s.set_custom_field({:integration_id=>"2", :title=>"cf title"})
-                s.set_custom_field({:integration_id=>"3", :title=>"cf title2"})
-            end
-            i.add_coworker({
-                :integration_id=>"123",
-                :first_name=>"Kalle",
-                :last_name=>"Anka",
-                :email=>"kalle.anka@vonanka.com"
-            })
-            o = FruitToLime::Organization.new
-            o.name = "Ankeborgs bibliotek"
-            o.with_source do |source|
-                source.par_se('122345')
-            end
-            #o.source_ref = {:name=>'Go',:id=>"PASE122345"}
-            o.set_tag("tag:bibliotek")
-            o.set_tag("tag:Bj\u{00F6}rk")
-            o.set_custom_field({:integration_id=>"2", :value=>"cf value"})
-            o.set_custom_field({:integration_id=>"3", :value=>"cf Bj\u{00F6}rk"})
-            o.with_postal_address do |addr|
-                addr.city = "Ankeborg"
-            end
-            o.with_visit_address do |addr|
-                addr.city = "Gaaseborg"
-            end
-            coworker = FruitToLime::Coworker.new({:integration_id => "1", :first_name => "Vincent", :last_name => "Vega"})
-            o.responsible_coworker = coworker
-
-            emp = o.add_employee({
-                :integration_id => "1",
-                :first_name => "Kalle",
-                :last_name => "Anka"
-            })
-            emp.direct_phone_number = '234234234'
-            emp.currently_employed = true
-            i.organizations.push(o)
-            xsd_file = File.join(File.dirname(__FILE__), '..', 'sample_data', 'schema0.xsd')
-
-            xsd = Nokogiri::XML::Schema(File.read(xsd_file))
-            doc = Nokogiri::XML(FruitToLime::SerializeHelper::serialize(i,-1))
-            xsd.validate(doc)
-        }
-        it "Should not contain validation errors" do
-            expect(validate_result).to eq([])
-        end
-
-    end
-end
+
+require 'spec_helper'
+require 'fruit_to_lime'
+require 'nokogiri'
+describe FruitToLime::SerializeHelper do
+
+    describe "Validate according to xsd" do
+        let(:validate_result) {
+            i = FruitToLime::RootModel.new
+            i.settings.with_organization do |s|
+                s.set_custom_field({:integration_id=>"2", :title=>"cf title"})
+                s.set_custom_field({:integration_id=>"3", :title=>"cf title2"})
+            end
+            i.add_coworker({
+                :integration_id=>"123",
+                :first_name=>"Kalle",
+                :last_name=>"Anka",
+                :email=>"kalle.anka@vonanka.com"
+            })
+            o = FruitToLime::Organization.new
+            o.name = "Ankeborgs bibliotek"
+            o.with_source do |source|
+                source.par_se('122345')
+            end
+            #o.source_ref = {:name=>'Go',:id=>"PASE122345"}
+            o.set_tag("tag:bibliotek")
+            o.set_tag("tag:Bj\u{00F6}rk")
+            o.set_custom_field({:integration_id=>"2", :value=>"cf value"})
+            o.set_custom_field({:integration_id=>"3", :value=>"cf Bj\u{00F6}rk"})
+            o.with_postal_address do |addr|
+                addr.city = "Ankeborg"
+            end
+            o.with_visit_address do |addr|
+                addr.city = "Gaaseborg"
+            end
+            coworker = FruitToLime::Coworker.new({:integration_id => "1", :first_name => "Vincent", :last_name => "Vega"})
+            o.responsible_coworker = coworker
+
+            emp = o.add_employee({
+                :integration_id => "1",
+                :first_name => "Kalle",
+                :last_name => "Anka"
+            })
+            emp.direct_phone_number = '234234234'
+            emp.currently_employed = true
+            i.organizations.push(o)
+            xsd_file = File.join(File.dirname(__FILE__), '..', 'sample_data', 'schema0.xsd')
+
+            xsd = Nokogiri::XML::Schema(File.read(xsd_file))
+            doc = Nokogiri::XML(FruitToLime::SerializeHelper::serialize(i,-1))
+            xsd.validate(doc)
+        }
+        it "Should not contain validation errors" do
+            expect(validate_result).to eq([])
+        end
+
+    end
+end

data/spec/note_spec.rb

@@ -1,67 +1,98 @@
-require "spec_helper"
-require 'fruit_to_lime'
-
-describe "Note" do
-    let("note") {
-        FruitToLime::Note.new
-    }
-
-    it "must have a text" do
-        note.validate.length > 0
-    end
-
-    it "is valid when it has text, created_by and organization" do
-        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
-        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
-        note.organization = FruitToLime::OrganizationReference.new({ :integration_id => "456", :heading => "Lundalogik" })
-
-        note.validate.should eq ""
-    end
-
-    it "will auto convert org to org.ref during assignment" do
-        # given
-        org = FruitToLime::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
-
-        # when
-        note.organization = org
-
-        # then
-        note.organization.is_a?(FruitToLime::OrganizationReference).should eq true
-    end
-
-    it "will auto convert person to person.ref during assignment" do
-        # given
-        person = FruitToLime::Person.new({:integration_id => "123" })
-        person.parse_name_to_firstname_lastname_se "Billy Bob"
-
-        # when
-        note.person = person
-
-        # then
-        note.person.is_a?(FruitToLime::PersonReference).should eq true
-    end
-
-    it "will auto convert coworker to coworker.ref during assignment" do
-        # given
-        coworker = FruitToLime::Coworker.new({:integration_id => "123" })
-        coworker.parse_name_to_firstname_lastname_se "Billy Bob"
-
-        # when
-        note.created_by = coworker
-
-        # then
-        note.created_by.is_a?(FruitToLime::CoworkerReference).should eq true
-    end
-
-    it "will auto convert deal to deal.ref during assignment" do
-        # given
-        deal = FruitToLime::Deal.new({:integration_id => "123" })
-        deal.name = "The new deal"
-
-        # when
-        note.deal = deal
-
-        # then
-        note.deal.is_a?(FruitToLime::DealReference).should eq true
-    end
-end
+require "spec_helper"
+require 'fruit_to_lime'
+
+describe "Note" do
+    let("note") {
+        FruitToLime::Note.new
+    }
+
+    it "must have a text" do
+        note.validate.length.should be > 0
+    end
+
+    it "is valid when it has text, created_by and organization" do
+        # given
+        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
+        note.organization = FruitToLime::OrganizationReference.new({ :integration_id => "456", :heading => "Lundalogik" })
+
+        # when, then
+        note.validate.should eq ""
+    end
+
+    it "is valid when it has text, created_by and person" do
+        # given
+        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
+        note.person = FruitToLime::Person.new({ :integration_id => "456", :heading => "Billy Bob" })
+
+        # when, then
+        note.validate.should eq ""
+    end
+
+    it "is valid when it has text, created_by and deal" do
+        # given
+        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
+        note.deal = FruitToLime::Deal.new({ :integration_id => "456", :heading => "The new deal" })
+
+        # when, then
+        note.validate.should eq ""
+    end
+
+    it "is invalid if no note has no attached objects" do
+        # given
+        note.text = "They are very interested in the new deal (the one where you get a free bike as a gift)"
+        note.created_by = FruitToLime::CoworkerReference.new( { :integration_id => "123", :heading => "kalle anka" } )
+
+        # when, then
+        note.validate.length.should be > 0
+    end
+
+    it "will auto convert org to org.ref during assignment" do
+        # given
+        org = FruitToLime::Organization.new({:integration_id => "123", :name => "Beagle Boys!"})
+
+        # when
+        note.organization = org
+
+        # then
+        note.organization.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+
+    it "will auto convert person to person.ref during assignment" do
+        # given
+        person = FruitToLime::Person.new({:integration_id => "123" })
+        person.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        note.person = person
+
+        # then
+        note.person.is_a?(FruitToLime::PersonReference).should eq true
+    end
+
+    it "will auto convert coworker to coworker.ref during assignment" do
+        # given
+        coworker = FruitToLime::Coworker.new({:integration_id => "123" })
+        coworker.parse_name_to_firstname_lastname_se "Billy Bob"
+
+        # when
+        note.created_by = coworker
+
+        # then
+        note.created_by.is_a?(FruitToLime::CoworkerReference).should eq true
+    end
+
+    it "will auto convert deal to deal.ref during assignment" do
+        # given
+        deal = FruitToLime::Deal.new({:integration_id => "123" })
+        deal.name = "The new deal"
+
+        # when
+        note.deal = deal
+
+        # then
+        note.deal.is_a?(FruitToLime::DealReference).should eq true
+    end
+end

data/spec/organization_spec.rb

@@ -1,89 +1,103 @@
-require "spec_helper"
-require 'fruit_to_lime'
-
-describe "Organization" do
-    let(:organization) {
-        FruitToLime::Organization.new
-    }
-
-    it "must have a name" do
-        organization.name = "Lundalogik"
-
-        organization.validate.should eq ""
-    end
-
-    it "will fail on validation if no name is specified" do
-        organization.name = ""
-
-        organization.validate.length > 0
-    end
-
-    it "will auto convert coworker to coworker.ref during assignment" do
-        # given
-        coworker = FruitToLime::Coworker.new({:integration_id => "456", :first_name => "Billy", :last_name => "Bob"})
-
-        # when
-        organization.responsible_coworker = coworker
-
-        # then
-        organization.responsible_coworker.is_a?(FruitToLime::CoworkerReference).should eq true
-    end
-
-    it "will have a no relation as default" do
-        # given, when, then
-        organization.relation.should eq FruitToLime::Relation::NoRelation
-    end
-
-    it "should only accept relations from Relations enum" do
-        # given, when
-        organization.relation = FruitToLime::Relation::IsACustomer
-
-        # then
-        organization.relation.should eq FruitToLime::Relation::IsACustomer
-    end
-
-    it "should not accept invalid relations" do
-        # when, then
-        expect {
-            organization.relation = "hubbabubba"
-        }.to raise_error(FruitToLime::InvalidRelationError)
-    end
-
-end
-
-describe "OrganizationReference" do
-    it "can be created from an organization" do
-        # given
-        org = FruitToLime::Organization.new
-        org.name = "Lundalogik"
-        org.integration_id = "123"
-
-        # when
-        ref = FruitToLime::OrganizationReference.from_organization(org)
-
-        # then
-        ref.is_a?(FruitToLime::OrganizationReference).should eq true
-        ref.heading.should eq "Lundalogik"
-        ref.integration_id.should eq "123"
-    end
-
-    it "can be created from an organization_reference" do
-        # given
-        orgref = FruitToLime::OrganizationReference.new
-        orgref.heading = "Lundalogik"
-
-        # when
-        ref = FruitToLime::OrganizationReference.from_organization(orgref)
-
-        # then
-        ref.is_a?(FruitToLime::OrganizationReference).should eq true
-    end
-
-    it "is nil when created from nil" do
-        # given, when
-        ref = FruitToLime::OrganizationReference.from_organization(nil)
-
-        # then
-        ref.should eq nil
-    end
-end
+require "spec_helper"
+require 'fruit_to_lime'
+
+describe "Organization" do
+    let(:organization) {
+        FruitToLime::Organization.new
+    }
+
+    it "must have a name" do
+        organization.name = "Lundalogik"
+
+        organization.validate.should eq ""
+    end
+
+    it "will fail on validateion if it has a source with no sourceid" do
+        # given
+        organization.name =  "Lundalogik"
+
+        # when
+        organization.with_source do |source|
+            source.par_se('')
+        end
+
+        # then
+        organization.validate.length.should be > 0
+    end
+
+    it "will fail on validation if no name is specified" do
+        # given
+        organization.name = ""
+
+        # when, then
+        organization.validate.length.should be > 0
+    end
+
+    it "will auto convert coworker to coworker.ref during assignment" do
+        # given
+        coworker = FruitToLime::Coworker.new({:integration_id => "456", :first_name => "Billy", :last_name => "Bob"})
+
+        # when
+        organization.responsible_coworker = coworker
+
+        # then
+        organization.responsible_coworker.is_a?(FruitToLime::CoworkerReference).should eq true
+    end
+
+    it "will have a no relation as default" do
+        # given, when, then
+        organization.relation.should eq FruitToLime::Relation::NoRelation
+    end
+
+    it "should only accept relations from Relations enum" do
+        # given, when
+        organization.relation = FruitToLime::Relation::IsACustomer
+
+        # then
+        organization.relation.should eq FruitToLime::Relation::IsACustomer
+    end
+
+    it "should not accept invalid relations" do
+        # when, then
+        expect {
+            organization.relation = "hubbabubba"
+        }.to raise_error(FruitToLime::InvalidRelationError)
+    end
+end
+
+describe "OrganizationReference" do
+    it "can be created from an organization" do
+        # given
+        org = FruitToLime::Organization.new
+        org.name = "Lundalogik"
+        org.integration_id = "123"
+
+        # when
+        ref = FruitToLime::OrganizationReference.from_organization(org)
+
+        # then
+        ref.is_a?(FruitToLime::OrganizationReference).should eq true
+        ref.heading.should eq "Lundalogik"
+        ref.integration_id.should eq "123"
+    end
+
+    it "can be created from an organization_reference" do
+        # given
+        orgref = FruitToLime::OrganizationReference.new
+        orgref.heading = "Lundalogik"
+
+        # when
+        ref = FruitToLime::OrganizationReference.from_organization(orgref)
+
+        # then
+        ref.is_a?(FruitToLime::OrganizationReference).should eq true
+    end
+
+    it "is nil when created from nil" do
+        # given, when
+        ref = FruitToLime::OrganizationReference.from_organization(nil)
+
+        # then
+        ref.should eq nil
+    end
+end