fruit_to_lime 2.5.2 → 2.5.3

data/lib/fruit_to_lime/errors.rb

@@ -7,4 +7,10 @@ module FruitToLime
 
     class InvalidRelationError < StandardError
     end
+
+    class InvalidValueError < StandardError
+        def initalize(value)
+            super("#{value} is not a valid value.")
+        end
+    end
 end

data/lib/fruit_to_lime/model/deal.rb

@@ -36,12 +36,12 @@ module FruitToLime
         # LIME Go before the import.
         attr_accessor :status
 
-        attr_accessor :id, :integration_id, :name, :description, :probability, :value, :order_date
+        attr_accessor :id, :integration_id, :name, :description, :probability, :order_date
 
         # you add custom values by using {#set_custom_value}
         attr_reader :custom_values
 
-        attr_reader :customer, :responsible_coworker, :customer_contact
+        attr_reader :customer, :responsible_coworker, :customer_contact, :value
 
         def serialize_variables
             [ :id, :integration_id, :name, :description, :probability, :value, :order_date ].map {
@@ -118,5 +118,28 @@ module FruitToLime
         def customer_contact=(person)
             @customer_contact = PersonReference.from_person(person)
         end
+
+        def value=(value)
+            # we have had some issues with LIME Easy imports where the
+            # value was in the format "357 000". We need to remove
+            # those spaces.
+            fixed_value = value.gsub(" ", "")
+
+            if is_integer?(fixed_value)
+                @value = fixed_value
+            elsif is_float?(fixed_value)
+                @value = fixed_value
+            else
+                raise InvalidValueError, value
+            end
+        end
+
+        def is_integer?(value)
+            true if Integer(value) rescue false
+        end
+
+        def is_float?(value)
+            true if Float(value) rescue false
+        end
     end
 end

data/spec/deal_spec.rb

@@ -48,14 +48,55 @@ describe "Deal" do
         deal.customer_contact.is_a?(FruitToLime::PersonReference).should eq true
     end
 
-    it "will fail on validation if name, responsible and customer is empty" do
+    it "will fail on validation if name and customer is empty" do
         # given, when
         deal.name = "The big deal"
         deal.customer = FruitToLime::Organization.new({:integration_id => "123", :name => "Lundalogik"})
-        deal.responsible_coworker =
-            FruitToLime::Coworker.new({ :integration_id => "456", :first_name => "Billy", :last_name => "Bob" })
 
         # then
         deal.validate.should eq ""
     end
+
+    it "should convert value strings that looks like number to number" do
+        # given
+        deal.name = "The deal with a strange value"
+
+        # when
+        deal.value = "357 000"
+
+        # then
+        deal.value.should eq "357000"
+    end
+
+    it "should raise invalidvalueerror if value is not a number" do
+        # given
+        deal.name = "The deal with an invalid value"
+
+        # when, then
+        expect {
+            deal.value = "Im not a number"
+        }.to raise_error(FruitToLime::InvalidValueError)
+    end
+
+    it "should set value if value is an integer" do
+        # given
+        deal.name = "The new deal"
+
+        # when
+        deal.value = "100"
+
+        # then
+        deal.value.should eq "100"
+    end
+
+    it "should set value if value is a float" do
+        # given
+        deal.name = "The new deal"
+
+        # when
+        deal.value = "100.10"
+
+        # then
+        deal.value.should eq "100.10"
+    end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fruit_to_lime
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.3
   prerelease: 
 platform: ruby
 authors:
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-23 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: iso_country_codes